- 12 Nov, 2020 40 commits
-
-
Xiaodan Zhu authored
This CL removed the periods in the strings of reverse gesture toasts Bug: 1107183 Change-Id: Ia2196d08443a4ecc08a59e1680388eb74b2c3543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535913Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827007}
-
Kevin McNee authored
This allows for the use of portals with the --enable-experimental-web-platform-features flag. Note that this is the same configuration as the M85 origin trial: same-origin, Android only (see issue 1040212). We'll hold off using this flag for enabling for desktop and/or cross origin cases until those are further developed. Bug: None Change-Id: I0579c241c58aec3e37e5dd7fba4e8375d43d91a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518613Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#827006}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f86e9704c66b..696f7382ade0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC zmin@google.com,dbertoni@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1147077 Tbr: zmin@google.com,dbertoni@google.com Change-Id: I4d7799190c714c00c863c21c5a0d6d482e3009f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535991Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827005}
-
Eric Orth authored
Made `RecordParsed::rdata_` nullable but missed a deref in `RecordParsed::IsEqual()`. Original change's description: > Revert "Ignore unknown record types in DNS responses" > > This reverts commit e4620991. > > Reason for revert: Suspected for causing crashes on Windows/Intel. > For more info see bug. > > Bug: 1148269 > > Original change's description: > > Ignore unknown record types in DNS responses > > > > Previously worked only for address requests. Other request types (e.g. > > HTTPS), on seeing any unrecognized (and therefore unparsable) record > > type in the response, would fail the whole response as malformed. > > > > Bug: 1147247 > > Change-Id: Icd9e5ab2e39cf09ffe7c3945b011ebf1d4b45778 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529619 > > Commit-Queue: Eric Orth <ericorth@chromium.org> > > Auto-Submit: Eric Orth <ericorth@chromium.org> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#826462} > > TBR=mmenke@chromium.org,ericorth@chromium.org > > Change-Id: I03ea912d1a9c8a01be3d84a3f4d417c385f97c2d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1147247 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533548 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826873} Bug: 1148269,1147247 Fixed: 1147247 Change-Id: I312c095e519c62d730e5fb6165833727f5d913be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534629 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#827004}
-
dpapad authored
There is no reason for this file to be part of the shared webui_resources.grd, as it is only used by NTP as follows: 1) chrome-search://local-ntp/ (deprecated) 2) chrome://new-tab-page The former directly inlines the image by using flattenhtml=true, whereas the latter consumes it from a chrome:// URL. This is part of the effort of auto-genearting the contents of webui_resources.grd. Bug: 1132403 Change-Id: I20642b4c845393daf72597f156f7a934c9f3ea93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533646 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#827003}
-
Peter Wen authored
These defaults are no longer necessary now that downstream is using its own suppressions and baseline files. This makes sure that all targets use lint the way that these updated docs say. Bug: 1139957 Change-Id: I1ce9d79e990d472c719cdde688f2ca34a8100ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533575 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#827002}
-
Avi Drissman authored
If a string destined for a menu cannot be turned into a CFString, base64 it to allow for diagnosis. Bug: 1140620 Change-Id: I78447813c8cfa5cae92e3e02f693313faf5336ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535553 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#827001}
-
Lu Huang authored
design doc: https://docs.google.com/document/d/19dGklalQTRtRrG3PKrVbDRmYPLHGLnsGEwUaed7sAFQ/edit?usp=sharing overview cl: https://chromium-review.googlesource.com/c/chromium/src/+/2393252 Chrome status: https://www.chromestatus.com/feature/5739732661174272 Bug: 1072058 Change-Id: I8a73e070d0121635be015239dc8f6c34a55fad97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461219 Commit-Queue: Lu Huang <luhua@microsoft.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#827000}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ie35ef33111b2c4e5c766d8de5caa9d7612e703f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535556Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826999}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/43efdd17a959..c6215e29d0ea 2020-11-12 michael.liao@microsoft.com [ARIA]: Improve ARIAUtils.alert function If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1146247 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icddbd36c5b902248e985812438308c7e91072d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533167Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826998}
-
Nick Diego Yamane authored
A regression was introduced with initial extended-drag integration in Ozone/Wayland, which causes some misbehaviours described in more details at https://crbug.com/1148021. This CL addresses the issue the following issue: wl_pointer events may come in while the drag session is still running, which is particularly troublesome when it happens just after the drop event, making the event to be dispatched to the wrong window, e.g: the latest one for which an wl_data_device::enter was received. Further details can be found in the above mentioned link. To make window drag controller more resistant to such cases, this modifies it such that it ignores wl_pointer events until the session is finished. Bug: 1148021 Change-Id: I559ec271dd2d5bfd5609a8f89528ddda760fe321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533693 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#826997}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4804ac8724ff..e6dc3d37f58c 2020-11-12 zzyiwei@google.com Disable VK_KHR_external_memory_fd for Android build 2020-11-12 natsu@google.com Handle image properties from external device memory 2020-11-12 capn@google.com Fix conditionally enabling Reactor MSan instrumentation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I50a14f8d0551f6d685ccbc43ff2f16288bdba687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533164Reviewed-by:
-
Tom Anderson authored
This fixes a regression after f4d4d111 which rolled in the addition of metrics for harfbuzz. The issue is that the system harfbuzz and our //third_party harfbuzz were getting loaded at the same time. This CL adds HB metrics for component builds to prevent loading the system harfbuzz. This change is not done for non-component builds because it's not necessary and we don't want to accidentally add a dependency on HB's metrics. R=drott Bug: 1146397 Change-Id: Ifaebf0c86bedefb29cc88709eb89fb42af5a7b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522922 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#826995}
-
Salvador Guerrero authored
This CL fixes an invalid reference when ENABLE_BASE_TRACING is disabled. It is done by moving all references to tracing clases inside the trace event macro, which is compiled out when base tracing is disabled. Change-Id: I3cde469873163ac457fc9d1057b02f6da17b6632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535610 Commit-Queue: Salvador Guerrero <salg@google.com> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#826994}
-
Jacob Kopczynski authored
Moving appropriate builders into it. Bug: chromium:1127088 Change-Id: Ie4bc188c2ef86a8f87e7b9d606c34d06651ced50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534177 Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#826993}
-
Robert Sesek authored
This allows reading the Managed Preferences equivalent of the existing preference path allow rules in common.sb. This also allows reading ~/Library/Preferences/com.apple.security.plist in network.sb. Bug: 1134449 Change-Id: I42d414e5133c5931907d38c2bdb26d1431f837e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535650Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#826992}
-
Victor Hugo Vianna Silva authored
... decryptable ones. Before this CL, if the sync server sent an update for "ServerId" encrypted with an unknown key, then sent an update for the same id encrypted with a known key, the data type would remain blocked. The CL fixes this by removing any entry in entries_pending_decryption_ with the same id as an incoming successfully decrypted update. Fixed: 1148359 Change-Id: I56ef2d8c73686ff9375cfd1ff7d48da1a5fe53c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535230Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#826991}
-
Andre Le authored
- Added phone name to the notification and fix the text layout according to spec. - Added IDs to access app name and summary text in NotificationViewMD for customization. Screenshots: https://screenshot.googleplex.com/3sbTp3UdCCbmEHZ https://screenshot.googleplex.com/62qWt4XimsUwMKB https://screenshot.googleplex.com/5ie8JCirGmYpeS2 https://screenshot.googleplex.com/5KvapXRjX9zBKXP Bug: 1106937,1126208 Change-Id: I401566ad05e248a724f3665f0c1e4c9d1a7891c5 Fixed: 1147264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532041Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#826990}
-
Lukasz Anforowicz authored
This CL replaces most calls to NavigateFrameToURL(...) with EXPECT_TRUE(NavigateToURLFromRenderer(...)). Note that not all such calls have been replaced (e.g. this CL skips the ones where the naive/mechanical replacement would have caused test failures). For motivation (i.e. why NavigateFrameToURL is slightly undesirable) please see the linked bug. Bug: 1148049 Change-Id: I5b341c3e7cc2e0774d905705b2ca891dc0be862f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532855 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#826989}
-
Andy Paicu authored
Unit and browser tests to be added in a follow-up. Tested against local service implementation. Design doc: go/permission-predictions-client-doc Bug: 1138595 Change-Id: Ie685853401f5ecc76fa7821092cf962f49cad0dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526681 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#826988}
-
Owen Min authored
This reverts commit 6e5cadb7. Reason for revert: compile failure https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-dbg/22520? Original change's description: > Added support for one-time geolocation permission grants on desktop. > > Expanded the current permission request dialog to have the possibility > to accept the permission for only one time. > > The permission will be invalidated when all the tabs with that origin > are closed or navigated away from, or if a day has elapsed since the > grant, whichever comes earlier. > > Bug: 1147918 > Change-Id: I9f0cc029d0bd2cae56e433d8ba753e73495476f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483832 > Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826981} TBR=vasilii@chromium.org,engedy@chromium.org,ravjit@chromium.org Change-Id: I511823b3a656f211c472d76a9cce2d30ca7ab644 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536153Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826987}
-
Thomas Lukaszewicz authored
This CL adds metrics to track the position of a closed tab from both filtered and unfiltered lists. Bug: 1099917 Change-Id: I32ee18442cf965a05d7d92152ffc730c34674538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530260 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#826986}
-
Devlin Cronin authored
Add a base::Feature to control Manifest V3 support. If disabled, all Manifest V3-based extensions will fail to load. This should only be used as a last resort, and is very much a kill-switch (rather than a gradual ramp-up tool). By default, this feature is enabled (allowing manifest v3 extensions). Bug: 1147344 Change-Id: I3e30ad76fce12bae584a625c81e3759b31d9478e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520333Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826985}
-
Collin Baker authored
This enables use of ThumbnailSchedulerImpl in ThumbnailTabHelper. Bug: 1090038 Change-Id: Ie1961e142d48f4c821a668e46fe804449b050725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532910Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#826984}
-
Nico Weber authored
Ran `tools/clang/scripts/upload_revision.py 418f18c6cdfe56e77669e2f4d3df3bca1020156d`. Bug: 1147865 Change-Id: I4d734771fb846367d5bcf33b31293e04039c4f4b Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532714Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#826983}
-
Judy Wang authored
Test: Manually tested on Dut. Fixed: 1146655 Change-Id: If922581c6987815dacf4277359dcf2ff98a4bd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532309 Commit-Queue: Judy Wang <shidi@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#826982}
-
Ravjit Singh Uppal authored
Expanded the current permission request dialog to have the possibility to accept the permission for only one time. The permission will be invalidated when all the tabs with that origin are closed or navigated away from, or if a day has elapsed since the grant, whichever comes earlier. Bug: 1147918 Change-Id: I9f0cc029d0bd2cae56e433d8ba753e73495476f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483832 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Adam Langley authored
I'm flushing my queue of niggles that I've noticed over time: 1. The |Callback| interface in |CableAuthenticator| is moot. It always calls |CableAuthenticatorUI|, which is in the same package. There's even an |mUi| member already. 2. In a couple of cases calls were moved to the |mTaskRunner| thread, but since the Mojo network interface only works on the UI thread, we know that's the UI thread now and thus the transition is moot. Replace them with asserts. 3. A number of methods were more public than needed. If not specified, Java defaults to package-private, which works for a lot of cases here. BUG=1002262 Change-Id: Ieee4ab7fc9c1f3ae339d661b2ed5ce6e1adb28ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531178 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#826980}
-
Ryan Sturm authored
Any change to DSE should cause the search prefetch cache to be cleared. While it is only necessary to clean up when url or search post params change, it is healthier to clean up whenever DSE changes state. Bug: 1138647 Change-Id: I6f995b5423464decd823a33b9c71262cf3999c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515365 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#826979}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1605182400-7fb6cfb0609ea611bc3a38e3ac52d34b26c93566.profdata to chrome-mac-master-1605203985-0458f2948c8ea3f9d90fd537422a290135941c1f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia6fa53fd930e191af8419008d90f38a4001e7296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535931Reviewed-by:
-
dpapad authored
The motivation behind this is to remove usages of registerMessageCallback() test helper in order to eventually fully remove it. The usage in device_page_tests.js is actually the last usage of this helper. Bug: 1148403 Change-Id: I734fe61bfd7bdd7c440658618ac5486c3c1d06a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534152 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
With that policy admins can override whether modules are shown on the new tab page. Bug: 1142878 Change-Id: I9d7683b587fa1f1b8fd1e7f861f6789bc96e179e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531181 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826976}
-
Evan Stade authored
CastOptionsProvider has to be part of the implementation library. This was broken in 48d00622 Bug: 1057099 Change-Id: Idf2f0c56ff8fc65f83b22ddef77d3bca9361b148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534401Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
Emily Stark authored
For the purposes of measuring the Simplified Domain Display experiment, we're using a Suspicious Site Safety Tip, but we're removing the call to action buttons because we don't want to push the user towards what to do; rather, we want to direct their attention to the omnibox and then use the simplified domain UI to make a decision about what to do. This change therefore removes the buttons and Learn More link for the Suspicious Site Safety Tip. Bug: 1146471 Change-Id: I6101d1af604571a8b439f7096dab356795794962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532871 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#826974}
-
Ella Ge authored
The UKM added is similar as the existing UMA metrics TrustedWebActivity.QualityEnforcementViolation. Add the UKM to help us identify popular sites that violate the quality criteria often. New UKM collection review: https://docs.google.com/document/d/1zBXtJ9D8JBbBNtNdQhWhjHMz0Lry3h5MCgUOpxphfCs/edit# This CL also fixes a bug with the QualityEnforcementViolation UMA: When record the "Crashed" metric, the general metric will also be recorded again. Luckily we are not enabled the crashing part , so there should have impact on the collected data. Bug: 1147483 Change-Id: Id250c7037e951558be12186568f5520d48528354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530591Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#826973}
-
Javier Flores authored
Fixed: 1147714, 1147717 Change-Id: I067f651bdfaaf9459c9321fa9238d18f816d0bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534792Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#826972}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605182400-0a4bd93b21630824fe02bcc8b97bd908ea587b84.profdata to chrome-linux-master-1605203985-a72b3d0424c525881821dc3609a4c23423acaf56.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7abbe7a128e804d02bea924f58788d8596634f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535552Reviewed-by:
-
Devon O'Brien authored
Change-Id: I745619cefd609214b4c98b460224886159d76ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535219Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Devon O'Brien <asymmetric@chromium.org> Cr-Commit-Position: refs/heads/master@{#826970}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I288bd7602fdddceba1755668757b68e2c04a34ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535413Reviewed-by:
-
Ben Kelly authored
This CL translates the path-to-regexp parser from typescript to c++. Its based on the code here: https://github.com/pillarjs/path-to-regexp/blob/125c43e6481f68cc771a5af22b914acdb8c5ba1f/src/index.ts#L126-L232 We deviate from the path-to-regexp code in some terminology and output structure. In particular, we output a list of Part structures with types of kFixed, kRegex, kSegmentWildcard, or kFullWildcard as discussed in the design doc: https://docs.google.com/document/d/17L6b3zlTHtyxQvOAvbK55gQOi5rrJLERwjt_sKXpzqc/edit#heading=h.ymw6rim68920 Note, this CL does deviate from the design doc as well in that we are translating a more modern version of path-to-regexp than originally planned. This uses a "{...}?" style grouping for applying modifiers. We also do not yet fully include support for the "*" wildcard character. As such the grammar in the design doc does not really apply fully to this CL. Bug: 1141510 Change-Id: I1c3e4ef76587496301d2171fa9f76b51754dce0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518206 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
-
