- 11 Sep, 2020 40 commits
-
-
Garrett Beaty authored
These builders were assigned machines in https://crrev.com/i/3264546. Bug: 1126929 Change-Id: Ida6f75fa6d562aa4c71533eb36f41480688efcfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406519 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#806331}
-
Nick Harper authored
This change fixes a bug in the Net.QuicSession.ZeroRttState histogram where no entries would get recorded for 0-RTT not attempted in Google QUIC. This also adds a new histogram that provides more detail on why 0-RTT gets rejected. Change-Id: Ia15485827e16698a5e3a3be48f52b669b16f52ad Bug: b/168020146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405943Reviewed-by:
Renjie Tang <renjietang@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#806330}
-
Wenbin Zhang authored
This reverts commit 608a0e43. Reason for revert: Android builders on perf waterfall start failing since https://chromium-review.googlesource.com/c/chromium/src/+/2404674. Reverting the CLs after that. Original change's description: > Roll src-internal from 4bb03bb4b22d to 44c9ca6a2c0e (1 revision) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bb03bb4b22d..44c9ca6a2c0e > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC orphis@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: chromium:1040645 > Tbr: orphis@google.com > Change-Id: I586d0a124bb943405b379d527767540d5730141e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405975 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#806112} TBR=orphis@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: I55721462acc6cdeb5da2584ae493d1e119072c3c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1040645 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406521Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#806329}
-
Aleks Totic authored
Image detail canvases sizes were different. This forces all flex items to the same size. Change-Id: I4db361c5b1a1746a882ea903dc142d3614cba02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401805Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#806328}
-
Wenbin Zhang authored
This reverts commit 0be23048. Reason for revert: Android builders on perf waterfall start failing since https://chromium-review.googlesource.com/c/chromium/src/+/2404674. Reverting the CLs after that. Original change's description: > Roll src-internal from 44c9ca6a2c0e to d9ddf43a38c7 (2 revisions) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/44c9ca6a2c0e..d9ddf43a38c7 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC orphis@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: None > Tbr: orphis@google.com > Change-Id: I014e334ab708e71f06627a5cff15316aa8483222 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406094 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#806141} TBR=orphis@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: Ie21369e9364abb57374acc106ce34f33917f86b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406587Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/30d3022f727a..83ba93022571 2020-09-11 brianosman@google.com Support dangling type references in the IR generator's inliner 2020-09-11 bsalomon@google.com Always make atlas texture index varying a float 2020-09-11 jlavrova@google.com Reland "Removing ICU dependencies from skparagraph BUILD.gn file" 2020-09-11 jzern@google.com DEPS: update libwebp to v1.1.0-28-g55a080e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: I28d86901db1aa9b478fbe5a5107634b18a85ccc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406516Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806326}
-
Wenbin Zhang authored
This reverts commit 5cc6a1ae. Reason for revert: Android builders on perf waterfall start failing since https://chromium-review.googlesource.com/c/chromium/src/+/2404674. Reverting the CLs after that. Original change's description: > Roll src-internal from d9ddf43a38c7 to 0112b94ac90e (1 revision) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9ddf43a38c7..0112b94ac90e > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC orphis@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: None > Tbr: orphis@google.com > Change-Id: I62f197e6d5c64a57903baca3fb8166edfcf214e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406140 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#806177} TBR=orphis@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: I828d06841241b9f09425e50b4d7335705a45d0a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406699Reviewed-by:
-
Wenbin Zhang authored
This reverts commit 68b7ac65. Reason for revert: Android builders on perf waterfall start failing since https://chromium-review.googlesource.com/c/chromium/src/+/2404674. Reverting the CLs after that. Original change's description: > Roll src-internal from 0112b94ac90e to 2ec1f5c76dcd (5 revisions) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0112b94ac90e..2ec1f5c76dcd > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC sebsg@google.com,orphis@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: chromium:1103401,chromium:1124063,chromium:1126022,chromium:903249 > Tbr: sebsg@google.com,orphis@google.com > Change-Id: Ice046ba66d8ef5ba3e3a2cc57b6d0c1dde6b400f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406252 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#806204} TBR=sebsg@google.com,orphis@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: Ia6931517e083808129e422a488609f12c568ce82 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1103401 Bug: chromium:1124063 Bug: chromium:1126022 Bug: chromium:903249 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406520Reviewed-by:
-
Wenbin Zhang authored
This reverts commit 4555891d. Reason for revert: Android builders on perf waterfall start failing since https://chromium-review.googlesource.com/c/chromium/src/+/2404674. Reverting the CLs after that. Original change's description: > Roll src-internal from 2ec1f5c76dcd to 409a8e40330a (3 revisions) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ec1f5c76dcd..409a8e40330a > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC chanli@google.com,sebsg@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: chromium:1039881,chromium:1040645 > Tbr: chanli@google.com,sebsg@google.com > Change-Id: Iaeecf2709aab0a23ea5cdf3dffce8f39ad926098 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406373 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#806249} TBR=sebsg@google.com,chanli@chromium.org,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: Iadbd707c0f0f91c5a85b4f92236ea9d7cf6fb4a9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1039881 Bug: chromium:1040645 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406687Reviewed-by:
-
kylechar authored
SurfaceAggregator::Aggregate() could attempt to use the last entry in |dest_pass_list_| without verifying there was anything in it and crash. There is an early exit for an empty list, but it's after the code uses the last entry in the list. The way that member variables are used during Aggregate() is a bit awkward, many of them are used only for the duration of Aggregate() to avoid passing variables around and need to be reset, while others need to persist after Aggregate(). While it would be best if the temporary state needed during Aggregate() was refactored out, this CL adds a member function to reset variables needed only during Aggregate(). This allows moving the early exit before using |dest_pass_list_|. Bug: 1126897 Change-Id: Ie6979a637ba1f3f301394171ca74064fccc5c4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404473Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#806322}
-
Jazz Xu authored
This CL create a bubble for MediaTray and display MediaNotificationListView which got from MediaNotificationProviderImpl. Bug: 1122419 Change-Id: I7cb9a999f6629b63f896e9919e1692a57d168713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376982Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806321}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a1ecebbc8338..7870cf3f0a34 2020-09-11 syoussefi@chromium.org Vulkan: Fix RAW hazard with storage images 2020-09-11 geofflang@google.com Flush less frequently in QueryGL. 2020-09-11 courtneygo@google.com Vulkan: Use current commandBuffer pointer 2020-09-11 courtneygo@google.com Enable precision qualifiers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1078754 Tbr: ianelliott@google.com Change-Id: I369e397e2d5f3ded08991272e302918c6f4a6c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404618Reviewed-by:
-
evliu authored
This CL adds the //third_party/soda/ path to .gitignore. This third-party repo will be imported from src-internal/DEPS and contain the files required to test the Speech On-Device API(SODA). Bug: 1122784 Change-Id: I0513a157a83f72781e0db444acb7d5e6f0f43318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386459Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#806319}
-
Kyle Horimoto authored
This CL changes FeatureStatusProviderImpl logic to check whether DeviceSyncClient is ready before continuing. In real-world usage, this will always be the case, but on the Linux emulator this condition is not true, causing a crash. Bug: 1106937 Change-Id: Ie99d4085697867b730b81e52f28b0afdbb7a46f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405901 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806318}
-
Xi Han authored
Bug: 1127433 TBR: fhorschig@chromium.org Change-Id: I5d41b285bbd7c02e87d05e3623b828c6d2de22b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404889Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#806317}
-
Erik Chen authored
Change-Id: I34d76c9d3de95f66610bbd0124b476d7d35f875c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406598 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#806316}
-
John Chen authored
The test has been disabled for almost a year, and all crash dumps are gone. Reenable test to see if it is still flaky, and collect new dumps if needed. Bug: 1003776 Change-Id: Iccd4bd23b102e1e3c6d1346c04443c4d2e540096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363360 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
-
Josh Nohle authored
Instead of accessing the device name pref directly in the settings mojo implementation, use the local device data manager to get and set the device name in addition to observing for device name changes. Fixed: b/168138411 Change-Id: I610d653b640a36a5128ff66bb9e3c99b5aa7e538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404715 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#806314}
-
Matt Menke authored
There are only four URLRequestJobFactory implementations, and all but URLRequestJobFactoryImpl are test-only. This CL removes one of them, one is for FTP, which is deprecated. The last is for Cronet, which may take some effort to unwrangle. Ideally we'll eventually remove URLRequestJobFactory as well, but until then, this simplifies things a bit. Bug: 354158 Change-Id: I7e644ce6690692adc1231cf3a1464743ced073fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394155Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#806313}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dd680639768f..aeac9f88598d 2020-09-11 philipp.hancke@googlemail.com build: move rtc_prefer_fixed_point If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idf443654be4b2a67c950d9a8e35d5aece6b66159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406318Reviewed-by:
-
Hoch Hochkeppel authored
Re-working the tests for PostAsyncResults to by 2 typed tests run on 3 types, rather than 6 stand-alone tests. This reduces the code duplication without reducing the readability of the tests, and sets up well for adding additional methods to post_async_results that should be tested over the same set of types. For examples of the kinds of additional functions anticipated, see these abandoned crs: https://crrev.com/c/1981255 https://crrev.com/c/2386099 Adding said additional functions will be pursued as an independent change. Change-Id: I92c46760de15d6876eb73f7f3b49135b1d1570c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406492 Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#806311}
-
Michael Bai authored
Starts recording when the task is actually scheduled. Currently the recording is reset for every change, it caused the task delay time is shorter than it should to be. Test: passing existing test. Bug: 112742 Change-Id: I5c31a286b483d4f68ee892b9aa850aadaf62dc49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404799Reviewed-by:
-
Trevor Perrier authored
This CL adds the DetailedLanguageSettings feature to chrome://flags on Android. Bug: 1068667 Change-Id: I6b4bc7aeb0fe00741ea553e89459713834f79e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405942Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#806309}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ib31bd7df9b8002235c55b6192461efde35d322d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406176Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> Commit-Queue: Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#806308}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkSelectTest* Change-Id: I7b10ffe2e7080941bddc5adeee3bb65e18fb0463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404071 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#806307}
-
manukh authored
Local entities has launched through GWS. The chromium feature & flag are defunct. Bug: 1115108 Change-Id: I9d1f8094fea51e9a40413a60e6bf7faa7700bc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405707Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#806306}
-
Christian Dullweber authored
A couple of WebsiteSettings are missing from histograms.xml. Add the missing ones. Bug: 1095078 Change-Id: Ie4b3b93355a4622626d087395556801b2840bb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404443Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
Robbie McElrath authored
This CL adds tests for most Site Settings UI surfaces, including each Fragment type, popup type, and links to system settings activities. Bug: 1122705 Change-Id: I3232d490a8798adf9553629f4d5634221e83e100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382483Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#806304}
-
Orin Jaworski authored
This CL fixes a bug where clicking the omnibox would reset the line state to normal but not clear keyword mode. The expected behavior when clicking with keyword mode active is to not reset line state. Bug: 1127291 Change-Id: I4c081add27ead2058189a89940b980f8281841e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406352Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#806303}
-
Lei Zhang authored
- Use auto, = default, and std::make_unique(). - Remove content:: in namespace content. - Fix a few nits along the way. Change-Id: I55912384dcb5dff2d9a16b14706dca687b65aa75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404955Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#806302}
-
Richard Townsend authored
LLD has a known code-generation defect around setjmp/longjmp on this platform. Temporarily workaround by passing /guard:cf,nolongjmp which should stop the crashing until LLD's fixed. Bug: 1126549 Change-Id: I26871b23428bcbeaff7cda7cd136cdd3414eaa54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405755 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#806301}
-
Daniel Classon authored
Adds deep link to the enable SIM lock toggle on the Internet Detail subpage. Bug: 1115732, 1084154 Change-Id: Id3a7c85990e247d7238ba112e0b3e9f13b3c7836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353535 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
-
Gang Wu authored
Switch to tab is not fully enabled on Android yet, so those metrics still needed. Change-Id: Ib95b879c65f2ed1dc8298710d515ccd5eef449bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405895Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806299}
-
Dirk Pranke authored
This reverts commit 56428611. Reason for revert: Relanding now that the internal failure has been fixed. Original change's description: > Revert "Rename wrapper_scripts for generated_script tests in MB." > > This reverts commit 8700df8a. > > Reason for revert: > > Android builders started failing since this commit: > https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/217957 > > Traceback (most recent call last): > File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 105, in Main > ret = self.args.func() > File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 378, in CmdGen > return self.RunGNGen(vals) > File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 961, in RunGNGen > ret = self.GenerateIsolates(vals, isolate_targets, isolate_map, build_dir) > File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 1075, in GenerateIsolates > command, extra_files = self.GetIsolateCommand(target, vals) > File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 1392, in GetIsolateCommand > 'generated_scripts can no longer customize the script path') > AssertionError: generated_scripts can no longer customize the script path > > > Original change's description: > > Rename wrapper_scripts for generated_script tests in MB. > > > > A few tests (some Android resource_sizes tests, and one Perfetto > > test), were using generated_script tests that were generating > > wrappers that weren't named 'bin/run_$target_name'. > > > > We want all generated_script tests to be using consistent names, so > > this CL changes those targets. > > > > Bug: 816629 > > Change-Id: If447fbee6b33637de4c9711e87379128272285af > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380672 > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Reviewed-by: John Chen <johnchen@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#802694} > > TBR=dpranke@google.com,agrieve@chromium.org,johnchen@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 816629 > Change-Id: I11ec06405105860f01f3b7752df2024615f7badc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384069 > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802984} TBR=dpranke@google.com,agrieve@chromium.org,johnchen@chromium.org,wenbinzhang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 816629 Change-Id: I44017e48dc94a1af692a66e00bbd3a127b32b382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405793 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b686cc006318..970bf5ad2cd0 2020-09-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I9b8d9888b13f79dcc1c2eea909160b13bcb0a830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406472Reviewed-by:
-
Daniel Hosseinian authored
Navigate to the corresponding PDF page when the thumbnail is clicked on. Bug: 652400 Change-Id: I793a14f4b15b30506e2eaa22c87f6bf432ddd583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402180 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#806296}
-
Joshua Berenhaus authored
Adding the comma in so the message looks right! Change-Id: I2b2ee8da289df56914e986f36548f1fa03bfdb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406672 Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#806295}
-
Josh Nohle authored
Create a default device name of the form <profile name>'s <device model>. The profile name is retrieved in the same way as profile_info_handler.cc [1]. So, the name should be consistent with the one shown in Settings > "You and Google". The device model is set to model name from SysInfo HardwareInfo. If the model name is empty, a variation of "Chromebook" is used for Chrome OS and "device" for other platforms. [1]https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/webui/settings/profile_info_handler.cc;l=132-168;drc=b93f16ad9f7a986d964033bbd539a8eec677bfbf Bug: b/154863679, 1127017 Change-Id: I219cc3965ae0180f66c3953f0a9213dc5c55a1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298169 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Avi Drissman authored
Use a plugin child process, which doesn't have library validation. This way, loading the nss3 dylib into the process will work. Bug: 1111241 Change-Id: I8c9c6c0c77ac345bfb73e1574bccebc0db9dd791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404487Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#806293}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9f91f3564a76..e53ee0c93173 2020-09-11 jleconte@google.com Fix WebRTC Perf Test gtest_filter. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1123318 Tbr: skyostil@google.com Change-Id: I06b98fbdc0de8f154abadd67a9151c60e8ccac46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406354Reviewed-by:
-
