- 06 Jan, 2021 40 commits
-
-
Collin Baker authored
This reverts commit 2d4506ca. Reason for revert: build failure https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/20860? Original change's description: > Build the BoringSSL command-line tool > > It contains a benchmarking command that should help confirm the > impact of https://chromium-review.googlesource.com/c/chromium/src/+/2595350. > > Change-Id: Id69232190a3b29538162c46568cf12558606fd44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595253 > Commit-Queue: David Benjamin <davidben@chromium.org> > Commit-Queue: Adam Langley <agl@chromium.org> > Auto-Submit: David Benjamin <davidben@chromium.org> > Reviewed-by: Adam Langley <agl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840764} TBR=davidben@chromium.org,agl@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I7385f137a68b92becbbe4765b1c67b797211f2b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613519Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#840793}
-
cfredric authored
writes and reads. Change-Id: Ib071d8444d8fa67409d69cdaaafd75998db2d35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611965Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#840792}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4dde23fea599..1bd38fed1b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I77194ebc1469fcddf66ff88af32f7e1e801054a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612478Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840791}
-
Dominic Mazzoni authored
Note that we have our own dashboards outside of uma.googleplex.com so some automatic rollovers of histograms are not happening. This change also moves the TextToSpeech histograms to the accessibility/ subdirectory from other/, as we're the same team that owns those. Bug: 1153776, 1153775, 1153725, 1153724, 1153722, 1153717, 1153719 Change-Id: I24c2d313a63457060f5513a365eda41c5ef27240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605566 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#840790}
-
Chait Pinnamaneni authored
Request headers will show empty decoded data https://i.imgur.com/dwRxcMK.png Bug: 1160346 Change-Id: Idd7fef49f8f3ead4736f253c9dead61c5ff2d1ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605396 Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#840789}
-
Bo Liu authored
This is generating a significant number of crash reports that it's affecting ability to evaluate other crashes. There are reports from beta already, so going to remove the DumpWithoutCrashing and merge it before hitting stable. Bug: 1142569, 1037760 Change-Id: Id91b95a385ee91e0e065ec46e5f25a779f6e0c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612525Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840788}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a84acc4fcca8..f1fa60b91230 2021-01-06 senorblanco@chromium.org Use Jamie's 7-layer burrito of Vulkan DEPS. 2021-01-06 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from e6e704145b31 to 40b4928a73b7 (11 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I3fc54132192f7765a63e045db83300eb900d9252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612841Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840787}
-
Wei Li authored
When a signin dialog is created with modal type MODAL_TYPE_CHILD, it uses a web modal dialog paenting to its browser window. For this dialog, the shadow would be the standard bubble shadow. Specifying SMALL_SHADOW or BIG_SHADOW has no difference. So change to use the more standard SMALL_SHADOW, and will eventually remove all BIG_SHADOW usages. Bug: 940027 Change-Id: Ic23e533f502b764a0b857ddec01a90289ed2ba68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611639Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#840786}
-
David Bokan authored
Overlay scrollbars are enabled based on platform, though without a user option (in Chrome UI), so the runtime feature enabling/disabling them must remain. However, the about:flag has been expired since M76 and can be removed. Change-Id: Id9269637369e393556937cb2b231646eed202e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602895 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#840785}
-
Jeffrey Young authored
Previously an ambient mode settings update was issued as soon as the settings page was loaded. This is due to a change listener on temperature unit activating after fetching initial settings. New behavior only issues update settings request if temperature unit setting has changed. BUG=b:165098195 TEST=unit_tests --gtest_filter=AmbientModeHandlerTest.*Temperature* Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I63683bd6e150db4e235ca92287f7f8e0e3233d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602433 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#840784}
-
Yuke Liao authored
This CL supports --tast-vars in build/chromeos/test_runner.py to allow specify runtime variables to invoke Tast tests, and the immediate use case is to support running Lacros tast tests on Chromium CI. Bug: 1158590 Change-Id: I231e0960fb9e7737b97f5be6041d295f9f5b1b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604299Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#840783}
-
Mathias Bynens authored
Previously, we created a wrapper <div>, added an `id` attribute to the <input type=checkbox>, and added the corresponding `for` attribute to the <label>. This patch simplifies the implementation as follows: - We get rid of both the `id` and `for` attributes by wrapping the checkbox and the text label inside of the <label>. - We then also get rid of the wrapper <div>. This simplifies the code and reduces the resulting DOM size. This patch also improves the UI: now, the entire horizontal bar can be clicked to toggle the checkbox, as opposed to just the checkbox itself + the text label (whose length is variable, based on the user’s locale + font sizing/zoom preferences). Tests: autoninja -C out/Release blink_unittests out/Release/blink_unittests --gtest_filter=HTMLViewSourceDocumentTest.* Bug: chromium:920571 Change-Id: I42873f62d94b264a1b7edf3567e539301be07ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598907 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#840782}
-
Alex Newcomer authored
Add some metrics which will allow us to understand performance and possible issues on different devices. Change-Id: I12077149d56303b0241add20e4613ff3eb62a1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587656Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#840781}
-
Findit authored
This reverts commit cd5cde24. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 840681 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2Q1Y2RlMjRjMzVlMWM5MmY5YjQxYTUyODdkY2Q0YjZlODZkNzY2Ygw Sample Failed Build: https://ci.chromium.org/b/8858820663595122608 Sample Failed Step: weblayer_browsertests Sample Flaky Test: SubresourceFilterBrowserTest.ContentSettingsAllowlist_DoNotActivate Original change's description: > [Subresource Filter] Add content settings-based adjustment to WebLayer > > This CL incorporates Chrome's adjustment of subresource filter page > activation decisions based on content settings within WebLayer. To do > so, we have the shared SubresourceFilterSafeBrowsingActivationThrottle > directly invoke the logic in question rather than having > ChromeSubresourceFilterClient do so. That change necessitates some > others, also made in this CL: > - WebLayer brings up ProfileInteractionManager. > - SubresourceFilterClient provides an accessor for > ProfileInteractionManager. > - SubresourceFilterSafeBrowsingActivationThrottle calls the adjustment > logic via a new Delegate interface rather than doing so via > SubresourceFilterClient. This interface is implemented by > ProfileInteractionManager in production while allowing for porting of > tests that provide custom (or nil) stub logic. > > We also add browsertests of this interaction in //weblayer. > > Note that this CL does not do any incorporation of the relevant *UI* > for content/site settings of ad blocking in WebLayer; that will be > followup work. > > Bug: 1116095 > Change-Id: I394e62f12d5209a4302ffa57de9095c861b59613 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603574 > Commit-Queue: Colin Blundell <blundell@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840681} Change-Id: Ifda417fda7229cd6c7eca17174b65cdf6d314193 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611616 Cr-Commit-Position: refs/heads/master@{#840780}
-
Xing Liu authored
We should expect ReadingListManager::Add to return nullptr when the title can't be parsed as UTF strings, or the URL scheme is not http or https. Bug: 1157808,1163225 Change-Id: I1d4e9ceb74f2821bda19907936d43919c8cc9dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611628Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840779}
-
Cattalyya Nuengsigkapian authored
- save a workspace in window's property. - trigger saving to browser session when property is updated, but need force saving in `WindowOpened()` for newly created window. - restore each window to the right desk by assigning to the right parent desk container in `GetDefaultParentForWindow()`. - resolve desk activation conflict between browser session and an active desk restore by checking `IsSessionRestoreInProgress()` in ash to avoid every single window activation during restore. - resolve the parent desk conflict between the first restored window and a blank window by stop reusing the blank window for restore and always create a new window during restoration. - resolve clobbering tab restore by passing null browser when using desks restore feature. - add browser tests checking that each window restore to the parent desk if DesksRestore enabled, otherwise to the first desk, which is a default active desk after a crash. `browser_tests --gtest_filter=*SessionRestoreTestChromeOS*` Bug: 996999 Test: Manual test (a video in crbug comment 27) and browser tests Change-Id: I0f9202e10a7b861a676725e7390b15fd71a00933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572316 Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#840778}
-
David Van Cleve authored
When executing "platform-provided" trust token issuance requests (https://bit.ly/platform-provided-trust-tokens), TrustTokenRequestIssuanceHelper makes a delegate call that eventually gets ferried to the content embedder and comes back with a FulfillTrustTokenIssuanceAnswer::Status, which is (currently) a tri-state representing "success," "operation not supported," or "error". Logging this in TrustTokenRequestIssuanceHelper will let us evaluate the proportion of attempts at executing platform-provided trust token issuance that have sufficient embedder support, which, as the linked design doc describes, is a useful liveness metric to monitor during the feature's preliminary experiment launch. This CL adds a new metric recording this status; to test that the metric is logged correctly, the CL modifies existing platform-provided issuance unit tests in trust_token_request_issuance_helper_unittest and adds HistogramTester assertions. Fixed: 1162976 Change-Id: I492b5e9b95d19d51206cd85bb87351df5a76f74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610285Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#840777}
-
Collin Baker authored
ConvertJPEGDataToImageSkiaAndNotifyObservers() copies ThumbnailImage::data_ (which is a scoped_refptr) and posts a task referring to it to another thread. ThumbnailImage::ClearData() cleared the data behind the pointer before resetting the pointer. This led to a race condition where the data was being cleared on the UI thread and read on a background thread without synchronization. This CL simply resets the pointer in ThumbnailImage::ClearData() without modifying the wrapped data. As long as the data inside is treated as immutable, this is safe: updating ThumbnailImage::data_ does not change data that outstanding tasks see. Fixed: 1160146 Change-Id: I5ef9e1712cc5935f85d1b8d9226588cc43921b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611174Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#840776}
-
Mei Liang authored
This reverts commit c5868cd1. Reason for revert: root cause for crbug.com/1163561 Original change's description: > [Android] Test account management view for child account > > This CL adds two render tests for account management view in child > account mode when the sign-out option should be hidden. > > Bug: 1045525 > Change-Id: I9e53396fe642c78eaa37dd04457cfcf72730109e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597553 > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Victor Vianna (OOO 21/12-05/01) <victorvianna@google.com> > Commit-Queue: Alice Wang <aliceywang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840107} TBR=triploblastic@chromium.org,victorvianna@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,aliceywang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045525 Change-Id: Id37caf103ae1e4122d580b99a19556466972a086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612373Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840775}
-
John Lee authored
This CL updates each card in the Settings page such that rows that may appear at the very top of the card to not have top borders to prevent double borders caused by a top border and the card's shadow. Bug: 997034 Change-Id: Ie6337d9f08c094c712aaac8e73b3c3ab6c8f84c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601332Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#840774}
-
Joshua Pawlicki authored
Bug: 1163625 Change-Id: Icc09ec86b33393670cce2aa39265f2fc1b473a77 Fixed: 1163625 TBR: sorin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611292Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#840773}
-
Joe DeBlasio authored
This CL is a small change to announce the arrival of a MIX-DL alert to accessibility devices. We don't have testing infrastructure for accessibility in the downloads shelf right now, and this is a trivial change, so it's submitted without tests. I manually verified that this works as expected on Mac OS. Fixed: 1131084 Change-Id: Ie68a4f6ed5f71a25553deb2a776a7dcd3adf30a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606669Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#840772}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/32d68537a88c..b746b1f59851 2021-01-06 reed@google.com Pass sampling to surface.draw 2021-01-06 kjlubick@google.com [canvaskit] Fix examples with makeShaderCubic 2021-01-06 johnstiles@google.com Avoid emitting duplicate constant values in SPIR-V. 2021-01-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 069b8f699b59 to 8247d3c2481b (1 revision) 2021-01-06 robertphillips@google.com Add GrDDLTask::dump method 2021-01-06 ethannicholas@google.com Refactor some IRGenerator functions 2021-01-06 egdaniel@google.com Track resources on GrVkCommandBuffer as sk_sps. 2021-01-06 egdaniel@google.com Move GrcommandBufferRef.h to more generic GrRefCnt.h 2021-01-06 robertphillips@google.com Fix DefaultGeoProc member variable names 2021-01-06 egdaniel@google.com Add workaround to use full screen loads for vk discardable msaa. 2021-01-06 nifong@google.com Accept a callback used in MultiPictureDocument::endPage 2021-01-06 jcgregorio@google.com Include svg module in Doxygen generated output. 2021-01-06 johnstiles@google.com Clean up constructors for SkSL Literal types. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Ib4e60971a4b6f69ee2dc8830e27e3d7a80b35209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611415Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840771}
-
Guillaume Jenkins authored
Adds logic to the Sync & Google Services view mediator to disable the sign-in button when browser sign-in is disabled by policy. The info button's popover menu explains that sign-in is disable by the managed browser's organization, and provides a link to the chrome://management page for more information. No special handling is needed for the mobile identity consistency experiment because when it is enabled, the sign-in entry point in Google Services is removed from the UI. Screenshots of the new UI when sign-in is disabled: https://screenshot.googleplex.com/38iQWPYitD7hKCo https://screenshot.googleplex.com/4ozvEWnJLqdnzsY Bug: 1155745 Change-Id: I9348e6ae724d40ab8b38c39f45726bac0c8f5fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594011 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#840770}
-
Xiaocheng Hu authored
Bug: 1161232 Change-Id: I022b51133370062c9419198f44e2a5723256825e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613364Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#840769}
-
Clark DuVall authored
All DFMs now support isolated splits, so we no longer need to support merging DFMs into the chrome module. Bug: 1126301 Change-Id: Ibd166690e3d3987537ea10ece93e97c88085e1de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613461 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#840768}
-
Cattalyya Nuengsigkapian authored
This is a reland of http://crrev.com/c/2604907, which was reverted by http://crrev.com/c/2611090 due to flakiness of the test ModeSelectionWindowCycleControllerTest.CycleShowsWindowsPerMode. The issue is that CompleteCycling() activates a window in another desk, so deskSwitchAnimation takes a screenshot and sometimes fail if the test ends before it is taken. Original CL description: Regardless of where the highlight position is, after switching alt-tab mode, the highlight will be reset to the first or second window. This is consistent with highlighting when users first enter alt-tab mode: - In general case, highlight the second (next) most recently used window after the current one. - In the special case that the most recently used is minimized, highlight itself (the MRU window), so tabbing into it causes it to unminimize rather than opening up the next window in the list. - Track mode switching state in the controller to differentiate between normal tab pressing and mode switching. - Add Ash unit tests for both cases. `ash_unittests --gtest_filter=ModeSelectionWindowCycleControllerTest.SwitchingModeUpdates*WindowHighlight` Bug: 1157100 Test: Manual test (a video uploaded to crbug) and ash unit tests Change-Id: I9d3c3ee34e18b40c7d490b990f1a7171d8d8f37f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604907Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#840348} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613266 Cr-Commit-Position: refs/heads/master@{#840767}
-
Sophie Chang authored
Bug: 1154790 Change-Id: I57c821baae2e74c0da4b24a8d6639313f7550912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613525Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840766}
-
Brian Sheedy authored
Enables the VR instrumentation tests on android-10-arm64-rel, which is already running the AR instrumentation tests. Bug: 1163311 Change-Id: I28e49ac00431bf2a70f77131af530b49e2bc8e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611750 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#840765}
-
David Benjamin authored
It contains a benchmarking command that should help confirm the impact of https://chromium-review.googlesource.com/c/chromium/src/+/2595350. Change-Id: Id69232190a3b29538162c46568cf12558606fd44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595253 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#840764}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b631a88c6eeb..6650f7c2385e 2021-01-06 nodir@chromium.org [dirmd] Roll dirmd to 3d533070 2021-01-06 sokcevic@google.com Update error message if unable to determine branch 2021-01-06 ehmaldonado@google.com presubmit: Don't print comments for missing reviewers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1154541,chromium:832295 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I2d7be48389b0fc6d1a5b6c3ee2907e6f0728a2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612366Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840763}
-
Austin Sullivan authored
This CL renames the mojom files and types. Other CLs will further rename implementation and usage of these types. Bug: 1110509 Change-Id: I8f724f86b925f132bb4ed73c5edf208de5753627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601125Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#840762}
-
Devlin Cronin authored
The new doc site forked all the examples into a new repo (outside of Chromium). Remove the old examples. One of these examples (the calculator app) was used in a browsertest. Move it to chrome/test/data/extensions, and the test to chrome/browser/extensions. Bug: 1161364 Change-Id: Ieaaa062455cddfe8c21974cf7e640fa88141e835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602446 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#840761}
-
Dale Curtis authored
This allows the zero-copy construction of RGB frames from CPU backed ImageBitmaps and removes a copy from YUV backed ImageBitmaps. As the formats are now supported, planar access is enabled. Encoding support is enabled by teaching the utility method used by the encoders how to scale and convert RGB frames to I420 and NV12. Fixed: 1161012 Test: https://storage.googleapis.com/dalecurtis/canvas-test.html Change-Id: I3944a4903b8defc5592ba65d4536ec4d0750c861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601678 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#840760}
-
Shengfa Lin authored
Modify release script to handle ChromeDriver for Apple Silicon M1 arm64 as a separate zip file. Bug: chromedriver:3688 Change-Id: I4ff415e40e6da49321985b53bbd31e07da763621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612492Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#840759}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/c6345ca36de9..f88c00e45a2f 2021-01-06 wl@gnu.org * meson.build: Add summary. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I1b25a429bbe73812ca67f68ec0ff9a8f834c3f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613404Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#840758}
-
Joe Mason authored
This creates a simple accessor in RenderFrameHost to check whether a frame is cross-origin isolated. It allows features that are gated behind this policy a way to assert that they are only being invoked when allowed. Currently not all the information needed to determine this is available in the browser process so the accessor returns kNotIsolated or kMaybeIsolated. This also adds such a check to WebMeasureMemory, which is invoked from a renderer with OnWebMeasureMemoryRequested. It terminates the requesting renderer if it is definitely not cross-origin isolated. Based on http://crrev.com/c/2574730 by chrisha@chromium.org, which added IsCrossOriginIsolated to RenderProcessHost instead. BUG=1085129 Change-Id: I2d9d1dd344c85c9358d549fc775282e9736df580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578083Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#840757}
-
Hassan Talat authored
Enabling the Web Share APIs (navigator.Share) on macOS and have it disabled by default. Bug: 1144920 Change-Id: I2d00691f136ced6a8dc85b0478fb69dfeec5a9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607980 Commit-Queue: Hassan Talat <hatalat@microsoft.com> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Hassan Talat <hatalat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#840756}
-
Matt Reynolds authored
This CL addresses two issues: In HidServiceWin, |platform_device_id_map| is initialized incorrectly for devices that do not use report IDs. The item added to the map incorrectly has an empty |report_ids| vector which effectively means that the corresponding device ID will never be used. To fix it, the |report_ids| vector is initialized with a single element with value 0, indicating that the corresponding device ID should be used for all reports. In HidConnectionWin, when the connection is closed the |transfers_| list is cleared. If |transfers_| was non-empty, this will invoke the destructor of any PendingHidTransfer objects that were in the list. If the callback calls UnlinkTransfer, the DCHECK is hit since |transfers_| is already cleared. To fix it, the callbacks should check |signaled| and only call UnlinkTransfer when the file handle was signaled by the OS. Bug: 1163277 Change-Id: Ic7897a9373afdd0a2045c8bc89bce7478f9ddf29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612505Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#840755}
-
Evan Stade authored
Since these classes depend on blink types, they're moved to //components/site_engagement/content. In the future, for the purposes of ios support (bug 775390), these classes will likely need to be refactored to remove that dependency and move from content to core. Bug: 1147274 Change-Id: I1aae22152029a2e4ea52909137d555cb8e738ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599932Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#840754}
-