- 21 Aug, 2019 40 commits
-
-
Vasiliy Telezhnikov authored
This CL re-enables all tests in the suite. browser_tests are flaky, but all known differences with SkiaRenderer have been fixed. Please add vasilyt@chromium.org and jonross@chromium.org for new bugs related to flakes in this suite. Test: skia_browser_tests Bug: 982933 Change-Id: I6e5427d427aa22d5a4d38645b58f9b718c3239af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764251Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#689192}
-
Gabriel Charette authored
This reverts commit eb651697. Reason for revert: the culprit was another one of my CLs! Original change's description: > Revert "[TaskEnvironment] Standardize paradigm for classes forwarding traits" > > This reverts commit 7472b906. > > Reason for revert: sheriff suspects this caused a build break on win{,32}-archive-rel: > > https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/4309 > > In file included from ../../chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc_unittest.cc:14: > In file included from ../..\base/test/scoped_task_environment.h:15: > In file included from ../..\base/task/lazy_task_runner.h:17: > ../..\base/task/task_traits.h(263,5): error: static_assert failed due to requirement 'has_thread_pool ^ has_extension' "Traits must explicitly specify a destination (e.g. ThreadPool or a named thread like BrowserThread)" > static_assert( > ^ > ../..\chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc.h(108,39): note: in instantiation of function template specialization 'base::TaskTraits::TaskTraits<base::MayBlock, void>' requested here > base::CreateSequencedTaskRunner({base::MayBlock()}); > ^ > 1 error generated. > > Original change's description: > > [TaskEnvironment] Standardize paradigm for classes forwarding traits > > > > As discussed @ > > https://chromium-review.googlesource.com/c/chromium/src/+/1749538/6/ash/test/ash_test_base.h#84 > > > > Usage of explicit everywhere also avoids implicit copy construction > > and is the reason for changes to a few unit tests that previously > > used operator= to initialize their task environments. > > > > TBR=dcheng@chromium.org > > (for widespread mechanical change) > > > > Bug: 992483 > > Change-Id: I321576674f3b387a6f5069e8e71eebf41c98e7ed > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758338 > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Commit-Queue: Gabriel Charette <gab@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689098} > > TBR=dcheng@chromium.org,gab@chromium.org > > Change-Id: I69b71b220ab583bc3a18e8fb07213fa1b6a75b50 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 992483 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762475 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689122} TBR=ellyjones@chromium.org,dcheng@chromium.org,gab@chromium.org Change-Id: Ibc0ab9c4df6dcbc4a65fd26e0356c78e8b0f90b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 992483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764390Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#689191}
-
gogerald authored
Bug: 982018 Change-Id: Idb97cf0d324b4addc23a8ced0c75facb4096c126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757508 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#689190}
-
Kyle Milka authored
When the daily refresh toggle was deselected it was applying the selected state to the wrong element. Bug: 996147 Change-Id: I76bbb4590701636a56439940f1d69afe359661ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763339Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#689189}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2891cbc02f12..2d256c406cde git log 2891cbc02f12..2d256c406cde --date=short --no-merges --format='%ad %ae %s' 2019-08-21 treehugger-gerrit@google.com Merge "[GPU TRACE] Add GPU scheduling trace events" 2019-08-21 primiano@google.com Merge "Remove use of -isystem for googletest" Created with: gclient setdep -r src/third_party/perfetto@2d256c406cde The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I19c290c53bb20801185f414fa8c8026a29108089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764456Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689188}
-
Lutz Justen authored
Adjusts the icon of the Kerberos tickets based on the mocks in go/cros-kerberos-ux part IV: The Forgotten Things. - Adds a toast for ticket refresh - Removes space for general error in kerberos-add-account-dialog and makes the dialog resize when error shows up. BUG=952232 TEST=Compare Kerberos UI with UX mocks, see go/cros-kerberos-test and go/cros-kerberos-ux. Observe in awe that they match. Change-Id: Ic98a6abdf44aae881dfac1953cf599986f3f0cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728576 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#689187}
-
Kyle Milka authored
Bug: 996098 Change-Id: Ia7486e26c3225ff40a8fb9af36520788db0b58e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763342Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1d83e1e8a17e..24456989e21b git log 1d83e1e8a17e..24456989e21b --date=short --no-merges --format='%ad %ae %s' 2019-08-21 lujc@google.com Fix incorrect parameter in gl_angle_ext.xml 2019-08-21 syoussefi@chromium.org Vulkan: Support non-pow2 buffer alignments Created with: gclient setdep -r src/third_party/angle@24456989e21b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org,jonahr@google.com Bug: None Change-Id: Iedab9f61f80cc099be0eb53d6afcd52bd200ea19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764454Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d60490eeff86..7719c19e556f Created with: gclient setdep -r src-internal@7719c19e556f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I6ecf830dcdd39567fc86d6ed33005e577c5c95a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764458Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689184}
-
Jonghyun Ahn authored
Bug: 994989 Change-Id: I92f7cf9a1ee321e46cd5d3cf65ea50e0c18b9f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761334Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Jong Ahn <jongahn@google.com> Cr-Commit-Position: refs/heads/master@{#689183}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aa3cbb81b706..9e081d164c81 git log aa3cbb81b706..9e081d164c81 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 herb@google.com Don't send strike with no pending glyphs 2019-08-21 jlavrova@google.com Bug fixes for Flutter 2019-08-21 brianosman@google.com SkRuntimeShaderMaker -> SkRuntimeShaderFactory 2019-08-21 egdaniel@google.com Move CopyOps to CopyRenderTask. Created with: gclient setdep -r src/third_party/skia@9e081d164c81 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: Ie046f8dd97d6c03e32b0ac85a9310a2759a67fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764453Reviewed-by:
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread. This CL makes PaymentAppBrowserTest tests pass when run with ServiceWorkerOnUI enabled. It is fairly mechanical. One tricky part is whether the callbacks here need to be called asynchronously. In some cases we may already be on the thread the callback needs to run on, the CL still uses PostTask() to run the callback in case sync callbacks are not ok. Bug: 824858 Change-Id: I195d4ce93d267d9417a1e671d64b3d6ae4a8acc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763551 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689181}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ad86dfbd3219..722aa0bc8abe git log ad86dfbd3219..722aa0bc8abe --date=short --no-merges --format='%ad %ae %s' 2019-08-21 tcwang@google.com afdo: Add empty builders to verify and publish kernel profiles. Created with: gclient setdep -r src/third_party/chromite@722aa0bc8abe The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9ae317959212b22b4b578349e5e36537f2651580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764329Reviewed-by:
-
James Forshaw authored
This CL adds a call to a Win32k API to check if it is really disabled by the mitigation. Change-Id: Ibab06e93db59c326b0df79ea562198e055beb88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764178Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#689179}
-
Evan Stade authored
The test is leaking. Not sure if it's also failing, so removing the suppression from 64d6e9f9 Bug: 996235 Change-Id: Ie1e5d11dbc7225e47fff3a6c0e62be5b193bdcd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764492Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#689178}
-
Sean Gilhuly authored
Move the source of truth about GPU compositing status from ImageTransportFactory to GpuDataManagerImpl, add an accessor, and check the value in ImageTransportFactory initialization. Update |gpu_feature_info_| with the status. This is done to reduce reduce gpu state duplication. ImageTransportFactory and CompositingModeReporterImpl still contain a bool for gpu compositing, but they're only privately available, and used as a cache for the compositing state in GpuDataManagerImpl to make sure the fallback action isn't performed more than once. Bug: 819474 Change-Id: I3e28762f34a2ad6c170ca59a72611e65153a6176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708422 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#689177}
-
Takuto Ikuta authored
This will be submit after crbug.com/985705 for https://ci.chromium.org/p/chromium/builders/webrtc/WebRTC%20Chromium%20Linux%20Tester Bug: 954875 Change-Id: I486cb6de5604f00cdfb4a3b9079647e8c21be3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757417 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#689176}
-
Evan Stade authored
It's also failing. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/1377 TBR=kyleju@chromium.org Bug: 856601 Change-Id: Ia58b1682355390080f2faa732dcc5d2570effdb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763260Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#689175}
-
Mehran Mahmoudi authored
This adds the capability to replace a dialog's ModelList while the dialog is being displayed. More details can be found in the crbug. Bug: 993528 Change-Id: I43f8934cd4e138f7a4b99e1ad923b7515dacb46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758547Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689174}
-
Elly Fong-Jones authored
This change: 1) Removes some stub code that was trying to disable a test 2) Fixes SwitchTabsMac on 10.14+, where SendGlobalKeyEventsAndWait CHECKs Bug: 852232 Change-Id: I304c12488de83dcf6c361018f359c776a23cf1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762485 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#689173}
-
Hiroki Nakagawa authored
This CL makes AppCache for frames use new BrowserInterfaceBrokerProxy mechanism instead of DocumentInterfaceBroker. Before this CL, AppCache used DocumentInterfaceBroker for frames, and BrowserInterfaceBrokerProxy for workers. That complicated the code. After this CL, both frames and workers use the same BrowserInterfaceBrokerProxy mechanism. Relevant CL for AppCache for workers: https://crrev.com/c/1746128 Bug: 936482 Change-Id: I6f30ddec6d2055c9e4748c42a41c031f6c220b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758038 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#689172}
-
Brian Liu Xu authored
This patch fixes logic for snapping layers to physical pixel boundaries, when pixel canvas is not enabled, by allowing the subpixel offset to be dynamically computed. Previously, layers could get stuck at 100% DPI pixel boundaries (making some UI blurry on platforms where fractional scale factors are used, e.g. Windows), as once an explicit value was set, the offset would no longer be dynamically computed. This patch - Updates SnapLayerToPixelBoundary to stop View from setting explicit subpixel offsets for non-pixel-canvas platforms so that they may be auto computed. - Updates view_unittest. Bug: 992730 Change-Id: I8e8c87107f13157e92f125bcfb281226ebc6c422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761301Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Brian Liu Xu <brx@microsoft.com> Auto-Submit: Brian Liu Xu <brx@microsoft.com> Cr-Commit-Position: refs/heads/master@{#689171}
-
Tim Judkins authored
Moved the key for this pref and the logic for getting / setting it from ScriptingPermissionsModifier to ExtensionPrefs. This lays the groundwork for making it cleaner to set this value on installation if permissions were withheld on installation. Bug: 984069 Change-Id: I5580dfbdd57f4e2a3e92dd7b62b02bf04b35fee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762720Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Tim Judkins <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#689170}
-
Joel Hockey authored
Ensures that apps with tabs still have the expected tab grab width. Bug: 846546 Change-Id: I43660db954cceb7097bae7998f030da2aa5e22cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763269 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#689169}
-
Hazem Ashmawy authored
Add an activity to show a list of recent WebView crashes ordered by the time they are captured. It's a simple ListView where each item is a TextView that shows: - Crash Upload ID (if the crash is uploaded). - Crash Upload time (if the crash is uploaded). - Crash Upload Status. - Crash Local ID (unique id for the crash report on the device). - Crash Capture time (the time when the crash is captured). - App Package Name (the package name where the crash took place). - Variations (experiments keys that were running when the crash happened). A report button is only enabled for uploaded crashes to provide more info about the crash. It opens a webpage to open an issue on crbug.com using "WebView Bugs" template quoting crash-upload-id. Bug: 948923 Bug: 990189 Binary-Size: This change adds a new ui activity to webview, it also adds many strings which probably caused that large increase in binary size. However, all these strings are marked as not translatable so this should significantly cut down the size increase estimated by the bot. Change-Id: Ie09b4a95da4a2cc60898b69f69f7fde04420240e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700202Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#689168}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0641cddc. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" ecaae252 "Code health refactoring of animation.cc." ff24116c "[css-layout-api] Re-add LayoutEdges." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I5cc34a3af34ae00127390b9f9b5c678444676332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763874Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689167}
-
tby authored
Bug: 959679 Change-Id: I220a180d2f1113404eb51972664f4e60bcb37152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762250Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#689166}
-
Xianzhu Wang authored
This reverts commit a1fe850a. Reason for revert: speculative revert for crbug.com/996037. Original change's description: > Cache animation base computed style only on default StyleForElement() > > StyleForElement() can be used to get the default style (i.e. the > style that will be applied on the element), or style derived from > custom parent style for e.g. inherited first line style. We should > cache animation base computed style in the first case only. > > Bug: 989490 > Change-Id: Ia30b3e7bcd65cdb9456eb925e5c24f156353bff9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753030 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686915} TBR=wangxianzhu@chromium.org,futhark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 989490,996037 Change-Id: Ib12e4e55e70eaeb2c82ca173c145c225c1d79802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763343Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689165}
-
Luum Habtemariam authored
Since ServiceManager went away, we're clearing up some leftover CupsProxyService constants. Trivial change. Bug: chromium:945409 Test: confirmed service behavior unchanged Change-Id: I45ffdeb3b0ad1990798a4a4d5115e791a6eefbfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764430 Auto-Submit: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#689164}
-
Gabriel Marin authored
The perf collector issues dbus commands to run perf as root but the dbus client is not thread safe. Temporarily, map the collector task runner to the current thread (UI), until we can implement a fix in the dbus client. BUG=b:139816773 Change-Id: I02766ed512a10f1868dda7bd58205397997ef9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764319Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#689163}
-
Lily Chen authored
This changes the CookieStore's GetCookieListCallback from taking a CookieList (for included cookies) and a CookieStatusList (for excluded cookies), to taking a CookieStatusList for both. Previously, the statuses of included cookies could be assumed to be INCLUDE, so they did not need to be passed to the callback. The next change adds more nuanced information to CookieInclusionStatus such that statuses must be explicitly passed even for included cookies, hence a CookieStatusList must be provided. This also makes GetAllCookiesCallback take a CookieList only, since the second CookieStatusList parameter (for excluded cookies, of which there were none, since we are getting all cookies) was unused. Bug: 993843 Change-Id: I4c6bedc0c161f863b9a1755bb93e615f2793202e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758437 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
-
Ken Rockot authored
This changes ProfileImpl to own the IdentityService instance directly, lazily initialized by a direct call to Profile::GetIdentityService() instead of going through the Service Manager. Bug: 977637 Change-Id: I6ab794e019fabb8c65c80491ac124778dd0e822f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761217Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#689161}
-
Lan Wei authored
In ExecutePerformActions function, we dispatch key events first, mouse events then touch events, some code are redundant with different pointer types. I cleaned some code shared with different pointer type. Bug: 606367 Change-Id: I27e7e538db8026b87938abd19ae71f59e1c6844a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762769Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#689160}
-
Matt Mueller authored
Fix enforcing RSA certificate keyUsage for known roots when cert verification completes asynchronously. Bug: 795089 Change-Id: Ic830507465887d6bfe13b6fd9e05dc08d9f52dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763636Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#689159}
-
Raymond Toy authored
WebAudio legacy code often does something like: DCHECK(foo); if (!foo) return; The style guide says the if/return should be removed; DCHECK failures should not be handled. Part 2 of N: Update a few more files and for the most obvious cases where we can remove the if/return. Bug: 957654 Change-Id: Ie5a30a67a58b88df9b5eb579d06894c710c9b1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758593Reviewed-by:Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#689158}
-
Peter Kasting authored
This is necessary because ThemeProperties::GetDefaultColor() is never actually reached for COLOR_TOOLBAR_BUTTON_ICON (so the kGoogleGrey100 return in GetIncognitoColor() was dead code). ThemeService::GetDefaultColor() unconditionally uses the tint, which was {-1, -1, -1} in dark mode after http://crrev.com/688233 . This approximately restores the behavior from before that CL, when dark-mode was special-cased for TINT_BUTTONS to just return white. Another way to solve this would be to remove this code from ThemeService, add a "return kChromeIconGrey" to GetLightModeColor() for COLOR_TOOLBAR_BUTTON_ICON, and add processing to browser_theme_pack.cc to compute an override color if the theme specifies TINT_BUTTONS. This would change HasCustomColor() to return true "more accurately" -- i.e. only if the theme customizes the color, instead of what it does now, which is to return true any time the tint is not a no-op. Looking at callers of HasCustomColor(COLOR_TOOLBAR_BUTTON_ICON), they seem to want it to return true in the dark/incognito case, so I've avoided this route for now, although perhaps these callers could be updated (e.g. to check if the returned color was non-default or just unconditionally use the returned color as if it's "custom"). This does not apply the dark tinting to TINT_FRAME*, since doing so will cause dark mode to darken the frame images of every theme that uses them without explicitly setting a manual tint (i.e. almost all themes that use custom frame images). This is sort of an interesting effect, but would almost certainly be considered "breaking" these themes. Bug: 995681 Change-Id: I4dd8a7c24323b5a4caf24b3ad08188f73de028c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762943 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: -
Elly Fong-Jones authored
This test doesn't work and can't be made to work on 10.14+: it requires CGEventPost (because window dragging is handled by the WindowServer), which either pops a permission modal or simply does nothing depending on system config. Bug: 767299 Change-Id: I09e305c0bce83131df4b40a5154b6bd5af52a21a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762476 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#689156}
-
Ben Joyce authored
Need to change for androidx presubmit check. Bug: 767058 Change-Id: I2efb55945ebce3533807a0c63b8044f1cbe3cb54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762545Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#689155}
-
Darwin Huang authored
Turns out that ReadFromClipboard does use the buffer argument. Here's[1] an overload supporting it, and here's[2] a use-case with kDrag. [1]: https://cs.chromium.org/chromium/src/components/bookmarks/browser/bookmark_node_data_mac.mm?rcl=d5f58793b0d31cc3e2f05c23ba3194c4d5191da3&l=42 [2]: https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/tab_contents/web_drag_bookmark_handler_mac.mm?rcl=d5f58793b0d31cc3e2f05c23ba3194c4d5191da3&l=27 Change-Id: I59c2645c865ed52215afaa4c111dcfbca4c26819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763213Reviewed-by:
-
Samuel Huang authored
Previously interface ModuleInstallUi.FailureUiListener has two callbacks: {onRetry(), onCancel()}. This CL merges the callbacks to onFailureResponse(), which takes a |retry| param to distinguish the two cases. This results in a slight savings in method counts (4 right now). Bug: 927131 Change-Id: I2965906f033fc05920657ea4cb1cd7424bc8a86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763640Reviewed-by:Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#689153}
-
