- 18 Sep, 2020 40 commits
-
-
Thomas Lukaszewicz authored
Currently if Tab Scrolling is enabled the TabStrip is allowed to grow beyond the visible bounds of the TabStripRegionView with the help of a ScrollView. Existing caption hit testing uses the TabStrip view to determine whether a rect or point belongs to the caption area. This results in a bug where areas of the browser window are no longer recognized as part of the caption area. This is due to the non-visible parts of the TabStrip continuing to contribute to the hit testing logic as it overflows. This patch updates the TabStripRegionView to support the necessary hit testing logic and ensure that only the visible portion of the TabStrip is used. Bug: 1129703 Change-Id: I49ccf9ba573afba84921a66249ef38723787cbba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411704 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#808579}
-
Sven Zheng authored
They've been stable for the last 2 weeks. The latest gold images I approved PageInfoBubbleViewBrowserTest should be actual ui changes. I also went through 10 recent changes with skia-gold@ commentby. I don't see pixel_browser_tests caused any comments. So I think existing tests plus these tests on FYI should be stable enough. Bug: 1102894 Change-Id: I541877dfee293c427af3fd102cba8a3985f088ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418807Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#808578}
-
Yuly Novikov authored
Switching from a single i3-8100 machine to 3 Xeon E-2288G machines. Also drop driver and OS versions for Linux GTX 1660 bot to simplify upgrades. TBR=kbr Bug: 1042292 Change-Id: I9630d921ae8044ba5ad60e78b8f298a8369d365b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419127 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#808577}
-
Joey Arhar authored
This test produced different output every time it failed since a randomly generated string was being passed to assert_equals. This patch does the same check but prevents the generated string from getting into the error message so we can include it in our failing test expectations. Fixed: 1129420 Change-Id: I5cffb6c3dfbe7bb551a626780273291d732f6e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416727 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#808576}
-
Daniel Rubery authored
Based on some recent problems with the Client Side Phishing system, we could use a few more high-level metrics. This CL adds three such metrics: - Whether the local model identifies phishing or not, on every classification - Whether the server-side models identify phishing or not, every time we contact Safe Browsing. This can also be used to determine total pings sent to Safe Browsing. - What the current model version is. While this is indirectly controlled by the Finch config, measuring it directly can detect mistakes made in the config or on the server-side. Fixed: 1128205 Change-Id: Ia3e3036c7ce2dc9e3e6814bd626897ca0d055698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416063Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#808575}
-
Dave Vandyke authored
Add the isRegexSupported extension function which provides extension developers with a way to check that a given regular expression can be used as a regexFilter rule condition. Skipping presubmit since this seems to be hitting crbug.com/956368. R=karandeepb@chromium.org, kelvinjiang@chromium.org Bug: 1088457 No-Presubmit: True Change-Id: Ic51df5dd096806472f25e4053a020c0a08368179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372465 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808574}
-
Matthew Denton authored
BPF sandbox policies normal use this code sequence if they are using a broker: auto* broker_process = SandboxLinux::GetInstance()->broker_process(); if (broker_process->IsSyscallAllowed(sysno)) { return Trap(BrokerProcess::SIGSYS_Handler, broker_process); } Switch this to: auto* sandbox_linux = SandboxLinux::GetInstance(); if (sandbox_linux->ShouldBrokerHandleSyscall(sysno)) return sandbox_linux->HandleViaBroker(); ...which has the advantage of being clearer. This also makes it easier to land SECCOMP_RET_USER_NOTIF support, as if USER_NOTIF is supported we will use bpf_dsl::UserNotif instead of bpf_dsl::Trap, and users of the sandbox shouldn't have to care which one is used. Bug: 1117351 Change-Id: I809fdb4118fef39d8b142fdd571743c49e0812a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377422 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#808573}
-
Chris Sharp authored
BUG=1121162 Change-Id: If2ec2a9c3a5c1f76373a8cdddc920267c64b13eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418618 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808572}
-
Wenbin Zhang authored
Resharding to reduce long poles on shard runtime, which on some platforms are ~3 times as average. Bug: chromium: 1129958 Change-Id: I8c865769bb88f6b28a2398c2ac148cc7e7766ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418801Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#808571}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d949c910de8c..df123b290f75 2020-09-18 vadimsh@chromium.org [cipd] Rollback latest CIPD deployment. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1129704 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I60938edc77134e9a155a4cc6b1c65de2f0dff031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419467Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808570}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 55a72d30. With Chromium commits locally applied on WPT: b943d006 "[COOP] Access reporting with 2 reporters." d236b21e "Reland: "[layout] Ensure fragment tree consistency."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ief4a9c68938a5e9e87b8ae448cfd04c5a2deefb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419551Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808569}
-
Alex Ilin authored
Some UIs using cr-customize-themes won't have a confirm button. The theme should be applied and automatically confirmed in that case. Bug: 1129186 Change-Id: I34d11264ddcd1977ca5d2179024016f80f10546f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418374Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808568}
-
Yi Gu authored
The test SameSiteNavigationResetsDocumentUsedWebOTP is flaky due to a race condition. This patch adds EvalJs which can wait until the promise from WebOTP is resolved. Bug: 1120305 Change-Id: I30d7f39b97960ef0088d5e48e0fb672607351452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416755Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808567}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5bfca93e1a51..fbab23e18687 2020-09-18 adetaylor@chromium.org Add CPEPrefix for rapidjson. 2020-09-18 courtneygo@google.com Vulkan: need to serialize access to mFenceRecycler 2020-09-18 jmadill@chromium.org Tests: Allow tests to function without VVLs. 2020-09-18 geofflang@google.com Refactor IsMipmapFiltered to take the min filter directly. 2020-09-18 jmadill@chromium.org Traces: Move up from tests/perf_tests/ to tests/. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:895969 Tbr: jmadill@google.com Change-Id: I33a0fdae9e1d72aec1253822d563d263300daf23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808566}
-
Min Qin authored
This is a reland of the previous CL. The previous CL was reverted as there are still some other info bars showing up and messing with the duplicate info bar. So this reland just searches for the duplicate infobar, rather than waiting for 1 info bar to appear. There are several issues with this download test: 1. The new download progress info bar will mess up with the duplicate infobar when trying to find the latter. 2. Download update may never go through DownloadManagerService in download's new code paths 3. Only 1 duplicate infobar will show at a time, so the AllowMultipleInfoBars test is no longer valid This CL fixes the above 3 issues. BUG=1128665,597230 Change-Id: I3e3dcc818e9ae6ed2a4b1218bc1f7a38bddd94b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412989 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808565}
-
Mila Green authored
Bug: 1128397 Change-Id: Ifdaf5d6e5734a53f83ef73758df9cb4eb0a7e262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414559 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808564}
-
Matt Jones authored
This patch blocks an invalid state and silently reports a stack to chrome's crash reporter which will allow us to continue to track down the root cause of the issue. A side-effect of adding this logic allowed us to track down another long-standing issue with the "settle animation" where the internal state would be set to "none". This was an issue with operation order: canceling animation after the new state was set. Bug: 1126872 Change-Id: I0dae62be822d7f3fe8e116597d17b08899b3e239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416871 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#808563}
-
Tommy Martino authored
This should fix the compiler warnings. It also introduces improved logic for finding text fragments in the page, including support for prefixes and suffixes. Bug: 1129390 Change-Id: I67f8cf00f6afa200920fc4bd52634ee7b05d3089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419573Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#808562}
-
Boris Sazonov authored
Adds logic to trigger sign-out if account cookies are cleared while there's only an unconsented primary account. Bug: 1095112 Change-Id: Iaa65f31ef8da6759cd9afaed2ce9dd6f16e511d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410875 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#808561}
-
Siyu An authored
Bug: 1112095 Change-Id: Idf4553fd4367378a5117900b5ab75cbbe1dfeee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418013 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#808560}
-
David Black authored
We should only show the HoldingSpaceTray if we have a logged in user. Bug: 1129227 Change-Id: I4b1e6843c49f7bebfcdd47e4f9a4310fd726691e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414706Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#808559}
-
Brian Sheedy authored
Enables the standard GPU Mac tests on the ARM-based Mac DTKs. Bug: 1105652, 1105656, 1105648 Change-Id: I794e41fd55ded954fd7547435e97471240d8d837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412217 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#808558}
-
yiyix authored
blink_perf.canvas target is removed in this cl https://chromium-review.googlesource.com/c/chromium/src/+/2367753. As the target is removed, we also need to remove all references to the target in code description. Bug: 1077148 Change-Id: Ibf60e37e58260a536a2392808e7bfc8b268c4edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417853Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#808557}
-
Fabrice de Gans-Riberi authored
This reverts commit a4a8af90. Reason for revert: Broke chromeos-amd64-generic-lacros-dbg https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-lacros-dbg/129 Original change's description: > Disable lacros_chrome_browsertests for device. > > These tests only run on Linux, not on ChromeOS devices. > > Change-Id: If22d19f0cdcb95efd412d7c099df05361413350f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419007 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Auto-Submit: Erik Chen <erikchen@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808521} TBR=avi@chromium.org,erikchen@chromium.org Change-Id: I6ffb195890b15821d53a93972b9380e52652f8af No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419148Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#808556}
-
Bo Liu authored
There is evidence that malware is overwriting the memory of this header string in the binary in order to avoid sending the header which then identifies the app. Try to confirm this theory by constructing the string from pieces at run time which should disrupt a simple search / replace mechanism. Bug: 1028189 Change-Id: I03b40a2a60ae29e06572d0bb501dba68acb4d201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416869Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808555}
-
bttk authored
Bug: 1109369 Change-Id: If22a2762311ecdce441fa695a19c528173b35214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332361Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#808554}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c884631f9942..be0a9ca63d9d 2020-09-18 johnstiles@google.com Migrate remaining SkSL GLSL tests to golden outputs. 2020-09-18 johnstiles@google.com Remove inliner from IR generation stage. 2020-09-18 robertphillips@google.com Actually test the direct-context's thread-safe proxy cache 2020-09-18 johnstiles@google.com Migrate geometry SkSL tests to golden outputs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: scroggo@google.com Change-Id: I1f0a3d6c6a31327b7a9693cfc9750aacb9bc3981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419454Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808553}
-
Joey Arhar authored
The clusterfuzz test case is very large and complicated, so I wasn't able to reproduce the test case in a normal/minimal page. From debugging while using the clusterfuzz repro tool, all I can tell is that find-in-page is trying to scroll to the "Choose File" text node inside an <input type=file>, and that it doesn't have a LayoutObject for some reason, despite being attached to the document and the call to UpdateStyleAndLayoutForNode in the previous block being run. Bug: 1129341 Change-Id: I6de3eac626899ab15c157150ed5015119c497876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419154 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#808552}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/576f2f50..31d58940 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5f40bf1aa676ef22bd8c190e1541c65b4dbbc664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419511Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808551}
-
Tibor Goldschwendt authored
This reverts commit dc50a154. Reason for revert: No longer needed Original change's description: > [ntp][modules] Add basic collapse and expand functionality > > Collapsing/expanding hides/shows the local module UI. > > Before: https://screenshot.googleplex.com/7YpsgDQZg6EQbjT > After: https://screenshot.googleplex.com/3wv7qaoupMtPQj5 > > Bug: 1124089 > Change-Id: I80d88b1c2311da6a4d047e2ffb4837b6d4158add > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388977 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805099} TBR=mahmadi@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1124089 Change-Id: I8dda5d5d19debe25b618cb7b26f520a6307a653e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419464Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#808550}
-
Matt Wolenetz authored
AtomicString statics are bound to the thread where they were initialized. This change switches MSE implementation to instead use enums or non-thread-specific strings, in anticipation of upcoming usage of MSE in either the main thread or dedicated worker threads. Longer term, similar will be needed for core/html/track objects, though we may instead switch to using prepopulated, valid-everywhere, AtomicStrings at that point (when the cross-thread MSE implementation has stabilized enough to get AudioVideoTracks feature working fully when using MSE in worker). BUG=878133 Change-Id: I37f973d5175deb7bce6b96106e0a30bd6fa15ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417452Reviewed-by:
Will Cassella <cassew@google.com> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#808549}
-
Michael Hansen authored
When invalidating surfaces we check for available mediums. We currently look for a WiFi or Ethernet connection, but these are not actually used for discovery or advertising until WiFi LAN is supported. This adds a constant, |kIsWifiLanSupported|, which will let us turn off this logic for now without discarding the related code. Bug: 1129069 Change-Id: I550667151369d2df100e4dfb94af64bed0fa4a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414781 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#808548}
-
Xida Chen authored
This is the design doc: https://docs.google.com/document/d/1zCIs8zBE7SPIS_OTvTuLkLbEgSfh-RxF0cYSCNAm-Ko/edit?ts=5f4ea439#heading=h.7o3hpjjptc4v In this CL, we detect inline style mutation. Bug: 1111392 Change-Id: I7ed591ee46429fc59d582dd47119974e9e585ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408152 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#808547}
-
Paul Moy authored
Add three new fields to the process fetcher: total memory, resident memory and free memory. All fields are reported in KiB. Bug: chromium:1102518 Change-Id: I894fdb4ed5605f12d95bdac4de67952e0414eff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417319Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#808546}
-
Anastasia Helfinstein authored
Currently the EventHandler has methods start() and stop(), while the RepeatedEventHandler has methods startListening() and stopListening(). Standardize on start() and stop(). TBR=akihiroota@chromium.org AX-Relnotes: n/a. Bug: None Change-Id: Iac26647a9f218e4ce3f838ee74575a1de542d3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415408Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#808545}
-
Ali Juma authored
This caps the number of entries in each Safe Browsing list to 2^{20} entries. Currently, the largest list on iOS has between 2^{19} and 2^{20} entries. Bug: 1129162 Change-Id: Ibf6b8b7665b079d040e5d34e8b6e86492c136a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415211 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#808544}
-
Zentaro Kavanagh authored
- Maintains a mapping of fake methods, resolvers and fake data Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ic07ddfc300679611b4d8dc908bb61a30631e9874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417450 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#808543}
-
Collin Baker authored
Bug: None Change-Id: Idde218c29a55dff202e71ba1b8871a95791f8fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419160 Auto-Submit: Collin Baker <collinbaker@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#808542}
-
Justin Cohen authored
TBR: michaeldo Bug: 1108809 Change-Id: Iae89246f4a66b6661db11292129631996f20d6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419269 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808541}
-
Justin Cohen authored
TBR: vsemeniuk Bug: 1129441 Change-Id: I7e6956083443f7b60ac29c0bfca515a23599ddf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419270 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808540}
-