GitLab

BUG=105941
TEST=Verify NTP4 still works, tree green.
Review URL: http://codereview.chromium.org/8776015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112809 0039d316-1c4b-4281-b951-d872f2087c98

This breaks some ChromeOS tests. Among the log output:
"Feature 'chrome_url_overrides' is not allowed in this type of manifest."

Original review: http://codereview.chromium.org/8654001

BUG=101992, 104103, chromium-os:23709
TEST=no

Review URL: http://codereview.chromium.org/8786004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112808 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112807 0039d316-1c4b-4281-b951-d872f2087c98

It is possible to try and close the window now before the TemplateURLService is loaded. In this case we will not have a fallback search engine to select by default. So we will just reject attempts to close the window in this circumstance until it is loaded and a fallback choice has been set. It should be an edge case.

http://crbug.com/106078
TEST=unit test
Review URL: http://codereview.chromium.org/8771018

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8790001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112804 0039d316-1c4b-4281-b951-d872f2087c98

It's typically extensions/apps team members making changes to the manifest file
here.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8789001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112803 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112802 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8785001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112801 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r7301: (pdox) Update BINUTILS_REV to pull in merge with git binutils repo up to
r7302: (ncbray) NaCl Mac 10.5 buildbots use Python 2.7 instead of 2.5.
r7303: (jasonwkim) Disable x86* translator on CrOS due to missing shim
r7304: (jvoung) Do a barrel^H^H^H^H^H^H toolchain DEPS roll!
r7306: (robertm) Add support for a bigger jail whih can  build large parts of chrome.
r7307: (dschuff) Fix unrecognized option bug in pnacl-translate, make run.py quiet mode swallow sel_ldr stderr output
r7308: (dschuff) Update torture test scripts to use clang, update known failures for clang
r7309: (sehr) Make llc and ld command lines use argz, and add new command line interfaces
r7310: (mseaborn) x86-64 Windows: Fix check in stack unwinding test to be suitably strict
r7311: (robertm) Exclude /usr/lib LIBPATH when using arm cross toolchain.
r7312: (mcgrathr) Move over tweaks to munge-phdr script from chromium repo
r7313: (mseaborn) Re-enable the multiple-sandboxes test on x86-32 Linux
r7314: (sehr) Update toolchain to get http://codereview.chromium.org/8771010/.
r7315: (robertm) update arm trusted TC to lastest version (manually built, labelled "rev 7000")
r7316: (mseaborn) Remove redundant "exit_status=0" arguments
r7318: (noelallen) Revert of ARM break.
r7320: (krasin) Update glibc rev to 9e33f4. This brings in: Define __WORDSIZE 32 for strt* routines.
r7321: (jvoung) Bump chrome deps / binary rev.
r7323: (sehr) Add needed Pnacl support to sel_universal.  This allows testing the argz-based
r7324: (jvoung) DEPS-in third_party/ply from chromium to allow running the IDL generator
r7326: (mseaborn) Enable tests/windows_crash_in_syscall to build with PNaCl
r7327: (mseaborn) sync_tgz.py: Fix unchecked subprocess.call() call
r7328: (ncbray) Browser tests are retried when known flake occurs.

BUG=none
TEST=nacl_integration

Review URL: http://codereview.chromium.org/8775037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112800 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=checklicenses.py should work on third_party/libphonenumber
Review URL: http://codereview.chromium.org/8769025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112799 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105046
TEST=manually


Review URL: http://codereview.chromium.org/8651001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112798 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105797
TEST=Manual


Review URL: http://codereview.chromium.org/8676049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112795 0039d316-1c4b-4281-b951-d872f2087c98

R=jhawkins@chromium.org
BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8733013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112793 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8774016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112792 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105763


Review URL: http://codereview.chromium.org/8735004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112790 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=execute extension

Review URL: http://codereview.chromium.org/8784001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112789 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8771043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112788 0039d316-1c4b-4281-b951-d872f2087c98

Implement SetVisuallyDeemphasized in ChromeRenderViewObserver
- Add a ChromeViewMsg_SetVisuallyDeemphasized and use it to toggle background dimming on web contents via ChromeRenderViewObserver;
- Derive WebViewColorOverlay from WebKit::WebPageOverlay and add to web view when need to dimming the background;
- Remove RWHV SetVisuallyDeemphasized since it's no longer used;

BUG=103386
TEST=Verify fix for 103386, dimming should show up even when accelerated compositing is on.


Review URL: http://codereview.chromium.org/8730001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112787 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds a --allow-legacy-extension-manifests command line switch that
lets folks load extenions with old manifest_verions even if they would
otherwise be forbidden.

This escape hatch will help ease the transition to modern manifests, both for
us and for extension developers.  (We plan to use this switch internally to
avoid converting some test data to modern manifests.)

BUG=62897
Review URL: http://codereview.chromium.org/8776059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112786 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105813
TEST=Create a new profile and enable sync, then delete that profile. Profile deletion should succeed, sync should continue to operate for other accounts and sync data from the deleted account shouldn't be affected.


Review URL: http://codereview.chromium.org/8772028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112785 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:200392,chromium:102139
TEST=Run ChromeOS with the flag --enable-bluetooth.  Navigate to the settings page and clock on "Enable bluetooth".


Review URL: http://codereview.chromium.org/8773040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112784 0039d316-1c4b-4281-b951-d872f2087c98

Along with file contents, need to send in a passcode string for decrypting encrypted onc files. The decrypt implementation will be handled by gspencer@

BUG=chromium-os:19397
TEST=compiles.

Review URL: http://codereview.chromium.org/8759007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112783 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

R=jbates@chromium.org


Review URL: http://codereview.chromium.org/8759001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112782 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88782
TEST=X509UtilNSSTest

Review URL: http://codereview.chromium.org/8537025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112780 0039d316-1c4b-4281-b951-d872f2087c98

Dues to link issues on chromeos clang.

This reverts commit 2c6c8fc139bae1b64a184c13c979f408721316a3.

TBR=dennisjeffrey@chromium.org

BUG=
TEST=

Review URL: http://codereview.chromium.org/8774053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112779 0039d316-1c4b-4281-b951-d872f2087c98

CairoCachedSurfaces are representations of a GdkPixbuf that live on the display
server instead of in process. GtkThemeService currently returns a
CairoCachedSurface for a (IDR#, Display). Instead, make gfx::Image keep
CairoCachedSurfaces as a representation and make CairoCachedSurface work on any
display, keeping the mapping to display server resources as an implementation
detail.

This has the benefit of:

- You don't need to go through GtkThemeService to access all resources,
  simplifying the code in some places and allowing sharing of static images
  across profiles.
- This will let us (in the future) remove several image conversions in the GTK
  port.

This is part 1. Part 2 will remove the custom CairoCachedSurface calls from
GtkThemeService.

BUG=106060
TEST=none
R=rsesek@chromium.org
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/8769017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112778 0039d316-1c4b-4281-b951-d872f2087c98

WebKit side (which needs to land first) is: https://bugs.webkit.org/show_bug.cgi?id=73232 which landed as WebKit r101602

BUG=103578
TEST=

Review URL: http://codereview.chromium.org/8743001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112777 0039d316-1c4b-4281-b951-d872f2087c98

We've had lots of trouble over the last six months with the ChromeOS extension-based file picker.  In particular, for the Windows/Mac/GTK file pickers selecting a file is synchronous with closing the dialog.  On ChromeOS, with the extension picker, it's not.  We've historically gotten into trouble with the order of deletion of all the associated objects.  This patch defers the SelectFileDialog::Listener callback until the dialog closes, to match the semantics of Win/Mac/GTK.  This allows us to use a more natural window.close() call in the file manager JavaScript, though sadly we still have to call the unload handler manually.  I also renamed ExtensionDialogIsClosing() to ExtensionDialogClosing() to match WindowClosing().

This also fixed a problem on Aura where closing the file picker by clicking the dialog "X" button resulted in the inability to reopen it.

BUG=105311
TEST=browser_test SelectFileDialog*, also navigate to a web page with <input type='file'> and be sure you can cancel with the 'X' button on Aura and reopen the dialog.


Review URL: http://codereview.chromium.org/8770028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112776 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8771026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112775 0039d316-1c4b-4281-b951-d872f2087c98

Store frame intervals in an array rather than throwing them away. This is to
enable more-detailed study of frame rates.

Report error as sigma directly, instead of 60 - 1000/sigma. This should help
understand whether standard deviation is even the right metric to use for frame
rate instability.


Review URL: http://codereview.chromium.org/8536008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112774 0039d316-1c4b-4281-b951-d872f2087c98

Added a unit test to check such a scenario.

BUG=105391
TEST=Ensure that all TemplateURLServiceSyncTest unit tests succeed.

Review URL: http://codereview.chromium.org/8689007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112773 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106114

Review URL: http://codereview.chromium.org/8770038

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/8775068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112772 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8771032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112771 0039d316-1c4b-4281-b951-d872f2087c98

It is possible to try and close the window now before the TemplateURLService is loaded. In this case we will not have a fallback search engine to select by default. So we will just reject attempts to close the window in this circumstance until it is loaded and a fallback choice has been set. It should be an edge case.

http://crbug.com/106078
TEST=unit test
Review URL: http://codereview.chromium.org/8771018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112770 0039d316-1c4b-4281-b951-d872f2087c98

Don't make classes derive from ChildProcessHost, and instead have them use it through composition. This cleans up the code and makes it easier to understand (as well as more closely conform to the Google C++ style guide). It also makes it possible to add an interface around ChildProcessHost in a future change.

BUG=98716
Review URL: http://codereview.chromium.org/8774040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112769 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104749
TEST=valgrind bots

Review URL: http://codereview.chromium.org/8775065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112768 0039d316-1c4b-4281-b951-d872f2087c98

Fix use-after-free. OnChildDied deletes the current object, so we shouldn't call member functions afterwards. I'm refactoring this code in another cl, but figured I'd fix this separately to make things clearer.
Review URL: http://codereview.chromium.org/8776041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112767 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101992, 104103
TEST=existing, ManifestTest

Review URL: http://codereview.chromium.org/8654001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112764 0039d316-1c4b-4281-b951-d872f2087c98

Changed the accelerated html pages to use raf to draw multiple frames. Changed the webgl and canvas2d pages to draw onscreen rather than offscreen to make sure the compositor draws the page.

BUG=105785,104142


Review URL: http://codereview.chromium.org/8692013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112763 0039d316-1c4b-4281-b951-d872f2087c98

Also, remove a couple of unused functions and rename some to be more meaningful following the recent refactoring.

BUG=102441
TEST=Manual


Review URL: http://codereview.chromium.org/8775021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112762 0039d316-1c4b-4281-b951-d872f2087c98

TBR=glider@chromium.org
BUG=99304
TEST=less flakiness on valgrind bots

Review URL: http://codereview.chromium.org/8776062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112761 0039d316-1c4b-4281-b951-d872f2087c98