GitLab

The spec requires that requests be aborted on addAll() failure:

https://w3c.github.io/ServiceWorker/#cache-addAll

See the sections that say "Terminate all the ongoing fetches
initiated by requests with the aborted flag set."  Note, there
appear to be a few places where this text is missing as noted in:

https://github.com/w3c/ServiceWorker/issues/1543

Currently there is no way to reliably observe that this abort takes
place in a WPT test.  The AbortSignal is not updated for internal
abort decisions and the information is not propagated to the signal
on a service worker FetchEvent.request.  Therefore this test only adds
a simple unit test to verify the related AbortController was triggered.

Bug: 1130781
Change-Id: I0e0498741a6d387147a2ef0ea9d31feaa805dee8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429308Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812273}

This reverts commit 9a224d53.

Reason for revert: causing a crash of HoldingSpaceUiBrowserTest.OpenItem on linux-chromeos-chrome

BUG=1133808

Original change's description:
> Miscellaneous holding space fixes.
>
> Fix pin toggle bounds in HoldingSpaceItemScreenshotView:
> The bounds of the pin toggle button were being stretched to match the
> full height of its parent container.
>
> Fix context menu bounds:
> Context menu should be below the associated view (when space allows).
>
> Fix long press gesture:
> When long pressing, the pressed view should become the selection just
> prior to showing the context menu.
>
> Fix crash in HoldingSpaceTrayBubble:
> If closing bubble due to ESC, bubble widget should only be closed if it
> exists and hasn't already been marked closed.
>
> Fix drag behavior:
> The holding space bubble should be closed during drag events.
>
> Bug: 1131262, 1131267, 1129981
> Change-Id: I5a1f0536ae6badeed841e0a6106e9c423cbf3781
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436671
> Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
> Commit-Queue: David Black <dmblack@google.com>
> Cr-Commit-Position: refs/heads/master@{#812064}

TBR=dmblack@google.com,amehfooz@chromium.org

Change-Id: I1a1321e8ad5a5c3dc9d7371a62908d06f4d8bdf4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1131262
Bug: 1131267
Bug: 1129981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441320Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812272}

https://chromium.googlesource.com/angle/angle.git/+log/fa082bb58ba7..e1d1b8b30e95

2020-09-30 jmadill@chromium.org Fix info collection on Android without Vulkan.
2020-09-30 jmadill@chromium.org Additional perf test cleanup & functionality.
2020-09-30 courtneygo@google.com Vulkan: Check that its okay to add commands
2020-09-30 syoussefi@chromium.org Vulkan: Constants for unpacked D/S attachment indices

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1133459
Tbr: jonahr@google.com
Change-Id: I7a2e522bbef1a7e5a982ad364fe2bf29721fcbb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441027Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812271}

This reverts commit 7c25668c.

Reason for revert:

Caused test error for https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20645

Original change's description:
> Reland "Rewrite scroll interruption tests into browser tests"
>
> After we finish the scroll unification, the scrolls happens mainly on
> the compositor thread, and the scroll code in the main thread will be
> removed. eventSender sends the scroll events to main thread, so it
> would not work after the scroll unification. We rewrite below tests
> fast/scroll-behavior/main-frame-interrupted-scroll.html,
> fast/scroll-behavior/overflow-interrupted-scroll.html and
> fast/scroll-behavior/subframe-interrupted-scroll.html into browser tests
> because we cannot guarantee that the scroll arrives before the animation
> completes.
>
> TBR=bokan@chromium.org
>
> Bug: 1047176
> Change-Id: I59bb34a98326892380d748a2a4691ea4664cad26
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438652
> Reviewed-by: Lan Wei <lanwei@chromium.org>
> Commit-Queue: Lan Wei <lanwei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811936}

TBR=bokan@chromium.org,lanwei@chromium.org

Change-Id: If1db54aa0562084ed90124f9b5e4597e37647378
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1047176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441293Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812270}

This comprises:
* Making <ntp-most-visited> 3px shorter so that modules move up a tad.
* Remove top margin of first module if there is no promo.
* Making modules a tad narrower so that they match the search box
  including their border.
* Increasing the module title font size.
* Tweak shopping module image background color.

Fixed: 1130032
Change-Id: I10c4b7a9932af106e906e20907bfcc938d2f733e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439519
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812269}

This is a reland of 7927c8a6

TBR=calamity@chromium.org,steimel@chromium.org

Original change's description:
> Use JS modules for the NTP module
>
> Uses JS modules for the NTP module and updates
> closure so it can resolve chrome://kaleidoscope.
>
> Change-Id: I985b20a7faca215bd5194a4a21c790d5a4ff0262
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435441
> Reviewed-by: calamity <calamity@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811807}

Change-Id: I348d2116dc851394804866642a24da48d25e3edf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441109Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812268}

Has been commented out for a while, which means the test passes.

TBR=bsheedy

Bug: 679696
Change-Id: I39601b7d83535dcb91a9fa24fc61e43cb5f75f8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441269Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812267}

Reduces runtime from 6106ms to 1320ms

Bug: 989569
Change-Id: I468ce8f180d218e5cdbae1c3327cd13750a15949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439343
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812266}

Client Side Detection models are based on a combination of a DOM model
and a vision-based model. The most recent DOM model was found to be
faulty, so we need to rollout new combined models. This CL updates
the fieldtrial_testing_config to be in sync with the config changes.

Change-Id: Id50dc55a52c927567dd97d76715098fd7c53de6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437007
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812265}

1. Encapsulated the test logic of checking click action of
TableViewInfoButtonItem.
2. Added EG test to save password settings UI.
3. Added the accessibility IDs of save password switch item and managed
item to constants file.

Bug: 1131052
Change-Id: Ice93cde0f2db4917d66293188faa063e16869e08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436690
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812264}

TBR=bling-team@google.com

Change-Id: I69df1a68450c5099c2d3e061bc904b5d825320f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441279Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812263}

Bug: 973801
Change-Id: I96fcf532f33e80b246475a2ba8a806d5019a33b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438199Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#812262}

They were necessary to prevent crashes at one point, but other
refactoring appear to have rendered them unnecessary, and they can cause
createDocument/createHTMLDocument to incorrectly return null when they
are called on an implementation object from a detached document.

Bug: 1128911
Test: dom/nodes/DOMImplementation-createHTMLDocument-with-saved-implementation.html
Change-Id: Ia37201a15db195f24e6d3988ee9dddd1d15806c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432850
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812261}

Adds support for modal-type dialogs to BubbleDialogModelHost.

Functional changes to the dialog are:

* Adding an associated label to the window-name textfield.
* Focusing and selecting all text in the window-name textfield.

Bug: 1096586,1106422
Change-Id: Iacf39997897041493d622a9840032ca46c76e8fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438581
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812260}

This CL:
* Removes CaptivePortal.DetectionResultSincePortal which no longer seems
  to accurately reflect its intended results.
* Adds NetworkPortalDetector.Result and
  NetworkPortalDetector.NetworkType to report Chrome portal detection
  results (so that they can be compared with Shill results).
* Removes some complex code to reduce log spam that shouldn't be
  happening (and if it is we should know about it).

Bug: 1132475
Change-Id: I961cd9f6dafe70f209c6db09a982bfea8d102b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432852Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812259}

This function can be called when the "malware" tag is present on a scan
request since POTENTIALLY_UNWANTED and UNCOMMON don't exempt from a
deep malware scan. This also makes the function tolerant of all results
which means the UX won't block since the callback will always run.

Bug: 1132981
Change-Id: Ie8836f73ccbcf7af103560d3b9d5291b0709a4f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436416
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812258}

Patch ae49e297, "Add tracing to
ClassifyNavigation to make debugging easier." introduced the following
code:

struct TracingCategory {
  static constexpr const char kNavigation[] = "navigation";
};

This looks fine at first glance, but has one subtle problem that the
author of the code might not have been aware of. In C++14 (which is
currently used by chomium) a static constexpr member variable (unlike
other global constexpr variables) has an external linkage. This is not
really intuitive and is probably why it was fixed in C++17, where such
static constexpr member is inline.

The interesting part is this subtle difference in linking semantics
breaks component builds when using GOLD linker instead of LLD.

  obj/content/browser/browser/navigation_controller_impl.o(.debug_addr+0x858):
  error: undefined reference to 'content::TracingCategory::kNavigation'

To fix this lets just convert TracingCategory from struct into a
namespace. This way it should be inlined no matter which version of the
C++ standard the compiler is instructed to adhere to.

Ref: https://en.cppreference.com/w/cpp/language/constexpr

Change-Id: Ibf0471eaf20805cc7af8236386aa7c5318d26f4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436824
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812257}

In order to add a separate settings section for pointing sticks (a.k.a.
TrackPoints), we need to be able to distinguish them from mice. This CL
uses the `INPUT_PROP_POINTING_STICK` evdev property to identify them,
then uses booleans to report whether mice and pointing sticks are
present. The `InputController` interface still counts them as mice for
now (to retain the existing behaviour until the next CL is submitted).

We take this approach (as opposed to creating separate lists, like we do
for touchpads) because `DeviceHotplugEventObserver` only has the one
category, and we can't add another one there as it's also used in the
X11 stack, which doesn't distinguish pointing sticks.

Bug: 1114828
Test: check mouse settings still appear when a mouse is connected

Change-Id: I7018f78f2af26e61540438385a3c6c9ced15265b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423405Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Harry Cutts <hcutts@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812256}

Previously, the socket's remote was bound on a different thread from
the one that would eventually call Disconnect which was causing a
deadlock when Nearby Connections was cleaning up a channel.

By switching to a shared remote that is explicitly bound on the task
runner we avoid the deadlock with minimal changes.

Fixed: 1132738
Change-Id: I19f89d5f38cc6ae88237038aa3cc0cc6e3eb8f5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437689
Auto-Submit: James Vecore <vecore@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#812255}

This CL is moving a branch to a DCHECK.

The GetTtsPlatform() can't safely be null since other piece of code
in the same file are using the pointer without any safety check.

Example:
  if (GetTtsPlatform()->PlatformImplAvailable()) {
    GetTtsPlatform()->ClearError();
    GetTtsPlatform()->StopSpeaking();
  }

After reading the code, I came to the conclusion that it can't be
null.

The TtsPlatform::GetInstance(...) will take the tts platform
from:
  GetContentClient()->browser()->GetTtsPlatform();
If this is null, it will returns:
 TtsPlatformImpl::GetInstance() instead.

Each platform has the proper implementation PlatformImpl.

Change-Id: Ib4e88dd1be3b557dd30c3c55041e7d8d4f0e1401
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438198
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812254}

In preparation for a CL to implement split rich autocompletion, this CL
adds the appropriate no-op field trial params and flags.

Bug: 1062446
Change-Id: I1eeeaaabb91ce3e0c9bfde2eac7a9c46c75c9baf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426969
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812253}

Fix MediaCanPlayTypeTest.CodecSupportTest_NewVp9Variants' test
expectation now VP9 profile2 is supported on Mac ARM64.

Bug: 1128445
Change-Id: I1094cf518823f52d7880f645d39bfeca0e582feb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441187
Auto-Submit: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812252}

Callsites should only use FromTypeAndToken.

Bug: 973801
Change-Id: Ide955dd19de105310ba699c2e5246454f6e1abaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432201
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812251}

This is necessary for Chrome because a normal profile and an incognito
profile use the same MediaRouter. That object should be notified when
the incognito profile shuts down.

This is not necessary for WebLayer because OTR contexts have their
own MediaRouter (the OTR context is not linked to a normal/base
context).

Bug: 1057100
Change-Id: I9c4426a4219bd971c6690b4d2712e5d39ec3f91e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438946Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812250}

And restructure feed code so that we can use it.

This flag pulls Feed v1 out of the build.
It's a bit different that enable_feed_v2. enable_feed_v2
retains most of the v2 code in chromium -- only the internal
code is actually removed when enable_feed_v2 is off.
If both flags are ON (the default), we use the InterestFeedV2
feature to select which version to use. To facilitate this,
only feed_feature_list.cc and FeedFeatures.java should inspect
the state of this feature directly.

If both build flags are OFF, we use the V2 UI classes as
essentially a pass-through to a recycler view, but will
not request any Feed content.

The compile flag enable_feed_in_chrome was removed.

Other changes:
* I've moved some files around to make it more clear what code
  is for v1 only.
* I've added FeedV1 and FeedV2 java classes to wrap access to
  version specific things, so that FeedV1 can be removed using
  the compile flag.

Bug: 1129187
Change-Id: I19b1b8deeafae51b00e6b2c23373da787dc7c93d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417533
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812249}

Fourth in a series factoring the ThreadProfiler platform specific
configuration state from the code that takes action on the state.
Defines a GetChildProcessEnableFraction function that returns how
frequently the profiler should be enabled within a given process.

The end goal is to reduce the configuration complexity, to support
enabling per-thread on Android.

Bug: 1129939
Change-Id: I936c671cd30f1750cf87d6ec8ce9aee45c051be4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424672
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812248}

As discussed in crbug.com/1133002#c6, remove this to make room for
content_browsertests

Bug: 1133002
Change-Id: Ib6598f2b2b8681378e13a196f66d064f6ff24983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441108Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#812247}

Change-Id: I8a928600f226b452abd8c0747f6baf123ed10a5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437742
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812246}

This CL gives heuristically detected street name and house number field
precedence over server predictions.

Change-Id: Icadcb5854e15127830d9b9b114d9986943517dfa
Bug: 1099202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440521Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#812245}

This CL modify the media tray such that the bubble won't close when user
unpins media tray from shelf.

Bug: 1133488
Change-Id: I4ea32592c15b49312c8ab6a14e734069b39c9f5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439011Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812244}

As an ongoing effort to make the window cycle list (alt-tab) more
interactive, this CL makes it so the following interactions cycle the
window cycle list:
  - Two and three finger horizontal trackpad scroll.
  - Mouse wheel scroll.

Test: Manual + added tests.
Bug: 1067327
Change-Id: Ibec4a34ee6e2eca77589d2598ad44fb84a2bea62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426477
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812243}

When PDF contents are rotated, rotate the canvases holding the
thumbnail images using CSS. Resize the divs holding the canvaves so that
the layouts of the thumbnails are updated.

Bug: 652400
Change-Id: Ib17fbba2905ac71a38d310ea1dd419933d7785eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438476
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812242}

When no windows are shown, and a user presses tab, focus the
launcher/Home button on the display which has the mouse.

This was based on @newcomer's original CL,
https://crrev.com/c/2128227.

The comments there as well as in the bug have been handled here.

Bug: 1060337
Change-Id: I801b8ecc4e7fefb697cf2ace56736f6e85b3cd43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412518
Commit-Queue: Angus McLean <angusmclean@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812241}

https://skia.googlesource.com/skia.git/+log/a87c5076a876..aac5728a8260

2020-09-30 robertphillips@google.com Make GrRRectBlurEffect use the thread-safe uniquely-keyed view cache (take 2)
2020-09-30 johnstiles@google.com Add ProgramWriter, a non-const version of ProgramVisitor.
2020-09-30 johnstiles@google.com Add unit test for inlining trivial arguments.
2020-09-30 ethannicholas@google.com moved SkSL Extension data into IRNode
2020-09-30 csmartdalton@google.com Don't cast emscripten pointers when assembling WebGL interface
2020-09-30 johnstiles@google.com Update nanobench SkSL tests.
2020-09-30 ethannicholas@google.com Revert "Revert "moved SkSL ExpressionStatement's data into IRNode""
2020-09-30 bsalomon@google.com Add sample count field to GrD3DTextureResourceInfo.
2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ec42b1438fd2 to fa082bb58ba7 (11 revisions)
2020-09-30 johnstiles@google.com Avoid creating temporary variables for nested trivial cases.
2020-09-30 johnstiles@google.com Revert "moved SkSL ExpressionStatement's data into IRNode"
2020-09-30 brianosman@google.com Revert "Make GrRRectBlurEffect use the thread-safe uniquely-keyed view cache"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1108408,chromium:1133459
Tbr: brianosman@google.com
Test: Test: Test: CQ
Change-Id: Ibfa175c50422039e16124cea3b99c0b2db410f4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440987Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812240}

This seems to be used in tablet mode. Extending 1 year more.
Also added owners.

Bug: 1125830, 1072660, 1072659, 1088587
Test: none
Change-Id: I91bb14e92d8372d228a29d629941eb896c8c6b1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438495Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812239}

In preparation for rotating the thumbnails in response to PDF content
rotations, propagate the number of clockwise rotations to the
thumbnails.

A future change will implement the rotations.

Bug: 652400
Change-Id: I89933d30edb102a31ae5381677aaf9f8874dadea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437487
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812238}

Fixed: 1130478
Change-Id: I755023dbe5fc9c96b2e9c693a3b233b47551a9c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439646
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812237}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/59d478038b9b..e816b5197f5e

2020-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com
Change-Id: I7693a90103689bcdc241a96f7b180529ce73e4e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440471Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812236}

Whenever the VK visibility / bounds changes, it notifies listeners such
as the WorkspaceLayoutManager. For historical reasons, we always notify
the first time, even if there was actually no change.

For example, the VK starts off with empty "displaced" bounds. If the VK
is opened, the "displaced" bounds can still be empty (as expected).
However, we still notify listeners that the bounds have "changed" to
empty, even though it was already empty.

This can be misleading. It makes more sense to only notify when there is
actually a change in the bounds value.

In fact, [1] relies on this behaviour. Whenever it receives a zero bounds, it
assumes that the VK went from shown -> hidden. The assumption only holds if we
always send real bounds changes.

[1] https://source.chromium.org/chromium/chromium/src/+/master:ash/wm/workspace/workspace_layout_manager.cc;l=249;drc=e3687581e4b1a85562130e9cc1a8765fc5b9022e

Bug: 1030481
Change-Id: I0cdd91e2b334caefd3f10b818d3d4b6b77a2ee93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434410Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812235}

AutofillAssistantRuntimeObserver

AutofillAssistantRuntimeManager will keep the state if Autobot UI is
shown and accordingly notify about change subscribed observers.
AutofillAssistantRuntimeManager can be queried about visibility of
Autobot's UI.

Bug: 1133783

Change-Id: I044855c20dae6b4c4fec5a9f6624afee3af48442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424186
Commit-Queue: Milica Selakovic <selakovic@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812234}