GitLab

BUG=310373
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/253333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271440 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374871
TBR=rtenneti@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/292693006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271439 0039d316-1c4b-4281-b951-d872f2087c98

This CL addresses a potential problem due to a race: 
|suspend_observer_| [1] could have been deallocated in 
~AVFoundationMonitorImpl while still being in use 
in Device Thread [2]. This race didn't show up in normal
circumstances since it needed the Device Thread to
be active for a very short time; xians@ stumbled upon
it during some unrelated code activities that made a
browser_test fail.

This CL then cleans up the management of 
|suspend_observer_| from the  AVFoundationMonitorImpl
to a new class SuspendObserverDelegate, the former 
living exclusively in UI thread, the latter in Device 
Thread. SuspendObserverDelegate gets the Device
Thread parts of AVFoundationMonitorImpl.

The new class sits between AVFoundationMonitorImpl
and the Objective-C++ CrAVFoundationDeviceObserver.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/device_monitor_mac.mm&sq=package:chromium&type=cs&l=259
[2] https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/device_monitor_mac.mm&sq=package:chromium&type=cs&l=336

BUG=288562, 372418

Review URL: https://codereview.chromium.org/276573009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271438 0039d316-1c4b-4281-b951-d872f2087c98

aura_unittests should run on linux and windows (including mac)
ash_unittests should run on chromeos and windows.

BUG=none
TEST=none
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/282363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271430 0039d316-1c4b-4281-b951-d872f2087c98

Non-PNaCl builds that use libc++ also require these headers.

BUG=None
R=mallinath@chromium.org

Review URL: https://codereview.chromium.org/291803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271429 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TBR=erg@chromium.org

Review URL: https://codereview.chromium.org/292763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271428 0039d316-1c4b-4281-b951-d872f2087c98

Since narrowing conversion in the `{}` is ill-formed in C++11, it raises
compile error with G++ 4.8.2.

BUG=

Review URL: https://codereview.chromium.org/294523007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271427 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371822

Review URL: https://codereview.chromium.org/295643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271426 0039d316-1c4b-4281-b951-d872f2087c98

This is so I can introduce a new way to do PPP interfaces that are
passed to a related PPB interface, instead of using PPP_GetInterface.

Note this doesn't add support for the PNaCl shim yet, although it should
at least make it compile.

BUG=367896

Review URL: https://codereview.chromium.org/281203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271425 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the UserContext from user.[cc|h] to its own header and
implementation files.

BUG=367847
TEST=Updated unit and browser tests

TBR=nkostylev (chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc)
TBR=nkostylev (chrome/browser/chromeos/chrome_browser_main_chromeos.cc)
TBR=pamg (chrome/browser/managed_mode/chromeos/manager_password_service.[cc|h])

Review URL: https://codereview.chromium.org/290513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271424 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374297
TBR=mpearson@chromium.org,jhawkins@chromium.org

Review URL: https://codereview.chromium.org/286063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271423 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to provide a ContextFactory to the Compositor so that
we can create Compositors on multiple threads.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/284233009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369531
TEST=everything still works

Review URL: https://codereview.chromium.org/263973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271421 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365927

Review URL: https://codereview.chromium.org/255403007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271420 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271419 0039d316-1c4b-4281-b951-d872f2087c98

This was the only CL in this build:

Test failures: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/23684

browser_tests browser_tests browser_tests 381 disabled 5 flaky failed 5 ( 24 mins, 12 secs )
stdio
PRE_ThemeDataPackInvalid
ThemeDataPackInvalid
ContextMenusAPI_Basic
Shim_TestNewWindow
SpeechRecognitionAPI_HasPermissionDeny

> Blink roll 174243:174291
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174243:174291&mode=html
> TBR=
> BUG=
> 
> Review URL: https://codereview.chromium.org/291923002

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/295703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271418 0039d316-1c4b-4281-b951-d872f2087c98

Store a stacktrace of PrefService destruction in PrefChangeRegistrar to debug a
race condition: ~PrefChangeRegistrar causes a crash. The current hypothesis is
that this is caused because the PrefChangeRegistrar is registered to a Profile
that is already destroyed. This code stores stacktrace when the Profile's
PrefService is destroyed to see whether this is correct.

BUG=373435

Review URL: https://codereview.chromium.org/290083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271416 0039d316-1c4b-4281-b951-d872f2087c98

Several systems in chromium (about:tracing, some code in blink) use
tcmalloc's heap profiler, so keep most of it around.  Do disable support
for the HEAPPROFILE envvar, and for the exit-time dump to "Exiting" (unless in
profiling=1 builds), as that causes a static initializer.

BUG=94925
R=willchan@chromium.org

Review URL: https://codereview.chromium.org/295583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271415 0039d316-1c4b-4281-b951-d872f2087c98

first_notification_ was getting reset on each notification in UpdateWatch,
causing the filtering to be less effective than it should have been.


BUG=NONE

Review URL: https://codereview.chromium.org/273843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271414 0039d316-1c4b-4281-b951-d872f2087c98

 * Allow BeginFrameArgs inside an EXPECT_EQ call.
    EXPECT_EQ(args1, args2)

 * Allow gtest to pretty print BeginFrameArgs objects.

   Output use to look like;
---------------------------------------------------
    Expected: args1
    Which is:
      16 byte object <0xFF 0xFF 0xFF 0x01 ...>

    Actual: args2
    Which is:
      16 byte object <0xFF 0xFF 0xFF 0x01 ...>
---------------------------------------------------

   Output now looks like;
---------------------------------------------------
    Expected: args1
    Which is:
     BeginFrameArgs(1, 2, 3)

    Actual: args2
    Which is:
     BeginFrameArgs(1, 2, 4)
---------------------------------------------------

BUG=371223

Review URL: https://codereview.chromium.org/273823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271413 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372754,302040
R=earthdok@chromium.org

Review URL: https://codereview.chromium.org/272763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271412 0039d316-1c4b-4281-b951-d872f2087c98

Creates asynchronous versions of SetCookie, removeAllCookie and
removeSessionCookie which take callbacks.

BUG=
TEST=AndroidWebviewTest

Review URL: https://codereview.chromium.org/273873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271411 0039d316-1c4b-4281-b951-d872f2087c98

Promises are now enabled by default

BUG=none
R=adamk@chromium.org

Review URL: https://codereview.chromium.org/290273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271410 0039d316-1c4b-4281-b951-d872f2087c98

This includes the toolbar itself, the browser actions area, the location bar,
and location bar components like the EV bubble view.  The omnibox itself (i.e.
the editable control) is given a minimum width of 150 px (which matches the EV
bubble min width).

* Also fixes a bug where the EV bubble was not allowed to shrink as intended.
* Also fixes a bug where the toolbar requested 3px too much size by default when
  the "toolbar origin chip" was enabled.

BUG=58915
TEST=Try to shrink the browser width, make sure the omnibox never gets "too narrow"

Review URL: https://codereview.chromium.org/271013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271409 0039d316-1c4b-4281-b951-d872f2087c98

- Adds components/bookmarks to it.
- Remove chrome/browser/ui/gtk, which does not exist anymore.

BUG=None
TEST=~/depot_tools/watchlists.py components/bookmarks*
R=sky@chromium.org

Review URL: https://codereview.chromium.org/285373009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271402 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271401 0039d316-1c4b-4281-b951-d872f2087c98

Add third_party/elfutils, at release 0.158.

BUG=

Review URL: https://codereview.chromium.org/264303009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271400 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271399 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174243:174291&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/291923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271398 0039d316-1c4b-4281-b951-d872f2087c98

BUG=305722
TBR=sadrul@chromium.org

Review URL: https://codereview.chromium.org/287413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271396 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271395 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff jkummerow@chromium.org in case of problems.

TBR=jkummerow@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/290383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271394 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374298
TEST=compiles
R=asvitkine@chromium.org, blundell@chromium.org

Review URL: https://codereview.chromium.org/293623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271393 0039d316-1c4b-4281-b951-d872f2087c98

To remove dependencies to BrowserProcess and IOThread from NetworkTimeTracker.

Remove NetworkTimeNotifier from IOThread, add NetworkTimeTracker to BrowserProcess instead.
Change all users to use the NetworkTimeTracker instance owned by BrowserProcess.
Since NetworkTimeTracker is living in the UI thread, there is no need to have multi-thread callback chain in NetowrkTimeTracker, the only exception is sync_backend_host_impl.cc who needs a callback which can be run on the IO thread.

BUG=371470
TEST=git cl try

Review URL: https://codereview.chromium.org/271853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271389 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271382 0039d316-1c4b-4281-b951-d872f2087c98

In a later CL, MetricsService ctor will take an instance of
MetricsServiceClient.

BUG=374238

Review URL: https://codereview.chromium.org/292693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271380 0039d316-1c4b-4281-b951-d872f2087c98

Passing bounds instead of insets is a more reliable approach in general, but has disadvantages when resizing the whole browser window (as new bounds are only available after round-trip to DevTools frontend).

BUG=373669
TBR=avi@chromium.org // For browser_window_controller_browsertest

Review URL: https://codereview.chromium.org/221283009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271379 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374722

Review URL: https://codereview.chromium.org/287313004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271378 0039d316-1c4b-4281-b951-d872f2087c98

This device does not require pairing. It is necessary to connect it to
a USB port so it will become available. When disconnected from the USB,
the device will try to connect via Bluetooth, at this time it is marked
as trusted.
Signed-off-by: Eduardo Lima (Etrunko) <eduardo.lima@intel.com>

R=keybuk@chromium.org
BUG=366356

Review URL: https://codereview.chromium.org/287073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271377 0039d316-1c4b-4281-b951-d872f2087c98

The current JNI generator does not support using an inner class of an
object that is in the same package as the class being processed. This CL
add a new annotation to handle this case.

R=bulach@chromium.org

Review URL: https://codereview.chromium.org/290403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271376 0039d316-1c4b-4281-b951-d872f2087c98