- 14 Sep, 2018 40 commits
 - 
- 
Chromium WPT Sync authored
Using wpt-import in Chromium f861aa1a. With Chromium commits locally applied on WPT: d8d86dd3 "Implement Feature-Policy: lazyload" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24692 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: Ia8b9f6ea7856428a7574f7435da9eb936deabd0c Reviewed-on: https://chromium-review.googlesource.com/1226814 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#591318}
 - 
Eric Seckler authored
This makes ThreadWatcherTest compatible for use of TestBrowserThreadBundle to prepare for the upcoming PostTask refactor. The TestBrowserThreadBundle initializes globals that will be required to post a task to or obtain a TaskRunner for a BrowserThread. This is a more involved change, since ThreadWatcherTest currently runs the UI thread on a separate thread from the main thread. Since this is not supported by TBTB, this change also refactors the test architecture. The tests now use the WatchDogThread to verify expectations and wait for state changes on the ThreadWatcher objects. This is closer to the way ThreadWatcher would be used in practice. State changes are now observed on the WatchDogThread, too, eliminaing the need for some locking, and signalling uses nested RunLoops instead of condition variables where possible. Bug: 878356 Change-Id: I6e759b140c7544b7abbdb8fd59f6a51163dc31e4 Reviewed-on: https://chromium-review.googlesource.com/1222891Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#591317}
 - 
Alex Clarke authored
This class's job is to map base::TaskTraits to actual task queues for the browser process. This was split off from https://chromium-review.googlesource.com/c/chromium/src/+/1214223 and is a pre-requisite for the BrowserUIThreadScheduler. Design doc: https://docs.google.com/document/d/1z1BDq9vzcEpkhN9LSPF5XMnZ0kLJ8mWWkNAi4OI7cos/edit# BUG=863341, 872372 Change-Id: Ic80e8f66cf245cca136c29387031d111e57fa713 Reviewed-on: https://chromium-review.googlesource.com/1224115 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#591316}
 - 
Philip Jägenstedt authored
In preparation for removing document.origin. Bug: 692084 Change-Id: I24b73ef0e6e5ab0317d2d6c25faec5a4c8a54512 Reviewed-on: https://chromium-review.googlesource.com/1170686Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#591315}
 - 
Matthew Cary authored
There are frequently a small number of symbols that are repeated with different offsets. These are benign but cause some annoyances, for example they can make it appear that a binary is not ordered correctly, necessitating the threshold used in check_orderfile.py (q.v.). This CL adds a small amount of logging for the repeated symbols that will make it easier to see the cause if a larger number of symbols get repeated. Bug: 758566 Change-Id: I04038bebec38b1b38e5667a578e7b4e06ac6060d Reviewed-on: https://chromium-review.googlesource.com/1201853Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#591314}
 - 
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c12805f8..9e11a283 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieee24a047a868e919a019dbf6a66d60f4f013fc0 Reviewed-on: https://chromium-review.googlesource.com/1226528Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591313}
 - 
Kuo-Hsin Yang authored
The serving dir is also included by the pages. Bug: chromium:883798 Change-Id: Ifb67e19b03303e4929a0e588f5450707adec4835 Reviewed-on: https://chromium-review.googlesource.com/1226484Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Vovo Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#591312}
 - 
Philipp Hancke authored
BUG=webrtc:7063 Change-Id: I6436a1f9ebcb34bbc770ee4f1792e6636aa8efa4 Reviewed-on: https://chromium-review.googlesource.com/1204097 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#591311}
 - 
Kent Tamura authored
This CL introduces mojo struct FileChooserParams, and replaces content::FileChooserParams with it. - We transfer the mojo struct over a legacy IPC message temporarily. Following CLs will remove the legacy IPC message. - Update blink::WebFileChooserParams so that it matches to the mojo struct. FYI: All-in-one CL: https://chromium-review.googlesource.com/1170454 Bug: 869257 Change-Id: If9ebd72bb1d69cb1a6d2b282d82ec940ae103748 Reviewed-on: https://chromium-review.googlesource.com/1195242Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#591310}
 - 
Oskar Sundbom authored
There's no point in registering before having gotten an AudioProcessorControls to proxy to. Registering too early means it'll discard the request to start an AEC dump. I also simplified SetControls, as it should only be called once. The current structure was left behind from when the plan was to call it with nullptr to detach from the controls. Bug: 851959 Change-Id: I4470a127fb6e22aa1b6fe4dd8a0b9bd0866514a4 Reviewed-on: https://chromium-review.googlesource.com/1224930Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591309}
 - 
Lei Zhang authored
Some users with Cinnamon use gnome-control-center for native printer management. So try launching it for Cinnamon users. BUG=869845 Change-Id: Icbb73dd4db72c5151175015ffd8e6d0aaae76cf4 Reviewed-on: https://chromium-review.googlesource.com/1226529Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#591308}
 - 
David Jean authored
Added handling of multiple edits by showing navigation bar when results are visible and handling any operation that would use the original root_node. Bug: 879570 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I451006aa456bcc494583aed58820e405d04852c0 Reviewed-on: https://chromium-review.googlesource.com/1213174 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#591307}
 - 
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/64b0fb599517..66261f1ac2b7 git log 64b0fb599517..66261f1ac2b7 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 csmartdalton@google.com ccpr: Don't release the stashed atlas proxy inside CopyAtlasOp Created with: gclient setdep -r src/third_party/skia@66261f1ac2b7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I81d568ed3c405536bd8a237635e39e55ff90b91d Reviewed-on: https://chromium-review.googlesource.com/1226376Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591306}
 - 
Kunihiko Sakamoto authored
In b2 format, CBOR header no longer appears at the first line of the xxd output. Bug: 803774 Change-Id: I57b8a3833cbc2ec7339346244fe23099680f6a86 Reviewed-on: https://chromium-review.googlesource.com/1226754Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#591305}
 - 
Rune Lillesveen authored
Style invalidation, style recalc, and layout tree rebuild all starts from the document root looking for dirty nodes which needs updating. That means we have unnecessary overhead traversing down to the dirty nodes, in particular when the number of dirty nodes are few and they have ancestors with many siblings. The overhead is mlog(n), if the depth to the dirty node(s) is n and the number of siblings for each ancestor is m. In particular, this overhead was noticed for the whatwg single page HTML spec where a lot of the time spent on updating hover style was spent in traversal. In this CL we introduce common ancestors for dirty nodes through the StyleTraversalRoot class which is specialized for dirtiness for needing style invalidation, style recalc, and layout tree rebuild. The common ancestor is updated as part of marking ancestors child-dirty which is when we hit an ancestor which is already marked child-dirty which then becomes a candidate for being a common root. We start traversal from this common root which means we will only have to traverse ancestors (for cleaning dirty bits and other functionality we rely on being called on ancestors) and not any of their siblings. Note that in some cases we need to start at a node higher up the ancestor chain to make sure we have enough context like for WhitespaceAttacher. Local testing measuring performance using devtools of hovering section headings and links in the single page HTML spec shows that the RecalcStyle time is reduced by ~90%. Although that's an extreme case, we hope to see reduction in UMA numbers for Style.* performance for the 50th percentile. Bug: 868810 Change-Id: I1e2cea742348f35a07f89d31e8938e857d7405d8 Reviewed-on: https://chromium-review.googlesource.com/1149300 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#591304}
 - 
Momoko Sumida authored
After discussions in https://github.com/WICG/construct-stylesheets/issues/23, we concluded that using the same constructable stylesheet in multiple Documents should not be allowed, as it can raise security risk. This CL bans the use of CSSStyleSheets in different Documents by introducing associated_document_ in CSSStyleSheet and checking if the style is applied to the same Document when it's added to AdoptedStyleSheets of any TreeScope. Link to the issue: https://github.com/WICG/construct-stylesheets/issues/23 Link to related CLs: crrev.com/c/1197002 ^ Bring back moreStyleSheets as adoptedStyleSheets crrev.com/c/1160422 ^ Implement Document.createEmptyCSSStyleSheet Bug: 807560 Change-Id: Ia0ff0af8f9baeca09b14bcbeb10897cc99b5a0bf Reviewed-on: https://chromium-review.googlesource.com/1220527 Commit-Queue: Momoko Sumida <momon@google.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#591303}
 - 
Mike West authored
Bug: 787905 Change-Id: Icbf2459fbd8bd60f6fc016624f72ec704491897b Reviewed-on: https://chromium-review.googlesource.com/1223368Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#591302}
 - 
Kuo-Hsin Yang authored
The serving dir is also included by the page. Bug: chromium:883798 Change-Id: I1d1a512774b69312642b6226a80023ac88ff3293 Reviewed-on: https://chromium-review.googlesource.com/1226752Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Vovo Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#591301}
 - 
Daniel Bratell authored
This adds support for jumbo compilation of services/network. Jumbo is a unity build implementation where many files are compiled together in the same translation unit. That is usually much faster, and more efficient, than compiling one file at a time, but it requires the code to be compatible with such treatment. In services/network there were two problems, one duplicated function which this patch unduplicates, and the IPC/ParamTraits system which is sensitive to include header ordering. In total, on the build time reference test, this saves 7 CPU minutes (from 12 to 4), or roughly 1 minute on an 8 core machine. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I997cc61159ccf9f23eb22f3b954b888b498e3862 Reviewed-on: https://chromium-review.googlesource.com/1221946Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#591300}
 - 
Takashi Toyoshima authored
Currently, we show console info when a throttling happens. I expect console's feature to gather similar messages omits repeating messages. But it does not work well if users' JavaScript put own logs. This patch adds a boolean flag to omit repeating messages. The flag will be reset when SchedulingLifecycleState changes. This should not happen so frequently. Bug: 883294 Change-Id: I3e7844a7d4456fde88e198f500e21cb74c2ada64 Reviewed-on: https://chromium-review.googlesource.com/1226482Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#591299}
 - 
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I86b7b1b4a6d52f080a16980860111423919ebfd9 Reviewed-on: https://chromium-review.googlesource.com/1226013 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591298}
 - 
Han Leon authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1214709, now we send ClaimClients Mojo message from within Blink, no longer need this WebServiceWorkerClientsClaimCallbacks to cross boundary of Content and Blink. BUG=879019 Change-Id: I755958f10b9cc3d049f89dec59eb2491bef31c1e Reviewed-on: https://chromium-review.googlesource.com/1220328 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591297}
 - 
Manuel Rego Casasnovas authored
These tests had issues that have been fixed in WPT so they now pass: * contain-layout-cell-001 and contain-layout-cell-002 fixed by https://github.com/web-platform-tests/wpt/pull/12926 * contain-size-025 fixed by https://github.com/web-platform-tests/wpt/pull/12960 * contain-layout-formatting-context-margin-001.html fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1490111 Change-Id: I238fd8df20a99536d65815061e10b32b0d59f21f Reviewed-on: https://chromium-review.googlesource.com/1226591 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#591296}
 - 
Marc Treib authored
Bug: none Change-Id: I5ea4c8dbc6cb3f6385fdd27ed94a5a3faf61edf2 Reviewed-on: https://chromium-review.googlesource.com/1224034Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#591295}
 - 
Sam McNally authored
Bug: 826090 Tbr: tzik@chromium.org Change-Id: I987999c5a0256609bde868e891f520611d008317 Reviewed-on: https://chromium-review.googlesource.com/1220872 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#591294}
 - 
Kyoko Muto authored
For the help of comparing two implementation design of "Imperative Shadow DOM Distribution API", this CL introduces some performance tests. Some of the tests are micro benchmark tests for each function, assign, assignSlot, assignElements, insertBefore, and appendChild, that manual slotting mode uses. In another tests, the performance of the new custom element, <my-detail>/<my-summary> are testes when assigned nodes are over 100. In addition, some algorithm for the new custom element are added to do the previous tests. Bug: 869308 Change-Id: Ib2ad2f2ea304d0f7ddbb25b5b85e739af7ee465b Reviewed-on: https://chromium-review.googlesource.com/1214964 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#591293}
 - 
Jani Hautakangas authored
This is a reland of 40a87fcf The patch was reverted due to fail in windows 'compile confirm no-op'. Compile failed because of empty linux specific gn component which resulted after applying sources_assignment_filters on windows builds. Relanding patch now by refactoring ime_linux gn component. Original change's description: > [ozone/wayland] Refactor IME deps for ozone platform > > Refactor base/ime components and dependencies for ozone > plaform integration to avoid cyclic dependencies. > > - Groups ui/base/ime common types into their own GN component > (ime_types) to break a dependency cycle that ozone ime context > integration would cause on ChromeOS. > - Groups some of ui/base/ime/linux interfaces into their own GN > component (ime_linux) to break a dependency cycle that ozone > ime context integration would cause on ChromeOS. > - Move chromeos source files under is_chromeos flag to avoid > depending them when chromeos is not used, but ime is needed > (kudos to msisov@igalia.com). > > Bug: 791920 > Change-Id: I0b1668564dde22c6e2b05ee1323ebbe4a1343475 > Reviewed-on: https://chromium-review.googlesource.com/1193871 > Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com> > Reviewed-by: Shu Chen <shuchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590072} Bug: 791920 Change-Id: I16de600ac66eb53e4e925bc8b8ab292f89a787dc Reviewed-on: https://chromium-review.googlesource.com/1224370Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com> Cr-Commit-Position: refs/heads/master@{#591292}
 - 
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f682624062b3..e899629be4d8 git log f682624062b3..e899629be4d8 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 buildbot@webrtc.org Roll chromium_revision 2338e7cc..2c0c7dfd (591117:591272) Created with: gclient setdep -r src/third_party/webrtc@e899629be4d8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0cdd9575f60e6592463a4b65c0c8e108fbf33d85 Reviewed-on: https://chromium-review.googlesource.com/1226377Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591291}
 - 
Samuel Huang authored
The current code (using fetch() API) seems to always use cached .ndjson file, even when server is restarted (on a different .ndjson file), and Shift-Ctrl-R is used to refresh. This CL changes API use to disable cache, so when .ndjson files are loaded by data_url, refreshing the HTML viewer would fetch the up-to-date version. There does not appear to be a performance cost to this. Bug: 880671 Change-Id: I9aab99c18895dc52bc9de0ec788c1c617ec06e8f Reviewed-on: https://chromium-review.googlesource.com/1225652 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#591290}
 - 
Kent Tamura authored
All of CrSearchFieldBehavior users use 'incremental' attribute and 'search' event handler in the same way. So CrSearchFieldBehavior dispatches CustomEvents named 'search' regardless of existence of 'incremental' attribute, and 'search' event handlers continue to work well. This CL has no behavior changes. This is a preparation to remove 'incremental' attribute and 'search' event. Bug: 690143 Change-Id: I5ababa9276be6c527bc1b0c4ac571fbdfb9ceccd Reviewed-on: https://chromium-review.googlesource.com/1218483 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#591289}
 - 
Maksim Sisov authored
This fixes the following GCC error: error: 'constexpr' needed for in-class initialization of static data chrome/browser/browser/tab_manager_stats_collector.o ../../chrome/browser/resource_coordinator/tab_manager_stats_collector.cc:644:49: member 'const base::TimeDelta resource_coordinator::TabManagerStatsCollector::kLowFrequencySamplingInterval' of non-integral type [-fpermissive] const base::TimeDelta ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: 'constexpr' needed for in-class initialization of static data TabManagerStatsCollector: :kLowFrequencySamplingInterval; Change-Id: I5ddcd2ef64c22e88a21d157f125c930d54a155ac Reviewed-on: https://chromium-review.googlesource.com/1213155 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#591288}
 - 
Darren Shen authored
Timing out from crashing on Linux. TBR=beccahughes@chromium.org Bug: 883706 Change-Id: I4c618b6c4ad88a895ba53cd177106487fec8eba7 Reviewed-on: https://chromium-review.googlesource.com/1226475 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#591287}
 - 
Hirokazu Honda authored
If ScopedFD is initialized with some integer, its dtor will close it as a file descriptor. Because close will cause an error if there is no file descriptor, this will fail VideoFrame unittest. To solve this issue, ScopedFD is initialized without anything (i.e. default ctor) is called. BUG=chromium:883249 TEST=media_unittest on linux Change-Id: If89a59d882fd887e4dc443bfd00153e69e336751 Reviewed-on: https://chromium-review.googlesource.com/1223167 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#591286}
 - 
Nigel Tao authored
Before, the web_apps.extension_ids prefs stored only the extension_id: "web_apps": { "extension_ids": { "https://events.google.com/io2016/?utm_source=web_app_manifest": "mjgafbdfajpigcjmkgmeokfbodbcfijl", "https://www.chromestatus.com/features": "fedbieoalmbobgfjapopkghdmhgncnaa" } } After, it stores both the extension_id and the install_source: "web_apps": { "extension_ids": { "https://events.google.com/io2016/?utm_source=web_app_manifest": { "extension_id": "mjgafbdfajpigcjmkgmeokfbodbcfijl", "install_source": 1 }, "https://www.chromestatus.com/features": { "extension_id": "fedbieoalmbobgfjapopkghdmhgncnaa", "install_source": 1 } } } This gets us closer to having uninstallation from one source not interfere with other sources, addressing the TODO added in https://chromium-review.googlesource.com/c/chromium/src/+/1212251/3/chrome/browser/web_applications/components/pending_app_manager.h Bug: 855281 Change-Id: I9e101e3bf508df03b1887151c3ab4056e76a8bf4 Reviewed-on: https://chromium-review.googlesource.com/1223349Reviewed-by:Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#591285}
 - 
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bdc115c23d21..f682624062b3 git log bdc115c23d21..f682624062b3 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 emircan@webrtc.org Reland Profile 2 to default profiles Created with: gclient setdep -r src/third_party/webrtc@f682624062b3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7f0fc3c11c980ae0c057cc4a7dc7e6e09063bb4a Reviewed-on: https://chromium-review.googlesource.com/1226375Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591284}
 - 
Chris Hamilton authored
These were lost in the shuffle during refactoring for proactive discarding, and are causing a small spike in user complaints. BUG=883071 Change-Id: I367398a4a148d760910f2c2edca73765f5f3dcc5 Reviewed-on: https://chromium-review.googlesource.com/1224954 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#591283}
 - 
Kent Tamura authored
We'll switch it to WTF::Vector<blink::mojom::blink::FileChooserFileInfoPtr> in a later CL. This CL will make it easier. This CL has no behavior changes. Bug: 869257 Change-Id: I4c2b75d72cd80795b84f3ce3f5e2086f0e2059dc Reviewed-on: https://chromium-review.googlesource.com/1226533Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#591282}
 - 
Kouhei Ueno authored
This CL measures PageLoadMetrics for pages loaded through SignedExchange: - Introduces SignedExchangePageLoadMetricsObserver and its unit test. - Adds the new PLT metrics to histograms.xml. - NavigationSimulator test infra adjusted to simulate signed exchange navigations. Bug: 863305 Change-Id: Ia0aa85153e61b7e30cd92d5f9ce047cdc11b546e Reviewed-on: https://chromium-review.googlesource.com/1209130Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#591281}
 - 
Dean Liao authored
It is used to set VideoFrameLayout according to hardware's response in S_FMT command. BUG=b:73752373 TEST=Build and deploy media_unittests to a CrOS DUT and run media_unittests --gtest_filter=V4L2DeviceTest* Change-Id: I332f46db85832a14b82d551249113f71711dc01c Reviewed-on: https://chromium-review.googlesource.com/1189314 Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#591280}
 - 
Alan Cutter authored
This CL updates the title text color for Linux and Windows 7 hosted app windows to be more consistent with Windows 10, Chrome OS, Android and text colors used by Gmail and Inbox. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357634&signed_aid=ONM068fpCagoCFdrDrfYuw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357642&signed_aid=2gnT0P6z9_fNMEZAGLKLnw==&inline=1 See bug for more screenshots. Bug: 883177 Change-Id: Ic24e1cf0b445251ebfdcd1aa0ae74c9343b1ff8e Reviewed-on: https://chromium-review.googlesource.com/1218186 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#591279}
 
 -