- 16 Oct, 2020 40 commits
-
-
Liquan (Max) Gu authored
Added PaymentAppService#resetForTest() to allow unit tests to clear the factories. This is needed because the singleton PaymentAppService does not clear its states between tests. This method will be used by the //clank tests. Bug: 1091475 Change-Id: Iffd27a74868cca573e3e1086a449f31f3344f66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477035 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#817960}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010160700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/9Q3G72W_FP-DamN_GtRTUZe7jm4X8tsVnaUJ3Gp3fuMC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: If3747bdf022e79c6bcf2795958582569db3e4b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479323Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817959}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4277.0-1602498224-benchmark-87.0.4280.20-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.21-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I79e36cc5159e3040fc336b4af82d3ffe6322f491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480923Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817958}
-
Nina Satragno authored
Do not send a PinUvAuthParam when reading a large blob. The current version of the spec states this results in an invalid parameter error. https://w3c.github.io/webauthn/#sctn-large-blob-extension Bug: 1114875 Change-Id: I6028fd8dbc21f2f89b845f30547d6b325b1aacc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477455 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#817957}
-
Paul Moy authored
Add two new fields to cros_healthd's CpuInfo Mojo struct. These two fields represent the time since boot that the device has spent in user mode and system mode, respectively. This will aid in the migration from deprecated Chrome APIs, which are currently the only sources of this information. Bug: chromium:1131602 Change-Id: I7987a28908eecd4f6feff14b35d42e9d7f1f2d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472600Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#817956}
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ib2c79c979f0006075a1b7980c7e718437cfd9c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477241 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#817955}
-
Yuly Novikov authored
TBR=bsheedy Bug: 1139336 Change-Id: I25464321de11fd36b8c93717bd33df864f5671d7 No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480962Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#817954}
-
Abigail Klein authored
This ensures that the associated control of the settings subpage always exists. Bug: 1055150, 1139209 Change-Id: Ied4245e55315096db19d50dd8f584bba8dbe718e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480062Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#817953}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010160700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/rrmrHRTSDAizvCLGZJ2cK4G6dB81VsAGljn1FJVQwlAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I27a0108f194f9bb1d9512e6fc568a142af620316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480122Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b1938273e405..2a8ada795146 2020-10-16 cwallez@chromium.org Format: Move the baseType to be per-aspect. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I19317298405af2b87f662d376ccfbce45832c4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479664Reviewed-by:
-
Nicolas Ouellet-Payeur authored
Some posted tasks in Safe Browsing would continue as normal, even after the Profile object is destroyed. Prevent those tasks from running when the Profile gets destroyed, to prevent instability when the DestroyProfileOnBrowserClose flag is enabled. Most of the new code is adapted from before these CLs: https://crrev.com/c/1832883 https://crrev.com/c/1830291 Bug: 88586 Change-Id: Idb8ab585313001c70784a5866fe4bea1d53415dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467358 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#817950}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ifd3f2f29c286b42d1838fb6199d8e1ddce31c288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480123Reviewed-by:
-
Harry Cutts authored
This is empty for now, and will have settings added in follow-up CLs. There should be no visible changes to the UI when the flag is disabled. Bug: 1114828 Test: check sections display correctly with and without the flag set, and with and without mice and TrackPoints connected Change-Id: I8a13634be3cc3f256b3b4e562264ceb6f753316f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471900 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by: -
Eric Orth authored
Rename BuildTestDnsResponse[WithCname]() to BuildTestDnsAddressResponse[WithCname](). Clears up the unspecified name to be used in a subsequent CL for a more generic non-type-specific-builder, which will make it easier to write tests for HTTPS before I actually add parsing of those records. Also, while poking at these methods, modernize things a bit by having the DnsResponse returned as a movable value rather than unique_ptr. Also, fixed up the response copying internal to MockTransaction to actually fully copy the underlying buffer. The change from unique_ptr made it more obvious that const correctness was being broken. Change-Id: Idafcb6713fd213c48a6cc7432ffd7932295ca8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476780 Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#817947}
-
Hidehiko Abe authored
This reverts commit 4ee47291. Reason for revert: The unexpected test failure on the revert reason is fixed by crrev.com/c/2477055. Original change's description: > Revert "Undefine OS_LINUX for Chrome OS." > > This reverts commit 9b1cb285. > > Reason for revert: Appears to break linux-chromeos-rel: > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41980 > > In particular, the test says this: > > #if defined(OS_LINUX) && defined(OS_CHROMEOS) > // QueryOutputProtectionStatus() is known to fail on Linux Chrome OS builds. > std::string expected_title = kEmeUnitTestFailure; > #else > std::string expected_title = kUnitTestSuccess; > #endif > > The condition becomes impossible after this CL. It's not obvious to me whether defined(OS_CHROMEOS) is the right fix here, because the comment specifically refers to Linux Chrome OS. > > Hence reverting so that this can be sorted out with media folks before relanding. > > Original change's description: > > Undefine OS_LINUX for Chrome OS. > > > > Bug: 1110266 > > Test: Built and took diff of the executable via objdump. > > Change-Id: I80832fb472e6cc78d1e967f6216b1c33cc79ba73 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475013 > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#817475} > > TBR=thakis@chromium.org,hidehiko@chromium.org > > Change-Id: I42d0ff74a7f640edd2b9d986628329dcff6c5d4e > No-Presubmit: true > Bug: 1110266 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477033 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817543} TBR=thakis@chromium.org,jbroman@chromium.org,hidehiko@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1110266 Change-Id: I0aef4ae2fce1c70e89af0af982101d6cd7b6226b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477195Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#817946}
-
Marc Treib authored
Before this CL, ProfileSyncService contained a fixed list of data types that was supported in transport-only mode. That wasn't the right place for this logic: The central SyncService shouldn't have any special knowledge of individual data types. This CL introduces a new DataTypeController::SupportsTransportOnlyMode method that lets us move this logic into the individual controllers. Bug: 1056715 Change-Id: If2da58cd86c4f1035a7bb8e78f8776e1cc8451aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475117 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817945}
-
Victor Hugo Vianna Silva authored
This API was needed in the Directory implementation of Nigori as part of the process of enabling a custom sync passphrase. Nowadays this is taken care by SetEncryptionPassphrase(), so this CL removes it. It had three remaining callers: the Android and iOS ones are easy to adapt; the third is the implementation of the SyncBrowserProxy.setSyncEncryption() Javascript API, called from the sync settings WebUI page. setSyncEncryption() has poorly-defined semantics (crbug.com/1139060), so it requires a few more changes. In short, instead of receiving only what's needed ("Is a new passphrase being set? Which one?"), it takes an entire SycPrefs [1] object, with the would-be parameters encoded by callers in the setNewPassphrase/passphrase/encryptAllData fields. This CL takes a first step in cleaning this up. The encryptAllData field is no longer set in the JS, nor parsed in the backend, since it was only used to decide whether to call EncryptEverything(). This already requires that we update some JS tests: they used to verify the entire prefs object, now they must verify only the necessary fields. Next CLs will modify the signature of setSyncEncryption() to take only what's needed. [1] https://source.chromium.org/chromium/chromium/src/+/97d49f526544f71dcef5b3ed21f03c507014cff7:chrome/browser/resources/settings/people_page/sync_browser_proxy.js;l=94 TBR=jlebel@chromium.org Bug: 1033040 Change-Id: Ibe508f60dc7d16096bddf808b31a0fe8046010d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476637 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by: -
Claude van der Merwe authored
This policy allows administrators to prohibit users from enabling the upcoming Wifi Sync V2 feature which allows users to sync Wifi network configurations between Chrome OS devices and a connected Android phone. Bug: 1117619 Change-Id: I351d675c880f5b6be014a619274455e5922b0786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466677 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#817943}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3b5599f..eaf54362 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6fae22bf0903ab84e47a8ab09f18aedbe3e79dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479822Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817942}
-
Adam Langley authored
Although this APP_NAME pattern is used elsewhere, it doesn't work in this context because the string ends up getting processed by the Android system and thus there's no possibility to insert the substring. Lots of other strings in this file mention Chrome directly, so do that. (Skipping screenshot requirement because the screenshot already exists and the context isn't changed.) BUG=1002262 Change-Id: Ic393a88f2b546aa72438d0da6a71aad666f5a256 Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477517Reviewed-by:
-
Denis Kuznetsov authored
Fixed: 1133776 Change-Id: I45a1a077fa76de40a1c5b7602e7382c8335acdd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479424 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#817940}
-
Peng Huang authored
This reverts commit 1bcf9a08. Reason for revert: Performance regression https://crbug.com/1138455. Original change's description: > Fix render issue with render pass overlays on macOS > > The problem is because damage of a frame may not contain the whole > render pass area, and then the overlay backing will not be drawn > completely. Fix the problem by ignoring the frame damage area. > This CL also fixes some sync token issues. > > Bug: 1135727 > Change-Id: I6354b235fb9a7ffdeffe9c9270576ee648a7ba4d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464914 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816651} TBR=penghuang@chromium.org,ccameron@chromium.org,vasilyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1135727 Change-Id: Iad753341f65b3efbb64d298f3dfc40311a679112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479564Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#817939}
-
Elly Fong-Jones authored
These are the last production overrides of these deprecated methods. Bug: 1075649 Change-Id: I305f470db5573f6a945c26a20aab37b14a6bec7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476779Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#817938}
-
Antonio Gomes authored
This CL executes phase 1.3 in the design document [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/ Note that some aura::Window properties were also made available to lacros builds (see below), by moving their definition from //ash/public/cpp/window_properties.h|cc to //chromeos/ui/base/window_properties.h|cc. - kImmersiveImpliedByFullscreen - kImmersiveIsActive - kImmersiveTopContainerBoundsInScreen - kImmersiveWindowType BUG=1113900 R=jamescook@chromium.org, oshima@chromium.org, sky@chromium.org Change-Id: I8a1e20b1d2f5e7b95c88ca2c509a9dad2f72f8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471596 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#817937}
-
Aaron Leventhal authored
Bug: 1137930 Change-Id: I91de472e19a1c11a432b5e99f41782334e1dbb9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468679Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#817936}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd74ac6498c4..db0288d747ae 2020-10-16 bsalomon@google.com Move all YUVA image creation in GMs into sk_gpu_test::LazyYUVImage. 2020-10-16 bsalomon@google.com Reenable circle blur fast path for ellipse that transforms to circle If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1132617 Tbr: robertphillips@google.com Change-Id: I7c500b7408cb435c911a766ff39977d2c1525309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479251Reviewed-by:
-
Rahul Goyal authored
Bug: b/170202574 Change-Id: I02ab8326dd592d652ec70dede969f0f97a7c6290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476158Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Rahul Goyal <goyalrahul@google.com> Cr-Commit-Position: refs/heads/master@{#817934}
-
Luke Zielinski authored
Also split out the base mojo dependencies into their own group so it's easier to see what's used by tests and what's common infra. Bug: 1033611 Change-Id: Id6bc279e0296c5aa141f350f84cb66aa68f21568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477154 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#817933}
-
Zentaro Kavanagh authored
- New code should import the .m.js version which does not try to initialize loadTimeData during import which causes an order dependency on imports. Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ifec45279b8d8775f4d8eecb73b69e51e73b1f3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477418 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817932}
-
Dominique Fauteux-Chapleau authored
These attributes were incorrect for some policies, as none of them are per_profile since a DM token is needed for them to work and they are all cloud_only since they use EnterpriseConnectorsPolicyHandler. The updated policies are OnBulkDataEntryEnterpriseConnector, OnSecurityEventEnterpriseConnector and EnterpriseRealTimeUrlCheckMode. Change-Id: Icdf5116d76e47ae0fc2edd079245261770810a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477034Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#817931}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d8da6adce186..fab8fd6a143c 2020-10-16 aerotwist@chromium.org TypeScriptify AnimationScreenshotPopover.js 2020-10-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-16 aerotwist@chromium.org TypeScriptify ChangesSidebar.js 2020-10-16 jacktfranklin@chromium.org Migrate emulation/DeviceModeWrapper to TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2dba48f72c6358e99a46f4322f62d75ab756cf2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479252Reviewed-by:
-
Clemens Arbesser authored
This CL extracts the remaining dependencies into dedicated files, to be injected via constructor. The goal is twofold: First, this allows unit testing the communication with the backend. Second, it will allow adding new RPC calls in the future, without having to deal with complicated access_token logic or api keys. Note that this CL also removes the ability of service_impl to enqueue requests while waiting for access tokens. To the best of my knowledge, there is currently no need for this feature, and there is also no execution path where more than one request can happen at the same time. Finally, the CL refactors service callbacks to directly return the HTTP status codes, rather than a simple success bool, which should make it easier to debug certain kinds of issues. Bug: b/158998456 Change-Id: Ifad5309869aa38cda11233cb65c0f3650a7faba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466277 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#817929}
-
Peter E Conn authored
Change-Id: Iab5b9c18044011afc9c6ee5ac42e10dfc1b21480 Bug: 1138255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479168Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#817928}
-
arthursonzogni authored
I suspected there was no real reason to use base::Optional with FramePolicy. I believe the FramePolicy should always be defined and we should stop relying on fallback scattered through the code. I am trying to resolve: https://crbug.com/1101987 where the sandbox flags computed from the browser don't match the ones computed from the renderer. I was suspecting some nested document were missing setting the FramePolicy, but a fallback might be used later. Removing the fallback makes me think there is a greater chance the browser and the renderer could have access to the same data. Bug: 1041376 Change-Id: Ic06268341e3581e72c8124c352dc2fb4745f4be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460890Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#817927}
-
Matt Falkenhagen authored
Change-Id: I5a0d3bf160c64b2dbbe031a44391bc8cd206d56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479262Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#817926}
-
Corentin Wallez authored
The WebGPU spec now says that Extent3D defaults to all 1s, and that if the sequences are too small for GPUExtent/Origin3D, then the default values are use. Bug: chromium:852089 Change-Id: Ib5f646c016f13299212dc2f7452fbc71ec609af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478976 Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#817925}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602827193-4287d7521da41bae907bcfa87edebb4158ef284f.profdata to chrome-linux-master-1602849330-e626db1a42614bd1b3dbd5e4d956205e419c269d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7a125fa5445937bb8f926ab8c0100ec2f801a4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479253Reviewed-by:
-
Maks Orlovich authored
This format change happened in M76, so it's not very important any more. Fixed: 1125845 Change-Id: I528efd615b867781cab2ceb9536284053bb5b3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476034Reviewed-by:
Steven Bingler <bingler@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#817923}
-
Liên Hoàng authored
Context: See bug. Webkit automatically adds a sharp-corner highlight on tap, which doesn't match the rounded corners of the card. This highlight is already removed in many parts of the codebase (https://source.chromium.org/search?q=%22-webkit-tap-highlight-color:%20transparent;%22&sq=), and is non-standard anyway (https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-tap-highlight-color). Tested: Manually. Bug: 1134221 Change-Id: I9082f5425f23014f4e1c9c0de3ad76f63c84a5c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476874Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#817922}
-
Marc Treib authored
Tbr: dmblack@chromium.org Bug: 1139299 Change-Id: I2545904178548e972614a3a8e625263e6e655d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479468Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#817921}
-
