GitLab

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5db923d9d322..e1fce40060ca


Created with:
  gclient setdep -r src-internal@e1fce40060ca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:1012578,chromium:b/144121590,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:1022823,chromium:None,chromium:1026161,chromium:None,chromium:None,chromium:None
Change-Id: I17ff29e84ea421f88761d4dd15204f633a481e90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925175Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#716956}

The number of cases where we can't cache the page due to related active
contents turned out to be higher than expected. Record metrics to
understand why this is happening.

R=alexmos@chromium.org,arthursonzogni@chromium.org
BUG=1026101

Change-Id: If4c291f0b6108edef4162b0abecbdb9f978c5805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923289
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716955}

This CL changes the way autofill assistant a11y-announces chips. Previously, it would simply announce the text, followed by a generic 'double-tap to activate', e.g., 'Close. Double-tap to activate'. Now, chips are correctly announced as buttons, e.g., 'Close button. Double-tap to activate'. See linked bug for videos of before/after.

Bug: b/144823053
Change-Id: Id9577f522317025cd4e552d4489a088946236164
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924526Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#716954}

This patch adds a test that pins an extension and verifies it appears in
the toolbar. In order to call IsActionVisibleOnToolbar, the visibility
of ExtensionsContainer overrides on ExtensionsToolbarContainer are moved
to public to match the superclass.

This patch also changes ExtensionsMenuViewUnitTest from a
BrowserWithTestWindowTest to a TestWithBrowserView. The pin button
requires the bubble to have a Widget before it can be clicked on, and
the most straightforward way to accomplish this is to have a
BrowserView to wire everything up correctly.

Bug: 984654
Change-Id: I5f81fd66567d09634a8c54a1cba26d9c963ec6d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917238
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716953}

Skips populating policy map with nullptrs if DecodeIntegerValue returns nullptr.

Bug: 1015281
Change-Id: I13580caea4eb42893abca74abfdd9edb0e93ca35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924430Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Olya Kalitova <okalitova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716952}

It's a tiny class which does nothing if no listeners are attached and
having it for Windows fake audio device changes will be helpful.

BUG=1020006
R=guidou

Change-Id: I690c05edb55fcbdcef72ede68e759686243586e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925291Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716951}

I encountered trybot failures in https://crrev.com/c/1907147 -- I was able to
fix them by including both atomic_string_hash.h and string_hash.h, but
atomic_string_hash.h should IWYU.

Change-Id: I2501300bdb85bd765b8af6e9605dea460c26adc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924981
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716950}

Previously we were reading the public key instead of the instance ID as
a temporary stopgap since RemoteDevices did not have the instance ID
available. Now we correctly read from the instance ID in
EligibleHostDevicesProviderImpl.

Bug: 923594
Change-Id: Icf9de35ce98e3bb5194e5d54e7b41e4d039acbb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923333Reviewed-by: Josh Nohle <nohle@chromium.org>
Commit-Queue: Max Li <themaxli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716949}

https://boringssl.googlesource.com/boringssl/+log/d709b0d8926707f3143d8cf7c84350e49e56ec38..6ba98ff60144f60aba589b4d6121689528fbae76

Bug: none
Change-Id: I50ad62fdc3dfe54fba398abfcba52ea52a6ac607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918314
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716948}

Show Active Directory account in the "Accounts" list in Settings.

Bug: 996206
Change-Id: I23fa5c51977c81466b3bff5f38e0772240acbd05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763691
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716947}

GetTerminalId returns old terminal, or Terminal System
App if feature is on.

Launches System App when LaunchCrostiniApp is called with
Terminal System App ID.

Bug: 1019021
Change-Id: I2420e2f3ca5bcc423ee5ea991f4301b86d1b965d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925831Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716946}

Currently, chrome resources domain is not accessible from packed crx CCA
signed with dev key. This CL is a workaround by copying those used
function to chrome_util.js.

Bug: b/144748372
Test: Both CCA and CCA installed from packed crx function normally.
Change-Id: I6329eaee53a1ba71fb3c9ea09c570b1437b2ebc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925841
Commit-Queue: Kuo Jen Wei <inker@chromium.org>
Auto-Submit: Kuo Jen Wei <inker@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716945}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/57b4cb40b21d..2ee9aaa288d9

git log 57b4cb40b21d..2ee9aaa288d9 --date=short --no-merges --format='%ad %ae %s'
2019-11-19 rharrison@google.com Initialize binary for use as guard later (#3058)
2019-11-19 stevenperron@google.com Handle OpPhi with no in operands in value numbering (#3056)
2019-11-19 stevenperron@google.com Kill the id-to-func map after wrap-opkill (#3055)

Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@2ee9aaa288d9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
TBR=radial-bots+chrome-roll@google.com,courtneygo@google.com

Bug: None
Change-Id: I9ae03531f594900093fb82d7438aae5a7bb3b3f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925877Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#716944}

This CL activates audio multichannel processing when there is multi
channel playout with content that is not upmixed mono.

A killswitch (WebRTC-ApmExperimentalMultiChannelRenderKillSwitch)
is available in the WebRTC audio processing code that can be used to
deactivate the effect of this CL.

As part of this CL, the flag kWebrtcMultiChannelApmDescription
is redefined to control the activation of capture multichannel
processing.

Bug: b/141975053
Change-Id: I99d3cbba6ecc799985959978d10a6cff839f2f10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921976
Commit-Queue: Per Åhgren <peah@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716943}

This commit improves the reliability of the EULA browser test
EulaTest.LoadOnline. This test was disabled due to its flakiness
in the past and is now enabled again.

Tested locally. Ran 100 tests under stress without failures.
The test was failing randomly before.

Bug: 865710
Change-Id: If5fd67cbc784d577af2fa5e90906db09dec24754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891314Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Renato Silva <rrsilva@google.com>
Cr-Commit-Position: refs/heads/master@{#716942}

This fixes a regression from http://crrev.com/716332 , which changed the enabled
button foreground color from grey to blue.  That was correct for pushbutton
text, but incorrect for checkbox/radio icons (and, incidentally, download shelf
button ink drops), which were using the same color ID.  To fix this, introduce a
distinct "unchecked button" color ID with the old (correct) color and change to
using it.

Bug: 1026176
Change-Id: I7c2b97431fd52fe85b4d560fe1737e8ff347888f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925340
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716941}

https://swiftshader.googlesource.com/SwiftShader.git/+log/7e11f46ddf8e..2377845dd216

git log 7e11f46ddf8e..2377845dd216 --date=short --no-merges --format='%ad %ae %s'
2019-11-20 bclayton@google.com Reactor: Move print apis out of core reactor header.
2019-11-20 bclayton@google.com Reactor: Remove the CallSupported capability.
2019-11-20 bclayton@google.com Reactor: Add ConstantData() and member function calling
2019-11-20 bclayton@google.com Reactor/Traits: Swap the naming of CToReactorPtr and CToReactorPtrT.
2019-11-20 bclayton@google.com Reactor/Traits: Fix brokenness with CToReactor::cast of pointers.

Created with:
  gclient setdep -r src/third_party/swiftshader@2377845dd216

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/142132927,chromium:b/143479561,chromium:b/143479561,chromium:b/143479561
Change-Id: Ia1ccdbc8b7301752b1bc937acec787d4d8da60ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925879Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#716940}

Disk cache is, by definition, persisted, so use base::PersistentHash(),
which currently has the exact same behavior as base::Hash(), but is
actually guaranteed not to change.

Bug: 1025358
Change-Id: I43c53197d97c7781ef0fcfbacb89cdb214abc24e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924603Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716939}

Added color mixer that defines default chrome color ids used by the
omnibox that conform to existing color semantics in color pipeline.

Bug: 1003612
Change-Id: Ie91b66644eacc115efac992cac6ecc277c7a80c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922971
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716938}

PageTransitionGetQualifier is misinterpreting a user selecting a link
as a back/forward or typing in URL bar, disabling intent picker from
displaying when it should. We need to mask out the client redirect such
that the intent picker shows.

Bug: 1015296
Change-Id: I4081c3a6bffec350aafa05824ac56802ce89f518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924329Reviewed-by: David Jacobo <djacobo@chromium.org>
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716937}

base::Hash() is deprecated and is being replaced by base::FastHash().
The output of base::FastHash() is only fixed within the lifetime of a
single process, so if the code depends on the mapping of inputs to hash
outputs not changing over time, base::PersistentHash()—which currently
behaves identically to base::Hash()—must be used instead.

Bug: 1025358
Change-Id: I5aa0800317f39eaabdb221bbacfe0c11fa9e2c02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925698
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716936}

This CL converts QuicTransportConnector mojom interface client in
blink to use BrowserInterfaceBroker. Its binder was registered to
browser interface by https://crrev.com/c/1869149 and we only need
to use BrowserInterfaceBroker instead of InterfaceProvider.

Bug: 936482
Change-Id: Iaeea11f075cd38f6586a459c9f7e46b361fde966
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923218Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#716935}

Right now, the |print_backend| parameter is optional. If one is not
provided, GetSettingsOnBlockingTaskRunner() will create one. Instead of
doing this, make |print_backend| required and fix up the callers that do
not provide one. This simplifies GetSettingsOnBlockingTaskRunner(),
which gets a valid |print_backend| most of the time.

Change-Id: Ifc6d37d19218af9e08307db506d29655d3fe8c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918347Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716934}

This patch means supporting autocomplete "username" attribute in autofill.
This is used as the password manager username
and at the same time enables autofilling of emails.

It is useful for websites that use an email address as the username.

Bug: 1018162
Change-Id: I7d544372b99cfcbcf208b6ab9a861bcaf28616af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916740Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Cr-Commit-Position: refs/heads/master@{#716933}

Update webui_util.*:
- Remove unused AddPair() function, and move the second version to
  nacl_ui.cc, since it is only used there.
- Remove unnecessary second namespace layer.
- Add methods for setting up Web UI data sources for pages that have
  been updated to Polymer 3.
- Use these methods in Bookmarks, Downloads, Extensions, Print Preview,
  and Welcome.

Bug: 965770
Change-Id: I3afaa4af9a4f3896d73f690206bae1edb623f711
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923331Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716932}

We're not going to use this.  For incognito, color providers will be
instantiated per-window in either light or dark mode.  For active/inactive,
colors that vary (e.g. the frame) will be listed with distinct IDs and people
can ask for them directly; if necessary we can add convenience "...for the
current state" accessors on the caller side later.

Bug: 1003612
Change-Id: Ifd9ea84094884f345e8635d295f0997953c1fcf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925430
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716931}

base::Bind is deprecated in favor of either base::BindOnce or
base::BindRepeating, depending on whether the callback is invoked once
or multiple times.

Bug: 1007762
Change-Id: I138c46449a3c998eb35e6cca5a9beb1050727b92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924175Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716930}

"from_store" is more optimized for the reading scenarios.
However, PasswordForm objects are used for both reading and writing
to the PasswordStore.

"in_store" is more suitable to cover both reading and writing.

TBR=gambard@chromium.org

Bug: 978430
Change-Id: I449ab49cdabfc65670fb9149b19925cc41aefaf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924255
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716929}

Bug: None
Change-Id: I69959f2549294ea6c45edc93595925ceaaebcb28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917531Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716928}

The TerminalSystemApp feature flag will still control
whether the new terminal app is shown, but we will always
allow chrome://terminal to serve content since it is now
used for crosh.

Bug: 1022250
Change-Id: I5feae6e4d6cfe5bf7fd830d27f55a343d390fb6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924330
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716927}

This change directly apply opacity in the disabled state instead of using
different background-color/color.

Tests are also added to verify the color of the empty space (below the options)
with white and black background.


Bug: 1021228
Change-Id: I942323bc04444b04ba14506aece95adf5de5b506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920474
Commit-Queue: Alex Keng <shihken@microsoft.com>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716926}

HKCU\Software\Google\Chrome key should be deleted during uninstall if it
has no subkeys that must persist (i.e., Extensions and
NativeMessagingHosts).

BUG=931268
R=etiennep@chromium.org

Change-Id: I1f2c7f97a48bc9861efba941123f529a38bda07a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924511
Commit-Queue: Greg Thompson <grt@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716925}

This was originally introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/1781442.

It's being removed now as the implementation of this service will rely
on a different transport.

Change-Id: Idc493fd59c8ef44d7867cc45c91af2ad9b9217a0
Bug: 1020579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924191Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Joao da Silva <joaodasilva@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716924}

This CL componentizes the //chrome/browser/ssl dependencies of
//chrome/browser/ssl's SSLBlockingPage(Base). A followup CL will
componentize those classes themselves. The goal is to dedupe
WebLayer's SSLBlockingPage implementation by sharing //chrome's.

This CL does not put any of the moved files in the
security_interstitials namespace to avoid churn on files that will
subsequently move.

Bug: 1025059
Change-Id: I1f5cb6f9cfb6468089a259bf135d1db6970c9441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924428Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716923}

This patch is a part of FetchEvent WorkerTiming patches. This feature enables a
service worker to attach PerformanceMark/PerformanceMeasure timings to a
request during the fetch event handler. The timings will then be exposed to the
page using blink::PerformanceResourceTiming.

This just adds TODO comment about FetchEvent WorkerTiming for navigation. This
patch doesn't change any behavior.

Explainer : https://github.com/wanderview/fetchevent-worker-timing/blob/master/explainer.md
Design doc: https://docs.google.com/document/d/1-ebnv7OFiVd3k2-jbtQGO5s3BKHIp7lRx3ujhgNKvB0

Change-Id: I9f999ef458fbcbef9189f5d6cf3d10c6ba63c1c1
Bug: 900700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924172
Commit-Queue: Yuta Kasai <yutakasai@google.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716922}

It doesn't seem to be useful any longer. It's only set by SearchBoxView
when the search box text input changes, and it's only read by
SearchBoxView to update the search box text input when the model value
is changed (which seems a bit redundant). Additionally, SearchBoxView
stops observing the model while it's updating the selection, which means
that SearchBoxView::SelectionModelChanged  (the only code that actually
accesses the search model's selection model) doesn't ever get called.

Change-Id: I7e9489ea703942f7759162e5e3527f438c143e8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925287Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716921}

This CL moves the network::ResourceRequest referrer serialization
logic out-of-line, allowing us to extract debugging information from
the associated DumpWithoutCrash().

R=dcheng@chromium.org

Bug: 1021908
Change-Id: I7df6c8744c70ef94928db79042b650a8a612f4e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925121Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716920}

Suspected change reverted:
https://chromium-review.googlesource.com/c/chromium/src/+/1913610

TBR=dtseng@chromium.org

Bug: 1026473
Change-Id: I71347783dd8264aa459c9c6236bed65b6780282e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925889Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716919}

base::Bind is deprecated in favor of base::BindOnce or
base::BindRepeating depending on whether the callback is invoked once
or multiple times.

Bug: 1007777
Change-Id: Ia24167c85acd53947f53f26b77e2264ac95131d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923985
Auto-Submit: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716918}

This imports feed code into chromium/src/third_party.
third_party/feed_library is now a copy of what used to be
DEPS imported into third_party/feed.

References to third_party/feed have been replaced with
third_party/feed_library.

Note that the directory name was changed to satisfy a presubmit
failure.

third_party/PRESUBMIT.py was updated to fix a bug encountered in this CL.
The cause was that it identified the removal of third_party/feed's README,
and thought that files in third_party/feed_library/ were in the same
directory.

Why move the feed into chromium?
This library is no longer used in other projects, and we will in the
future be making simplifications to the code for its future use in chrome,
longer term migrating parts to c++. Having the code in the Chromium repo
lowers friction to changes. See the bug and doc for more information (sorry
but those are view-restricted).


Bug: 1024945
Change-Id: I7871f7ede706b9f9b4fe23111a1113b339562dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917083
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716917}