- 20 Mar, 2019 40 commits
-
-
Matt Menke authored
Previously, it took a bunch of individual parameters, which was getting a bit excessive. Also, CommonConnectJobParams are now created by the HttpNetworkSession. This will hopefully make a couple refactors a bit simpler: * Switching over ProxyResolvingClientSocket to not need its own socket pools (It will need its own CommonConnectJobParams). * Slimming down SocketParams classes by adding more stuff to CommonConnectJobParams (Like the SpdySessionPool and QUIC globals). * Separating the WebSocket and Transport SocketPools. Bug: 921369 Change-Id: I23b9011a9c5b9dafa0eeb1e63f585417ffc0c355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529697 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642407}
-
Leon Han authored
Used features (for UseCounter purposes) of a controller service worker should be considered as part of information of this service worker. To be consistent with this logic, this CL puts them into blink.mojom.ControllerServiceWorkerInfo rather than always passing/accessing them separately like before. BUG=931092 Change-Id: Ic4f99e33b15b367226ea7440941b74422b3a6441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527870Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#642406}
-
Noel Gordon authored
Mitigate this issue: make the thread_bundle RunUntilIdle when tearing down these unittests. See crbug.com/943570#c7 for rationale. No-try: true Bug: 943570 Change-Id: Ib8df70054ea9de3d7277da0b49e8885bf103b44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530385Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#642405}
-
Julie Jeongeun Kim authored
This is a follow-up CL of [1]. It changes t.step() to t.step_func() from animations/prefixed and address review comments from [1]. [1] https://crrev.com/c/1525789 Bug: 936364 Change-Id: Ica1d58cd903ec8429f0ceac93a3ff3f1e514082b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530358 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#642404}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2894d13a0d9b..37a9294d2eb9 git log 2894d13a0d9b..37a9294d2eb9 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@37a9294d2eb9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Idcc39cd22e4d712922a544536d8e4c209d077946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531768Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642403}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e85c22df678..cf9613f166a2 git log 8e85c22df678..cf9613f166a2 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 brucedawson@chromium.org Avoiding writing ninjalog.cfg unnecessarily Created with: gclient setdep -r src/third_party/depot_tools@cf9613f166a2 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:941810 TBR=agable@chromium.org Change-Id: I8142be62de15086d8c32147942abd18d370541eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531767Reviewed-by:
-
Raul Tambre authored
These changes allow more of Chromium to be built using Python 3. The scripts still work with Python 2. There are no intended behaviour changes. Bug: 941669 Change-Id: I6897d00ce00ec6aa5d7ca216b9f302e725a21897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527522Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#642401}
-
Miyoung Shin authored
- unsigned long -> uint32_t - No logic change - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930252 Change-Id: I73df0c545df9a669a0db7528fbf52e0c581189b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530357Reviewed-by:
-
Kunihiko Sakamoto authored
This reverts commit cc9ce2e5. Reason for revert: Broke Android CFI compile https://ci.chromium.org/p/chromium/builders/ci/Android%20CFI/4788 Original change's description: > Enable cfi-icall on the CFI bots > > Previously cfi-icall was disabled because I mistakenly thought > is_cfi=true would enable cfi-icall. Enable it explicitly. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_cfi_rel_ng > > Bug: 942060 > Change-Id: I0949e0f547f5ea17c54bb2fb4c99e269daf0f67f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529360 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642364} TBR=martiniss@chromium.org,vtsyrklevich@chromium.org Change-Id: I0e86b4b1c80df66a3c0849661e4c1902b6d5d950 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942060 Cq-Include-Trybots: luci.chromium.try:linux_chromium_cfi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530383Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#642399}
-
Miyoung Shin authored
- unsigned long -> uint32_t/wtf_size_t/uint64_t - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930252 Change-Id: Id05e83f486d1d11cac16ff17fbcd72b33ca986d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530502Reviewed-by:
-
Chris Hall authored
R=aboxhall,dmazzoni BUG=889370 Change-Id: I128efc5bf744a18bc7794fcd7d7251d5eb404409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520126 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#642397}
-
Xianzhu Wang authored
The failed because of a bad rebaseline. Rebaseline them again. TBR=wangxianzhu@chromium.org,ksakamoto@chromium.org Change-Id: I91592a17e5911f9e99de4afc7ba8c3feff411f85 Bug: 943907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531821 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#642396}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0861b5e50a7f..d196c3c607f0 Created with: gclient setdep -r src-internal@d196c3c607f0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ksakamoto@chromium.org,mmentovai@chromium.org,carlosk@chromium.org,hendrich@chromium.org Change-Id: Icbd9d0b8f655558f61876f1841f5b8099d9ccb17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531764Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642395}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 86168611. With Chromium commits locally applied on WPT: 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 2b037bdc "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" 35d5999d "Add pause to wait for scroll stop in WPT pointerevent touch test" 73fa2b38 "[wpt] Fix actionsWithKeyPressed.html.ini" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jsbell@chromium.org: external/wpt/IndexedDB kojii@chromium.org: external/wpt/css/CSS2/text rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ida6de87d7db1f10f41bfe9991ff763e230995322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531716Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642394}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/platform/animation and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ia87ee21c53cdadcbbab23b6c4c3c8300068ab38c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524400Reviewed-by:
-
Steven Zhu authored
Bug: internal b/127656475 Change-Id: Ib7681e6de5693ab25c5df96274b691b2ad0aa9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530838Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Steven Zhu <jz@chromium.org> Cr-Commit-Position: refs/heads/master@{#642392}
-
Peter Kasting authored
Using the default method as in https://chromium-review.googlesource.com/c/chromium/src/+/1367129 prevents extension popups from opening their own popup windows, e.g. JS alerts. Since there's no plan to deprecate that functionality and we can't come up with a good alternate route, this restores part of the previous code. This does not re-introduce the problem with long clicks re-showing the popup; that was sufficiently addressed by the rest of the previous CL. Bug: 941994 Change-Id: I59bb7d695b51e250a096b8ca8331876593507ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529753 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#642391}
-
Hitoshi Yoshida authored
Implement ExtendedAttribute and ExtendedAttributes class to follow the designed APIs. https://docs.google.com/document/d/1ZPuPWjBSQVfVeJYptk7dYg1OAxx89-kwHz6oJlZGA5o/edit?usp=sharing Bug: 839389 Change-Id: I21e2f4dd02433d52c14b362bd9f2cafd4eee3667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520518 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#642390}
-
Joel Hockey authored
This reverts commit 94aaefbb. Reason for revert: Not helping to detect flakes Original change's description: > Try and debug flakes in ExtractMountNameFileSystemNameFullPath tests > > Bug: 942371 > Change-Id: I8364196af047263086580c11e7db5188ac6915bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530317 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641839} TBR=fukino@chromium.org,sammc@chromium.org,joelhockey@chromium.org Change-Id: I549986343c7764e044c179abb9bdda807973c241 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531883Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#642389}
-
Stuart Langley authored
Bug: 941590 Change-Id: Ic162bb3574599e85cefd43284e341aa0f7833742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524820 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#642388}
-
Chris Hall authored
R=aboxhall,dmazzoni BUG=889370 Change-Id: I423a97dccb1de48deaec862e66dfa3add7ec8341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519969 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
-
Alexandre Courbot authored
Creating a VideoFrame instance from a V4L2 buffer reference is a common operation. The best place to do this is in the buffer reference itself, since it can export the required DMABUFs itself, has a reference to its own device, knows about its own layout, and can cache and reuse the VideoFrame instance instead of creating a new one for each request. This CL adds (and uses) such a method. Although it only works for MMAP buffers, it will probably be extended in the future to other kinds of buffers when they support queueing a VideoFrame directly. Bug: 792790 Test: VDA unittest passed in regular and import mode on Hana. Test: VEA unittest passed on Peach_pit. Change-Id: If387d8f11f8a5c72d7fc26907f5c9bea4835d8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517503 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#642386}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c75272708a80..d537949d45f3 git log c75272708a80..d537949d45f3 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 dhanyaganesh@chromium.org chromeos_config: Change the sanitizer builds to be full builds 2019-03-20 tcwang@google.com chromite: Update HWTests in toolchain builders. Created with: gclient setdep -r src/third_party/chromite@d537949d45f3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I090a7d922eb687129b3e7c71b407c6d85a19bbb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531763Reviewed-by:
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I0c9842f44a344337f6b71a579f1f0b9d4d45009e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529490Reviewed-by:
-
Devlin Cronin authored
The preferencesPrivate API is no longer used. Remove it. Bug: 593166 Change-Id: I5d56c3c79d0423b6534a7298f3d5103a09bc6707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529119Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#642383}
-
Hwanseung Lee authored
Get rid of NetworkHintsInterface and replace it with WebPrescientNetworking. Mock classes which subclass NetworkHintsInterface for tests also changed to subclass of WebPrescientNetworking. Bug: 939636 Change-Id: I12aa8a2769262490377d20ea89a1ab0bfbd68a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513796 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#642382}
-
Hayato Ito authored
- Tracking bug: https://crbug.com/906494 - Explainer (WIP): http://goo.gl/UjCQnz No web-facing behavior change. To performance sheriffs, I expect that this CL brings the performance improvements on perf tests, such as blink_perf/shadow_dom. Please assign me to a bug if you observe any performance improvements or regressions other than that. Bug: 906494 Change-Id: I6a473b7938a1aa71ac36a7dc776f34684b066861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1360197Reviewed-by:
-
Kunihiko Sakamoto authored
This reverts commit b495cf02. Reason for revert: Broke win-google-rel build (crbug.com/943912) Original change's description: > Navi: Add check for Local NTP flag before testing experiment variations > > Bug: 938093 > Change-Id: Ib09b75a213d46536caf180bacb6eaf480372af2c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529386 > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: John Lee <johntlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642230} TBR=sky@chromium.org,hcarmona@chromium.org,johntlee@chromium.org Change-Id: I886cfcebc0e1a4be203d5bed6f5feacd83ec683b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 938093,943912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530365Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b49eeb4960b..2894d13a0d9b git log 7b49eeb4960b..2894d13a0d9b --date=short --no-merges --format='%ad %ae %s' 2019-03-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 2dc0303903b1..f2564656e7af (3 commits) 2019-03-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-19 halcanary@google.com Documentation: notes on example fiddles 2019-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9b050f846a06..df35e382de78 (2 commits) 2019-03-19 bsalomon@google.com Reland "Add small offset to t in GrLinearGradientLayout." Created with: gclient setdep -r src/third_party/skia@2894d13a0d9b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:938592 TBR=brianosman@chromium.org Change-Id: Ia6f66c7ccc4d33a1ed9ab98c81deeaf201e85ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531760Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3580425baa28..8e85c22df678 git log 3580425baa28..8e85c22df678 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 vadimsh@chromium.org [lucicfg] Bump lucicfg version 1.5.4 -> v1.5.6. Created with: gclient setdep -r src/third_party/depot_tools@8e85c22df678 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If1b578fab3dd6762c8805eb2f598688511509d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531761Reviewed-by:
-
Regan Hsu authored
Currently, the input enable does not update correctly when words are added or removed from the user's spell check dictionary. This CL ensures that the input enable is updated correctly. Bug: 914738 Change-Id: I743a0dd50a33af030d0e11bbd68938c02dc9256a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529709Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#642377}
-
Peter Kasting authored
* Use constexpr * Change override comments to match more common style * Call superclass methods (more technically correct) * In OnWidgetActivationChanged(), call superclass method before doing override code instead of after; this makes it harder to omit calling the superclass via early return * Use CloseWithReason(), as BubbleDialogDelegateView does * Shorten code by using conditional instead of switch, and not handling DCHECK failure Bug: none Change-Id: Iffe3a4f229924fad13fd9b08e431a31308821fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531652 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Eliot Courtney authored
Bug: 942991 Test: unit test Change-Id: Id1956d3fe239c0740770274a95ba9119f6fe2bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529500Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#642375}
-
rajendrant authored
Bug: 932634 Change-Id: Icb5009f436181c1686885dbbfea724dc8a67b77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522926Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#642374}
-
Rachel Wong authored
Existing tests are also updated to reflect the new description requests. Bug: 916420 Change-Id: I5be994335ec54f78c0faea86e6930eee2ca4c411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505742Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#642373}
-
David Bertoni authored
Previously, incrementing inflight events for service workers only worked on the UI thread code path. This CL makes it work on the IO thread code path as well. Change-Id: I488ebf980f951bf384f727e73f58f408ecff3e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522548 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This is a part of moving manifest implementation to blink. content::ManifestUmaUtil would be removed after completing to move the manifest implementation from content to blink. Bug: 704441 Change-Id: I5ae55cc02c01c3b3f30268bb0da8dadc83b84f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524818Reviewed-by:
-
Meilin Wang authored
Tests failed because assistant was disallowed by account type for the following reasons: - Autotest with real gaia login: Caused by a race between chromeos login finished and account info fetch finished. - Tast with fake gaia login: Account info fetch not be faked under fake gaia env. This changes fixes these issues by first retry to initiate assistant when account info updated, and also bypass the account type check in assistant::IsAssistantAllowedForProfile under fake gaia env. Misc: Add IsGaiaServicesDisabled helper function in chromeos_swithes. Bug: 942781, 939146, 940618 Test: local compile and run autotest/tast tests on DUT. Change-Id: I25bdcda9587988426745c2dd036da1b8be6f636a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530119 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#642370}
-
Rakina Zata Amni authored
There are multiple ways to make <select> not use the menulist, including adding the multiple attribute or using the size attribute. Bug: 943195 Change-Id: Ie1b31a977321c1ae7f6e00fbe93337c214594a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530323 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Robert Liao authored
This is a run of run-clang-tidy.py -checks="-*,google-explicit-constructor" -header-filter=ui/views/* \\src\\ui\\views\\ BUG=940732 TBR=sky@chromium.org Change-Id: I6690fe5a5f4db5fb43711912ca370952d99e16f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531728Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#642368}
-
