- 12 Jun, 2020 40 commits
-
-
Erik Chen authored
Bug: 1065798 Change-Id: I62517bfae74e61f9ff42d92b4ad865876f59c130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242687Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#777914}
-
Cicy Tan authored
Bug: b/154273161 Change-Id: I24e2902d195ebac5f7f6f98931705fe59ffd8b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242042Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#777913}
-
Adrienne Walker authored
Bug: 1092400,402379 Change-Id: I10ecbc4359b2c48ec7f38a20d5901faa7e3e87fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243356 Auto-Submit: enne <enne@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#777912}
-
Nico Weber authored
net_unittests recently made it (barely) over the 1h timeout on win-asan, so shard the tests 16x like we already do on linux/asan. Edited the .pyl file manually and then ran testing/buildbot/generate_buildbot_json.py to update the json files. TBR=aeubanks Bug: 794372 Change-Id: I6bb9b0f57dde161858fe96bc44c58e5bec534da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243439Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#777911}
-
rbpotter authored
Remove "document" per recently updated mocks. Bug: 1078543 Change-Id: Ifded88d6d1930663f92e9796fb44f5a28eb9afa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242590Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#777910}
-
kylechar authored
WrappedSkImage can't use SkPixmap for ETC1 since the pixel buffer is compressed. Split the Initialize() function up into ETC1 and non-ETC1 variants. Bug: 1091682 Change-Id: Ie8b59e27d85192158d93a65adbd4451a0ab0920b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242043 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#777909}
-
Yue Zhang authored
Now that http://crrev.com/c/2119188 has made TabGridDialog use the ScrimView from RootUiCoordinator, this CL migrates the component to use the new ScrimCoordinator to control the scrim view. To achieve that, we expose a getter of ScrimCoordinator in RootUiCoordinator and pass it down through constructor. Bug: 1064140 Change-Id: I8f629fd2cab6f3fa8a6236fe58f982e637a994a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223458 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#777908}
-
Sammie Quon authored
Noticed this was painting for the duration of a multi-window drag. It's a small UI, but we can improve some performance by using a solid color layer. Also change to use CompositorAnimationRunner. Test: manual, Ctrl+Shift+Alt+P shows no painting Bug: none Change-Id: I9abce7b80ce076c3e44ffe4526158db897c26e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240007Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#777907}
-
Xiaoling Bao authored
Bug: 1068797 Change-Id: I09f8c00825972bfdda38806497fcb8ec4abe7c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239764 Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#777906}
-
Yue Li authored
The overlay dialog webview is flashing last shown url. Reset the webview to avoid. Bug: b/158605455 Test: Manual Test Change-Id: I9ce5a63d840b432a2dafbac3dc4f2089f59ef987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242592Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#777905}
-
Daniel Cheng authored
How to contribute was migrated to markdown awhile back. Change-Id: I1dd9602175a436f3cd49a73ad2fe8587b7452172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243257 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#777904}
-
Akihiro Ota authored
1. Moves all logic into AXTree, instead of splitting logic with AXNode. This allows us to check the cache before doing anything else, which eliminates some redundant work we were doing before. 2. Add a new AXTreeTest for hidden nodes. 3. Change null return value from 0 to base::nullopt. This more accurately reflects that we were unable to compute a valid value for either posinset or setsize. 4. Update expectation files. Bug: N/A AX-Relnotes: N/A Change-Id: I5b0bc2c40f6adfc97f3bca2426dcca55ef4dba62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204427 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#777903}
-
Joshua Pawlicki authored
Bug: 1094333 Fixed: 1094333 Change-Id: I269f2a09f149c9c7d22669dd9f76c9e770f1104a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242681 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#777902}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e73f278c09bc..19e418fb88c2 2020-06-12 uekawa@google.com cros_mark_android_as_stable: add XkbToKcmConverter to x86_64_userdebug. 2020-06-11 vapier@chromium.org pformat: improve json fp typing 2020-06-11 tcwang@google.com afdo: Post-process Android/Linux profiles to fixed number of functions 2020-06-11 dhanyaganesh@chromium.org test_stages: Print suites per model 2020-06-11 engeg@google.com config: remove puff from hw testing 2020-06-11 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-11 lamontjones@chromium.org artifacts: allow missing tarball in BundleTastFiles If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I8dbfed2fe876626ef9b83e93f5db0deec6cef0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243162Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777901}
-
Eric Roman authored
Bug: 1069750 Change-Id: Ic239766478e1e0086f76f9361e4cb59658d50342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242221Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#777900}
-
Manuel Rego Casasnovas authored
This patch adds a new compositing reason kTrivial3DTransform separated from k3DTransform, so we can identify trivial 3D transforms. It modifies CompositingReasonFinder in order to return kTrivial3DTransform or k3DTransform as compositing reason. On top of that the patch enables transformed rasterization for the new compositing reason kTrivial3DTransform. BUG=1078401 TEST=CompositedLayerMappingTest.TransformedRasterizationForTrivial3DTransform TEST=CompositingRequirementsUpdaterTest.NonTrivial3DTransforms TEST=external/wpt/css/css-transforms/subpixel-transform-changes-004.html Change-Id: I1acb7846af8d86c26474322818bd80c8bde2d031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241111Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#777899}
-
Dana Fried authored
Previous logic ignored the fact that GlassBrowserFrameCaptionButtonContainer::NotClientHitTest() does not check bounds, as it is convention for the calling method to hit test the child's bounds before calling a NonClientHitTest()-type method. This resulted in the hit test returning HTCAPTION for all areas of the grab handle, out to the window edge, which in turn prevented resizing of the window (and probably other issues as well). This change institutes the HitTest() check on the container before calling the non client hit test logic. It does not affect Mohnstrudel mode, where hit test check was already being done correctly. Bug: 1092724 Change-Id: I9ef1ea5b84130d2e81f819c4c6f3a949cbc7fb39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242480Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#777898}
-
Adam Langley authored
Several tests are setting unknown algorithms in order to trigger a timeout for testing. This presumably dates to back when the virtual authenticator couldn't produce valid responses. However, unknown algorithms shouldn't produce timeouts because the virtual authenticator acts like button presses happen immediately, so timeouts mean that a request is getting dropped. (Which is what is happening and is the motivation for this patch series.) This change removes all but one instance where this timeout trick is being used and deduplicates some tests too. (Test-only change.) BUG=1094066 Change-Id: I54ac9dbe649deb6d78f1bfd3e98b105e4145899b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242531 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#777897}
-
Donn Denman authored
Adds strings that will be used to show in-product-help for the lonpress experiment. The bulk of the change to put up the ballons will be done in a separate CL within a week. BUG=1086724 Change-Id: I4c65e105d8f5b10116c0b81648f94ebb24b60593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242792 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#777896}
-
Eric Roman authored
* Delete the "*suggested-workflow.md" document in favor of a single triage document * Remove responsibility of discovering unlabeled network bugs * Add responsibility of triaging subcomponents * Add responsibility of sending summary email * Add extra details on how to triage Change-Id: I8eb02fe9b107a1c90cc8a2de35d969402eacdc32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239580 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#777895}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591963164-33fa4197519e527f43603ae281985803bfeaced7.profdata to chrome-mac-master-1591977558-7170645d7cf66fa796ff151165a33077272cf120.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia1471bfeeb572a43acc67ff00dcc1c60c350946b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243332 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777894}
-
Scott Violet authored
As discussed here is the list of new names: AwOriginMatcher -> OriginMatcher JsJavaConfiguratorHost -> JsCommunicationHost JsToJavaMessaging -> JsToBrowserMessaging JavaToJsMessaging -> BrowserToJsMessaging JsJavaConfigurator -> JsCommunication There is no functional change here. Unfortunately some files are showing as new, when this is really a move. BUG=1042771 TEST=none Change-Id: I8472776f0e37beadb57405a6479422f19936b2f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242229Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#777893}
-
Rahul Singh authored
This CL enables the Windows only kDesktopPWAsAppIconShortcutsMenu flag. With this, installed PWAs with a shortcuts member in their Web App Manifest will have a shortcuts menu associated with their app icon. Users will be able to invoke the shortcuts menu using the app icon in the Taskbar or the Windows Start menu. Bug: 955497 Change-Id: Ib7a2275fd5ff8988b9cb79bc9c19b30550b362b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242730 Commit-Queue: Rahul Singh <rahsin@microsoft.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#777892}
-
Nnamdi Theodore Johnson-Kanu authored
Split bluetooth_pairing_dialog resources into bluetooth_pairing_dialog_resources.grd and bluetooth_pairing_dialog_resources_vulcanized.grd Bug: 1090882 Change-Id: I0d9855aaaf21db900f27f92b7b38d7ab1daac18a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239147 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#777891}
-
Robbie Gibson authored
ios/web now has an API to block cookies. The backend data source for when cookies should be blocked lives in content_settings::cookie_settings. Because the two APIs are slightly different, a bridge is needed to transform updates to cookie_settings into updates to the ios/web API. Bug: 1087873 Change-Id: I6097e3bc48a85349dd553e6a3311724c8114ebf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238108Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#777890}
-
Dana Fried authored
See comment here: https://chromium-review.googlesource.com/c/chromium/src/+/2239979/2/ui/views/win/hwnd_message_handler.cc#2087 Bug: 1088416 Change-Id: I820d345e8a52eb43c564e40592a6808aa31e8fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242234 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#777889}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/14421b233ee2..d1c98676c033 2020-06-12 eseckler@google.com Merge "client lib: Remove thread_local definitions on iOS" 2020-06-12 treehugger-gerrit@google.com Merge "Show time_in_state only if non-zero runtime" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icf683c6f6679e572ae6f56eaa70daeb06d04b730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243165Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777888}
-
Xiaoqian Dai authored
See go/cros-dark-light-switcher for the spec. Bug: 972162 Change-Id: Id226b0769ae62ed029246dea9eb89f6e29283f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242223Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#777887}
-
Sammie Quon authored
They will just be placed at the right spot and become visible when overview ends. SetBounds ignores invisible transients anyhow, so this will just cancel the animation of the main window and visible transients. Test: manual Bug: 1091547 Change-Id: Idbd07a3abd99f0d03bb2cfe8d0ad91c4ed22b6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242231Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#777886}
-
Xiaoqian Dai authored
Bug: 972162 Change-Id: Ife610b2dbf30c7c801ca2254fac0a792d89bb72c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242224Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#777885}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4aeb30f1..f0e19d3f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie218d17524c8c999cad5ea818b2e9842e94bd81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242182Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777884}
-
John Abd-El-Malek authored
I missed this when adding PLM support to WebLayer in r762410 but Michael pointed it out in a follow-up comment. This was added to Chrome in r408744 and WebView in r761966. Bug: 1072834 Change-Id: I491386bf52015841c4542e40ca5db4783443e4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240310 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#777883}
-
Adam Langley authored
The unittest had a bunch of instances where 123 was used as a random, invalid algorithm. Now that we have kInvalidForTesting, use that consistently. BUG=1094066 Change-Id: I8b93b1a698aaa04fc4af66c9be791a9d2011f55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242130 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#777882}
-
Teresa Kang authored
The workaround for crbug.com/600386 (WontFix) can be removed, along with removing software_rendering_while_hidden and logic around the fallback mechanism from accelerated gpu to cpu. The software_rendering_while_hidden field is only set to true when the fallback mechanism is enabled and when a hidden canvas wants acceleration. Since the mechanism is disabled, the field is never true. The field is only used in conditional statements to check the truth of the value, therefore it's safe to remove all instances of it. CANVAS2D_BACKGROUND_RENDER_SWITCH_TO_CPU was used to disable the fallback from gpu to cpu for canvases in the background as it was set to always be 0. After the removing the fallback mechanism, it is safe to remove this constant as well. Bug: 1090180 Change-Id: I27f0819a00e63d6ffc9cc0791e1f11dbbbe50837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238364 Commit-Queue: Teresa Kang <teresakang@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#777881}
-
Christopher Cameron authored
At some point, popup RenderWidgetHostViews stopped being told which process they should appear in. Fix this. Note that popups are strange in that the RenderWidgetHostView doesn't have a parent WebContentsView, rather, it is just the content view for the NSWindow. Add a sentinel remote_cocoa::kInvalidNSViewId to specify to RenderWidgetHostViewMac::MigrateNSViewBridge to indicate that we shouldn't mess with the app-side NSView hierarchy. Bug: 1091179 Change-Id: I905877e7b306c9f648734e4a433859f7d636356c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242851Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#777880}
-
zhaoyangli authored
Added a test switch to write the file of compiled test list to a writable path. In test runner, when parsing GTest output, read the file and store the tests starting with "DISABLED_" to test result json file. Bug: 1065022 Change-Id: I4311360e47aea7985e4b06da310b389a4d962a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229245Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#777879}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/97a773c9c48b..4576282f49d8 2020-06-12 caseq@chromium.org Extensions: only perform URL check in addExtension if we already have the URL 2020-06-12 tvanderlippe@chromium.org Revert "Add rollup_entrypoint to rollup entrypoints in front_end" 2020-06-12 jacktfranklin@chromium.org Losen member-accessibility lint rule. 2020-06-12 tvanderlippe@chromium.org Add rollup_entrypoint to rollup entrypoints in front_end 2020-06-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1061037,chromium:1093731 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I43fed59b11d2574937854f8e616f903eb390965f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777878}
-
Mohamed Heikal authored
Bots that do not build every commit might see a change from aliasing .*lite.* proto runtime -> .*javalite.* proto runtime to aliasing the opposite direction since they did not build the commit in the middle that removes the first alias. Depfiles are always one build behind so this causes a dependency cycle and prevents the bot from even regenerating the depfiles leading to a failure until the bot runs gn clean. This cl avoids this issue by just renaming one of the targets to avoid stale depfiles having an effect. Bug: 1093059 Change-Id: I659f92b67fa303ce9829614772bb48bd31711d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243256 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#777877}
-
Steve Kobes authored
Bug: 1088311 Change-Id: I9e93f3193de6d75bfb2d5c384a0455619340f961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233310 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#777876}
-
Christopher Cameron authored
Inline the body of MakeBacking to its callers. Bug: 1092155 Change-Id: Ie37e6a1cc3fabe741a029355d81e40ff5d30e7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242115 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#777875}
-