GitLab

In transition to let RenderPass take responsibility to allocate
DrawQuads, Copy method from DQ is moved to RP.

In drawquad_unittest, no RenderPass is present, thus it takes advantage
of default copy constructor.

Follow 368403003.

BUG=344962

Review URL: https://codereview.chromium.org/380893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282640 0039d316-1c4b-4281-b951-d872f2087c98

The previous implementation of the directory-based file templates (like {{source_out_dir}}}) was overly simplistic. It did not allow these templates to be used in the outputs section of a target since the directories were relative to the build directory (it was only useful for actions).

This new implementation changes the expansion of these values depending on where they're used, so they can be absolute when used in the outputs section, but relative to the build directory when used in the args section.

The implementation of outputs was changed to allow the use of these expansions. The previous implementation stored them as SourceFiles which didn't allow the use of directory expansions, since that happens after converting the input to a SourceFile. This new patch stores the outputs as a list of strings to allow this to be late-bound properly (and it turns out that almost all users of this wanted the strings anyway).

Changes the function that checks that files are in the output directory to optionally handle templates. Adds a test for this function.

Fixes a bug in get_target_outputs that it didn't work for copy() targets that contained templates. Fix this and add a test.

BUG=
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/387663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282639 0039d316-1c4b-4281-b951-d872f2087c98

There are some PPAPI dev interfaces that should not be added to the SDK, so it
is better to warn instead of making it a presubmit error.

BUG=none
R=teravest@chromium.org
TEST=made change to ppapi/cpp/buffer_dev.h, ran git cl presubmit

Review URL: https://codereview.chromium.org/379923010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282637 0039d316-1c4b-4281-b951-d872f2087c98

As per spec update:
https://github.com/slightlyoff/ServiceWorker/issues/353

Now the active worker is set to REDUNDANT when unregistered. If it has a
controllee, this happens when it no longer has a controllee.

This patch adds a Doom function to ServiceWorkerVersion which takes
care of setting REDUNDANT and purging resources once there's
no controllee. This obviates the need for ServiceWorkerStorage to
listen for NoControllees and purge resources then.

BUG=388095

Review URL: https://codereview.chromium.org/377153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282636 0039d316-1c4b-4281-b951-d872f2087c98

Convert githash to chromium revision instead of blink revision while doing a blink bisect (with -l option) in _FetchAndParse.Even though we are doing the blink bisect http://commondatastorage.googleapis.com/chromium-webkit-snapshots/index.html still stores the builds by chromium revisions.

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/383903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282635 0039d316-1c4b-4281-b951-d872f2087c98

They are always "true" for now, due to the way BLE devices work under Windows 8.

BUG=388016

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282286

Review URL: https://codereview.chromium.org/378293007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282634 0039d316-1c4b-4281-b951-d872f2087c98

We have to use the SetupDIGetDeviceProperty API to retrieve this specific property, as the "connected" status is something common to many PnP devices.

BUG=388016

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282212

Review URL: https://codereview.chromium.org/379943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282633 0039d316-1c4b-4281-b951-d872f2087c98

This should enable NULL deref and wild memory access detection!

TBR=rnk@chromium.org
BUG=345874
NOTRY=true

Review URL: https://codereview.chromium.org/387013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282632 0039d316-1c4b-4281-b951-d872f2087c98

This adds a test for the bug fixed in https://codereview.chromium.org/373083002/, and also extends the existing tests to check the GAIA given name.

BUG=none

Review URL: https://codereview.chromium.org/386733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282631 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282630 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177910:177920&mode=html
TBR=junov@chromium.org,falken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/386933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282629 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361809
TBR=dtu@chromium.org,chrishenry@google.com
NOTRY=True

Review URL: https://codereview.chromium.org/383963006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282628 0039d316-1c4b-4281-b951-d872f2087c98

Step 1 in the 7-step dance to do an import where failing tests have been
removed.

BUG=389134
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/371853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282627 0039d316-1c4b-4281-b951-d872f2087c98

Add proper coverage to heap_profiler.

BUG=382489

Review URL: https://codereview.chromium.org/351183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282626 0039d316-1c4b-4281-b951-d872f2087c98

The public API of mojo should not depend on any third-party library.
This CL remove the @Nullable annoation on Message#readAndDispatchMessage

R=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/385113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282625 0039d316-1c4b-4281-b951-d872f2087c98

Simple test code refactoring, no behaviour change.

Part 1: https://codereview.chromium.org/371743002/

BUG=391487

Review URL: https://codereview.chromium.org/381413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282623 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/393177
TBR=sail@chromium.org

Review URL: https://codereview.chromium.org/381423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282622 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/388803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282621 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements the new design for expanded public session pods from
crbug.com/214904#c40. The basic pod is added now. The advanced pod will
be added in a follow-up CL.

The new design requires a different animation when the pod is expanding:
An expanded pane slides out to the side and part of the main pane
disappears. To facilitate this new animation, the CL refactors the HTML
and CSS implementing user pods to be more modular with several panes
that can overlap each other. This will also make it easier to implement
the new standard pod design in crbug.com/361375.

BUG=214904,241790
TEST=Manual, for all pod types, including desktop

Review URL: https://codereview.chromium.org/369893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282618 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392145

Review URL: https://codereview.chromium.org/371263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331299

Review URL: https://codereview.chromium.org/373443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282614 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282611 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff dslomov@chromium.org in case of problems.

TBR=dslomov@chromium.org

Review URL: https://codereview.chromium.org/381383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282610 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds the menu and the list of casts. The menu just shows the menu, casting feature is not implemented.

All changes are effective only when the command line flag is specified. And the resource (cast icons) may change later.

Major changes:
- Detect Cast extension and load it
- Discover casts and show them on the menu

BUG=305511
TEST=manually testted

Review URL: https://codereview.chromium.org/381073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282609 0039d316-1c4b-4281-b951-d872f2087c98

Nico tells me that lldb is better than gdb. So give it a try.

BUG=370551
R=marja@chromium.org

Review URL: https://codereview.chromium.org/386913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282607 0039d316-1c4b-4281-b951-d872f2087c98

The GPU is sandboxed on Mac, this value just defaults to "false"
and so we don't report it correctly.

NOTRY=true
BUG=348914

R=kbr@chromium.org

Review URL: https://codereview.chromium.org/385463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282606 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds support for deleting files and directories, including recursively.
The new event in IDL has [nodoc], since we don't want to show it on
developer.chrome.com before most of the R/W features are done.

TBR=kalman@chromium.org
TEST=unit_tests, browser_tests: *FileSystemProvider*DeleteEntry*
BUG=391362

Review URL: https://codereview.chromium.org/375543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282605 0039d316-1c4b-4281-b951-d872f2087c98

These tests were disabled in https://codereview.chromium.org/379323003/

This change depends on https://codereview.chromium.org/373613004/

BUG=373120

Review URL: https://codereview.chromium.org/385103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282603 0039d316-1c4b-4281-b951-d872f2087c98

To focus geometory calculation, remove the role other than caculation from the
Viewport class.

BUG=245926
TEST=manually

Review URL: https://codereview.chromium.org/382143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282602 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
[0711/004616:ERROR:unit_test_launcher.cc(360)] no test result for
SafeSearchUtilTest.ModifyYoutubePrefCookie
[ RUN      ] SafeSearchUtilTest.ModifyYoutubePrefCookie
c:\b\depot_tools\win_toolchain\vs2013_files\vc\include\xstring(79) : Assertion
failed: string iterator not dereferencable
c:\b\depot_tools\win_toolchain\vs2013_files\vc\include\xstring(80) : Assertion
failed: "Standard C++ Libraries Out of Range" && 0
[7000/7003] SafeSearchUtilTest.ModifyYoutubePrefCookie (UNKNOWN)


> Enforce SafetyMode for YouTube if prefs::kForceSafeSearch is on, by modifying (or adding) YouTube's PrefCookie in the HTTP header.
> 
> This is essentially a followup to https://codereview.chromium.org/11186002/
> 
> BUG=344815
> 
> Review URL: https://codereview.chromium.org/354183002

TBR=treib@chromium.org

Review URL: https://codereview.chromium.org/385113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282601 0039d316-1c4b-4281-b951-d872f2087c98

This ensures the window can close when it has sheets attached, e.g. the "Open File" dialog.

BUG=362444

Review URL: https://codereview.chromium.org/389453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282600 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282599 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177902:177909&mode=html
TBR=junov@chromium.org,falken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/389533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282598 0039d316-1c4b-4281-b951-d872f2087c98

While compling on linux with g++ 4.8, the file chrome/test/ppapi/ppapi_browsertest.cc is throwing

../../chrome/test/ppapi/ppapi_browsertest.cc:452:1: error: multi-line comment [-Werror=comment]
cc1plus: all warnings being treated as errors

NOTRY=true

Review URL: https://codereview.chromium.org/386933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/378303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282596 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389170

Review URL: https://codereview.chromium.org/375143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282595 0039d316-1c4b-4281-b951-d872f2087c98

Before:
- CertDatabase::ObserveNSSCertDatabase(NSSCertDatabase* source) and implementation referenced NSSCertDatabase
- NSSCertDatabase() referenced CertDatabase::GetInstance()

Now:
- CertDatabase has no reference to NSSCertDatabase.
- NSSCertDatabase references CertDatabase.

BUG=NONE

Review URL: https://codereview.chromium.org/370633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282594 0039d316-1c4b-4281-b951-d872f2087c98

clock() returns a processor time, which does not change while
a thread is sleeping. So, Flush() would be called less often
than you expected.

TimeTicks uses a monotonic timer so this would be a better
choice than Time because TimeTicks is not affected by host's
time settings.

BUG=264856
TEST=trybots

Review URL: https://codereview.chromium.org/381473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282593 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377813

Review URL: https://codereview.chromium.org/341823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282592 0039d316-1c4b-4281-b951-d872f2087c98

Before, mounted file systems were remembered at shutdown. However, if
a Chromebook crashes, or goes out of battery, then Chrome will fail to remount
previously mounted file systems after a reboot.

This patch remembers mounted file systems in preferences, as soon as they are
mounted, or unmounted.

TEST=unit_tests: *FileSystemProvider*Service*
BUG=389012

Review URL: https://codereview.chromium.org/334263017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282589 0039d316-1c4b-4281-b951-d872f2087c98