GitLab

Removes all references to cellular network checks since they're no
longer controlling access to preload/prerender features.

Removes the enum value from NetworkPredictionStatus and
FINAL_STATUS_CELLULAR_NETWORK from prerender final status.

Change-Id: I18d55917579d02f596615743c2736b6173e559c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368361Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801163}

Bug: 1082556
Change-Id: Ida303c739b31a9af6be2d394214ece28f3613b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373173
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Auto-Submit: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801162}

There is no actual usage of this abstract class anymore.

Bug: 533069
Change-Id: I31ce5c99727a1ce11918b22a2252b3113c2c8878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371683Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801161}

https://android.googlesource.com/platform/external/perfetto.git/+log/c86d8fb76ac3..746445da75a4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Idfb5b833d89b018e6720466ed374bc3474cba55f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372593Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#801160}

Crash fixed by:
https://chromium.googlesource.com/chromium/src.git/+/39bb8526f08be06a5d19791cc0fc98a5978dedd0

Bug: 1121015, 1120431
Change-Id: I957909c539d4c626dbeb238fd7e856bce4fcebb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373174Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Auto-Submit: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801159}

This CL makes BrowserImpl save the UI state of BrowserViewController
when destroying/creating it so we can save the controls location. It
doesn't use onStoreInstanceState directly because the
BrowserControlsContainerView lifecycle doesn't exactly match what
Android expects (onStoreInstanceState gets called after BCCV is already
destroyed).

Bug: 1120209
Change-Id: Ibedf4f8ad1e01f29518b404d94961b0e97689b9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368479Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801158}

Not sure what this one was doing.
There should be no behaviour change.

Change-Id: Id06d09013d54617e8928033c04e728cab9471a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369494Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801157}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/86e14dba..48246beb

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I84306bb48f84a2f2038bb279c0bea0cb96a1190a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373142Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#801156}

Many of these lint warnings were turned off because it was difficult to
fix all of them when they were introduced (usually via a lint update)
and fix incoming new errors at the same time.

Adding existing issues to the baseline and enabling for new code.

Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2369576

Fixed:
  - Regenerated baseline post-revert of a previous refactor that changed
    filepaths of errors that were in lint-baseline.xml.

Bug: 1116130,807734,671170,831774,635567
Bug: 1069186,804427
Fixed: 807734,635567,804427

TBR=wnwen@chromium.org,twellington@chromium.org,agrieve@chromium.org

Change-Id: I52fd71ed6678d35d5d31567be3038c53e544fa84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372928Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801155}

This is a reland of Ice3b2bd0589a8aff83a0f50f7bcd2d2ff6938989

Original change's description:
> Revert "FontAccess: Replace web_tests with WPT tests"
> 
> This reverts commit cfb42f4a.
> 
> Reason for revert: The upstream CL of this CL (https://crrev.com/c/2364009) is likely the cause of build breakage for Win10 Tests x64 build starting from: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/48700
> 
> Original change's description:
> > FontAccess: Replace web_tests with WPT tests
> > 
> > Replaces web_tests with WPT tests to ensure cross-browser compatibility
> > in the future.
> > 
> > Bug: 535764
> > Change-Id: Ice3b2bd0589a8aff83a0f50f7bcd2d2ff6938989
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365332
> > Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
> > Reviewed-by: Joshua Bell <jsbell@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#800345}
> 
> TBR=jsbell@chromium.org,oyiptong@chromium.org
> 
> Change-Id: I6f85c0cb68f8c30ab29a618f3365d2473c9a8b99
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 535764
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367585
> Reviewed-by: Maggie Cai <mxcai@chromium.org>
> Commit-Queue: Maggie Cai <mxcai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800478}

TBR=jsbell@chromium.org,mxcai@chromium.org,oyiptong@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 535764
Change-Id: I360c6c2fba2ec5bb665430b670df77ed645aa794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368444
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801154}

If fingerprint auth is supported, the in-session auth dialog needs
to explicitly start fingerprint auth session (so that biometrics
daemon can get prepared for the upcoming fingerprint scans), and
explicitly end fingerprint auth session when no more retries are
expected.

Bug: b:156258540, b:144861739
Change-Id: I7534594a696bd42f6f29fdc85fe8548b5cf8caae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369336
Commit-Queue: Yicheng Li <yichengli@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801153}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d989a67c59d5..d32b1bc30216

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC pmonette@google.com,wolenetz@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1085115,chromium:1119897,chromium:1120089,chromium:1120137
Tbr: pmonette@google.com,wolenetz@google.com
Change-Id: Iacd18a171dbb47c1ad075b2dfd1368a97f56bc39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372776Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#801152}

Bug: 1010217
Change-Id: Id243885fd52d5d62d96d415037d54ab7bd8d05d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372913Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801151}

BUG=b:162421778

Change-Id: I3e93cabe5791930f8ce793e569af0152193749d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367512Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jeffrey Young <cowmoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801150}

DevTools event listener is passing a dereferenced pointer value
to navigation. However, sometimes it's dereferencing a nullptr value
(from an uninitialized unique_ptr)
causing navigation tracker to crash when try to use the reference.
See bug list 3578 for a case when that pointer is nullptr.
When navigating to a blank page and an alert is triggered,
ChromeDriver will not wait for the original navigation to
finish and set the original Page.navigate response info state
to ignore; when the response finally come back, ChromeDriver is
not copying the result in the response causing the result uninitialized.

Bug: chromedriver:3578,chromedriver:3488
Change-Id: I7fd6159d724036a7354a47844da9d14d76c70b3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370091Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Shengfa Lin <shengfa@google.com>
Cr-Commit-Position: refs/heads/master@{#801149}

This reverts commit 3d77d782.

Reason for revert: Fix landed: https://chromium-review.googlesource.com/c/chromium/src/+/2360816

Original change's description:
> lacros: Temporarily revert back to Linux user-agent.
> 
> The transition to Lacros is intended to be transparent to websites. As
> such, Lacros needs to set the ChromeOS user-agent. However, in some
> contexts (e.g. chrome://settings) Lacros must behave like the Linux
> browser. The problem is that webUI makes the assumption that user-agent
> uniquely identifies platform, and that there is only one browser per
> platform. Thus, setting the ChromeOS user-agent triggers ChromeOS
> settings behavior, which uses ChromeOS-only private extension APIs,
> which crashes the renderer.
> 
> The appropriate long-term fix to this is to correctly plumb additional
> information into WebUI so that it can distinguish between Linux,
> ChromeOS and Lacros browsers. This is currently not possible without
> refactoring a substantial number of tests. This CL is a stopgap measure
> to allow chrome://settings to be usable in Lacros.
> 
> Bug: 1096590, 1111985
> Change-Id: Iabb8691e37ba6db4baba680e3d624248e8647321
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367473
> Reviewed-by: Darin Fisher <darin@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Auto-Submit: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800292}

TBR=darin@chromium.org,erikchen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1096590
Bug: 1111985
Change-Id: I4e7bb004b4c64ee67e0bc08440e186988e14ff85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369501
Auto-Submit: Erik Chen <erikchen@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Reviewed-by: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801148}

Merge-With: eureka-internal/441076
Merge-With: eureka-internal/441060

Bug: internal b/165807391
Test: cast_audio_backend_unittests
Change-Id: I2ef33d20f5aa3b5cda8db238d575d318c02092d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369581Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801147}

Instead of forcing ArgType<T>, just generically match a signature type.
This allows classes to choose to implement e.g. by reference or value,
at the cost of possibly-more-cryptic template errors when people don't
implement a setter.

We could probably give better errors than this with some helper structs
to restrict to e.g. single-arg member functions whose arg is convertible
from ArgType, but this seems good enough for now.

Bug: none
Change-Id: I079fd9dd5cd3cb51297855d2ccabde65148c0b6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363562
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801146}

When an animated dismissal is triggered while the user is interacting
with the banner, the dismissal animation is wonky. Since a cancel
indicates the removal of that Overlay request in a non-user generated
manner, it should be ok to just have it removed from the hierarchy.

Bug: 1120706
Change-Id: I3172724ba8121e67838a03ca1b41065b9091654a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372809
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801145}

Change-Id: I366350f45ee519bf1410fbe198d90b5f64814d7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372919
Auto-Submit: John Chen <johnchen@chromium.org>
Reviewed-by: Shengfa Lin <shengfa@google.com>
Commit-Queue: Shengfa Lin <shengfa@google.com>
Cr-Commit-Position: refs/heads/master@{#801144}

Using wpt-import in Chromium 7e4565c2.
With Chromium commits locally applied on WPT:
9f52c7e4 "COOP: add reporting to redirects"
d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html"
e221ccf9 "Quota: Add tentative to WPT name."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Change-Id: I6c8b6739d98afd7469e32abb6ddb9710671c92a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373011Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#801143}

It's annoying that one cannot just call size() on a std::array in a
compile-time context. Instead std::tuple_size and std::remove_reference
is needed. While std::array is used quite a lot in Chromium,
std::tuple_size is not. I assume that people are either not writing
assertions, using run-time [D]CHECKs, or using static_assert with
constants that are also used as std::array lengths.

None the less, I cannot point at a body of std::tuple_size in the code
base that would be cleaned up by this, so the case for adding a #define
is not that strong. *I* would certainly use it in static_asserts though!
(And would change [D]CHECKs into static asserts.) Maybe others would
too.

A #define isn't as nice as a constexpr function, but the latter doesn't
work as nicely at the call site. Consider the obvious:

  template<typename T, size_t N> constexpr size_t std_array_size(const std::array<T, N>&) { return N; }

That works, but not for references, where the compiler objects that the
reference “is not a constant expression”, even though the value is never
used.

Other non-define functions can work if preferred, but are worse at the
callsite. For example:

  template<typename T> constexpr size_t std_array_size() {
    return std::tuple_size<typename std::remove_reference<T>::type>::value;
  }

But that has the callsite pattern:

  static_assert(base::std_array_size<decltype(array)>() == kFoo);

This this change uses base::span::extent to define a macro, EXTENT, that
works for any type that base::make_span recognises, including
std::array.

Change-Id: Id4688117b5a558e022448ad901fa3d4995182826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364136Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801142}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /ui/gfx/canvas_skia.cc

This CL was uploaded by git cl split.

R=danakj@chromium.org

Bug: 1110266
Change-Id: I791bd924bc12bc017b8708ecfa8b7ac33d32b005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370735
Auto-Submit: Sean McAllister <smcallis@google.com>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801141}

BUG=1120822
TBR=wychen@chromium.org,pmonette@chromium.org

Change-Id: I974e9ff6e2d6029de826c488a97d28c0f1add788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372735Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801140}

Configure new tester android-pixel4a_power-perf on main perf
waterfall to run power.mobile benchmark.

Bug: 1106954
Change-Id: Iac7af6f97c108d9a148cbb038dc94b6e5a2fea85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368454Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801139}

TBR=rsleevi@chromium.org

Change-Id: I53068eafa480eae583c1ae880fa49a7b2f6827d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372592
Commit-Queue: Nick Harper <nharper@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Auto-Submit: Nick Harper <nharper@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801138}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/490961030b55..149a3b758125

2020-08-24 sokcevic@google.com Warn when non-inclusive parameters are used

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1098560
Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com
Change-Id: Iefb2dd79c17909511e963a90d4521f1289d511ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372908Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#801137}

Holding space items will be persisted to profile prefs. Note that we
don't persist Downloads as those have a separate persistence storage.
Also note that we don't yet persist images. Ideally, we shouldn't need
to.

Known deficiences:
- Doesn't yet restore downloads
- Doesn't yet restore images

Bug: 1119496
Change-Id: I74f929c8bb802a15e6771dc58ea68ec20380fe26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367701Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#801136}

Bug: 1098534
Change-Id: Ie3ef928071d1e5c542d9ba1e8496652c94916b35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367807Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801135}

Subsequent CLs will use Nearby's bluetooth::mojom::Adapter to
scan for and register BLE advertisements.

Note that incoming and outgoing BLE GATT connections are not
supported by Nearby Chrome at the moment and the respective
methods on BleMedium are left as no-ops.

See go/nearby-chrome-bt for more details.

Bug: b:154845685
Change-Id: I31537b957129a7cac6272b5f9eed3157a2e6dfa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364032Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801134}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /chrome/browser/ui/blocked_content

This CL was uploaded by git cl split.

R=csharrison@chromium.org

Bug: 1110266
Change-Id: I3aa4df135631af02b22232f4a1c9cdbd360c67cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371259
Auto-Submit: Sean McAllister <smcallis@google.com>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801133}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /chrome/browser/metrics/oom

This CL was uploaded by git cl split.

R=csharrison@chromium.org

Bug: 1110266
Change-Id: I09612099e3d071042a3f2765e5976f0b3c001b75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371252
Auto-Submit: Sean McAllister <smcallis@google.com>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801132}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /content/browser/conversions

This CL was uploaded by git cl split.

R=csharrison@chromium.org

Bug: 1110266
Change-Id: I42bb363056e26229c924208094657ac22ddc3873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371288
Auto-Submit: Sean McAllister <smcallis@google.com>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801131}

This is a reland of 297abb5a.

Added the xctest argument for iOS unit tests such that they
are triggered using the correct test runner.

Original change's description:
> [ios] noncq to run tests on 14.0 simulators
>
> ios-simulator-noncq to compile with xc12b5 as well.
> Running iOS 14.0 simulators for our test suites on xc12b5.
>
> Change-Id: I7ca5f763174c296278401ae3563894a4f5210379
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367792
> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800739}

Change-Id: Ieb214a3e7788a551258470c1fb076e6603343384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370165
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801130}

This reverts commit 3fce1e3f.

Reason for revert: Bad interaction with another revert causing compilation failure.

Original change's description:
> Android: Re-enable 14 useful lint warnings
> 
> Many of these lint warnings were turned off because it was difficult to
> fix all of them when they were introduced (usually via a lint update)
> and fix incoming new errors at the same time.
> 
> Adding existing issues to the baseline and enabling for new code.
> 
> Bug: 1116130,807734,671170,831774,635567
> Bug: 1069186,804427
> Fixed: 807734,635567,804427
> Change-Id: Id955384003a6928ea5ad3efe635a84515663b17b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369576
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Auto-Submit: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#801073}

TBR=wnwen@chromium.org,agrieve@chromium.org

Change-Id: I543e84fefdce54d2f5f189007ac82faa8d6f4976
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1116130
Bug: 807734
Bug: 671170
Bug: 831774
Bug: 635567
Bug: 1069186
Bug: 804427
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373282Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801129}

Create a Chrome flag for client side
detection on Android so it's easier to
manage without using a command line
flag.

Bug: 1108080
Change-Id: I2ffbdcb708dac89c0539039b7d06ba5e4aa4f58b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363222Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801128}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /content/shell

This CL was uploaded by git cl split.

R=danakj@chromium.org

Bug: 1110266
Change-Id: I9e9c506a2dcafdb6d83ccc0c8d163349ef9eae46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370297
Auto-Submit: Sean McAllister <smcallis@google.com>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801127}

Set kRestartFactorFinch and kInitFactorFinch to 4 for Android. This will
set the initialization and restart timeout to 60 seconds (4*15 seconds)
for kGpuWatchdogV2NewTimeout finch on Android.

For kGpuChannelTimeoutInSeconds in the browser process on Android, use
the timeout constant from the watchdog instead of a hard-coded value.

Bug: 1120145
Change-Id: I32e39c5b005a9957cf1d4fff58c4aabcb3964397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282782Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801126}

The crash at OverlaySceneLayer destructor comes apparently from
ui::WindowAndroid being in the destroyed state while its
::RemoveObserver method is called. It makes OverlaySceneLayer
destructor not the appropriate place to call it, since the
destruction order of the objects are not clear.

This CL changes the place where WindowAndroidObserver is added
or deleted i.e. when WindowAndroid's compositor is attached
or detached. WindowAndroid is guaranteed to be available
when these observer event is invoked, so it's safe to do the
operation.

Bug: 1120832
Change-Id: Ib43c420f4d5af51fca4377e92d46a408d41e86f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371384Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801125}

FrameLoaderStateMachine has 3 states. The first is for creating the
initial empty document. However, several places that check for this
state don't need to. Also, the usage in DocumentLoader can be
replaced by checking equivalent internal state. This leaves just two
places it is checked in FrameLoader itself. Instead of having the
initial empty document be part of FrameLoaderStateMachine, create a
new private FrameLoader enum for tracking its lifetime transitions
(uninitialized->initialized->detached).

With this state removed, FrameLoaderStateMachine is effectively a
boolean for whether we're displaying the initial empty document or not.
Replace this with an is_initial_empty_document_ boolean on Document.
This boolean still needs a way to be forced to false in certain cases
(i.e, internally during document.open(), and externally for consistency
during cross process navigation).

Change-Id: I7fa0a830f70fed81de13ed633d9686ee16a75161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354208
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801124}