GitLab

As suggested in https://crrev.com/c/1690965, rename methods from the
OAuth2TokenServiceDelegate to reflect the name of the public API that
is exposed through DevieAccountsSynchronizer.

As suggested in https://crrev.com/c/1667346, remove the account_id
parameter from OAuth2TokenServiceDelegate::ReloadAccountsFromSystem
by declaring different methods on iOS and Android.

Bug: none
Change-Id: Ibf8c9bce07a61504fbaf00d9268f60f1a1d52e3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697648
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676459}

This change resolves a NPE happening during deferred startup on slower devices.
It looks like these devices do not have AutocompleteCoordinator ready in time
to invoke the call to prefetch ZPS suggestions.

The downside of this change is that in these cases prefetch would not happen,
but there is a possibility we do not need to trigger it either; the prefetch
is executed currently whenever user accesses a new tab page, too.

Bug: 982343
Change-Id: Ida84fedcb8f0f057c95979d8571cb9033f2884c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693337
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676458}

Bug: 981647
Change-Id: If34b775d7bd4b4ea261c9771a537d866d671ac41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693397Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676457}

Bug: 981879, 982289
Change-Id: Ib2424bb8c149721f3380f9ff71dbcf078d0dace3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689335
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676456}

Windows.Devices.Sensors WinRT API in Chromium

As the first step for implementing usage of the
Windows.Devices.Sensors WinRT API in Chromium, this CL:
  - Introduces a feature flag (disabled by default) to switch
    between the already existing ISensor API and the new
    Windows.Devices.Sensors API implementation.
  - Adds a skeleton PlatformSensorProviderWinrt.

Verified by:
  1. Built Chromium and installed the private build.
  2. Verified ambient light sensor could be instantiated when
     the flag was in default state.
  3. Verified ambient light sensor could not be instantiated
     when flag was set to Enabled.
The new unit test was run as well.

Bug: 958266
Change-Id: I3be7fa46c7d00d87d40fc0ea9074c88a42122512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685853
Commit-Queue: Wenjie Shi <wensh@microsoft.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676455}

Currently, pdf/draw_utils.* only contains code to draw shadows. Move
this code into pdf/draw_utils/, so there is a directory for more drawing
utility code in upcoming CLs.

Change-Id: I869835ee82fca67622623b92c26e6af23b234741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696441Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676454}

According to spec (*), we shouldn't perform range checking for
math function at parse time. This patch stops such checking on
SVG lengths.

This also eliminates an improper call of
CSSMathFunctionValue::DoubleValue(), so that we can put runtime
unit type checking in there.

(*) https://drafts.csswg.org/css-values-4/#calc-range

Bug: 979895, 982425
Change-Id: Id7abfcda611c23216127818e7e2473b065116fd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693132
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676453}

When a calc() length is passed to media queries, the current code
assumes that there's always a DoubleValue(), and the unit type matches
TypeWithCalcResolved(), which is incorrect.

This patch partially fixes the issue when the calc expression can be
resolved without type conversion. Handling type conversion is more
complicated and hence left broken by this patch (as it's already broken).

Bug: 982542
Change-Id: I258b3d1aeec69fb65fbadd86981e97974239289b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696191Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676452}

Add support for a manual WebAPK update flow. This is a *dev*
feature intended to help test changes to WebAPKs/manifests
without waiting for a long time period.

The buttons set a flag that schedules an update when
next launching the WebAPK. Once scheduled, the update will
occur sometime after the WebAPK is closed. This avoids the
need for refactoring or modifying the update path and
instead just requires plumbing a status message to the UI.

Bug: 918898
Change-Id: I7eb3203f30de95f4918ae64489be9c72e24ce8f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674164
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676451}

https://skia.googlesource.com/skia.git/+log/620b7e9b012f..455c41a014c7


git log 620b7e9b012f..455c41a014c7 --date=short --no-merges --format='%ad %ae %s'
2019-07-11 halcanary@google.com Sample/Camera: make it work without /skimages
2019-07-11 mtklein@google.com rename to bt709_luminance_or_luma_to_alpha
2019-07-11 jlavrova@google.com Fix for Windows specific compiler issues (constexpr).
2019-07-11 halcanary@google.com experimental/tools: set-change-id-hook
2019-07-11 robertphillips@google.com Alter approximate scratch texture binning after 1024
2019-07-11 scroggo@google.com Revert "Update Wuffs version"


Created with:
  gclient setdep -r src/third_party/skia@455c41a014c7

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fmalita@google.com

Change-Id: I41c72abeb4098d6a560c1b7f738e03ef996529bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696993Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#676450}

When we are tracing on android P and above we should be able to connect
to the system tracing service and participate in the trace.

Bug: 964324
Change-Id: I6fa212e0b01fcc11476598540704d050f33cd31a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687266
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676449}

This CL adds logic to disconnect TextTrackContainer's ResizeObserver
when the container is removed from the document. This fixes an issue
where video elements were leaked since the ResizeObserver was a root
within the object graph.

TESTED=Patched into M76 and it fixed the leak for StratosMedia

Bug: 971193
Change-Id: Ie4c72ed34009a804d8f5d433c730ef146a9e42a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693027Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676448}

Add a NativeFileSystemPermissionRequestManager class similar to the existing
PermissionRequestManager class that queues and and combines multiple requests
for the same permissions.

Bug: 878585
Change-Id: Ice4f2c6f12a258b2f8210de2ee617487076175a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687563
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676447}

We ran the SkipPassthroughTouchEventQueueFilter Finch experiment and
pushed it out to 1% of the stable population across mobile and desktop.
We've reviewed the data, paying particularly close attention to the
Android results and are confident that we can adopt the 'skip filtering
all events' behaviour by default. This will allow us to simplify
(remove) the touch event filtering code from
passthrough_touch_event_queue.cc as well as align our FID measurements
to be closer to the user experience when there are no javascript touch
event handlers on a page.

This CL changes the corresponding base::Feature (SkipTouchEventFilter)
to be enabled by default, effectively enabling the experiment for all
users.

This CL is planned to land in conjunction with a server-side config that
will configure older clients to adopt behaviour similar to this new
status-quo. That way, FID measurements will be more comparable across
these versions, even for users who don't upgrade to new major versions.

Bug: 914500
Change-Id: I8b5c1b20f02ecdcf8c1c76341c3adad86e5aa768
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688353Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676446}

Before every call to an accessibility API on the renderer, we were not checking if the layout tree is clean,
but only if the LayoutView of the document object had a clean layout
which is not the same thing.

Change-Id: If8852842aaf4da06bbb8e65ba495b18c46f82b6a
Bug: 133517108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601618Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676445}

Some of the tests suites have had consistent flakes. Where at least one test
fails, then passes. However the tests failing is not consistent. The errors also
do not appear to be directly related to SkiaRenderer but are likely caused by
timing changes.

This adds a filter in order to not run those tests.

TEST=skia_renderer_browser_tests

Bug: 982933
Change-Id: I638b7a19bcf2b8b4369e100dec5131383fd0add9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696542Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676444}

- this adds a new beforePrinting state to Document::Printing
- if we are in beforePrinting, keep the Canvas recording and
  use it for printing
- We only do this if rendering-mode is not pixelated

Bug: 959357
Change-Id: If29b90b344b5af42cc3cbbed2f867d82841f2def
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637656
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676443}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I6261553002bc8ec81226c8d2c1568d77d80b26b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696990Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#676442}

Looks pretty stable on the fyi bot:
https://luci-milo.appspot.com/p/chromium/builders/ci/chromeos-kevin-rel-hw-tests

And decreases shard count from 6 to 2 since the shards are pretty quick.

Also remove the retry-limit args from telemetry_unittests. Not sure it's needed
anymore.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel

Bug: 938502
Change-Id: Ice81330589683772671f3133a4a607af8ff2bf89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695760Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676441}

This change includes moving |complete_callback_for_testing_| to the
NavigationRequest.

Bug: 916537
Change-Id: Ic8430f6f082382b6b2670a895ef3f42a31f7e9b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692413Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676440}

In cases when the policy store flow fails, there can be multiple
reasons on low level. The added logs would help narrow down the reason
when we encounter this situation.

BUG=chromium:979195
TEST=None

Change-Id: I84f7088075ecef33d9abbabda10aed2cf7c90433
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697185Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Igor <igorcov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676439}

This change is meant to be a pure refactoring. It is not meant to change
behavior.

The current design of AutofillAssistantModuleEntry makes them specific
to a WebContents. This assumes that everything needs a tab and
WebContents, and that we should wait if there isn't one, which won't be
true for the DirectActionHandler to be returned by
AutofillAssistantFacade.

This changes makes AutofillAssistantModuleEntry global and stateless,
getting rid of the intermediate factory instance.

This change also extracts the AssistantOnboardingCoordinator that was in
AutofillAssistantModuleEntryImpl, to make it reusable in the
implementation of direct actions and adds a test for the new use
case (onboarding without tabs.)

Bug: b/134741524
Change-Id: Iadf0831cdbf252910de841996b99943c7336036f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695305
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676438}

With GlobalTaskQueueFactory removed, link-time injection of the
webrtc::CreateDefaultTaskQueueFactory has no effect any longer

Bug: webrtc:10284
Change-Id: I5af06bd5e7ddcc3c49bebe23e6f0bea6a1d616ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695558
Auto-Submit: Danil Chapovalov <danilchap@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Danil Chapovalov <danilchap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676437}

This test has been marked as passing everywhere but started failing on
the GPU FYI waterfall on builders that appear to all have SkiaRenderer
in common. This CL suppresses the test again on this configuration.

BUG=chromium:918155
TBR=wangxianzhu@chromium.org

Change-Id: I7c078376efa8d593282f0d056332b81fdeb9573e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697743Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676436}

The call to web_contents()->Focus() had no effect when called
from InitializeWindow since the RenderWidgetHostView instance
is not created yet.  (So WebContentsViewAura::Focus() could not
call RenderWidgetHostView->Focus).  Moved the focus call to the
RenderViewCreated callback when we know the RVHV is available.
This fixed setting the focus.

Now that the top level window received focus properly, fixed
the AXTreeSourceAura::GetTreeData routine to obtain the
correct ax node ID by asking the focus client for the focused
window and then getting the node id from the obj cache.

Prior to this change, HTML nodes that had aura-live attributes
set would not trigger TTS properly since the ChromeVox extension
code expected to find focus on the top level node. Otherwise,
it would ignore the live region changes.

Test: Tested downstream display assistant build

      In devtools console window,
          var div = document.createElement('div');
	  div.innerHTML="Please speak this";
          div.setAttribute('aria-live','polite');
          document.body.appendChild(div);

      Verified before the fix, TTS would say nothing.  With the fix,
      TTS for the live region is spoken as expected.

Bug: 981373
Change-Id: I5e1744b5e37422faede4a217eec20271fc253ed3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688878Reviewed-by: Sean Topping <seantopping@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676435}

The histogram is soon to expire and based on the discussions on the bug,
it seems it is not used and it is not useful. For this reason, this CL
drops the code reporting for such histogram.

BUG=975502,879133

Change-Id: Iabef86141f972b578338f67d91099e06968300bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697624
Commit-Queue: Armando Miraglia <armax@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676434}

Bug: 973425
Change-Id: Ief1f427bfaaab642051be53e9a75a9a933a01581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688183
Auto-Submit: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676433}

Change-Id: I94aed3bbe9a4ef2edea4ee38e9fca03b1181292b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696167
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676432}

AudioHandler::Context() returns an untraced raw pointer to the
context so checking its value might be pointing some non-null
garbage after the context is gone. In that case, invoking
GetExecutionContext() might return a pointer to some random
memory space.

By checking a local flag on ExecutionContext's validity,
we can avoid such memory access.

Bug: 977107
Test: ASAN build does not crash on a repro code with the fix.
Change-Id: I19020e019cc3d9d52de3bebbe23129e7dd7b0a5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693163Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676431}

Remove the parameter as it is not used (except to check that the
value is correctly set for the primary account). Instead check
that a non-empty value is set for the primary account after the
call to DeviceAccountsSynchronizer::ReloadAllAccountsFromSystem.

Bug: 982681
Change-Id: I9627ef85e5e1f4df66872418ea8ac07cc72f03b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695307
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676430}

Adds ResultCodes that are used by the forthcoming CryptAuthDeviceSyncer.

Also, adds a parameter that specifies whether or not the device registry
changed as a result of the DeviceSync attempt.

Bug: 951969
Change-Id: I700d225983b4f0c357e652ae5f157ea7f50e2fec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684246
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676429}

Rename these variables and methods in LCP and ET:
* NotifyBackgroundImageRemoved to NotifyImageRemoved
* RecordBackgroundImage to RecordImage
* BackgroundImageId to RecordId
* background_image_id to record_id
* invisible_node_ids_ to invisible_images_
* visible_background_image_map_ to visible_images_

Updated a few comments.

This is a follow-up patch for crrev.com/c/1692494

Bug:972146, 982431

Change-Id: I1bef73f5b4adb4b8731d792dee6b0e07c4759e4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695819Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676428}

The test does not currently work when the share menu displays in a
popover.

BUG=983135

Change-Id: I6d9e106792b4bb383b257fd6b315e62a0fdddc23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698122Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676427}

Bug: 982900
Change-Id: Ic089629eed8bec1d68c1fcbc7ae88bb326ca1282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696219
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676426}

Right now, the SKV Android bot does not pass
--enable-features=UseSkiaRenderer. Although it doesn't seem to be
required yet, it should be passed to be consistent and allow future
developers to rely on this consistency.

Bug: 963238
Change-Id: I3095b8bbdc3692c0fe668d49eb1f39cd1bae4e3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693390
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676425}

Inject PrefServices to SigninManagerAndroid via
SigninManagerAndroidWrapperFactory. This tackles the last dependency
preventing the componentization of SigninManager.java.

This change is discussed and described within "componentization of
SigninManager.java":
https://docs.google.com/document/d/18887XeZNJ9pmoTdJducssk5_yVU2CQ3EqaRFoMqWCCk/edit?usp=sharing

Bug: 963408
Change-Id: Ib0afa4e818b545f325f79e689ff6882e80fb0735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688959
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676424}

This reverts commit eb6b4eb4.

Reason for revert: It looks like the test went green just before this
CL landed. Attempting to re-enable. 

Original change's description:
> Disable flaky test WebRtcMediaStreamTrackAdapterTest.LocalVideoTrack.
> 
> Bug: 982200
> Change-Id: I68547d2d5b097ab0fd816e44ca548a0024acec70
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692223
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#675841}

TBR=falken@chromium.org,sergeyu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 982200
Change-Id: I66dac5938e32c0e08f1eff79eb37fe5a821c6a03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698241Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676423}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e545aee4..2206e55a

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6b82ecd96d468365a7ab95b7fb10912c0f09bb31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698164Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#676422}

Python 3 only has range, so change to it.  These shouldn't be
critical path to care about iterator-vs-generator differences
in Python 2.

Bug: 983071
Test: `./grit/test_suite_all.py` passes
Change-Id: I85909abb85870e458fa1e6d819e61e6314d6efab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698163
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676421}

moved part of reloadWithRendererInitiatedNavigation and
loadCurrentURLWithRendererInitiatedNavigation related to
request loading.
moved hasOpener, currentNavItemReferrer, createWebUIForURL
and clearWebUI which are only used in request controller
or with no direct used in crw_web_controller.  For example
createWebUIForURL is now only called through the
navigation handler delegate.

crw_web_controller is down to ~2800 lines, of which 800+ are just
delegates that are mostly proxy to peoperties or methods of other
extracted components.

Bug: 956512
Change-Id: I93af07d8d51b5c9c2dc9a23eaccbf14c91ecc6ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692741
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676420}