- 23 Sep, 2019 40 commits
-
-
Adrienne Walker authored
... per discussion at TPAC. Naming still needs bikeshedding, but updating the plumbing to reflect the latest thinking. This experimental option is behind the RuntimeEnabledFeatures::IDBRelaxedDurabilityEnabled flag. Bug: 965883 Change-Id: Ied85fbe6fc106871e9c5d501eccababf5c96c293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814221 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#699109}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/49fd27d9af5f..a905cbcdc21b git log 49fd27d9af5f..a905cbcdc21b --date=short --no-merges --format='%ad %ae %s' 2019-09-23 jmadill@chromium.org Compact built-in symbol table. Created with: gclient setdep -r src/third_party/angle@a905cbcdc21b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:998535 Change-Id: Idae90bcb0a0a38e63736ef7b441946e193e64c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819902Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699108}
-
Jinsuk Kim authored
BottomSheet dark mode is properly handled by https://crrev.com/c/1004907. The tint adjustment performed previously should now be removed. Bug: 1004907 Change-Id: Iefbd2d76efd956c73229ece6126dc3cca167d1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818880Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#699107}
-
Lambros Lambrou authored
This adds an option '-n <notarization username>' to the signing script for the Mac Chromoting host installer. If the option is present, the final disk image (DMG) will be uploaded to Apple for notarization, with the provided username, and the password from the environment variable $NOTARIZATION_PASSWORD. If successful, the DMG will be stapled with the result. Bug: 999406 Change-Id: I745d15f35deb2c8360bb9e2ed236ce27a636c50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807961Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#699106}
-
Will Harris authored
BUG=726150 Change-Id: I1da9356babc457791455d3472d2113c44fe8f50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819972Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#699105}
-
Marcin Wiącek authored
Patch is continuing strategy from https://chromium-review.googlesource.com/c/chromium/src/+/1594725 and sharing default interpolators in more places (they were moved from CompositorAnimator.java to separate Interpolators.java) Change-Id: I73efff08d44db09b100e217f01f8fd1876b72daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807497 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#699104}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/37dd8faa..d0581808 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I922c43080f0fbe1cbe2be7d28d4ee109355bd476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819807Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699103}
-
Alexei Filippov authored
Same for RowWordStarts BUG=1006840 Change-Id: I9d9149e810383dce9bf2520408034238532ea707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819638Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#699102}
-
Eric Willigers authored
Any empty list of list items can be discarded when parsing grid-template-rows, grid-template-columns, etc. Discussed in https://github.com/w3c/csswg-drafts/issues/4173 Change-Id: I859020aaa78b71d2540d9ec188335f22db3f278a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810454Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#699101}
-
Jon Mann authored
When translating managed properties to a mojo object the allow_roaming value was getting pulled from the wrong dictionary which resulted in it always being set to 'false'. This prevented the correct subheading from appearing on the network details page. Bug: 1006410 Change-Id: I78a8976668429646d56a9f3d2fe2f5f52964fbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819976Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#699100}
-
Sky Malice authored
Bug: 992585 Change-Id: I76d8de861d6844bfa00bd402ab8bf4110c7974f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819997Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1f5e48f34c74..62ba8cb7666f git log 1f5e48f34c74..62ba8cb7666f --date=short --no-merges --format='%ad %ae %s' 2019-09-23 lamontjones@chromium.org image_lib: more debug output forLoopbackPartitions.Mount Created with: gclient setdep -r src/third_party/chromite@62ba8cb7666f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9e6464a301fc14150ab6aa2dcd60f3516a8c8f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819917Reviewed-by:
-
Jasper Chapman-Black authored
Instead of naming string literals 'string literal', name ASCII-encodable string literals using the first few characters of the literal (e.g. "string contents" or "long string contents[...]"). Non-ASCII-encodable string literals are still called 'string literal', and this change should be backwards-compatible. Sample (filtered) output at https://storage.googleapis.com/chrome-supersize/viewer.html?load_url=oneoffs%2Fsample-string-literals2.ndjson&byteunit=B&include=%22 This increased a sample .size filesize by 640K, about a 5% increase. Bug: 939221 Change-Id: Iaf6a0200b1bf5ed9420f506377eb7b4d422d56cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815881 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#699097}
-
Shakti Sahu authored
Bug: 1006817 Change-Id: I122fc9c2db8ef6fc0c62a4c31722538860fc1286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819885Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699096}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5073a9e8d71d..28837bfd862a git log 5073a9e8d71d..28837bfd862a --date=short --no-merges --format='%ad %ae %s' 2019-09-23 tcwang@google.com Fix tracing not started problem after Chrome OS is mounted to remove write-protection Created with: gclient setdep -r src/third_party/catapult@28837bfd862a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1000760 Change-Id: Id90b08667616212f7b17dbc1bff13c4d4e125ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819106Reviewed-by:
-
Thomas Guilbert authored
This CL add the necessary boilerplate to dynamically load the AAudio library, along with an output audio stream implementation built on top of AAudio. Change-Id: If07039e278ea8aadace44a03e2c2035073047f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814543 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#699094}
-
Stefan Zager authored
If the following sequence happens: - IntersectionObserver sends a notification - Layout is dirtied in a way that should generate a new notification - Lifecyce update runs - IntersectionObserver skips processing due to its 'delay' parameter ... then we need to guarantee that the IntersectionObserver will send the necessary notification after the required delay. If animation frames are being regularly generated, this won't be a problem, because the observer will get a chance to run at the end of every lifecycle update. But if the document goes dormant, and frames are not being regularly generated, then we must force a lifecycle update after enough time has passed, to give the observer a chance to run. Change-Id: I74b63486e5c9b05c662f9e2e6e1c0b4baf00eba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812798Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#699093}
-
Synthia Islam authored
The spec for 'quotes' recently changed so that the initial value is no longer implementation dependent. Added inheritance.html and inheritance-expected.txt according to latest spec Bug: 990557 Change-Id: I7db4a0fd2fed56c0b9c95784382f333c666d9fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816253 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#699092}
-
Patrick To authored
The API version currently isn't passed into xrCreateInstance. This works on today's OpenXR runtime from the Microsoft Store, but future runtimes will throw an error if the version is not specified. Bug: 1006428 Change-Id: I7243e848027957f2a4a51c3d564a3444fbc28ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817023Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699091}
-
Mohammad Refaat authored
Change-Id: I6678cfc2882800c5b2e0f9e95625872ab8ed7885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819622 Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#699090}
-
Andrew Xu authored
This CL enables scrollable shelf as default. It will be landed after discussion with other team members. Bug: 1002576 Change-Id: I21e3979a0e756207b4cfc0fa90fe844e1c971550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819861Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699089}
-
John Lee authored
This CL also hides the favicon if the tab is still loading and there is no favicon specified. This is more inline with the native tabstrip. Bug: 1004985 Change-Id: I223bd1b25ab7e2d4d8a264eb2d3c8dc468bdeabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810062Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#699088}
-
Toni Barzic authored
The new spec requires the apps grid to be moved down 24 dip, and it's opacity change to 0.1 when search results are shown. BUG=1006567 Change-Id: I239c0f052197b0df79f5552525288ca5ad56e881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817682 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699087}
-
Xinghui Lu authored
Password manager is able to capture committed text through Ime committed text events. Added a finch flag SafeBrowsingSendPasswordReusePing to control password reuse pings. Bug: 1004842 Change-Id: I5fd58380da245150953372ce024d5a536eed9f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815050 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#699086}
-
Dan Beam authored
Relevant style guidance: https://bit.ly/cr-cpp-do-dont#use-and-instead-of-bare Noticed while investigating https://crbug.com/1006619 but not really related. R=dpapad@chromium.org BUG=none Change-Id: Ia13d8fa63bed5d4958ce0de57811be5b92dae915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818464 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#699085}
-
Richard Knoll authored
This adds UMA to track the actual display delay of notifications with show triggers. Bug: 891339 Change-Id: I8263b9b50df06eabb38079641069863d74d26327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801758Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699084}
-
Alex Turner authored
Currently the owner of NavigationPredictorAnchorElementMetrics and NavigationPredictorPageLinkMetrics is a chromium.*com* not chromium.org email address and there is no listed owner of NavigationPredictorPageLinkClick. Bug: 1005467 Change-Id: I904a148b94e232d243369c27292e3ba8a5964b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811838Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b3542d95da65..4dd7c01ca87e git log b3542d95da65..4dd7c01ca87e --date=short --no-merges --format='%ad %ae %s' 2019-09-23 jvanverth@google.com Use safe computation for adding up YUVASizeInfo total bytes Created with: gclient setdep -r src/third_party/skia@4dd7c01ca87e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: If5bebc91e7b41a6c0a9dddc2959477d6de187614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819899Reviewed-by:
-
George Steel authored
Fix filenames of manual tests in external/wpt/css/css-transitions to include the proper -manual.html suffix instead of the legcy meta tag. Move their TextExpectations entries to NeverFixTests with the other manual tests. Bug: 626703 Change-Id: I93ad061f8b88dfc3abc7837c93d347b63de7bc61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795631 Commit-Queue: George Steel <gtsteel@chromium.org> Auto-Submit: George Steel <gtsteel@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699081}
-
Andrew Grieve authored
Change-Id: Ib441c5bd3ce3dec875e3403d8bf7eb1512dfdbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819349Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#699080}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fdb59f0d9088..6f18e68719fc git log fdb59f0d9088..6f18e68719fc --date=short --no-merges --format='%ad %ae %s' 2019-09-23 ehmaldonado@chromium.org gclient: Execute python hooks using vpython. Created with: gclient setdep -r src/third_party/depot_tools@6f18e68719fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I98535285f4fb1fe1a01b56f5b54e414896ccb410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819900Reviewed-by:
-
David Black authored
Hover changed events may be propagated during the widget close sequence. Previously, this could cause us to schedule a timer to auto- close the proactive suggestions view which would crash when firing due to the widget no longer existing. Bug: b:141386438 Change-Id: Ia2a2cf8ba11c9f1209df857edccbd160e1be45c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817762Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#699078}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/4edb70c11cc5..c5b0621faea0 git log 4edb70c11cc5..c5b0621faea0 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 rharrison@google.com Add --update_known_failures to spvc test script (#813) Created with: gclient setdep -r src/third_party/shaderc/src@c5b0621faea0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I0072a163189c6a3a72b134c1f3cd325de4ce2a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817775Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/112a550769c4..cbf54891be66 Created with: gclient setdep -r src-internal@cbf54891be66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If5995481d935803c1a2390a28682e868416ffa3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817768Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699076}
-
Maksym Onufriienko authored
Example of test run on iOS 13.0 real device https://ci.chromium.org/p/chrome/builders/try/iphone-device/166 This cl depends on http://crrev/c/1802023 that enables test output in console. Bug: 1001667 Change-Id: I95ae522be3ba573d6c2d5c7d74956e315cb8be8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793126 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#699075}
-
Emily Stark authored
When an HTTP auth prompt is cancelled, we close the prompt and refresh the page to retrieve the 401 error body from the server. There is some logic in LoginNavigationThrottle/LoginTabHelper that tracks/detects these refreshes to handle them specially, i.e. not re-show an auth prompt when the refresh commits. This logic was looking at NavigationController:GetVisibleEntry() to determine when an observed navigation was one of these refresh navigations -- but a visible entry is not always guaranteed to exist, leading to crashes. One correct fix would be to check for a null visible entry, but instead we now look at the pending entry. This is more specific because the pending entry is the one that would be for the refresh. Note: this fix relies on the assumption that GetPendingEntry() will always be non-null during a main-frame WillProcessResponse(). I think this condition is guaranteed, but if I'm wrong, it will show up as crashes when dereferencing GetPendingEntry(). In that case we'll need to add a check for a null GetPendingEntry(). Bug: 1005096 Change-Id: If4a72ca903e14da588c0ee515648e8d2694f8612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819331 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#699074}
-
Rakib M. Hasan authored
These operations don't depend on the reference files, therefore we don't need to look for these args for each reference file. Bug: chromium:982208 Change-Id: Ie3ffe4491d3ff5f23ccc087b60e6bb969c02bfa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817774Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#699073}
-
Brian Sheedy authored
Adds the necessary data dependencies for Telemetry ChromeOS stack symbolization to work on the bots and re-enables the stack symbolization tests on ChromeOS. Also adds support for ChromeOS to generage_breakpad_symbols.py, which is the same as Android. This is necessary because Android and ChromeOS need to use readelf instead of ldd due to potentially different architectures between the host and device. Bug: 978952 Change-Id: Ic143d8a9d233c324a1e4fd20463c9ce2ffeec40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790330 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
dpapad authored
Replacing with 'on-cilck' and click() respectively. Bug: 812035 Change-Id: Iaa2a1dc8a6b528b2cdfdb410601ea742c374757d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819109 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#699071}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1f89f58faeb8..e3a5983705da git log 1f89f58faeb8..e3a5983705da --date=short --no-merges --format='%ad %ae %s' 2019-09-23 swiftshader.regress@gmail.com Regres: Update test lists @ 1f89f58f Created with: gclient setdep -r src/third_party/swiftshader@e3a5983705da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Id366060c5330d71bb69eaaeb8883bc82ed13298f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817773Reviewed-by:
-
