GitLab

Bug:829460

Change-Id: I6aeb5fb1026616c1d0cc92bbeed0a1004813ae76
Reviewed-on: https://chromium-review.googlesource.com/1089931Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567706}

Change-Id: I639edf669730918329f3368c73440062c3df1997
Bug: 839419,818832,852786
Reviewed-on: https://chromium-review.googlesource.com/1100962
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567705}

This just adds a link to a crbug.com comment with some thoughts about
solutions to a TODO comment inside password_field_prediction.cc.

TBR-ing Vadym, because this is a comment-only minor change.
TBR=dvadym@chromium.org

Bug: 853149
Change-Id: Id71691e9abff7cb19d069b9de30eef5c4a64fe11
Reviewed-on: https://chromium-review.googlesource.com/1102683Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567704}

We are now seeing new WPT test names like:
external/wpt/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)
which were not handled properly by Base.output_filename because it would
consider the ".*)" part as the file extension.

Change-Id: I5adc37c37fb677dc360085d395f0213d096f04ef
Reviewed-on: https://chromium-review.googlesource.com/1102182Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567703}

This removes the other check that ensures a specific number of
infobars isn't showing.  This could be breaking if the translate
infobar showed up.

Stack:
java.lang.AssertionError: Criteria not met in allotted time.
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:93)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:172)
	at org.chromium.chrome.browser.PopupTest.testPopupWindowsAppearWhenAllowed(PopupTest.java:178)

BUG=771103

Change-Id: If439b42e6d0f63fa61cd75ea48bddb2e42571994
Reviewed-on: https://chromium-review.googlesource.com/1101830Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567702}

Bug: 853175
Change-Id: I3982fd6c2bc6fecbda09c3f5edb6731921c8618a
Reviewed-on: https://chromium-review.googlesource.com/1102464Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567701}

Bug: None
Change-Id: I3ab1fd657115a98baa6d88a11ecaf6d0457c83c7
Reviewed-on: https://chromium-review.googlesource.com/1101711
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567700}

Bug: 851544
Change-Id: I0504db37dce23a2cbc69624a30452e328c8d9a84
Reviewed-on: https://chromium-review.googlesource.com/1101998
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567699}

We will remove the grouping key feature in Telemetry, hence these stories need
to be named differently (right now, they are named the same but have different
grouping keys)

Bug: 849363
Change-Id: I360aea0720c13383486fdb113ceda775c9a4f136
Reviewed-on: https://chromium-review.googlesource.com/1101542
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567698}

This test was flaky due to a race condition in navigation code, which
has now been fixed. Let's try to enable it and see if the fix has helped
deflake this test.

Bug: 708139
Change-Id: I07c975eb6d6e207b6108f9f1cc6ed0e965981cde
Reviewed-on: https://chromium-review.googlesource.com/1102660Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567697}

This CL replaces UI strings of Bluetooth feature pod button in
UnifiedSystemTray. It also shows the connected device name, and if there
are multiple connected devices, it shows the number.

TEST=manual
BUG=813499

Change-Id: Ic4d840586f2ff490a9c72b19c6679bb3c5c674a6
Reviewed-on: https://chromium-review.googlesource.com/1102225Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567696}

This CL adds ConnectionRole as part of the scan filter passed to
BleScanner; then, when a scan result is returned, the delegate callback
is only invoked if a scan filter with the correct role is present. This
is necessary because BleConnectionManager should not attempt to handle
scan results for the incorrect role.

This CL also tweaks the Delegate's callback function to return a
ConnectionRole instead of a "is background" bool.

Bug: 824568, 752273
Change-Id: I6467312bfbe2057b046cbc606a55d30e90e48303
Reviewed-on: https://chromium-review.googlesource.com/1102124Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567695}

In not-surfaceless mode, webxr_ may not be initialized yet at the time
we get an incoming SetWebVrMode(false) call which calls EndPresentation.
Add a check to avoid a crash in that scenario.

BUG=846102

Change-Id: Ib5cd0d2483de831c6690cb8e1d3dbf139da44778
Reviewed-on: https://chromium-review.googlesource.com/1102122Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567694}

This CL makes the dimensions within the tab switch button a closer
to the spec: 8px between icon and text, and reduces the 18px to the
left of the icon to 16px. (The spec still wants 8px here.)

Additionally, it updates the icon using the provided SVG.

Bug: 780835
Change-Id: I4542ea03c4097b83c959f77ed86c96b2744e14ce
Reviewed-on: https://chromium-review.googlesource.com/1101399Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567693}

Some of the TouchActionBrowserTests are flaky. I was recently told by
sahel@ that setting speed_in_pixels_s to a very high number will ensure
there is one GSU only and will prevent the flaky. This does work, at
least locally. I have tried the test in this CL locally and it was
flaky without this change. With this change, I have ran this test 50
times without any failure.

This CL does that. Right now there are a few tests marked flaky, this
CL enables one of them first. I will monitor the flakiness dashboard
once this CL lands. If this does solve the problem, we will then enable
more tests.

Bug: 833015
Change-Id: I539703866094fb526e220c48aaf327836345b950
Reviewed-on: https://chromium-review.googlesource.com/1101464
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567692}

Before this CL, GetUploadToGoogleState only checked whether Sync
encryption (with a custom passphrase) was enabled at all. This wasn't
accurate for data types that are never encrypted, e.g. DEVICE_INFO or
AUTOFILL_WALLET_DATA. So this CL adds a per-data type encryption check.

One problem caused by this was that credit card autofill was broken for
users with a custom Sync passphrase. Note that credit card *upload*
should still be disabled for those users, so this CL adds an explicit
check for that.

Bug: 852815
Change-Id: I0d0119596c81fe32d9085b495a2e591d149bdad8
Reviewed-on: https://chromium-review.googlesource.com/1102328Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567691}

Bug: 852929
Change-Id: I909e627399821e61d8d0ad5ba94ff03cb45d8249
Reviewed-on: https://chromium-review.googlesource.com/1101651Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567690}

This CL prevents the is_acting_as_audio_controls_ state from updating
during an HTMLMediaElement's removal from the document. This fixes an
issue where a DCHECK was firing on the controls inserting elements into
the panel during a removal.

Bug: 851374
Change-Id: I28a4cd31dd4e0197b8fcad8cfaa9401dbf5aea61
Reviewed-on: https://chromium-review.googlesource.com/1098306Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567689}

This test was flaky due to a race condition in navigation code, which
has now been fixed. Let's try to enable it and see if the fix has helped
deflake this test.

Bug: 660288
Change-Id: Id5d74179b9719d97f712277d2fe2380b2235d74f
Reviewed-on: https://chromium-review.googlesource.com/1102569Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567688}

Setting the manager up for returning items for both a TableView model and a CollectionViewModel.

Change-Id: I27cea8787527dc8b4f28aa5abe7f38b3858dbc44
Reviewed-on: https://chromium-review.googlesource.com/1091703
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567687}

Bug: 833797
Change-Id: Ib83ba49c9cd87d8ff8723ea53b6f32404f0e066a
Reviewed-on: https://chromium-review.googlesource.com/1082473
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567686}

The Viz work on Mac has stabilized. The flakes we see in tests on our FYI bots
are general flakes. The original GL and Surface Invariants errors that prevented
us from running on the waterfall have all been fixed.

This adds the Viz testing group to the list of mac tests.

TEST=viz_browser_tests, viz_content_browsertests, viz_content_unittests

Bug: 850137
Change-Id: Ieef76cd4457bd967909cb56622fbfd243cbc38ae
Reviewed-on: https://chromium-review.googlesource.com/1095687Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567685}

Doing rpath stack handling is the correct thing to do, but since the framework
needs to be able to be symbolized on its own for the telemetry crash tests,
it needs to have all the rpaths it needs directly -- and then this code isn't
needed.  Removing it makes telemetry_perf_unittests's core.stacktrace_unittests
and content_shell_crash_test both fail if a framework has incomplete rpaths.

Reverts the parts of https://chromium-review.googlesource.com/c/chromium/src/+/1095834
that weren't a revert.

Bug: 850055
Change-Id: I9d0c4bd0d64ffbcfc03184dc761a4a2694b6754d
Reviewed-on: https://chromium-review.googlesource.com/1102056Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567684}

Also some doc comments and API tidy-up.

Bug: 783309
Change-Id: I1551478010dcd47aa0169935c4a3dc219997466e
Reviewed-on: https://chromium-review.googlesource.com/1102471
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567683}

And adds OopAsh for the new code path.

BUG=837686
TEST=covered by tests

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5e0dbaccd8974ecf996e7507f0e327fc37c281db
Reviewed-on: https://chromium-review.googlesource.com/1101648
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567682}

This CL adds specifications for time display font size and media button
background size. This fixes an issue where the time display and media
buttons were scaling up with the video size despite being in immersive
mode.

Bug: 850562
Change-Id: I1d6734f281bcfe2c269ab39efea958bd6087a1b5
Reviewed-on: https://chromium-review.googlesource.com/1101904Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567681}

This CL is part of a serie of CL to remove usage of the deprecated
method NavigationController::GetActiveEntry.

Bug: 273710
Change-Id: I68a14673811f5e2854828ec8aaa218e86f9bef87
Reviewed-on: https://chromium-review.googlesource.com/1102461Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567680}

Sanitizers macros should never be defined in a project BUILD.gn files.

Bug: 852817
Change-Id: I55597f31042ebeaf6aae8c8670892a9ba7f49417
Reviewed-on: https://chromium-review.googlesource.com/1102566Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567679}

This change updates how each of the SitePerProcessBrowserTouchActionTest waits
for hit testing data, using the new HitTestRegionObserver apis which also work
with Viz.

This also updates the helper method WaitForTouchActionUpdated to no longer
wait for child surfaces, as these calls were not actually doing anything. And
they also don't work in Viz. These tests currently aren't actually generating
frames, and syncing the renderer main thread should be sufficient.

TEST=SitePerProcessBrowserTouchActionTest*

Bug: 848021
Change-Id: Ibda33721785cda1202be0ede09bc393edf1b341a
Reviewed-on: https://chromium-review.googlesource.com/1099036Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567678}

This CL is part of a serie of CLs to remove usage of the deprecated
method NavigationController::GetActiveEntry.

Bug: 273710
Change-Id: Ifa92b8d5b357addd135d9fdc641696e92ed53f2d
Reviewed-on: https://chromium-review.googlesource.com/1102581Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567677}

When I moved the test suites from chromium.webkit to the debug
builders on chromium.linux and chromium.mac in r576522, I
accidentally dropped the --debug flag; this causes the builds
to fail completely when it looks in the //out/Release directory
for the binaries.

BUG=853209
TBR=robliao@chromium.org
NOTRY=true

Change-Id: Ia36854052c07c3b94a1b42b128e769ed08fc160e
Reviewed-on: https://chromium-review.googlesource.com/1102657Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567676}

In https://chromium-review.googlesource.com/1096489, I added a fix for an issue
where a tab could get stuck in a partially-discarded state if you started
dragging it and then tapped the incognito button while you still had your finger
down. Unfortunately, my original fix for the issue, which was to start an
undiscard animation in NonOverlappingStack#runSwitchAwayAnimation(), is a bad
idea, since that animation animates the StackTabs' scroll offsets, conflicting
with the incognito animation, causing animation jankiness.

This CL replaces the call to start the discard animation with a loop that just
sets each tab's scroll offset to 0.

Bug: 853034,852995,831359
Change-Id: I4b6e34bf68afb9ce025e3272c0c0816f84f8b48e
Reviewed-on: https://chromium-review.googlesource.com/1102115Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567675}

ProxyResolvingClientSocketFactory takes care of creating a new
HttpNetworkSession that is based on a given net::URLRequestContext.

This CL switches GCM's ConnectionFactoryImpl to using
ProxyResolvingClientSocketFactory, so there is less code duplication. This
will makes it easier to standardize usage of ProxyResolvingClientSocket to
prepare for servicifying it.

Bug: 844187
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I06b1f6b7c6fc7e8c458b24f2ee3dcc5664bd4c21
Reviewed-on: https://chromium-review.googlesource.com/1101058
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567674}

Change-Id: Id4ab9fafa2546b42a0094466c3f4cbefa6a65a56
Reviewed-on: https://chromium-review.googlesource.com/1102483Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567673}

https://chromium.googlesource.com/angle/angle.git/+log/06a2262078b2..0661eb899f46


git log 06a2262078b2..0661eb899f46 --date=short --no-merges --format='%ad %ae %s'
2018-06-15 jiawei.shao@intel.com Fix compile error in iterating ShaderBitSet


Created with:
  gclient setdep -r src/third_party/angle@0661eb899f46

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I424a7199d0df4a709e72f95ef40d5d3f72d85704
Reviewed-on: https://chromium-review.googlesource.com/1102403Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567672}

TBR=charliea@chromium.org
NOTRY=true

Bug: 853212
Change-Id: Id5f9e32f018e5cf3bcec17f49ea98738e1368eb0
Reviewed-on: https://chromium-review.googlesource.com/1102572Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567671}

This patch stops painting a line break the end of inline-block
because if an inline-block is at the middle of line, we should not paint
a line break.
Old layout paints line break if the inline-block is at the end of line, but
since its complex to determine if the inline-block is at the end of line on NG,
this patch just cancels block-end line break painting for any inline-block.

This patch fixes:
 paint/selection/text-selection-inline-block-rtl.html
 paint/selection/text-selection-inline-block.html
(rebase is for 1px line height).

Bug: 708452
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I270b48fd432e31b327796b098edc7c9553b356ad
Reviewed-on: https://chromium-review.googlesource.com/1096922
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567670}

Bug: 852075
Change-Id: Ic0dad63f55974911ae45355d546d1b7ec5efcdc3
Reviewed-on: https://chromium-review.googlesource.com/1101925Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567669}

BrowserDMToken storage should already read DM token from Registry.
MachineLevelCloudPolicyFetcher should be created if there is a DM token
avaiable.

Bug: 852903
Change-Id: Ib10f03a3c0c944358212d076b5c39f38fb88c4ce
Reviewed-on: https://chromium-review.googlesource.com/1101556
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567668}

List of patterns of .class files to exclude from the cronet_impl_native_java.jar,
while they still exist in the cronet_impl_native_java-src.jar. This CL fixes their
consistency, and reduce the cronet_impl_native_java-src.jar by about 50 KiB.

TBR=xunjieli@chromium.org

Change-Id: Ieefd47e47b406873c941203d509e898371392ee9
Reviewed-on: https://chromium-review.googlesource.com/1102235Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567667}