GitLab

Disable TabTest:testTabIsAlive on Android because it fails on FYI bot Android Tests (K N5, user build)(dbg). Re-enable it after the test on Android is fixed. See details in https://crbug.com/463933

BUG=463933

Review URL: https://codereview.chromium.org/971613004

Cr-Commit-Position: refs/heads/master@{#319104}

The tests should only run when tab control is supported.

See log on FYI bot Android Tests (K N5, user build)(dbg):
http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28K%20N5%2C%20user%20build%29%28dbg%29/builds/3050/steps/telemetry_unittests/logs/stdio

BUG=437881

Review URL: https://codereview.chromium.org/979833003

Cr-Commit-Position: refs/heads/master@{#319103}

We have shader compilation caching but telemetry can't benefit from it since
pages are tested with cache cleared.

We want to reflect the caching impact in our metrics. To enable the cache,
after the initial load of the page, we wait for a while for the page to
build some cache, and then reload the page and test the user interaction.

Linkedin and Wowwiki in key_mobile_sites_smooth are selected for this since
they are found to have expensive initial shader compilation cost.

BUG=430631,453861,451216

Review URL: https://codereview.chromium.org/959063002

Cr-Commit-Position: refs/heads/master@{#319102}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7ab4277..b841060

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/971463003

Cr-Commit-Position: refs/heads/master@{#319101}

A good portion of the current WebContentsObserver instances for any
given tab are Java-based. Each of these require separate JNI hops, as
well as repeated string conversions, for each observer callback. Avoid
such costs by having just one Java-based WebContentsObserverProxy that
bridges from native and allows multiple Java-based WebContentsObserver
subscribers.

BUG=440134

Review URL: https://codereview.chromium.org/786933005

Cr-Commit-Position: refs/heads/master@{#319100}

Fixes crash found when toggling the state.

BUG=463062

Review URL: https://codereview.chromium.org/969033004

Cr-Commit-Position: refs/heads/master@{#319099}

R=mbarbella@chromium.org
BUG=

Review URL: https://codereview.chromium.org/978523004

Cr-Commit-Position: refs/heads/master@{#319098}

Removing GSM.setupSessionSyncId() part 3/4. Generate the sync
sessions ID in SyncController and cleanup ChromeShellActivity.

BUG=428882

Review URL: https://codereview.chromium.org/951773003

Cr-Commit-Position: refs/heads/master@{#319097}

Enhanced Bookmark feature may need to be turned on by some java
instrumental tests. Therefore the flag should be added to the java
command line class.

BUG=458632

Review URL: https://codereview.chromium.org/973283002

Cr-Commit-Position: refs/heads/master@{#319096}

BUG=463769
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/976983003

Cr-Commit-Position: refs/heads/master@{#319095}

Previously, the update_rect() of the LayerImpl was used for the repaint
regions in the DebugRectHistory; now the base LayerImpl class defines a
virtual method giving back an invalidation Region that is overwritten by
PictureLayerImpl to use the already existent invalidations_ Region.
Regions give a more tighter bound on the invalidations than the
single conservative rect that was used before on a per-layer basis.

BUG=424682

Review URL: https://codereview.chromium.org/958843004

Cr-Commit-Position: refs/heads/master@{#319094}

New APIs can be more strict about enforcing not being called after
destroy.

BUG=457184

Review URL: https://codereview.chromium.org/974143002

Cr-Commit-Position: refs/heads/master@{#319093}

GYP wasn't generating correct list of dependencies when base.gypi was
included after untrusted.gypi. As result libbase_nacl.a wasn't always
rebuilt when the sources it depends on were changed.

BUG=461422

Review URL: https://codereview.chromium.org/976863002

Cr-Commit-Position: refs/heads/master@{#319092}

Previously owned by GSM downstream. Note that there will be
two SigninNotificationControllers in existence between this
landing and the downstream patch landing, but the only call
its listener makes (cancelNotification) appears to be
idempotent so it shouldn't matter.

BUG=428882

Review URL: https://codereview.chromium.org/952083002

Cr-Commit-Position: refs/heads/master@{#319091}

TBR=dpranke

Review URL: https://codereview.chromium.org/977943003

Cr-Commit-Position: refs/heads/master@{#319090}

Push messaging is a client of gcm and not a part of it. To improve layering it
should live in a seperate directory. This CL moves files matching
chrome/browser/services/gcm/push_messaging_* into chrome/browser/push_messaging/,
move the classes out of the gcm namespace. It also restrains GCMProfileService
to be the owner of PushMessagingServiceImpl. Instead it became a KeyedService.
By making it such it became easy to clean up the dependencies and ownership concerns
between push messaging and gcm.

BUG=402486

Review URL: https://codereview.chromium.org/955673004

Cr-Commit-Position: refs/heads/master@{#319089}

Build failed due to uninitialied values.
../../chrome/browser/media/protected_media_identifier_permission_context.cc:187:8: error: 'persist' may be used uninitialized in this function [-Werror=maybe-uninitialized]
../../chrome/browser/media/protected_media_identifier_permission_context.cc:205:32: error: 'content_setting' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Review URL: https://codereview.chromium.org/974223002

Cr-Commit-Position: refs/heads/master@{#319088}

TBR= bradnelson@chromium.org
BUG= none

Review URL: https://codereview.chromium.org/976053003

Cr-Commit-Position: refs/heads/master@{#319087}

BUG=397951

Review URL: https://codereview.chromium.org/971733003

Cr-Commit-Position: refs/heads/master@{#319086}

This script takes advantage of the fact that Mojo binaries are published in the
cloud to add functionality for viewing a URL in HTMLViewer embedded in the
kiosk window manager.

Review URL: https://codereview.chromium.org/982523004

Cr-Commit-Position: refs/heads/master@{#319085}

Depends on https://codereview.chromium.org/901493003/

BUG=448011

Review URL: https://codereview.chromium.org/878743007

Cr-Commit-Position: refs/heads/master@{#319084}

Test is racy by design, and testing this properly is not
worth the effort required to add the proper hooks into
initialization.

BUG=

Review URL: https://codereview.chromium.org/971103003

Cr-Commit-Position: refs/heads/master@{#319083}

Double-revert seems to have deleted the fixes:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/9ufqvcvv_DU

R=lcwu@chromium.org,servolk@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/979913002

Cr-Commit-Position: refs/heads/master@{#319082}

Make the chrome://extensions page use chrome.developerPrivate API to
select a file path and load an unpacked extension.
Also add tests for the api function, and convert it to a
UIThreadExtensionFunction.

BUG=461039

Review URL: https://codereview.chromium.org/979453002

Cr-Commit-Position: refs/heads/master@{#319081}

Reland of https://codereview.chromium.org/961323004
TBR=dpranke

Review URL: https://codereview.chromium.org/969173002

Cr-Commit-Position: refs/heads/master@{#319080}

R=lcwu@chromium.org,halliwell@chromium.org
BUG=internal b/19559717

Review URL: https://codereview.chromium.org/977443002

Cr-Commit-Position: refs/heads/master@{#319079}

R=lcwu@chromium.org,servolk@chromium.org,tsepez@chromium.org
BUG=

Review URL: https://codereview.chromium.org/971913002

Cr-Commit-Position: refs/heads/master@{#319078}

FakeSigninManager::SignOut was never updated to clear the account id on
SignOut. This result in calls to FakeSigninManager::IsAuthenticated
returning true after even after a SignOut.

BUG=

Review URL: https://codereview.chromium.org/980583003

Cr-Commit-Position: refs/heads/master@{#319077}

BUG=463458
TEST=crashes go away

Review URL: https://codereview.chromium.org/976903003

Cr-Commit-Position: refs/heads/master@{#319076}

The test method to find the generated protobuf python files needed to be updated. Also I copied a bunch of test files to the product dir.

    DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.ApiAuthCodeFetch/1
    DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.AutoEnrollment/1
    DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.PolicyFetch/1
    DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.Registration/1
    DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.Unregistration/1
    ComponentCloudPolicyTest.FetchExtensionPolicy
    ComponentCloudPolicyTest.InstallNewExtension
    ComponentCloudPolicyTest.SignOutAndBackIn
    ComponentCloudPolicyTest.UpdateExtensionPolicy
    CloudPolicyTest.FetchoPlicy
    CloudPolicyTest.InvalidatePolicy

BUG=463180

Review URL: https://codereview.chromium.org/979643002

Cr-Commit-Position: refs/heads/master@{#319075}

BUG=460949
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/970903005

Cr-Commit-Position: refs/heads/master@{#319074}

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/icu/+log/db16fd8..eda9e75

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/977043004

Cr-Commit-Position: refs/heads/master@{#319073}

BUG=460949
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/977593007

Cr-Commit-Position: refs/heads/master@{#319072}

Delegate to the embedder the decision to filter URLs to add to the history
through the HistoryClient defaulting to registering all URLs (in the base
class implementation but also when there is no HistoryClient during tests).

BUG=390953
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/971423002

Cr-Commit-Position: refs/heads/master@{#319071}

This CL is a companion to https://codereview.chromium.org/945423002, and will
allow a server app to serve apps that were uploaded to the Mojo bucket in GS
from Chromium without having to know anything about these apps in particular.

Review URL: https://codereview.chromium.org/956593003

Cr-Commit-Position: refs/heads/master@{#319070}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/20c53c8..96cd5bb

TBR=samli@chromium.org

Review URL: https://codereview.chromium.org/969913003

Cr-Commit-Position: refs/heads/master@{#319069}

onFailure is only invoked when the render frame has
been destroyed, but it is not really useful to
distinguish onComplete from onFailure in that case.
This also addresses the feedback that we received
from API Council.

This is a resubmit of CL 943633003

BUG=459539, 457184

Review URL: https://codereview.chromium.org/974483002

Cr-Commit-Position: refs/heads/master@{#319068}

- Introduce WebUIInjectionHost class and plumb InjectionHost interface
  to replace Extension in script injection system in the render.
- Store InjectionHost in ScriptInjection to avoid constructing InjectionHost
  objects everywhere.

BUG=459234

Review URL: https://codereview.chromium.org/934763003

Cr-Commit-Position: refs/heads/master@{#319067}

This CL adds default values to config parameters for running the Python tests of password manager.

It also corrects a typo (parrallel -> parallel).

R=engedy@chromium.org
BUG=463504

Review URL: https://codereview.chromium.org/977043003

Cr-Commit-Position: refs/heads/master@{#319066}

BUG=460949
R=primiano@chromium.org

Review URL: https://codereview.chromium.org/964873005

Cr-Commit-Position: refs/heads/master@{#319065}