GitLab

Add a thicker highlight around the thumbnail when it corresponds to the
active PDF page.

Draw an even thicker highlight around the thumbnail when it corresponds
to the active PDF page and it is focused.

Also, do not draw focus outline on thumbnails that are clicked.

Bug: 652400
Change-Id: I30a790ad400a705d766099fb322b297913f48f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434734
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812221}

Variable in assertion should be |length_result|, not |result|

Change-Id: I5c5060bb787aa7cc33a739bc856dec41c78bf790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438487Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812220}

The goal of this histogram isn't to measure which version the server is
expecting, but rather to upper bound how many differences (success OR failure)
there _could_ be if we changed to a locale-insensitive uppercasing approach.

Bug: 1051924
Change-Id: I8ed7471a6270b95e3cd1a4d8c808d23339321a02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438258Reviewed-by: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812219}

TBR=jianli@chromium.org
NOTRY=true

Bug: 1124981
Change-Id: I4d0bc93d601f69aeb0af506f67f86e274ba5734a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441277Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812218}

This reverts commit 04baf73b.

Reason for revert: outage is over

Original change's description:
> Disable clang tidy and metrics analyzer in tricium
>
> These machines are using the main linux pool, which is overloaded.
> See bug for more details.
>
> No-Presubmit: true
> Bug: 1133410
> Change-Id: I4b29e1d343c1dcbf46d185251db931199f06b322
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438852
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811805}

TBR=qyearsley@chromium.org,tandrii@google.com,estaab@chromium.org,martiniss@chromium.org

Change-Id: Ifed16288732733512d31f09d33d577aa4899ba41
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1133410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441119Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812217}

This reverts commit 7d7eb2cd.

Reason for revert: outage is over

Original change's description:
> Disable CQ experiments
>
> We're having issues with high pending times on the linux CQ pool.
> Disabling this for now, since experiments are optional and are
> currently using up capacity.
>
> No-Presubmit: true
> Bug: 1133410
> Change-Id: I4d34c8a7403249601dfbbdba450b46b97d3ef869
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438672
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Erik Staab <estaab@chromium.org>
> Auto-Submit: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: Erik Staab <estaab@chromium.org>
> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811773}

TBR=estaab@chromium.org,martiniss@chromium.org,gbeaty@chromium.org

Change-Id: Iba64cf556a302342d58dc207072ef8f05b868096
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1133410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441020Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812216}

This change fixes key press event handlers by checking a weak ptr before
invoking them.

Bug: 1133671, 1133688
Change-Id: Id7708653c127a49343edf57de2a6fa4522ca088d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440620Reviewed-by: Christoph Schwering <schwering@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812215}

Bug: 1048812
Change-Id: I7ddf909e0c5179f758230b9bd93734e015a6c45f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436273Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812214}

This toggle will suppress all signin promos when toggled off. If the
user tries to toggle it off when signed-in, it will show the signout
dialogue and start the signout flow.

The toggle sets Signin.Allowed pref to false in order to suppress the
promos and prevents the user from signing in.

Bug: 1097718
Change-Id: I31fcd199c2ad74ee36079bb63ad506673b2dfd4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437379
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812213}

Make thumbnails opaque in their default states. Remove opacity on the
thumbnail of the active page.

Decrease opacity when hovering over thumbnails of inactive pages.
Increase opacity against a white background when hovering over
thumbnails of active pages.

Bug: 652400
Change-Id: I58c39dfdba8bd606ce202c69c6e11e2e21beac82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434886
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812212}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009300800_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/ilg0VTVmMGe2tnW36QoR7xaXNXp9wHu7HMww1knXLeQC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa
Bug: b/138544570,b/138961540,b/154074742,b/162291209
Tbr: media-app@grotations.appspotmail.com
Change-Id: I7be12b629738deebb2712f4502bd4b230b3ca84c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440469Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812211}

This crash has been ongoing for a few years. The stack traces don't
lead to any obvious clues, and neither do the minidumps in Visual
Studio, since the most valuable local variable names have been
optimized away.

This CL adds two CHECKs and breaks apart two lines to try to get a
better clue as to why this crash is happening.

The crash seems to suggest we are using a dangling pointer.

Bug: 1024114
Change-Id: I085056561e776097120aab2ae075c32db49fcab7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439485Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812210}

Fixed: 1112489
Change-Id: I98922d19cf690879e9eb2ac23954a0dd542d5a0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438895
Commit-Queue: Matt Menke <mmenke@chromium.org>
Auto-Submit: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812209}

R=sky
BUG=1066670

Change-Id: Ibe851c24db25f4e7801e98918013914a297f063b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436787
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812208}

The dimensions label for capture mode shows user the dimensions of the
current capture region. Currently it is not styled, nor does it position
itself reactively.

This CL styles the label and also makes it reposition itself depending
on the position of the capture region.

Tests: manual + added tests.
Bug: 1131118
Change-Id: I5bd0283a2d2057ba76ba75f3d76c2856f261d89b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429588
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812207}

continuation.

When browser tabs changed and the bubble is not closed, the bubble's
size need to be re-adjusted in TaskContinuationView and
PhoneConnectedView.

BUG=1106937,1126208

Change-Id: I110b8cd25ce45764b0072f99c6ec32e1bf00444f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438753Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Andre Le <leandre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812206}

TBR=jianli@chromium.org
NOTRY=true

Bug: 1133772
Change-Id: I866e6a6bbdb82dcd6e1e6c7fc4a92943d8d9ecad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441194Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812205}

Bug: 1132703
Change-Id: I603a02f5243c173fa88c2cb21d7f94b672638d87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434551
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812204}

We should call |ITfThreadMgr::SetFocus| to notify input service about
focus change even if the input type has not changed.

This issue is introduced by crrev.com/810350.

Bug: 1133474
Bug: 1124612

Change-Id: I219fb624fb649b870bc081fbdac56373c1102d66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438478Reviewed-by: Siye Liu <siliu@microsoft.com>
Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Commit-Queue: Siye Liu <siliu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#812203}

Generate DIR_METADATA files
and remove metadata from OWNERS files
for //build.

Bug: 1113033
Change-Id: I9cf7592a3247c2a25990768644f7a699f2dac80c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438475Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Norman Rosas <normando@google.com>
Cr-Commit-Position: refs/heads/master@{#812202}

TBR=jianli@chromium.org
NOTRY=true

Bug: 1133770
Change-Id: I02d7060cfb3049e4ac8f9b2ef930456491756ea7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441291Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812201}

After discussion, we will stick to the GURL implementation for
merchant domain.

Therefore add missing logic to in offer data setter and validation
checker regarding merchant domain

Bug: 1112095
Change-Id: I60d021c034e68646720414bb808db3eaa46f6296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434466
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#812200}

WebUsbBlockedForUrls was removed a while ago so we don't need to mention it.

Change-Id: I15e5b9cae7847867e07c8fc81491c464f59e2df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440848Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812199}

Prior to this CL, chrome_pdf::RenderPDFPageToBitmap() always rendered
PDFs for printing. With this new option, let the PDF Thumbnailer render
PDFs for display.

Bug: 903742
Change-Id: I708b83f449239ee147da818eecb419cc33be7b76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430804
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812198}

Add an observer for SingleWebsiteSettings. Implement the callbacks to
record metrics and tell the PageInfoController to update permissions.

Bug: 1077766
Change-Id: I2d4f9d234b66a312372cf68e5d9f9a2cd49af798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431665Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812197}

Bug: 973801
Change-Id: Ia2095b57b5d23f429a33cd99c00d0e90054082b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438480Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812196}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/adefd526720b..d5ad6a50d168

$ git log adefd5267..d5ad6a50d --date=short --no-merges --format='%ad %ae %s'
2020-09-28 fletcherw lorgnette: pass source_name in ScanSettings
2020-09-14 clarkchung system_api,runtime_probe: add pci_subsystem in network fields

Created with:
  roll-dep src/third_party/cros_system_api

Change-Id: Ia268dfcc5c6a08ec950684c732bed0f4ee152681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439964
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812195}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/26525f46199d..5b238b2e5f6e

2020-09-30 janscheffler@chromium.org [WebAuthn] Fix tab order
2020-09-30 aerotwist@chromium.org [ts] Type-check Help with TypeScript Compiler
2020-09-30 janscheffler@chromium.org [WebAuthn] Add continuation dots for length names
2020-09-30 sigurds@chromium.org Make load-through-target configurable
2020-09-30 wolfi@chromium.org Dark theme improvements for issues panel
2020-09-30 aerotwist@chromium.org [ts] Type-check HeapSnapshot.js with TypeScript Compiler
2020-09-30 szuend@chromium.org [ts] Type-check media/PlayerListView.js with TypeScript
2020-09-30 wolfi@chromium.org Correctly handle multiple frames with same URL in frame tree
2020-09-30 szuend@chromium.org [ts] Type-check media/EventTimelineView.js with TypeScript
2020-09-30 jec@google.com Update What's New UI for Chrome 87
2020-09-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1069378,chromium:1122511
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I978e2f7ab69cdb66d3adbdb6634609606f73516b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440466Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812194}

Screenshots:
- Diagnostics App (before) http://shortn/_DpVL35bnh7
- Diagnostics App (after) http://shortn/_xR51HdiefI

Bug:1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*

Change-Id: Ib16a145c3ef03fcf82b8e0ed2e6474671987e3a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436810
Commit-Queue: Michael Checo <michaelcheco@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812193}

Change-Id: Ic9d1afe2f1494c3a9e8c5aa2737e51ea7d029051
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440850
Auto-Submit: Eric Roman <eroman@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812192}

Bug: 1099072
Change-Id: I04279a29202f217a5ed838af9319874a3adb63b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438876
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812191}

This CL adds support for overriding the translate language blocklist and
the URL host blocklist (each behind separate flags) when a link is
clicked that has hrefTranslate set. Each of these flags also supports a
parameter to indicate how much behavior should override these
blocklists: just the behavior of showing the translate UI, or the
automatic translation behavior as well.

Bug: 1131240
Change-Id: I1b4912ed1e369b04f1d326255c1a77763d825c0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425085
Commit-Queue: Scott Little <sclittle@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812190}

When the currentState is Peeked and a transition starts, if the user
switched direction (from Revealed to Hidden and from Hidden to Revealed
again), the layout switcher's collection view would start a new
transition when one already existed:
`'NSInternalInconsistencyException', reason: 'the collection is already
in the middle of an interactive transition'`

Create a bool property |layoutBeingInteractedWith|, which is YES when
the user is scrubbing a layout transition. The layout transition
progress is only updated if this property is YES.

Create a bool property |gesturesEnabled|, which is set to NO when a pan
gesture ends and set to YES when a gesture begins and
|layoutInTransition| is NO. This is to prevent a gesture from being
recognised if it starts while the layout is already transitioning but
changes or ends after the layout transition is over. If that were to
happen, the viewRevealngVerticalPanHandler would fail to notify the
animatees that a view reveal would take place.

Bug: 1130037, 1127604
Change-Id: Ifc5eb40843673ab3ce663ed23a3b2f8cf18d9564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421741Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Roberto Moura <mouraroberto@google.com>
Cr-Commit-Position: refs/heads/master@{#812189}

This fixes a fuzzer-discovered integer overflow. The modified line was
attempting to compute (1 - -2147483648).

Bug: 1133024
Change-Id: I5193e61fe3a144cce760b836d41e6d802eaccd14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437483Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812188}

- Added SandboxType::kMediaFoundationCdm and its corresponding sandbox
  switch of "mf_cdm" for the creation of MF Cdm LPAC Utility process.
- SandboxWin::IsAppContainerEnabledForSandbox() is updated to opt-in
  SandboxType::kMediaFoundationCdm to be created as AppContainer
  process.
- In SandboxWin::StartSandboxedProcess(), the MF Cdm is added with
  policies and LPAC capabilities to allow existing Windows platform
  compoenents to work properly.

More details can be found in this doc:
https://docs.google.com/document/d/19Y4Js5v3BlzA5uSuiVTvcvPNIOwmxcMSFJWtuc1A-w8/edit#heading=h.iqvhsrml3gl9

Bug: 999747
Change-Id: I8e0a0febb20b697c5631cf2561429305bf47b2e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401506
Commit-Queue: Frank Li <frankli@microsoft.com>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: James Forshaw <forshaw@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812187}

Bug: 772945
Change-Id: Id3a3397a84cb630bb8f51b69bc9faad3dab76fe8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438850Reviewed-by: Angela Yoeurng <yoangela@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812186}

Screenshots:
- Diagnostics App (before) http://shortn/_F7krCJQK2W
- Diagnostics App (after) http://shortn/_D86kuHAMy8

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: I36218799b5f7574e54947dd894c92724ccc56c36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438710
Commit-Queue: Michael Checo <michaelcheco@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812185}

The Directory doesn't exist anymore, so this CL updates references [1]
to it across the Sync codebase. For code that's already scheduled for
cleanup, the CL just adds TODOs pointing to the corresponding bugs.


[1] https://source.chromium.org/search?q=f:(components%7Cchrome).*sync%2F%20case:yes%20comment:Directory%20-f:%5Eout

Bug: None
Change-Id: I134fe4abe0a3d8e669686fed71d374da7be6f69c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440869
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812184}

[sheriff] Disable AutofillAssistantChromeTabIntegrationTest#interactingWithLocationBarHidesAutofillAssistant

TBR=jianli@chromium.org
NOTRY=true

Bug: 1131835
Change-Id: I43caed398441d1eb9c39eb69742d6a8dc67ad40b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441312Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812183}

TBR=jianli@chromium.org
NOTRY=true

Bug: 1131836
Change-Id: Ia9cf8cf32287b70b75d42e27c0fff9baece5a7bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441315Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812182}