GitLab

- Add parser/serialization for dictionary type.
- SH dictionary is implemented as a custom class containing a std::vector
- Add test cases from
  https://github.com/httpwg/structured-header-tests/blob/master/dictionary.json
- Follows Draft 15 of Structured Headers for HTTP
- https://tools.ietf.org/id/draft-ietf-httpbis-header-structure-15.html
- Replace OWS with SP when skipping whitespace in headers

Bug: 993790
Change-Id: If9ae207a7c79e3be70fe0f340adbb51fb3383753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033583
Commit-Queue: Rodney Ding <rodneyding@google.com>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746516}

https://swiftshader.googlesource.com/SwiftShader.git/+log/abc7a30a06c7..126720bd2e57

git log abc7a30a06c7..126720bd2e57 --date=short --first-parent --format='%ad %ae %s'
2020-03-03 jrprice@google.com Use LINK_FLAGS for -BSymbolic in CMake build

Created with:
  gclient setdep -r src/third_party/swiftshader@126720bd2e57

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Ibdada5aab49cc795e2c9649128096c17513c6f99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085024Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746515}

This componentizes both Java and C++ implementation of
SecurityStateModel. The dependency on security_state_tab_helper is
resolved by adding a SecurityStateModelDelegate interface.

Bug: 1052375
Change-Id: Ie6754d27c2c8e6edb1e06ab9b43b840131bee7b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072740
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746514}

This modality can be used in tests rather than choosing
an arbitrary modality for the test, reducing the coupling
between overlay functionality and specific implementations
for the web content area or infobars.

This CL adds support for contained and presented overlay
UI to test overlay UI code.  A follow-up CL will add
tests to OverlayPresentationContextImpl that leverages these
classes.

Change-Id: I648f95a6af1fc78c007fb8d96a7c6ca295928bae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068254
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746513}

Bug: 1058073
Change-Id: I97e4c8c135ace3135df3b0cf4880e37c08939460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085159
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746512}

When r728175 <crrev.com/c/1963597> supported traversing
items, it failed to add the size of child inline boxes.

The size of an inline box is different from the union of its
descendants when it has padding.

Bug: 982194
Change-Id: Id2e35cf4136cc0342f509c676f7a678ffcbece80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079775Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746511}

Before Change:
buildExtra and its dependencies live in AndroidPaymentApp.

After Change:
buildExtra and its dependencies live in WebPaymentIntentHelper.

Change:
1. create WebPaymentIntentHelper
2. move AndroidPaymentApp#buildExtra() and its dependencies into
WebPaymentIntentHelper.

Bug: 1057488

Change-Id: I79e873d28a7bcbe119ac2966590d2892ecf76f40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082479
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746510}

This CL short circuit the initialization of |report_only_feature_policy|
in SecurityContext to avoid unnecessary memory allocation.

Change-Id: Ieb7816600da97997203487dbbaf84034882aac61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081189
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746509}

This CL logs Rappor samples that hopefully will aid in proactively
identifying extensions that might be impacted by the changes behind
the CorbAllowlistAlsoAppliesToOorCors feature.

Bug: 920638
Change-Id: I40dec28c99673b8096170e1f1fce92c417ca0c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076425Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746508}

The DCHECK() verified that we only bound the UserActionRecorder once
during the lifetime of the OsSettingsUi class. However, I had not
realized that refreshing the settings page reuses the same underlying
OsSettingsUi object, so the BindInterface() function is actually
expected to be called once per load of the page (regardless of initial
load or refresh).

Fixed: 1055001
Change-Id: I4d22ec27a5279483d795de18c4f591f83984bf2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085532
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746507}

Retrieving an ExecutionContext from the LocalFrame passed from
NavigatorClipboard ensures that the correct ExecutionContext for the current
clipboard operation is always used.

In cross-frame circumstances, ScriptState's ExecutionContext would be that
of the parent frame, but LocalFrame's ExecutionContext would be that of the
child frame.

This was mentioned in [1], and initially introduced in [2].

This should ensure that the incorrect (parent frame's) PermissionManager isn't
requested when determining whether a permission has been granted, or when
asking for permission.

This CL does not fix the potential for a null dereference if the
ExecutionContext is detached, as both the ExecutionContext::From and
GetExecutionContext will result in a null dereference in this case.

[1]: https://crrev.com/c/2016200/19/third_party/blink/renderer/modules/clipboard/clipboard_promise.cc#91
[2]: https://crrev.com/c/804973

Bug: 1002794
Change-Id: I340224959fb98d3112464f4955c6d88e537f6199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057006
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746506}

Renamed to avoid all the fun-and-games of overload resolution with template functions.

Part of the overall effort to eliminate the need for and eventual removal of set_owned_by_client().

Bug: 1044687
Change-Id: I4f728af6e17b3c6c804db7eda58f0fb6d426d5f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068878
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746505}

This will simplify the QUIC merge rotation.

Change-Id: I3517f7c2e896d5b44625647fade04484e89a286b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084053
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746504}

Using wpt-import in Chromium 6559a5a6.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=smcgruer

No-Export: true
Change-Id: Ic3c6f9dfef42818b62e8ff711c5f46cfbfe7d736
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085231Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746503}

The general plan here is to make ExtensionAppShimHandler not know
about extensions, but be able to interact with either apps or
extensions via its ExtensionAppShimHandler::Delegate interface.

To this end, start changing the interface to take app ids instead of
extensions::Extensions. Most of this is mechanical, but a few
aren't quite:
* The Delegate::GetWindows method can't return an extensions type
  anymore, so inline its usage into new ShowAppWindows and
  CloseAppWindows methods (which, internally, will be able to).
* Remove RequestUserAttentionForWindow, and have the caller (which
  is extensions-based app code) make the appropriate calls.

Update tests to behave reasonably.

Bug: 1057195
Change-Id: Ife8f37b608a9a601eafd38da44c2ad50b99f41c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080487Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746502}

The previous implementation of DirectoryKey used a const string making
it largely incompatible with <algorithm> which I intend to make use of
in a few places. To fix this it should be made into a class that can
be copied and swapped, but with only a constant accessor.

Bug: 1058093
Change-Id: Ib3aff42e248910bd78b9a00c98777fd670999d37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084724Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746501}

Picks some low-hanging fruit that the compiler is not able
to optimize away: reduces repetition of local context object
construction in message decoding logic, and eliminates some
unnecessary inlined move operations.

Bug: 1058101
Change-Id: Ibedb0eb2c506b3a70c5c60d848633e420845f5cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083738
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746500}

A gclient hook would populate the contents of this dir. You could then
re-use these files in any arbitrary normal GN build flow. (No Simple
Chrome shell needed.)

Bug: 937821
Change-Id: I30a78d491088351756017a77fe160de39296b7d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052205Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746499}

Change-Id: Ie90cf1411b722da6d9c387480bcb38b2e7b44630
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083845
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746498}

The focus type is used to determine which streams volume limits are
applied to. For backwards compatibility, if the focus type is not
specified, it defaults to the content type.

Bug: internal b/150225634
Change-Id: Ib9b9c985176786bd759ba5629000b057be3abb6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080583Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746497}

https://android.googlesource.com/platform/external/perfetto.git/+log/8ff2fc8fcdb1..b9b24d1b0b80

git log 8ff2fc8fcdb1..b9b24d1b0b80 --date=short --first-parent --format='%ad %ae %s'
2020-03-03 skyostil@google.com TrackEvent: Avoid leaking legacy symbols to the global namespace

Created with:
  gclient setdep -r src/third_party/perfetto@b9b24d1b0b80

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:148779455
Tbr: perfetto-bugs@google.com
Change-Id: I1d554d91d08c0578530cbc407654e46af7687f34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085027Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746496}

This ensures the encoder is created before passing the captured frame
to the scheduler. This is to allow the scheduler (in future CLs) to
examine properties of the encoder before sending the frame to be
encoded. Such properties could include:
* Preferred quantizer values for normal and big frames.
* Whether big-frame-detection is handled by the encoder.

Bug: 891571
Change-Id: I28c32a1944913ca6dec240ab483b9a65d38f9576
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085120
Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746495}

It is possible to modify the data field without replacing it, so syncing
always where both a delegate frame and JS buffer exist.
Drive-by: handle cases with no delegate in other methods.

Bug: 1052765
Change-Id: I4cc1383b584d9d9f4334e0da1b6d7c092f94821d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084855Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746494}

This CL moves chromeOS strings for settings Smart Lock page strings
from settings_strings.grdp to os_settings_strings.grdp. It continues
the process of moving all chromeOS specific strings.

Bug: 967883
Change-Id: Ie18ee072f0684409aa888053054aed49e81fb64f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067637
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746493}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8a16ac6d467..0c3c538efb60


Created with:
  gclient setdep -r src-internal@0c3c538efb60

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1057652
Tbr: jbudorick@google.com
Change-Id: Iefab62969ea7bbdfc269515319865a7f604fe90a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083747Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746492}

QuotaManagerProxy post tasks to call itself on the right thread, but needs
to return after posting the task and before calling anything on QuotaManager.

Bug: 997258
Change-Id: Ia6914224006e128758b62c1aed96d3d3636e9790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084716Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746491}

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/63b8190db884..558f922788cc

$ git log 63b8190db..558f92278 --date=short --no-merges --format='%ad %ae %s'
2020-03-03 ebrahim [fuzz] Avoid empty memcpy and ubsan complain by length checking before memcpy
2020-03-03 ebrahim [fuzz] Remove the not yet fixed timeout, going to investigate
2020-03-03 ebrahim [fuzz] Add more of supposed to already be fixed cases from Chromium bug tracker
2020-03-03 ebrahim minor, debug bit, ops
2020-03-03 ebrahim [fuzz] Add another fixed case
2020-03-02 ebrahim Limit OT::Lookup subtables (#2219)
2020-03-02 ebrahim [fuzz] Add cases that marked as wontfix
2020-02-29 ebrahim [var] Build end-points array on gvar itself
2020-02-29 ebrahim [draw] minor
2020-02-29 ebrahim [draw] Fix invalid rendering of some glyph on Estedad-VF
2020-02-29 ebrahim [fuzz/draw] Call _get_glyph_extents
2020-02-29 ariza collect_unicodes() with clamp, calling add_range()
2020-02-28 grieger [subset] Limit the number of feature indices processed during script subsetting.
2020-02-28 grieger [subset] Limit the number of features processed in the feature closure.
2020-02-28 grieger [subset] Add fuzzer timeout testcase.
2020-02-27 grieger Limit the number of feature indices processed during feature collection.
2020-02-28 ebrahim [gvar] Add other possibly fixed fuzzer case
2020-02-28 ebrahim [glyf] Don't accept gids higher than maxp's glyphs number
2020-02-28 ebrahim [subset] Add source_blob as a hb_subset_context_t field (#2203)
2020-02-28 ebrahim Revert "collect_unicodes() to check gid < num_glyphs with cmap 12"
2020-02-28 ebrahim [gvar] Use hb_bytes_t.check_range instead having in house one
2020-02-28 ariza collect_unicodes() to check gid < num_glyphs with cmap 12
2020-02-28 ebrahim [draw] Add fuzzer runner
2020-02-14 qxliu [subset] GDEF LigCaretList subsetting support
2020-02-27 ariza reimplment serialize_int using check_assign()
2020-02-27 ebrahim [gvar] Minor, check whether sub_array result also have enough room
2020-02-27 ebrahim [gvar] Fix invalid memory access by refactoring GlyphVarData fetch logic
2020-02-27 razrfalcon Fix spelling.
2020-02-11 qxliu [subset] GDEF MarkGlyphSets subsetting support
2020-02-10 qxliu [subset] GDEF glyphClassDef subsetting support glyphClassDef uses the same ClassDef format. However, glyphClassDef table uses predefined class values so we do not remap class values.
2020-02-25 grieger Add a reverse () call to hb_array_t.
2020-02-25 grieger Switch to C style comments.
2020-02-10 grieger When serializing cmap14 order the offsets from smallest to largest. Current versions of OTS fail fonts with cmap 14's who's last offset does not point to the a block at the end of the table.
2020-02-26 ariza add oss-fuzz 20886 test file
2020-02-26 ariza fixes oss-fuzz 20886
2020-02-26 ebrahim [cff] minor, remove unused fields
2020-02-26 ebrahim [draw] Pass draw_helper_t itself around instead recreating it
2020-02-26 ebrahim minor
2020-02-26 ebrahim [glyf] Simplify contour end logic
2020-02-26 ebrahim [fuzz] minor don't abort main.cc when the file was empty or not found
2020-02-26 ebrahim [draw] Skip commands and paths not contributing anything
2020-02-26 ebrahim [draw] Port glyf path extract to draw_helper_t
2020-02-26 ebrahim [draw] Move common CFF path building logic to draw_helper_t
2020-02-25 ariza tweak reflecting review & add test cases
2020-02-25 ebrahim [fuzz] Practice variations on font object
2020-02-24 ebrahim [draw] Add a fuzzer
2020-02-25 ariza coding & comment tweaks
2020-02-25 ebrahim [cff] Make sure previous is ended on processing a seac
2020-02-25 ebrahim [cff] Make path extract easier to read and more defensive
2020-02-25 ebrahim [glyf] Refactor, move get_points inside Glyph
(...)
2020-02-20 ebrahim [draw] Add a private bit field instead null-checking quad-to callback
2020-02-19 ebrahim minor
2020-02-19 ebrahim Minor, switch to https links where possible
2020-02-19 ebrahim [tool] Minor, move input files link
2020-02-19 ebrahim [ci] Compatibility with Python 3
2020-02-19 ebrahim Remove python2 support from tests/utils scripts
2020-02-12 ricotz Improve GIR build
2020-02-19 ebrahim [ci] Update Ubuntu bots versions
2020-02-18 qxliu [subset] add one empty byte to glyf table if it's going to end up empty after subsetting This will make OTS happy and match what fontTools is doing now.
2020-02-18 ebrahim [glyf] Tweak path_builder_t
2020-02-18 ebrahim [glyf] minor
2020-02-18 ebrahim [glyf] minor, use private font coords to simplify
2020-02-18 ebrahim [glyf] Move contour_bounds_t into scope it is actually used
2020-02-18 ebrahim [glyf] minor, spacing
2020-02-18 ebrahim [glyf] Make returning phantoms to not require another vector
2020-02-18 ebrahim [glyf] do a phantom only iteration when possible
2020-02-18 ebrahim [glyf/gvar] Remove need of passing end points vector around
2020-02-18 ebrahim [glyf] Push consumer machine one more level further
2020-02-17 ebrahim [glyf] Adopt a state machine like style for the path builder
2020-02-17 ebrahim [glyf] Switch to ttf-parser's glyf to path algorithm
2020-02-17 ariza add test cases for hb_unwrap_type
2020-02-14 ariza renamed to hb_unrwap_type(); now recursive
2020-02-13 ariza add hb_get_type
2020-02-16 ariza pop_pack(share=false) in end_serialize()
2020-02-16 ariza add share option to pop_pack() (#2176)
2020-02-16 ariza rewrite read_points() to take lambda & consts args
2020-02-12 ebrahim [fuzz] minor style fixes
2020-02-12 ebrahim [fuzz] minor fuzzer case move, oops
2020-02-12 ebrahim [fuzz] minor, move two fuzzer cases to their correct place
2020-02-12 behdad [serialize] Catch signedness overflows in check_assign()
2020-02-12 ebrahim [fuzzer] Fix hb-set-fuzzer minor overflow issue
2020-02-11 grieger Add explicit values to the set fuzzer enums.
2020-02-11 grieger Add a few basic seeds for the set fuzzer.
2020-02-11 ebrahim Use multiplication to avoid undefined behaviour per clang
2020-02-11 ebrahim [colr] minor style fix
2020-02-11 ebrahim [subset/colr] minor improve to resolve msvc complain
2020-02-06 grieger Add hb-set-fuzzer. It fuzzes all of the hb_set process methods (intersection, subtraction, union, and symmetric difference).
2020-02-11 ebrahim Fix an unlikely UAF on the deprecated _set_glyph_func API
2020-02-10 ebrahim [tools] Print unicode links on gen-* tools output
2020-02-09 razrfalcon Add links to files used by python scripts.
2020-02-08 ebrahim [var] Fix the just introduced hb_font_set_var_coords_design storing bug
2020-02-08 ebrahim [tool] Optimize COLR glyph dump
2019-08-20 ebrahim Don't use _normalize_variations to avoid twice axis fetch
2019-08-14 ebrahim [var] Implement hb_font_get_var_coords_design
2020-02-07 grieger Use vector instead of map during page compaction in hb-set.
2020-01-28 grieger Fix page_map corruption in hb_set_t during process().
2020-02-05 qxliu [subset] GPOS6 MarkToMark subsetting support
2020-02-04 qxliu [subset] GPOS4 MarkBase subsetting support
2020-02-06 ebrahim Minor, fix warnings raised when built with -std=c++2a
2020-02-02 ebrahim [draw] Add hb_draw_funcs_is_immutable and hb_draw_funcs_make_immutable

Created with:
  roll-dep src/third_party/harfbuzz-ng/src
R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org

Fixed: 943666
Change-Id: Idc4796ee129d092bc6920d62b9588417485cc1ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085312
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746490}

This change adds a check in the WebContentsDelevate is available before trying
to show a prompt. Currently it crashes when trying to use it via the Payment
Handler.

Change-Id: Icfd16c2c408212b3698b6cff97a9c2b3f81f820e
Bug: 1051930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081351
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746489}

This reverts commit b85847a2.

Reason for revert: https://crbug.com/1058118

Original change's description:
> Add Android to SkiaRenderer field trial
> 
> Bug: 1019787
> Change-Id: I3f3121b7da6e46a9558ac0a2058b9ba8239fea84
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078772
> Auto-Submit: Jonathan Backer <backer@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Commit-Queue: Jonathan Backer <backer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#746352}

TBR=backer@chromium.org,rkaplow@chromium.org,holte@chromium.org

Change-Id: I6286d17f4ffee5072dcfad30e702668b5fe5cb0a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1019787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085551Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746488}

Hides marketing opt-in toggles from marketing opt-in screen - seems
weird, but the screen is also used as the final screen in the flow, with
pieces to force shelf navigation buttons in tablet mode.
Marketing opt in toggle implementation is slipping to M-83, so hide the
toggle by default (a follow-up will update the screen UI to address the
white space where the opt-in toggle should be).

Adds browser tests for the screen.

BUG=976949

Change-Id: If4c9db85be2607f99be15c9aef27f7b67fc41367
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083952
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746487}

Bug: none
Change-Id: I0dda0908227f65cda8a35931e83fd94a308c6f91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083563
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746486}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f57a5e85c09d..683c198380db

git log f57a5e85c09d..683c198380db --date=short --first-parent --format='%ad %ae %s'
2020-03-03 joselea@microsoft.com Typecheck SegmentedRange.js
2020-03-03 vidorteg@microsoft.com Locking lighthouse terms.
2020-03-03 joselea@microsoft.com Typecheck ParsedURL.js
2020-03-03 jacktfranklin@chromium.org Remove `Number.gcd`

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@683c198380db

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1011811,chromium:1050549
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I8e4cf098ca848a41c25b9587195ffd4fdd2d8891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085026Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746485}

As discussed in http://crrev.com/c/2066753:

"PreferredColorScheme has been removed in crrev.com/c/1845575 in favor
of setting color scheme via NativeTheme. This causes regression for
dark mode support in WebView by the following two reasons:

1. When WebView is run in multiprocess mode it means it has both
browser and renderer processes. Changes to NativeTheme that happens in
aw_settings (browser side) are not seen by NativeTheme in style_engine
(renderer side).

2. Different WebViews may use different darkening strategies. Using a
singleton to store preferredColorScheme means that we can't
differentiate them.

While the first problem can be solved by notifying theme_helper which
observes changes in browser side NativeTheme and passes them to
renderer, the second requires that preferredColorScheme is not
controlled by singleton.

This CL also adds tests to prevent such regression in the future."

This change builds on top of the CL above to revert more of
crrev.com/c/1845575 and http://crrev.com/c/1728056. The result is that
PreferredColorScheme is now updated through WebPreferences/WebSettings
and is only sent to the render process in one way.

Bug: 970285
Change-Id: Ia2ba874c23e2ab47a27ec53b52dcbee1ac5aeee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079192
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746484}

https://skia.googlesource.com/skia.git/+log/94b928cd7d3d..964aa91580b6

git log 94b928cd7d3d..964aa91580b6 --date=short --first-parent --format='%ad %ae %s'
2020-03-03 bsalomon@google.com Simplify adding key in SkImage_Lazy::lockTexturProxyView
2020-03-03 bsalomon@google.com Use spin lock in SkIDChangeListener
2020-03-03 bungeman@google.com Check for invalid unicode in fallback.
2020-03-03 jlavrova@google.com Selection in justification: Bugs: skia: 9969
2020-03-03 fmalita@chromium.org [skottie] Add another text grouping test

Created with:
  gclient setdep -r src/third_party/skia@964aa91580b6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1057692
Tbr: herb@google.com
Change-Id: If59bec1a91375da3111679329299fd68e072b734
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085021Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746483}

This change fixes the checks for the WebBluetoothNewPermissionsBackend
feature flag. Previously, it was checking if the BluetoothDelegate* was
not null and if the flag was enabled in the same statement. This is
incorrect because it falls back to using the original permissions system
if the delegate is null, which shouldn't happen if the feature flag is
enabled. With this change, the feature flag is checked first, then the
delegate pointer. If the delegate pointer is null, then the current Web
Bluetooth operation fails.

Design doc:
https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM

Bug: 589228
Change-Id: Ib01e90b49924d7ba4e1dd03c8117eae9e21e795c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081526
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746482}

Add retry logic with exponential backoff to KerberosCredentialsManager
for addition of managed accounts. This will cover the cases when the
first attempts fail because network is not ready yet, for example.
Network instabilities are common on first user login because
OpenNetworkConfigurations often changes network config on ChromeOS.

Bug: 1049331
Change-Id: I74b91cfd6fda3fc923061050a97fcb791761815e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039453
Commit-Queue: Felipe Andrade <fsandrade@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746481}

AppServiceAppIconLoader is used to replace ArcAppIconLoader to load app
icons for all apps.

BUG=1016159

Change-Id: I8889a7931127a83e6da48ab23878a9ba284aa303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084190Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746480}

This is a reland of 4ed2234c

TBR=sdefresne@chromium.org
TBR_REASON=Locally verified change build/config/ios/rules.gni no longer
breaks `gclient sync` when target_os_only = True

Original change's description:
> generate_wrapper targets for iOS' non-EG/EG2 tests, EG, and EG2 tests
>
> The existing iOS recipe utilizes an isolate template, and an
> isolated.gen.json file to fill the template in per test with
> config-variables and path-variables. This isolate template contains
> the command arguments to invoke the iOS test runner.
>
> To support the iOS recipe migration to the Chromium recipe, I use GN to
> generate a script per test target instead of the isolate template. The
> script is pre-baked with arguments to the test runner (run.py). The
> given Swarming task is expected to execute the test by invoking the
> generated script.
>
> Invoking the generated script requires changes to gn_isolate_map.pyl
> for each iOS test target, and thus, these changes are only additive.
>
> * "ios_test_runner_wrapper" template wraps the generate_wrapper target.
>  It bakes iOS specific arguments into the script, such that it can
>  launch run.py with the given args.
> * ios_eg2_test, ios_eg_test, and test templates have
>  been updated to utilize the ios_test_runner_wrapper for iOS targets.
> * mb.py to skip generated_directory check when writing isolates.
>  View crbug/ in comments.
>
> Change-Id: I941d37dfdff0bd1ead1baff70907a197fee3fe64
> Bug: 1055328,912681
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023748
> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745105}

Bug: 1055328, 912681
Change-Id: Ib6449bce4b07c8c50b0a59f58fe65caeaa48425f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083379
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746479}

In https://crrev.com/2fc1cb4db60 I removed a state bit from LTHI called
|did_lock_scrolling_layer|. This bit looked like it was tracking the
same thing as "are we currently in a scroll" for which we already have
other state.

Unfortunately, this was subtly wrong on two counts:

1) |did_lock_scrolling_layer| was only set in the non-animated path;
   animated scrolls always appeared invisible to this bit.
2) This was intentionally distinguishing between "currently scrolling"
   in the sense of "we've received a ScrollBegin" and "actively
   scrolling" in the sense  of "we've received a ScrollBegin as well as
   a ScrollUpdate that's caused some scrolling".

The latter is clear from the CL that added the bit:
https://codereview.chromium.org/676853002/. The use case in mind is
pages that preventDefault all touchmoves but not the touchstart. In that
case, CurrentlyScrollingNode will return a valid node because we receive
a ScrollBegin. However, we don't want to consider the compositor in a
scroll for scheduling purposes as the page is likely handling these
touches on its own.

The effect of this is that IsActivelyScrolling now returns true for
cases like wheel scrolling. This caused a change to scheduler
prioritization and regressed checkerboarding (but improved smoothness).

This CL restores the old behavior by making use of some existing state
and also updates names and comments to make this more clear to future
readers.

Bug: 1052474
Change-Id: Ibadf6053c1cc067ec659f6b84225a78cbda437b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083941Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746478}

Patch #7: On Android, pass currency to the CanMakePaymentEvent when
minimal UI feature is enabled, so the updated WPTs can pass.

Before this patch, the "currency" field of the CanMakePaymentEvent was
set only on desktop.

After this patch, the "currency" field of the CanMakePaymentEvent is set
on both desktop and Android when the minimal UI feature is enabled,
e.g., through chrome://flags/#enable-web-payments-minimal-ui flag, and
the relevant WPT passes on both desktop Android when opened in a full
browser.

Bug: 1005076
Change-Id: I9d24b97730c10bc4e6f4ce38ced89a3c33bb1a14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079686
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746477}