- 03 Apr, 2020 40 commits
-
-
nancy authored
ChromeNewWindowClient::OpenFileManager should open the file app, based on the previous code before the CL:2121518 is landed. This CL fix the issue caused by CL:2121518. TBR=xiyuan@chromium.org BUG=1067447 Change-Id: Icfd83c629760ff0913cf18801540c5374370efb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133991 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#756127}
-
Brandon Wylie authored
Bug: 1066642 Change-Id: Ice49aa71ce66b2c9586d676255c7593eea484525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131220 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#756126}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/daabea6ba6c0..1575b47cd3bd git log daabea6ba6c0..1575b47cd3bd --date=short --first-parent --format='%ad %ae %s' 2020-04-02 thestig@chromium.org Funnel CPDF_NameTree creation through Create(). 2020-04-02 thestig@chromium.org Add CPDF_Dest::Create(). 2020-04-02 thestig@chromium.org Move name tree internal structure creation code into CPDF_NameTree. 2020-04-02 thestig@chromium.org Fix nits in CPDF_NameTree. 2020-04-02 thestig@chromium.org Add CPDF_NameTree::CreateForTesting(). 2020-04-02 thestig@chromium.org Use FX_AllocUninit() in outline_aa::allocate_block(). Created with: gclient setdep -r src/third_party/pdfium@1575b47cd3bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ideda12527f45085493446d5dd9ab4775069a1ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135135Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756125}
-
dpapad authored
These changes have been mostly generated with a local script, followed by some manual editing. Execute the following target locally ninja -C out/gchromeos/ chrome/browser/resources/settings/chromeos:polymer3_elements or just the following with optimize_webui=false (for now) ninja -C out/gchromeos/ chrome Problematic *_module targets that are causing build errors to be thrown from polymer.py have been commented out and a TODO has been added for each of them. For example - wherever cr.define() calls exist, they need to include the contents of the entire file - A single <script> tag is expected in an HTML file Bug: 1045266 Change-Id: I6a9c98fe55d6d270e36d620b1aef1fef2fe8b8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133048 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756124}
-
Meredith Lane authored
TBR=rsorokin Bug: 1067461 Change-Id: I33b0cdd8823610da319870bfa1c8167fb0c847d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133992Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#756123}
-
Orin Jaworski authored
This CL starts preparing popup handlers for changes to either line index or line state, instead of only considering line and assuming the NORMAL state. The interface is changed, but not behavior. Bug: 1046523 Change-Id: I1cdf5e288b6be2c488795be2bfba0b276327326e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132769Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#756122}
-
chrome://media-appDavid authored
Bug: b/138961540, 996088 Change-Id: I514e5d4834beeaaf0eeb0062e53cbbbf4950cdad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132020 Auto-Submit: David Lei <dlei@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#756121}
-
S. Ganesh authored
* This is a skeletal implementation of the legacy Omaha3 interfaces as expected by Chrome's on-demand client. * All the methods that Chrome calls return S_OK, and unused methods return E_NOTIMPL. * When Chrome calls on-demand, we return "noupdate" for now. Bug: 1067348 Change-Id: I860492c5674a3f20ef74e432d344b065a9056aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134690Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#756120}
-
Carlos Knippschild authored
TBR=harringtond@chromium.org Bug: 923212 Change-Id: I76d739ab9b8d86881a7c51e13cde4b2659e03f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134505Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#756119}
-
Stephen Roe authored
The Fuchsia system logs contain more detailed information than the Fuchsia kernel logs. Currently only Fuchsia kernel logs are collected. The kernel logs are: - written to the swarming task output log along with the actual test output - optionally written to a "system_log" file in the test isolate output This CL will: - optionally write the Fuchsia system log to a "log_listener_log" in the test isolate output The Fuchsia system log will be written if the kernel log is written. The Fuchsia system log is written to "log_listener_log". The name "log_listener_log" was used because the Fuchsia kernel log contents are already saved in "system_log". Bug: 1042512 Change-Id: I900b5dfe9f6587f1901c19612060b979fae4da99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130679Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#756118}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a053f340a44c..dd29370cdd41 git log a053f340a44c..dd29370cdd41 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 geofflang@chromium.org Include the fragment output locations in the program cache key. Created with: gclient setdep -r src/third_party/angle@dd29370cdd41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ib9834c77c3d529a39e224e5b74ecf89afc06ca6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134490Reviewed-by:
-
Clark DuVall authored
permissions::PermissionManager::PermissionTypeToContentSetting DCHECKs when called on PROTECTED_MEDIA_IDENTIFIER on desktop, since it is Android/ChromeOS only. Change-Id: Ie9e69ed5edda49fee03e44980acaf864d9776d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134502 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#756116}
-
Hazem Ashmawy authored
Refactor the PersistentErrorView class into a Text message with an always yellow background and black text with an optional button for a quick action. Use round alert error icon currently in drawable resources instead of the framework triangle white icon, to match the black text color. Refactor WebViewPackageError to show a more informative message with a quick action to: - Change WebView Provider if it's possible. - If WebView provider cannot be changed, then offer to open DevTools from the current provider if it has a valid DevTools implementation. Clicking the message body will still open a dialog to offer a more detailed message and both options to open current WebView provider DevTools if possible or change WebView if possible. Stop showing the different package error dialog at the start of the UI. This will also fix the presubmit warning because of using setTextColor. Fixed: 1059475,1061164,1052192,1062406 Change-Id: I67176896580143e5e962991a36faf0576e156090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098689 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#756115}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c05b610125a0..f99302c4efe6 git log c05b610125a0..f99302c4efe6 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 capn@google.com Remove the D3D9 and D3D8 source code 2020-04-02 capn@google.com Remove the custom Visual Studio solution and projects Created with: gclient setdep -r src/third_party/swiftshader@f99302c4efe6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id0578e3a99b98eb8f49529c4672e5fb873308e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134493Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I6bafcca7bf55d779a4eec5271aa06cb8f34f80ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135150Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756113}
-
David Van Cleve authored
Previously, HasTrustTokensAnswerer enforced preconditions on the url::Origin passed to its constructor by making the constructor private and exposing a static factory method with the potential for failure. We can now enforce this in a cleaner way with the type-safety provided by SuitableTrustTokenOrigin, which allows removing some tests and deduplicating the precondition-checking logic. R=csharrison Bug: 1061116 Change-Id: Ief3776d605d7e64ea70c1fe738cf9725205489a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132598 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#756112}
-
Richard He authored
Dummy FeedNewTabPage constructor parameters are not changed accordingly. Change-Id: I36a5fa1052b4805768c6c69998f0becec90fe572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131802Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Richard He <linyhe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#756111}
-
Wei Li authored
These image colors are either used as placeholder background colors or error colors. We can safely replace them with kPlaceholderColor. BUG=1059867 Change-Id: Ie4485eb333dae5d52a238eeeb8e9cf6c6391553c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134625Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#756110}
-
James Cook authored
Add a row for "Settings sync" per go/cros-sync-mock. Implement this by forking the existing HTML because I anticipate other tweaks to the structure, layout, etc. Screenshot: https://screenshot.googleplex.com/jBQkUEZoT1O Note that there are now 3 versions of this dialog: * Current * SplitSettingsSync v1 * SplitSyncConsent (aka SplitSettingsSync v2) Bug: 1067212 Change-Id: I64861026cf66d59800511dc559669743410707a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134198 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756109}
-
Xianzhu Wang authored
When PaintLayerScrollableArea::NeedsScrollbarReconstruction() is true (in case that scrollbar theme is changed by DevTools device emulator, etc.) in UpdateAfterLayout(), we should ensure scrollbar reconstruction regardless of DelayScrollOffsetClampScope (which prevents scrollbar destruction in SetHas*Scrollbar(false)). Call scrollbar_manager_.DestroyDetachedScrollbars() to execute the delayed scrollbar destruction immediately. Bug: 1062597 Change-Id: Ia0524c3e836a03fdb707dee3004850772f4faa6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134945Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756108}
-
Livvie Lin authored
Use the same OWNERS as ios/chrome/browser/ui/util, since that's where the code in this directory came from. Change-Id: I817e7d77df70efcc2ae9e2cc92b05a091736a2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133163Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756107}
-
David Grogan authored
These tests used script-after-body but also an external stylesheet. script-after-body can be run before the stylesheet has loaded. The script-after-body stuff is now in an onload handler. Bug: 1063749 Change-Id: Id725c51ef2375ba9584cfacfa81e328b2b586ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133271Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756106}
-
Noel Gordon authored
If the pointer is down anywhere in the app, hovering over the tree Tab items shows their :hover and cursor effects even though these Tabs are not interactive: disable these effects so the Tabs look inert. So what about Pressed state for a Tab? No spec for this: reuse the Tab Hover state color for Pressed state for now (--google-grey-100). No-try: true Bug: 992819, 1062902 Change-Id: I571b252dbe4ddc3050284af505ae3432ad5521d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134088Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#756105}
-
Chong Gu authored
Bug: 1067357 Change-Id: I398ce1632636fb3f81e64c1e3c28fa997f5c5528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134582 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#756104}
-
Yuly Novikov authored
These would be used for Chromium on top of SwANGLE testing, like WebGL. Linux64, Mac64, Win32 Not running any tests at this point, to be added in a follow up CL. Also renames the GCE pools used for non-Chromium SwANGLE trybots. Bug: 1064477 Change-Id: I11172672a1b41bc567c84778554ecd3eaf353190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135132Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#756103}
-
danakj authored
Rename the target to web_test_common_mojom target and make it a public dependency of web_test_common, in order to treat them as one big build target. The power_monitor_test mojom is for browsertests so separate it into content_browsertests_mojom, and depend on it from content shell (which makes the impl) and from content_browsertests (which calls it). TBR=thakis Bug: 866140 Change-Id: Ibb40798e1afa94a3f8e983f921f9a5ce64d5882b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134622Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#756102}
-
Jeff Yoon authored
- try bot and builder migrated to Chromium via *.star files. ios-simulator-full-config trybot in trunk - mb_config ios_simulator_debug_static_bot for try and builder - tests all set to test_suites.pyl Bug: 1055164,912681 Change-Id: I1e5f9b3a0fbccb2c88f2fad26f1559ab3cc418f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119612 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#756101}
-
Peter Kasting authored
Move calls to the files that best match the directories the factories live in. In most cases this has little practical effect; see per-file comments for the exceptions. Bug: none Change-Id: If634e455c68f80361536243382ea9362d84181a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134926 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Kelvin Jiang authored
This CL adds functions for UrlPatternIndex which return all matching UrlRules. These functions will be used to evaluate modifyHeaders rules for the declarativeNetRequest API. Bug: 1064497 Change-Id: Iab0260892a2d7ad4ab5180b84320dfa2675cbf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116563 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#756099}
-
Xiaocheng Hu authored
This reverts commit 0e19fa7c. Reason for revert: should go through the normal review process Original change's description: > Reland "Record split UMA histograms when rendering has been delayed for font preloading" > > This reverts commit 950810de. > > Reason for revert: Loading behavior fixed > > Original change's description: > > Revert "Record split UMA histograms when rendering has been delayed for font preloading" > > > > This reverts commit 4a7fe529. > > > > Reason for revert: The loading behavior is designed wrong. > > > > The objective of these split histograms is to study, when there's font preloading, how effective delaying rendering is. > > > > Currently: the behavior is observed when rendering is delayed by font preloading. > > > > What's actually needed: the behavior is observed when font preloading occurs > > > > Original change's description: > > > Record split UMA histograms when rendering has been delayed for font preloading > > > > > > This patch adds split histograms of the following metrics when > > > rendering delay for web font preloading has been triggered: > > > - PaintTiming.NavigationToFirstPaint > > > - PaintTiming.NavigationToFirstContentfulPaint > > > - PaintTiming.NavigationToLargestContentfulPaint > > > - LayoutInstability.CumulativeShiftScore > > > > > > This will help us understand the effectiveness of this optimization, and > > > adjust the length of the delay to the best value. > > > > > > Bug: 1040632 > > > Change-Id: I6f8aa151c576c9d8d583647a3a7ef6fcb8fb833d > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109251 > > > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > > > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > > Reviewed-by: Bryan McQuade <bmcquade@chromium.org> > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#754771} > > > > TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org > > > > Change-Id: I7829822fea47183df9d4ed27c0eec2a1f888aa0b > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1040632 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131010 > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#755081} > > TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org > > Change-Id: Ibae7230089fe9e56e91cf1480d19c7bc70778567 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1040632 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131011 > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755108} TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1040632 Change-Id: I80ae98e1f0ec97a11f35bb2c55ad9d591f1b07b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135047 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#756098}
-
Peter Kasting authored
* Put calls to other "ensure factories built" metafunctions before calls to build specific factories. * Name all the metafunctions EnsureBrowserContextKeyedServiceFactoriesBuilt(). * Alphabetize. * Remove unnecessary blank lines. * Remove no-longer-applicable comments. Bug: none Change-Id: Ibc17ccc32d16b0cd8692cbea719ded3c9de9d662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134621 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Scott Violet authored
IsOfficialBuild() appears unused. BUG=none TEST=none Change-Id: I4a2552d143015bb22f112bcbde2faa9e2d243280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132666 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#756096}
-
Karandeep Bhatia authored
This CL: - Allows extensions to specify no static Rulesets as part of the "rule_resources" manifest key or optionally to omit the "declarative_net_request" manifest key. Since we support dynamic rules, we should allow this. Also, we plan to implement the ability to toggle the set of enabled static rulesets, under which a state with no enabled static rulesets should be allowed. - Since we now allow extensions to not specify any static rulesets, don't fail if an extension calls updateDynamicRules or getDynamicRules if the extension doesn't have any registered rulesets. - Also, move the book-keeping for the set of extensions with active rulesets to RulesetManager from RulesMonitorService. RulesetManager already maintains the set of active rulesets, so it should be the source of truth for this info. BUG=754526, 953894, 931967 Change-Id: I3d9c6eae5f4d0691b8272ffa4e81c6791f273c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125691Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#756095}
-
John Budorick authored
Bug: 965140 Change-Id: Icdac9b49d15dc489aec21e0f2a99f4184621245f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627560 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#756094}
-
Sophie Chang authored
This also re-enables the browser tests since the flakes were mostly tied to the UMA histogram reporting. Bug: 1060966,1060397 Change-Id: I67a1dfafa5d220e3a2165981e4bd4a6812174aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134645 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#756093}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL some os and browser routes had the same name. This was a bit confusing. If some c++ code called the route '/languages', it is not clear if this url is a chrome or browser subpage. A distinction needed to be made. This CL renames OS specific route LANGUAGES, which is shared with browser routes to a more distinguishable name OS_LANGUAGES. Allowing this bug(990169) to be unblocked. Bug: 990169 Change-Id: Ic2d6dc3120d505ef2a864023c6d89a57301acdd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123311 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#756092}
-
Xiaohan Wang authored
In general, after playback starts, we do NOT support removing or resetting the CDM if one is already set. There's no use case for this at least for now and foreseeable future, and this change would help simplify some logic. Bug: 1066893 Change-Id: I53ad2445fab79d78b34e76d252c9c069c3e8950d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133173Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756091}
-
Wei-Yin Chen (陳威尹) authored
Before this CL, home button would be hidden when Start surface is on, except for the single-pane variation. Bug: 1055561 Change-Id: I8dd7862dffcb42fab77eaf1829ce441d30a5ea34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112330 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#756090}
-
Daniel Rubery authored
We want to fail open, but we don't want to tell the user "Scan complete" if the scan didn't actually complete. Change-Id: I174a9cec446ade9282438d1b1dd240cbbe3153be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132782 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#756089}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I3d893bdb737ec96f5f0cd3f998eb147388b0753d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132351Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#756088}
-
