- 26 Apr, 2019 40 commits
-
-
Daniel Cheng authored
Bug: 841899 Tbr: rdevlin.cronin@chromium.org Change-Id: Ifa01917f00bab75db998abddf4d487fb1b049990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584598 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#654499}
-
Daniel Cheng authored
Bug: 841899 Change-Id: If27e6942058fba40ee59ac10a64ce0c97ed5b179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584926Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#654498}
-
Xianzhu Wang authored
We chose to skip direct transform/opacity if the property is animating in compositor in crrev.com/c/1565467 (fast-path for simple transform change) to reduce risk of it. We observed that it caused regressions for several benchmarks. Now allow direct transform/opacity on the end of animation in this separate CL. We already have several test cases testing the situation. Bug: 954611 Change-Id: I6a8516dba92f6a3b02efd664bbc12315fe94d63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585263Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#654497}
-
Sergey Ulanov authored
This reverts commit 4a436e48. Reason for revert: The problem was fixed in SDK Original change's description: > [Fuchsia] Disable media_unittests failing in new SDK > > New SDK removed some services that the tests depend on, which broke 2 > tests: FuchsiaVideoDecoderTest.H264 and AudioOutputTest.Play200HzTone. > Disabling these tests temporarily until the problem is resolved. > > TBR=wez@chromium.org,maxmorin@chromium.org > > Bug: 956446 > Change-Id: I16f69249f49df6fc6c874196a17bca9973f154dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582034 > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653924} TBR=wez@chromium.org,sergeyu@chromium.org,maxmorin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 956446 Change-Id: Idd9fee71cdb802490fe422f8a1e44dfff8d62b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585395Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#654496}
-
Andrew Grieve authored
This reverts commit ce3df784. Reason for reland: Updated resource_sizes.py with renamed .ap_ path Original change's description: > Revert "Android: Compile .proto and .arsc resources at the same time" > > This reverts commit 697c9ab8. > > Reason for revert: Broke resource_sizes.py > > Original change's description: > > Android: Compile .proto and .arsc resources at the same time > > > > Saves a couple of seconds of build time for base bundle modules, > > and simplifies the GN logic for resources. > > > > Also fixes chrome_apk using unoptimized arsc file when lemon is > > enabled (broken by 2e296d82). > > > > Simplifies temp file usage in compile_resources.py by having all > > outputs go to the staging directory. > > > > Removes cruft: > > * Unused --no-compress flag > > * Unnecessary "Touch()" of R.txt > > > > Bug: 950233 > > Change-Id: Ida77380e8038002435ec3d320105d9feaa3c2136 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568568 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#653275} > > TBR=agrieve@chromium.org,tiborg@chromium.org > > Change-Id: I76bd9cf76b357156efa2848613ab576486d18476 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 950233, 955959 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581988 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653653} TBR=agrieve@chromium.org,tiborg@chromium.org Bug: 950233, 955959 Change-Id: I73367591e5d88fad86ebb24827238ca064a0f55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585941Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#654495}
-
Sigurdur Asgeirsson authored
Nodes in the PM graph are now self-indexed rather than by id. A stable opaque id is still provided for serialization purposes. Bug: 910288 Change-Id: I89ff8aef3763ed9f4406498457cb224c5d38ad29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585004Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#654494}
-
jdoerrie authored
TBR=jdoerrie@chromium.org Bug: NONE Change-Id: I1ac9128815d5f59127c6618227ff3ac42d6f7193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583737Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#654493}
-
khmel@chromium.org authored
This fixes 2 issues, first that in case of CPU heavy load, one CPU might work for one thread for a long time, in this case if thread was activated before zoomed view time it would be wrongly considered as an idle thread. Second issue is band selection SVG captures event that lead to incorrect detailed view activation in case next clicks is done in bounds of this selection. TEST=Locally BUG=b:122555793 Change-Id: I355eafa8dbc14bb66527522970354876e0d54a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585248Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#654492}
-
Dale Curtis authored
FFmpeg indicates more than this will cause issues, and it certainly causes OOM errors for 8K H264 content. VP9 playback doesn't seem to benefit at all from going from 16 - 32 threads. BUG=893984 R=sandersd Change-Id: Ibaa2dfac94cbdd4f42f728b579c063a960b4f973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584567 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#654491}
-
Piotr Bialecki authored
Bump expiry_milestone for flags owned by xr-dev@. Bug: 954532,929789 Change-Id: I1b7cb111c71976fee413033a4eb1d7ea1881232f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582614Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#654490}
-
kylechar authored
A gpu::Mailbox is needed to do something useful with the texture in GLOutputSurfaceOffscreen. Convert it to use SharedImageInterface to generate a gpu::Mailbox and then GL texture from that. Bug: 601869 Change-Id: Id7da76e06bf119bc0d679132330b75bc1662836a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585059Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#654489}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7a2205ca50c8..c62691b671a9 git log 7a2205ca50c8..c62691b671a9 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 tandrii@chromium.org git_cache: print if cache bundle under the same number already exists. Created with: gclient setdep -r src/third_party/depot_tools@c62691b671a9 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:943696 TBR=agable@chromium.org Change-Id: I8e0b641a23ab537d2152b3fe5c38a1c4cb758345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585932Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654488}
-
Francois Doray authored
Change-Id: I958f00fcd81c261515db469aa913c7945862db26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582221Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#654487}
-
Aaron Krajeski authored
Tests needed to be rebaselined due to this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1486711 Bug: 909937 Change-Id: If609d4e1420b4923b7e1ce68a5069d41cfb779be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585278Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#654486}
-
Greg Kerr authored
This deletes calls to InitializeSandbox that are no longer called. These are processes which only use the V2 sandbox. Bug: 917445 Change-Id: I87b96a4f4071438eeaf68e6d07ddc2c9813b3e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582967Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#654485}
-
Jan Krcal authored
This reverts commit a75e19c4. Reason for reland: fixed the test flakiness. Original change's description: > Revert "[AF Wallet] Ignore remote metadata deletions in USS sync" > > This reverts commit 948191bb. > > Reason for revert: introduces flakiness in integration tests > > Original change's description: > > [AF Wallet] Ignore remote metadata deletions in USS sync > > > > This CL changes behavior of the wallet_metadata sync bridge to ignore > > remote deletions. This is safe as every deletion should be eventually > > processed locally and for corner cases there is anyway already a GC > > routine. > > > > This is motivated by observed ping-pongs of deletions-creations between > > clients running Directory code and clients running USS code, leading > > to considerably increased number of address conversions on USS. This > > CL breaks these ping-pongs and should get the conversion counts on > > comparable levels. > > > > Bug: 953693 > > Change-Id: I1a30f51d4727a08f84ef33091089d2a7a366b4df > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583896 > > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#654413} > > TBR=jkrcal@chromium.org,mastiz@chromium.org > > Change-Id: Ia8afa93aa834101d154e1a1a3db3996f686d1786 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 953693 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583711 > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#654471} TBR=jkrcal@chromium.org,mastiz@chromium.org Change-Id: I737e61569db88219f10db68817b03b5467389df4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 953693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584310Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#654484}
-
Scott Violet authored
This code was split when we had two nearly identical window types. That is no longer the case, so this template can be nuked. BUG=none TEST=none Change-Id: I876e18d1335c74e2ab34e1ba34d423f60bf6babf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585160 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#654483}
-
Raymond Toy authored
Previously we only tested the result of getFreqencyResponse for peaking filters. Add test for all the other filters as well. Bug: 390266 Change-Id: I7cba2a0dbcfaf3e6c0fec0a92eaedf8779f2d361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584368 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#654482}
-
Brian Sheedy authored
The VR instrumentation tests have always taken a while to run with a Daydream View paired due to the number of tests. For whatever reason, they take even longer on Android P, causing them to fairly regularly hit the 1 hour timeout on the bots. So, enable sharding for the Daydream View version of the tests. Bug: 953990 Change-Id: Ife442148e4799318f0665a4dfa345fbeff47a361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585251Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#654481}
-
Scott Violet authored
I had to do this in a separate step as git doesn't handle moves particularly well. BUG=none TEST=none Change-Id: I6e948957013eb6b7db97c12d4c980ad35a7b1827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584842 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#654480}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2de3e3c02f29..dca3ea5e1719 git log 2de3e3c02f29..dca3ea5e1719 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 clouds.flowing@gmail.com fix example.cpp (#2540) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@dca3ea5e1719 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org,geofflang@chromium.org Change-Id: I82fe9d860669eeaef8a15dbe80a791ac9e5b7d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585926Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/517f7f858d97..d7f22e29c4a1 git log 517f7f858d97..d7f22e29c4a1 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 simonhatch@chromium.org Dashboard - Calculate comparison_magnitude for custom ranges Created with: gclient setdep -r src/third_party/catapult@d7f22e29c4a1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:894529 TBR=eyaich@chromium.org Change-Id: I24cacdc410c6ffdb1fcf240584af2ae3b18bcd6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585925Reviewed-by:
-
siashah authored
The Save button is enabled based on the error type value. Before: https://screenshot.googleplex.com/xujMptYhWxW After: https://screenshot.googleplex.com/jTj8SnNL82A Bug: 955825 Change-Id: I123c72d23342e5c04f8ce3e4c02610720b6a7231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584166Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#654477}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6e345f4e28d3..999374532cec git log 6e345f4e28d3..999374532cec --date=short --no-merges --format='%ad %ae %s' 2019-04-26 eseckler@google.com Merge "processor: Tokenizer support for TrackEvent + InternedData" Created with: gclient setdep -r src/third_party/perfetto@999374532cec The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I58a49e0cc896f363a75474f680166bc10ebe4a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585923Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d3aeecd01069..d521ce39e99f git log d3aeecd01069..d521ce39e99f --date=short --no-merges --format='%ad %ae %s' 2019-04-26 egdaniel@google.com Test vulkan msaa on test bots. Created with: gclient setdep -r src/third_party/skia@d521ce39e99f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I6e252b23bbd4c58e4b4e3a8fde07b7ca0bc3dff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585924Reviewed-by:
-
Nicolas Ouellet-payeur authored
Bug: 957003 Change-Id: I60f2c62d75dfc2a7d1b86f5b9880151d5d11c78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585465Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#654474}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/419c9cd57073..75c4cbfa717a Created with: gclient setdep -r src-internal@75c4cbfa717a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: I10b65df10fdb516c26b0dd3f695e74e1bada10c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585921Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654473}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/eb37b1394300..e670fd97951a git log eb37b1394300..e670fd97951a --date=short --no-merges --format='%ad %ae %s' 2019-04-26 srte@webrtc.org Adds getter for FieldTrialParameter keys. Created with: gclient setdep -r src/third_party/webrtc@e670fd97951a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie183d7aaf9756d506940118a1c822303f1b7938b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585922Reviewed-by:
-
Jan Krcal authored
This reverts commit 948191bb. Reason for revert: introduces flakiness in integration tests Original change's description: > [AF Wallet] Ignore remote metadata deletions in USS sync > > This CL changes behavior of the wallet_metadata sync bridge to ignore > remote deletions. This is safe as every deletion should be eventually > processed locally and for corner cases there is anyway already a GC > routine. > > This is motivated by observed ping-pongs of deletions-creations between > clients running Directory code and clients running USS code, leading > to considerably increased number of address conversions on USS. This > CL breaks these ping-pongs and should get the conversion counts on > comparable levels. > > Bug: 953693 > Change-Id: I1a30f51d4727a08f84ef33091089d2a7a366b4df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583896 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#654413} TBR=jkrcal@chromium.org,mastiz@chromium.org Change-Id: Ia8afa93aa834101d154e1a1a3db3996f686d1786 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 953693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583711Reviewed-by:
-
Saman Sami authored
We already do this in PixelsMatchReference() but that only applies to references that are stored in a file. Do something similar for the other variation of RunPixelTest where the reference is stored in memory. Bug: 939442 Change-Id: If71be3a9fa1d701711740dc11d341c57f56cbcfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585546Reviewed-by:
-
Jérôme Lebel authored
The footer view for SectionIdentifierWebServices section only exists when Unified consent flag is off. Bug: 957025 Change-Id: Ia24835365878169abe0db58a49fb4f9073b997e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584277Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#654469}
-
John Abd-El-Malek authored
Bug: b/130750620 Change-Id: Ibc476c617578abbc73d9cdfebaac84e07617e46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579422Reviewed-by:
-
Justin Cohen authored
Bug: 845992 Change-Id: I48a17d1c9749a8fa56b155b48d2ae923245ecacc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529951 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#654467}
-
Evan Stade authored
Newly implemented: Observer::SuspendDone() Bug: 644348 Change-Id: I2fd3057e839c8580608f8e934627d2652ed54b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584393Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#654466}
-
Evan Stade authored
Newly implemented: RequestRestart() Bug: 644348 Change-Id: Ia3aab1d6acbc5dc817d72b7a8eb5641a6dce10ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584365Reviewed-by:
-
Evan Stade authored
The old API returned a callback which encoded the identifier for the client's block-suspend request. The new API takes and uses an UnguessableToken as the identifier for the request. There should be no functional change. The new API will be easier to implement in the Mojo client. TBR=shik@chromium.org Bug: 644348 Change-Id: I395f7746ad7075d1a994d4a08ebaaf267da1782a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575777Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#654464}
-
Huanzhong Huang authored
Currently Clear Browsing Data contains the following chain of actions: Cell selection -> Update on the browser state -> Browsing Data Counter restarted -> Cell reloaded (instead of reconfigured) to accommodate latest data counting result -> Cell selection state cleared due to reload -> Cell needs to be reselected to compensate These actions form a cycle and thus are the cause of responses to tapping being laggy. This change fixes the issue essentially through breaking the chain at the first step. Bug: 957013 Change-Id: Ibf25fde3845378640856ab158cf0e37339ec7f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584506Reviewed-by:
-
Tommy Martino authored
This CL represents a big chunk of the work towards generalizing the Password-specific structures to also handle manual filling of Credit Cards (and, later, Profiles). Specifically, it introduces a new parent class, AccessoryController, which fills the role originally called "AccessoryItemTranslator" in our design doc. This class handles the translation of domain-specific data types (e.g., AutofillProfile) into UserInfo that can be sent along to the filling UI. It took on some a slightly larger role than was previously planned, because after digging around in this code, it felt like knowing how to translate a T into a UserInfo and knowing how to route a selection event to the appropriate manager were functionally similar. This is only the first step towards that structure; there are other chunks of code I can generalize further, but I wanted to keep the scope somewhat manageable. My goal is that, ideally, once this work is done, we can simply implement a class that extends AccessoryController<CreditCard> or AccessoryController<AutofillProfile>, and require only trivial changes to the ManualFillingControllerImpl to get that data through to the UI. Bug: 902425 Change-Id: I104afad234114be034c791b53c2cfad693a91554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519091Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#654462}
-
Tibor Goldschwendt authored
Bug: 925126 Change-Id: I155fd5ad81729aa01de476e073115a3246a0ca99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547706 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#654461}
-
Samuel Huang authored
Previously SuperSize failed for desktop Chrome, because the linker .map generated when CFI is enabled (desktop only) has many Level 3 entries with sizes are equal to the containing Level 2 entries. But these entries have advancing addresses, so overflow occurs, and the ensuing negative gaps size triggers assert failure. This CL implements CFI support for SuperSize to fix the issue. Details: * linker_map_parser.py: * Detect (Level 2) .L.cfi.jumptable entries, and extract them as Level 2 symbol "** CFI jump table". * This sidesteps the above overflow problem -- this appears only for .L.cfi.jumptable entries. * Collected and print various stats in verbose mode. * Note: Level 3 details in .L.cfi.jumptable are discarded (~64k symbols). * Process CFI's __typeid_*_type_array: These are Level 3 entries that have size = 1: So we use |span| explicitly. * All other __typeid_ entries are found to be suppressed by the |next_usable_address| mechanism: Print warnings if found. * archive.py: * _AssignNmAliasPathsAndCreatePathAliases(): Suppress "Symbol not found" warnings for __typeid_ symbols to reduce noise. * _AddNmAliases(): Add special case to skip "** CFI jump table" symbols (can't skip all "*" symbols though; we still want e.g., "** outlined functions"). * Add LinkerMapParserTest.test_ParserCfi() to handle only the new CFI-related cases. There is no change in SuperSize results for ChromePublicApk.apk generated without CFI (currently the default). Bug: 947114 Change-Id: Iaa0b7c8a779bddbd899afb88b246b978f0c41cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579461 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
-
