Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 13 Dec, 2016 31 commits
  3. 12 Dec, 2016 9 commits
    • bshe's avatar
      Enable cardboard support for non-Daydream devices · a22648ac
      bshe authored 
      If VrCore exists on non-Daydream devices, WebVR Cardboard support should be enabled.

BUG=671370

Review-Url: https://codereview.chromium.org/2556093002
Cr-Commit-Position: refs/heads/master@{#437962}
      a22648ac
    • rockot's avatar
      Chrome Mash: Use absolute path to run chrome executable · 312059d8
      rockot authored 
      The child process launcher now switches to the host executable's
path before running a new child process. That breaks mash_runner
code which launches the host executable if the host executable was
invoked by relative path.

This changes mash_runner to always reference the host executable
by absolute path when rewriting child command lines.

BUG=None
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2573593002
Cr-Commit-Position: refs/heads/master@{#437961}
      312059d8
    • csashi's avatar
      Expanded Autofill Credit Card Popup Layout Experiment in Android. · 9ecb4387
      csashi authored 
      Assets are yet to be added to this change.
BUG=664367

Review-Url: https://codereview.chromium.org/2531223003
Cr-Commit-Position: refs/heads/master@{#437960}
      9ecb4387
    • asvitkine's avatar
      Restrict transmission of external exp ids to signed in users. · 9ed7b561
      asvitkine authored 
      Since external experiment ids are not based on Chrome's low
entropy source, they do not have the same guarantees about
not identifying a user as Chrome's variations. As such, we
should only transmit them for signed in users, whose identity
is already known by Google so there's no risk of identifying
them through these headers.

Note: The signed-in state checking in this CL is only done for
web content area requests and not other internal requests,
like to the suggestion service, where it treats the state as
"not signed in". This is fine to do because variations service
ids are still sent, which is what the other call sites are
interested in.

BUG=672532
TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org

Review-Url: https://codereview.chromium.org/2558913003
Cr-Commit-Position: refs/heads/master@{#437959}
      9ed7b561
    • alexilin's avatar
      predictors: Fuzzy comparison of request priority for images. · 54585e4c
      alexilin authored 
      The browser tests for ResourcePrefetchPredictor check that the actual
request priority is equal to the expected value. But for the images the
priority cannot be precisely defined because there is a race between the
preload scanner issuing fetch requests and frame view performing layout
and promoting priorities of all visible images.

BUG=650253,673028

Review-Url: https://codereview.chromium.org/2569723002
Cr-Commit-Position: refs/heads/master@{#437958}
      54585e4c
    • yzshen's avatar
      Mojo JS bindings: lazily initialize the underlying connection of interface ptr. · 348e013f
      yzshen authored 
      This is useful when the user creates a bound interface ptr and passes it without
actually using it to make any calls, which is pretty common.

BUG=579646

Review-Url: https://codereview.chromium.org/2563593005
Cr-Commit-Position: refs/heads/master@{#437957}
      348e013f
    • estade's avatar
      Update WM shadow transitions. · 77932377
      estade authored 
      When changing from one shadow type to another, cross fade the two.

BUG=608852

Review-Url: https://codereview.chromium.org/2562143002
Cr-Commit-Position: refs/heads/master@{#437956}
      77932377
    • moshayedi's avatar
      IME for Mus: Use ui::InputMethodChromeOS to provide logic for ime driver. · b171ff9c
      moshayedi authored 
      The goal of this CL is to modify content_browser's IMEDriver so we have access
to ui::InputMethodChromeOS's functionality in mus+ash.

This CL:
- Modifies ui::InputMethodChromeOS so it can call an ack callback after
  processing events.
- Introduces InputMethodBridge to acts as a bridge between
  ui::mojom::InputMethod and ui::InputMethodChromeOS.
- Introduces RemoteTextInputClient to send commands received from
  ui::InputMethodChromeOS to a remote client over mojo IPC.
- Modifies content_browser's IMEDriver implementation to use
  ui::InputMethodChromeOS via InputMethodBridge.
- Some unittests to verify that InputMethodBridge works correctly.

BUG=665981

Review-Url: https://codereview.chromium.org/2557493002
Cr-Commit-Position: refs/heads/master@{#437955}
      b171ff9c
    • tapted's avatar
      Mac: Fix lifetime problem under BookmarkBarController stopPulsingBookmarkNode. · 561b5ae6
      tapted authored 
      BookmarkBarController has a weak pointer in a |pulsingButton_| data
member. This is an NSView which can be destroyed in
-[BookmarkBarController redistributeButtonsOnBarAsNeeded] when it is
removed from its superview.

Since bubbles close asynchronously, and fade out, the bookmark bubble
can cause a UAF to |pulsingButton_| via stopPulsingBookmarkNode. This
can occur if a resize triggers redistributeButtonsOnBarAsNeeded while a
bookmark bubble is still alive.

There's no need for this to be a weak pointer. Make it scoped_nsobject
instead.

This affects both Cocoa and MacViews.

BUG=616051
TEST=Added unit_test:
BookmarkBarControllerTest.RedistributeButtonsOnBarAsNeeded

Review-Url: https://codereview.chromium.org/2567973002
Cr-Commit-Position: refs/heads/master@{#437954}
      561b5ae6