- 26 Aug, 2020 40 commits
-
-
Mohamed Amir Yosef authored
This is a reland of d705fd61 Original change's description: > [Passwords] Remove passwords from the correct store in ... > > ... CompromisedCredentialsManager() > > Bug: 1108422 > Change-Id: I66ea95309a1c3242fe8e32591ae986d68dbe5ee2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372429 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801348} Bug: 1108422 Change-Id: I27710fb2db2356ac5cce088ea1a27e67ac13d58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375466Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#801728}
-
Benoit Lize authored
Bug: 1072567 Change-Id: I0a1930a42275e8fbd9e9460a152e4b8297c8b713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351972Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#801727}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/12df3cafeee0..9e26ae045526 2020-08-26 afdx@google.com spirv-fuzz: Overflow ids (#3734) 2020-08-26 greg@lunarg.com Fix DebugNoScope to not output InlinedAt operand. (#3748) 2020-08-25 vasniktel@gmail.com spirv-fuzz: Split the fact manager into multiple files (#3699) 2020-08-25 andreperezmaselco.developer@gmail.com spirv-fuzz: Add inline function transformation (#3517) 2020-08-25 vasniktel@gmail.com spirv-fuzz: Fix MaybeGetZeroConstant (#3740) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I75bbe77145ce986b6b52e50d4a29ba501ff01cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377515Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801726}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1dec2f31..e23bb2ed Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia5d2cdbcae4e5ac97a06f0d390c5fb02ea9e1fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377454Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801725}
-
Aaron Leventhal authored
Menu list popups that are inert should not be present in the platform accessibility tree. AX-Relnotes: n/a. Bug: None Change-Id: I9414fc05c271fc0b3f29d8c5ef8db9fe84af90c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368469Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#801724}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a139788b4c78..ead4ca052b99 2020-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 7bce5194d1d6 to 3c2454b82c05 (19 revisions) 2020-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 752313f1 to 0839d38f (372 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1085700,chromium:1119669 Tbr: mtklein@google.com Test: Test: Test: CQTest: Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_* --use-angle=vulkanTest: Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.InvalidatingAndUsingDepthDoesNotBreakRenderPass/* Change-Id: I72051f8b4c8bda6727f0a476d140ec18c1474d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377520Reviewed-by:
-
Chih-Hsuan Kuo authored
In order to not start remoting on the receiver that implements an unsupported remoting version, Chrome should get the remoting version info from the capabilities response and check whether it should start remoting or not. Due to the backward-compatibility, Chrome will not start remoting only the receiver implements a newer remoting version. Bug: 1119742 Change-Id: I5bb7979d35f3a1ec5e8b998f41cb02e682fde845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366340 Auto-Submit: Chih-Hsuan Kuo <chkuo@google.com> Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801722}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a095d432e768..99b0f8d26cbe 2020-08-26 eshr@google.com Reland "[Adaptation] Remove QualityScalerResource when disabled." 2020-08-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 44a1544c..d4203a22 (801457:801568) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic0610638119cf781b3dadfb8da9fd4c6e636e4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377521Reviewed-by:
-
Josh Nohle authored
This implementation: - Stores the set of selected contacts to prefs, but the full contact list must be downloaded as needed. - Handles the upload of contacts to the Nearby Share server. - Schedules periodic check-ins with the server to see if contacts have changed since the last upload. Bug: b/154863722, b/154861871 Change-Id: I72c03ea0f922f3386fd6ea5336fbab728f0e429c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307477Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#801720}
-
Tanmoy Mollik authored
This crash occurs when the user signs out from SyncAndServicesSettings page and then presses back. This cl checks that there is a signed-in account during destroying the SyncAndServicesSettings page. This check will prevent the assertion check from the crashing the app. Bug: 1112532 Change-Id: I54e5e800bf0f69df2da5dcad57f51037528001fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372282Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#801719}
-
Clemens Arbesser authored
Bug: b/166266031 Change-Id: I2ab6523282c7eb271c4874abe6b4238e7ff1dffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375170 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#801718}
-
Michele Mancina authored
Bug: b/159308598 Change-Id: I99118fd33bdfef27bfbbf9551266d9a3b8f072c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362913Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Michele Mancina <micantox@google.com> Cr-Commit-Position: refs/heads/master@{#801717}
-
Henrik Boström authored
Now that https://webrtc-review.googlesource.com/c/src/+/180620 has rolled into chromium, we can re-enable the disabled tests and update the expectations that more tests are passing. Follow-up CLs will make us pass even more tests. Bug: chromium:1060083 Change-Id: Ia1e1432746293fa395e5bda72e163f223f316b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377707Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#801716}
-
Nohemi Fernandez authored
The potential race condition occurs when the accounts with refresh tokens becomes misaligned with the accounts in the Chrome Identity service. Bug: 1069950 Change-Id: Icdf3542ca69026f06a4cc8b793a0c2f1bc3518e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375368 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#801715}
-
Rune Lillesveen authored
Test added a border of 20px to a width of 80px and expected 100px, but border is added to both sides. Reduced border to 10px. Bug: 1121917 Change-Id: I98fd76c9eb9581f842e2d8ea90e2e8b32fba01f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377487Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#801714}
-
Yuki Yamada authored
This CL adds checking is_bound() in FileSystemDispatcher::Cancel(). |remote| can be unbound there because the order of ContextDestroyed() invoked in ExecutionContext::NotifyContextDestroyed() became nondeterministic in another CL https://crrev.com/c/2369012 Bug: 1120886, 1100257 Change-Id: I14636312859b7b91fc15b127ebc629105a77c016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371448 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#801713}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/cdc009c24afa..6730854c3971 2020-08-26 apodtele@gmail.com * src/smooth/ftsmooth.c (ft_smooth_raster_overlap): Limit width. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I4a99889af5d563e33a8758dd4bee0fb5c21b9733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377146Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#801712}
-
Victor Vianna authored
The PopupHidingReason argument is unused in the desktop implementation so this CL introduces HideImpl() to replace Hide(PopupHidingReason) calls. Change-Id: I0379758bdcaeea84ee1db3693e6497854c19c75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375465 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#801711}
-
Yoshifumi Inoue authored
This patch enables |NGInlineNodeDataEditor::VerifyItems()| to verify offsets in |ShapeResult| to identify reproduce steps. Bug: 1121885 Change-Id: I1fb1e423c134f3228cee3487e5af5ae86745437b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376933 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801710}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/42aaf8bd7f23..184443e8d779 2020-08-25 thestig@chromium.org Move CPDF_InteractiveForm::AddStandardFont() to an anonymous namespace. 2020-08-25 thestig@chromium.org Move GetNativeCharSet() into an anonymous namespace. 2020-08-25 thestig@chromium.org Move GetNativeFontName() into an anonymous namespace. 2020-08-25 tsepez@chromium.org Pass actual isolate to GetForegroundTaskRunner() 2020-08-25 thestig@chromium.org Pass a ByteStringView into FindNativeTrueTypeFont(). 2020-08-25 thestig@chromium.org Shuffle code around in CPDF_InteractiveForm. 2020-08-25 thestig@chromium.org Use files_to_check parameter with FilterSourceFile(). 2020-08-25 thestig@chromium.org Simplify RetrieveSpecificFont(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1121682 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I2a820da4743896a2989d253df3e547a03892986f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377517Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ac636dc7dfe0..e7d4ae57bbbb 2020-08-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-08-26 szuend@chromium.org [ts] Type-check ui/TabbedPane.js with TypeScript 2020-08-26 szuend@chromium.org [ts] Type-check ui/FilterBar.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib118e64164b26486524682a18fa345c21a53c630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377510Reviewed-by:
-
Curtis McMullan authored
Bug: b:161491149 Change-Id: Ia68838aa8aaf218ace7d1ac49f946decfeaada10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371387Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Cr-Commit-Position: refs/heads/master@{#801707}
-
Yunke Zhou authored
Bug: 1121901 Change-Id: I28047ad3da5b1a61ae91ee492f8b6ec53a7b2f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377486Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#801706}
-
Linkun Chen authored
Reference: https://gn.googlesource.com/gn/+/master/docs/reference.md#var_public_deps Allow inheriting ability to include public headers. Test: CQ Bug: 1121813 Change-Id: I9e8111319be6fbe33eb11bfd58807e0e89bf84c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376380 Commit-Queue: Linkun Chen <lkchen@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#801705}
-
Hodol Han authored
Remove STGMEDIUM* usages, make StorageDataInfo constructor private, and provide a factory method of StorageDataInfo. There is no explainable reason to use STGMEDIUM pointer. In current implementation it seems to be used to test validity of STGMEDIUM, but we still can verify whether STGMEDIUM is valid or not by TYMED_NULL. We assume StorageDataInfo owns that STGMEDIUM, but it still can be copied and used elsewhere. A factory method called TakeStorageMedium takes and nullifies STGMEDIUM to prevent the problem. Change-Id: I3ea7e22d4363cc2ce6e3838433f249f7486d1129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329204Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#801704}
-
Alex Rudenko authored
The set of CSS Grid settings has changed so we add a new histogram to track the new set of settings. The previously used histogram becomes obsolete. Frontend CL: https://crrev.com/c/2366793 Bug: 1109177 Change-Id: I391595622ef99c7e2e6be554f2141acc4e44d752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367833 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#801703}
-
Fredrik Söderqvist authored
This interface has a single user and is overridden by a single subclass (SVGImage), so it seems more pertinent to just implement this using other existing building blocks. Change-Id: I241c382c71052821e59280cd4cee10d2deef33dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372285 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#801702}
-
K. Moon authored
Adds a chrome_pdf::UrlLoader class that abstracts pp::URLLoader. This is currently a very thin abstraction that almost exactly duplicates the pp::URLLoader API, in order to minimize changes at call sites. At this point, the biggest change is that UrlLoader uses scoped_refptr for reference counting, rather than pp::Resource. In the future, this will allow a Pepper-free implementation of UrlLoader that doesn't rely on Pepper's resource management. More minor changes to the API include using base::span<char> instead of void* and size_t for passing buffers, and using ResultCallback instead of pp::CompletionCallback. This change also cleans up some IWYU issues in url_loader_wrapper_impl.cc. Bug: 1099022 Change-Id: Ia8764603c791942f8839d376e4866366a04f002e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376510Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#801701}
-
Kunihiko Sakamoto authored
And run wbn-subresource-(third-party-}origin-trial.https.html under it. This allows us to enable SubresourceWebBundles by default for web tests. Bug: 1082020 Change-Id: I8359cdb7359a77371e0c73f6cf69f129ef5d2fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377665Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#801700}
-
Giovanni Ortuño Urquidi authored
https://crrev.com/c/2360089 added a "IsOffTheRecord" check to fix a crash in incognito. Unfortunally that introduced a new crash for Guest sessions. IsOffTheRecord() returns true for both incognito and guest session profile, which caused guest session to try to use the original login profile which leads to a crash. This fixes the issue by excluding guest sessions and only getting the original profile for incognito mode. Bug: 1121553 Change-Id: Iface9c78a56de1c44295d503e7090a64cdb471ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377187Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#801699}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13e23939fb1a..346ebfc47a54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917 Tbr: hayato@google.com Change-Id: I281e139d842360c6a3d5a083fa3580e18806e651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377508Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801698}
-
Hirokazu Honda authored
AcceleratedVideoEncoder implemented in VaapiVideoEncodeAccelerator returns one-time Picture on GetPicture(). In other words, different Picture instances returns every GetPicture(). This behavior likely leads to a bug. In fact, vp9 metadata is not filled because it attaches the metadata in the returned Picture and refers to it later but the pictures are different. This CL fixes the interface so that it will always returns the same instance. Bug: 1030199 Test: tast run webrtc.* on atlas Test: video_encode_accelerator_tests on atlas Change-Id: I5ec1cb17e032566ed082469331f89a380d86148f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371085 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#801697}
-
Minggang Wang authored
This patch removes EnableReducedReferrerGranularity from WebRuntimeFeatures, because features::kReducedReferrerGranularity is available in Blink now. Bug: 860403 Change-Id: If7da017b49bf86c2a539e07ac03a0735658f6a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358992 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#801696}
-
Luciano Pacheco authored
Remove JS code, CSS style and images used by non-native controls. Native controls have been enabled by default for a few milestones (since M73) crbug.com/909963#c7 This CL dead code since the feature flag has been removed: CL:2018089. Tested manually opening one video as well multiple videos and switching between them. Bug: 909963 Change-Id: I3478fb03cb33acff2d58e527af48a31879c37c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362171Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#801695}
-
David Roger authored
This prevents Chrome from shutting down while the profile picker is displayed. Fixed: 1119369 Change-Id: I1d9df7c66c360dd29984876382b116d5732cb132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375350Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#801694}
-
Gauthier Ambard authored
This CL hides the NTP avatar when the user isn't signed in. Fixed: 1115654 Change-Id: Idfcdadddbfb2ccd81000833d561aca46ac8074cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375247 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#801693}
-
Maksim Sisov authored
This is a reland of f985905e. This change broke our headless build: ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed. assert(ozone_platform_x11) ^----- See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included. "//ui/events/platform/x11",. Fix: Don't include x11 build for headless case. Original change's description: > X11 and Ozone: enable use_x11 and use_ozone > > This is the final change that enables use_x11 > and use_ozone for Linux builds and (as it was > before) excludes X11 for chromeos, chromecast, > lacros. > > in order to run ozone/X11/wayland, one must pass > —enable-features=UseOzonePlatform > —ozone-platform=x11 or wayland. otherwise, > non-ozone/X11 is used. > > it’s also possible to completely disable X11 > so that clients, who need that kind of build can > continue to have that. > > Bug: 1085700 > Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#801523} Bug: 1085700 Change-Id: I8bf0abead6c94c95ddc58443de7cf2268c977cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376806Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#801692}
-
John Palmer authored
Bug: b/166339813 Change-Id: Icf220bf8446cc9e6c761607dd99a9b918e4909fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377526 Auto-Submit: John Palmer <jopalmer@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#801691}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 877c823f. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: external/wpt/css/css-cascade NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I8dd7c6e2f7cc059a192d609db9cee4eb2d3813b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377425Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801690}
-
Fredrik Söderqvist authored
We can use a wrapping SVGImageForContainer instead, and then call AsSkBitmapForCurrentFrame() as in the BitmapImage case. Drop unnecessary null-checks for |image| (it is dereferenced already, and cannot be null because of ImageResourceContent::GetImage). Bug: 1121177 Change-Id: I1f327bdca72b6ba60ae30413607246226c4c7e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375171Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#801689}
-
