- 17 Dec, 2020 40 commits
-
-
Fabrice de Gans-Riberi authored
* Add basic start/stop and send/receive tests for the Cast Streaming component * Merge 2 core targets in cast_streaming into one. Bug: 1110490 Change-Id: Ia949ca73c69badeaaad60adb024b3f4bcb44f40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553143Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#837890}
-
Hirokazu Honda authored
video_encode_accelerator_tests crashes if the test is built with --dcheck_always_on=true. It is because the sequence that destroys a decoder used in BitstreamValidator is different from one that initializes the decoder. This fixes the issue by destroying the decoder in the same sequence as of initialization. Bug: b:174318867 Test: video_encode_accelerator_tests on volteer Change-Id: I76a224705534945ee7f4c4ab8e1c1dd73fdcacea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592853 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#837889}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6bf9e131d05a..0da7da798b33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Icb1c9f0301043bd8c455ef6bebf1d59fc262f8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596057Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837888}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I3cfc0267c733659383f007e19cc98ec174ed1026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592220Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#837887}
-
Ahmed Mehfooz authored
This CL adds a feature flag for stylus battery status in the stylus tools menu. Also adds skeleton code to set up the UI to be hooked up with backend CL in a subsequent CL. Bug: 1158537 Change-Id: I873c1dac4827a64e0f66a18aa63a4df1e0c44036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590366 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837886}
-
hscham authored
For Python3 compatibility. hash function added in crrev.com/c/2277687 for Field requires hash function for EnumValue (self.default). BUG=941669 Change-Id: I787bca64a05d379088a6e2846f03b76e258e0701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584728Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
-
Roman Arora authored
Fixed: 1147535 Change-Id: If8ad3df877d1baa5ce32c7199b50ff4d886555dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585994 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#837884}
-
Yu Liu authored
Bug: b/175707921 Change-Id: I9f54d970e45ffb6a8cee83f3b70aa5f6f75f8bbf Corresponding BlueZ metrics implementation can be found at: https://chromium-review.googlesource.com/c/chromiumos/third_party/bluez/+/2595924 Change-Id: I9f54d970e45ffb6a8cee83f3b70aa5f6f75f8bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595525Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yu Liu <yudiliu@google.com> Cr-Commit-Position: refs/heads/master@{#837883}
-
Josiah K authored
(http://go/magnifier-panning-improvements-design-doc) AX-Relnotes: n/a Bug: 1144037 Change-Id: I82c2b1c330826a4e48ed47482f98f1a0c0168894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503568 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837882}
-
Matt Mueller authored
This should reduce the impact of cache initialization on the first page load. Bug: 1159560 Change-Id: Ib21e9c9736e3dd1d81b194e59fcd1fb26fba6e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595971Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#837881}
-
Nancy Wang authored
This CL implements below functions: 1. Save the app launch information to local variable |file_path_to_restore_data_|. 2. Add flags |ShouldUpdate| per profile path to record whether there are updates to be saved to the full restore file. 3. Add a timer to delay and cache the restore data writing. 4. Call FullRestoreFileHandler to write the restore data from |file_path_to_restore_data_| to the full restore file on a background task. There will be a separate CL to add tests. Bug: 1146900 Change-Id: Icf7a674d0d474005eb8dc33b39b5660ab6436153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589613 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#837880}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1608097529-a53990c96ba4fe0e9c85a726eccdb7c47db8df34.profdata to chrome-win32-master-1608141458-c308516ff1ef658b0966cc17b391babeaf39cbb5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I48f115b6a196344c2390b67eee62d8e426c6c44b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595705Reviewed-by:
-
Xiaocheng Hu authored
This patch switches counter() and counters() to use @counter-style rules (including predefined ones) instead of relying on the deprecated EListStyleType enum. Note: The purpose of this patch is to ensure that there's no breakage after fully switching counter() and counters() to the new implementation for the predefined counter styles. Follow up patches will verify the new implementation against custom counter styles and apply fixes, if needed. Bug: 687225 Change-Id: I981f55dfffff97feac5edfd42b1569fa40de47e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591873Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#837878}
-
Chris Thompson authored
Change-Id: I2e9656516a03bbb43c31175dd178cc223a171ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596776Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#837877}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608141458-ce789808658cedde2d9d2bce7c84c9a07b9d1c0e.profdata to chrome-linux-master-1608163120-124e90d18fac2bedecb2b27b978f1959d49c27fb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I38f0b034d1ee9e02ac0e49b45bcedf8e13ef2a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596738Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8a5112747ff0..508bcddc99e4 2020-12-16 yiorsi@gmail.com Fix: right-click in CSS var() cannot open the context menu 2020-12-16 andoli@chromium.org [module.json extensions] Migrate profiler views If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1124707,chromium:1134103,chromium:1152391 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I42afedfb2df40d05c9320ed8deec16de0206b974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596003Reviewed-by:
-
Gabriel Charette authored
Sheriff notes: This is expected to artificially reduce IOJank* metrics. Modal dialogs launched via GetAppOutputInternal in launch_posix.cc are guaranteed to block and thus should use WILL_BLOCK semantics (as opposed to MAY_BLOCK like it did). However, Process::WaitForExit can't use WILL_BLOCK semantics because of an existing workaround for TestLauncher to not use ScopedBlockingCallWithBaseSyncPrimitives when waiting on processes or TestLauncher ends up creating or TestLauncher ends up flooding the pool to 256 workers regardless of --test-launcher-jobs (it posts each test as a task right off the bat and expects the pool to cap the parallelism...). The best solution to get proper tracing and thread restrictions right is thus to add custom trace events and keep assertions that waiting is allowed when launching the process. Each platform was doing something slightly different here, this CL brings all platforms inline with annotations that are visible in tracing but ignored by IOJank metrics. Example broken trace showing up in IOJank slow reports on Linux: https://goto.google.com/btbzu (SS: https://snipboard.io/7sDO1r.jpg) R=fdoray@chromium.org Bug: 1064645, 1144161, 899897 Change-Id: Id087f91df8c2201ca10db5438456c638f9b791e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233299 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#837874}
-
Daniel Murphy authored
This cleanup migration should be complete now. See this bug [1], which gives more context on the cleanup itself. Removing, which is basically reverting commit d3d65a10 [1], but leaves the pref value for cleanup as per guidelines. This is also being done to replace this functionality with WebAppMover [2] (google only). [1] https://crbug.com/1127128 [1] https://chromium-review.googlesource.com/c/chromium/src/+/2391704 [2] https://docs.google.com/document/d/1GOek_Q4O_jTewHHx0MLnbYXvlTdEKT-KmkPZ5R0VJ3c/edit Bug: 1158066, 1127128 Change-Id: I75de00f67a3f26984c10f1dbdf0389b6f31c71a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587402 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#837873}
-
Leonid Baraz authored
No semantics changes whatsoever. Change-Id: If7d2aee72d62b09cbe864157416988835febfc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596016Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#837872}
-
John Williams authored
Bug: 1159209, b/1154342 Change-Id: I67f862c2f1e9cd2f8cfaeb2d73c5e22ebd360bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559589Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#837871}
-
Gyuyoung Kim authored
This CL migrates AwViewHostMsg_OnContentsSizeChanged to FrameHost interface. This CL uses AssociatedRemote to keep the message order. OnMessageReceived() is removed because AwRenderViewHostExt doesn't handle IPC message anymore. Bug: 1157128 Change-Id: If1e6132ac4c99cb1f1f7ee484a424ba5cc3a75a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592269Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#837870}
-
Asami Doi authored
This CL replaces `data.errors.empty()` with `data.NoBlockingErrors()` because we don't want to consider the WARN_NOT_OFFLINE_CAPABLE state as an error. The state just logs a warning message to DevTools and Application > Manifest > Installability and it should not affect the behavior. Bug: 1157809 Change-Id: I03cf02f134ff4f96441723bf893aac380160cced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592245Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
James Vecore authored
This CL: https://crrev.com/c/2594308 introduced new error states to receive surface registration which was causing the notification manager to fail registration at startup. We can get around this issue by allowing background receivers to register regardless of medium or transfer state. Change-Id: I50f8b00a0a01ea4bd6eb6b259f6c5c522fa38c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596062 Commit-Queue: James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#837868}
-
Joey Arhar authored
Before this patch, <input type=checkbox> and <input type=radio> can be left in an active state if you press the spacebar down to toggle it, and then press tab to move focus away before releasing the spacebar. This patch calls SetActive(false) on the blur event for these input types, which clears the active state in this case. The test uses test_driver.Actions(), which isn't supported by the layout test runner but works just fine in the separate wpt runner in the wpt github repo. I wrote the test and verified that it works well with the separate wpt test runner, then wrote a TestExpectations line against the bug to track the issue with the layout test runner: crbug.com/893480 Fixed: 1157510 Change-Id: I13a0900277dbfccc87ba81ffd684b12430665e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594107Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#837867}
-
Yuta Hijikata authored
This is a mechanical change that renames deprecated macro replacing: - BUILDFLAG(IS_{ASH,LACROS}) with BUILDFLAG(IS_CHROMEOS_{ASH,LACROS}), - gn var is_{ash,lacros} with is_chromeos_{ash,lacros}. There is a section about the renaming on http://go/lacros-macros. Bug: 1052397 Tbr: sky@chromium.org Change-Id: I96abf99580c0c4e9d657ee91ac768f4875ea6080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592580 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#837866}
-
Zhiyuan Cai authored
This change adds test for PriceWelcomeMessageCard component, including https://chromium-review.googlesource.com/c/chromium/src/+/2556657 and https://chromium-review.googlesource.com/c/chromium/src/+/2575579. Bug: 1148020 Change-Id: Ica16dac79569e241d850dc0ee79c613fc212ece8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581694 Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837865}
-
Wei Lee authored
Currently the path to send broadcast when capturing only works on SWA. Since we are about to deprecate the platform app version of CCA, it is okay to only support this function on SWA but not platform app. Bug: b/173559007 Test: Manually Change-Id: Id33b6a88c4adafaf5725c5bd874b3d80166b9012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592295 Auto-Submit: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#837864}
-
Brian Sheedy authored
Removes expectations for the context_lost suite that have been determined to be stale. This only touches expectations that have passed 100% of the time on all builders. Bug: 603329, 965268, 1034008, 1155766 Change-Id: I18cbf44cff542eabf5fc40a4f716af2f04f6a1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591969Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#837863}
-
Curtis McMullan authored
This CL adds the required proto operations to request and return suggestion candidates to the IME shared library. Bug: 1146266 Change-Id: Ie3636e7ef9abf546c2e0ec5c11a8b47cd865f8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583669 Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837862}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6bf9e131d05a..0da7da798b33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I91e0dff097d0b00f948700e88a9e5b2b5a970393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595238Reviewed-by:
-
Koji Ishii authored
Following up a review comment in r837819 crrev.com/c/2589576 that was made after it was landed. Bug: 1154531 Change-Id: Ib2d6529646be5d4287317fd00bcd193ad10c22c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595750 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#837860}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/632a23afa487..ba158b9daf08 2020-12-16 bungeman@google.com Remove SkScalerContext::getGlyphCount. 2020-12-16 johnstiles@google.com Pass a shared_ptr to Inliner::inlineCall. 2020-12-16 reed@google.com Add filtermode to drawnine 2020-12-16 bsalomon@google.com Make backend allocation tests avoid alphatype conversions 2020-12-16 djsollen@google.com Revert "Rename getTopDevice/getDevice to topDevice/baseDevice" 2020-12-16 egdaniel@google.com GrVkRenderPass supports resolve attachments and discardable msaa. 2020-12-16 kjlubick@google.com [canvaskit] Expose sampling variants of drawImage and drawImageRect 2020-12-16 ethannicholas@google.com Tightened up SPIR-V block output 2020-12-16 bsalomon@google.com Add GrSurfaceFillContext 2020-12-16 johnstiles@google.com Improve inliner variable name mangling. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Ifba67091b56f8b9fe563e729d2e8b9d81110f6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596381Reviewed-by:
-
Sean Gilhuly authored
deqp/functional/gles3/fbodepthbuffer.html deqp/functional/gles3/fborender/resize_03.html deqp/functional/gles3/fborender/recreate_color_00.html deqp/functional/gles3/fborender/recreate_color_01.html deqp/functional/gles3/fborender/recreate_color_04.html deqp/functional/gles3/fborender/recreate_color_05.html Bug: 1159539 Change-Id: I6fb6dc758fa7e1d4a995cbe58e52d9e0cb7f1da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595451 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#837858}
-
Mason Freed authored
The flake portal seems to indicate that these tests are no longer flaky. I'm going to re-enable them, and see if any revert to flaky. Fixed: 1043488 Change-Id: Icaa2c004a96abad5c217486a35d81117c9fb379d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594321 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#837857}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I000c8b21503db04762a8f08bc02c9339bb42a63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596380Reviewed-by:
-
David Black authored
The placeholder text needs to be updated and a chip added which allows the user to navigate to the Files app. Note that the UX spec has not yet been delivered so font sizes, spacing, etc. are subject to change. Also note that the Files app icon still needs to be plugged in. This CL also fixes some focus rings which were incorrectly colored. Screenshot: http://shortn/_0FB67SM4PA Bug: 1159527 Change-Id: I88e1e7cbc90178f558d2d3490bbd10a358f72c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596218 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837855}
-
Yue Zhang authored
Screenshot with fake data: https://drive.google.com/file/d/1X1Pwho3xM_lyHQ6zO24XcGtuG2lbnAy-/view?usp=sharing&resourcekey=0-1esda1N3RkpWE_rTqZyuDg Bug: 1157892 Change-Id: Ib3a6cb5d1cef705377d39d3e4b1fbd08df994d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589364 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837854}
-
Xianzhu Wang authored
When mobile viewport is enabled, we have two viewports: the visual (inner) viewport and the layout (outer) viewport. The clip of the visible viewport is not in the paint property tree, so we need to apply the clip separately. The clip was mistakenly removed in crrev.com/824480. Also fix a bug before crrev.com/824480: the current scroll offset of the visual viewport was not considered when applying the visual viewport clip, which caused invisible shifts reported and visible shifts not reported. Bug: 1141739 Change-Id: I425718b1fdfb2689a7f2948c561101d0b476eb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593180 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#837853}
-
Greg Thompson authored
FilePathWatcherKQueue::Watch uses a FileDescriptorWatcher, which requires that its callers handle spurious runs of callbacks after the watch is cancelled. If this speculative fix resolves the crash, a follow-on CL will revise the FileDescriptorWatcher documentation to make this case explicit. BUG=1156603 R=fdoray@chromium.org Change-Id: I7d5da3fb4e58cf30efab21963908b3ff41e9dc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593379 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I18c19719e133d5c770c98cd52544e084784a3905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596419Reviewed-by:
-
