- 16 Jul, 2020 40 commits
-
-
Greg Thompson authored
This CL includes: - Some gentle style updates. - Explicit extraction of only one file. - Use of SetFileInformationByHandle to set the creation time and attributes of the output file before closing it rather than use of SetFileTime and SetFileAttributes after the fact. This avoids potential filesystem races. - Removal of some dead code. BUG=None Change-Id: Iaa27f6951a96fc5cec55fa9b0cd8505f48f2515e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303710 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#789255}
-
Yuke Liao authored
This CL adds functions to download the latest or any given version of ash-chrome. Bug: 1104318 Change-Id: I32da0de5d590586a4c47f55c93fc004e00ce70af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302931 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789254}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9b7d8ae2b062e8f030c01ab8d6b1024c1cd348aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303105 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789253}
-
Chris Lu authored
Adds a config for the FullscreenControllerBrowserScoped flag. Bug: 790886 Change-Id: Ibbb765e6d7affa49bde4afc8effefdce48da94a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299236Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#789252}
-
Sophey Dong authored
Screencast: http://dr/file/d/1eBuaixYJ1kbutQBpT4bCTlyjHY66OeLP/view Screenshots: http://screen/PebTHg6AOTm, http://screen/2SoE6iSFJ3a Finch param command line test flags: -enable-features="SharingQRCodeGenerator<MyStudy" --force-fieldtrials=MyStudy/Group1 --force-fieldtrial-params=MyStudy.Group1:max_url_length/300 Bug: 1105139 Change-Id: I3277f02ac35bcb94d998c8a7c37b1becc26eee79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299462Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#789251}
-
Ravjit Singh Uppal authored
Bug: 995969 Change-Id: Ib89e52839557ee11d92141575e3fa77d68b3ed24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292295Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#789250}
-
Xianzhu Wang authored
This is a part of the work of removing from DisplayItemClient::VisualRect(). Now we calculate visual rect for display items during paint. For most SVG objects, the visual rect is simply EnclosingIntRect(object.VisualRectInLocalSVGCoordinates()) (not including outlines). Bug: 1104064 Change-Id: If72e66238585c17c48fda21a80060c24029b25f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301206Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789249}
-
Anastasia Helfinstein authored
When a window is resized, a locationChanged event is not fired on its descendants (e.g. the maximize button, the web contents). So Switch Access' locationChanged handler should listen to events on all of the current node's ancestors as well. Also adds support for listening to multiple nodes with RepeatedEventListener. AX-Relnotes: n/a. Bug: 1105296 Change-Id: Idba74866ef71fa0adebb1e08647a860404afb43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300825Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#789248}
-
Xianzhu Wang authored
Change-Id: I7230bd37e7f9c1c136e1c23b6acdc340eb089121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303452Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789247}
-
Stephen Chenney authored
We are starting up new experiments with Paint Holding and need these histograms to continue. Bug: 1104961 Change-Id: I6683260b5459c7b2cbe83a2aa7f6669af1a304ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300933 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#789246}
-
Sahel Sharify authored
Flake portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTgsSBUZsYWtlIkNjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFRhYk1hbmFnZXJUZXN0LkRpc2NhcmRUYWJzV2l0aE9jY2x1ZGVkV2luZG93DA TBR=fdoray@chromium.org Bug: 1106485 Change-Id: Iee3f1a06c3819e0bdb29e89d38534913d80761a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303769Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789245}
-
Mohammad Refaat authored
One of the tests used to disable the ability to proceed to the web page via an experiment preference (testProceedAlwaysDisabled) wasn't cleaned up after the test is done. Instead add cleanup and set the preference to default in setup. Bug: 1106070 Change-Id: I57d2a378491f84281bbede147089aa88c98ca8ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300823 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#789244}
-
Roman Sorokin authored
Fixed: 1105085 Change-Id: Id39e2ecdf4f2196c78c84b85bf6c0ab7ff051f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299345Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789243}
-
Evan Stade authored
Make sure that an invalidated dialog doesn't call AppModalDialogQueue::ShowNextDialog() during shutdown. This could potentially cause issues as it causes ShowNextDialog to be reentrant, which doesn't seem intentional. Also remove an unnecessary check: the active dialog is not in the dialog queue so we don't need to check the queue against the active dialog when hiding a batch of dialogs. Bug: 1060986 Change-Id: I962a5cf14c3f5b67d287de61464b604dbe96aaf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295822 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#789242}
-
Sinan Sahin authored
Currently, the vertical and a11y tab switchers observe the browser controls even if they aren't visible. This affects the rendering performance for the tabs. The fix is to add/remove the observer when the layout shows/hides. Bug: 1105601 Change-Id: I60fd18fdeebf3d281ab95146a16c99ff8c5acde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300986Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#789241}
-
Kartik Hegde authored
Validate the communication between NetworkDiagnosticsImpl and the routines. BUG=chromium:1096551 TEST=unit_tests --gtest_filter=NetworkDiagnosticsImplTest.* Change-Id: Id0868b88791e4b3fe9ec18b6257b68ef64ed41b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274149 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#789240}
-
Alan Screen authored
Printing from within the context of a pepper plugin for a Flash object started crashing once the print composite usage stopped the inefficient practice of generating metafiles for both individual pages and the full document, in r751614. Even though this issue of printing a Flash object is not of much interest because of Flash being near end-of-life, we can at least not crash the tab on users who happen to invoke such a print. This restores ability of print preview to complete and provide page images, although the content of the Flash object is empty. This at least matches the behavior prior to r751614. Bug: 1098860 Change-Id: I86f7030ade0f126d6994b810f26775bf8cfe2693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298036Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789239}
-
Pete Williamson authored
Some switches treat offline pages differently depending on the namespace. The proper namespace should be NTP_SUGGESTIONS_NAMESPACE. Bug: 1099057 Change-Id: I83b6e0dfa73d4601c831a534e8e47d2643b44f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297529 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#789238}
-
adamta authored
Removes default section inset on the NTP for the section that contains the Discover feed. Was preventing users from tapping the 3 dot menu on cards. Bug: 1085419 Change-Id: I24b9010aa847f3d24104165ba6f3ef0b00dbb081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300201Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594814211-6e9c837aecb05743d0a6513baf4c13c15785a909.profdata to chrome-win64-master-1594878809-f70bebc20790ac0846ac45f570a81eb656b74862.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I11f05a0c62bb25bb671fdc3a5eb2a5d38bf3b80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302089Reviewed-by:
-
Megan Jablonski authored
Also update Translate subframe histogram owner from dougarnett to sclittle. Bug: 1105002 Change-Id: I8647c4dfb511c66f27fc3a35c95e96fca07976de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300405Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
-
Sophie Chang authored
Bug: 1106448 Change-Id: Iffdcda8a392ee50b24ac482dfa437363ddbab7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302922Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789234}
-
Adrian Taylor authored
Sheriffbot sets M-<current stable milestone> for Security_Impact-Stable, Security_Severity-{High,Critical}... but only if the M- is not already set. This is the desirable pattern: * Sheriff sets something to Security_Severity-High and Security_Impact-Stable * Sheriff does not set M- label * Sheriffbot sets it to the current stable milestone (e.g. M-84) * Later, when it's fixed, Sheriffbot adds merge requests to 84, and we ship it in the next security fix. We sometimes see this pattern: * Sheriff sets something to Security_Severity-High and Security_Impact-Stable * They also set the M- tag, but set it to the next stable milestone * Sheriffbot therefore does not set a M- label * Later when it's fixed, Sheriffbot does not add merge-requests to 84. * We don't ship the fix as soon as we should. This change calls out that the main sheriff labelling responsibility is Impact and Severity, and most other things are set downstream by Sheriffbot. Change-Id: Ie8d518dfa9230599f6f941de219e43382b991369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302739Reviewed-by:Max Moroz <mmoroz@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#789233}
-
Abigail Klein authored
Add a button to expand and collapse the caption bubble from 2 lines of text to 8 lines. The spec for this is in go/chrome-live-caption-ux. Once a bubble is expanded, it stays expanded for the duration of its lifetime (or until it is collapsed). It remains expanded on new tabs in the same window, or when a tab is refreshed. The bubble has the following make-up: Caption Bubble: Box layout, Vertical orientation, End cross-aligned Close Button Content Container: Flex layout, Vertical orientation, Stretch aligned Wait Text Label Error Message: Box layout, Horizontal orientation Error Icon Error Text Expand Button Collapse Button Screenshots: Collapsed state: https://screenshot.googleplex.com/RPSwG1R5n5H Expanded state: https://screenshot.googleplex.com/MPVExFxsum8 Bug: 1055150 Change-Id: Icb9d81bd68cc4a657e3241662ce5d90f3b63aadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284284Reviewed-by:Dana Fried <dfried@chromium.org> Reviewed-by:
-
Oleh Lamzin authored
Migrate message pipe browser tests from MediaApp. Bug: b:159927590 Change-Id: Icc3d4d759bce94a739a6fe0b56c85129c5b58b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282597 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#789231}
-
Justin DeWitt authored
No-Try: true Change-Id: Ib269d60dcb6daf7de927a306f0f8b19671df3aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302940Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/71892ba52d17..19856e664354 2020-07-16 bsheedy@chromium.org [Telemetry] Capture CrOS logs as artifacts 2020-07-16 cduvall@chromium.org Reland "Set WebView implementation for any WebView APK" 2020-07-16 awdavies@google.com [telemetry][fuchsia] dev_finder -> device-finder 2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1102653,chromium:1105096 Tbr: oysteine@google.com Change-Id: Ib789224ef2741feedfe3d279e082f8b0c09f4669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303040Reviewed-by:
-
Brian Sheedy authored
Rolls the goldctl CIPD revision to pick up the newest version. This is so that the service account used by tests will no longer need read permissions for the GCS bucket that images are uploaded to, which will prevent it from potentially leaking internal image data in the future when internal results exists. TBR=ynovikov@chromium.org Bug: 1077274 Change-Id: Ib8d231905a684a7891a145dcce911fae46909383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303357Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#789228}
-
Sean Harrison authored
Continuing work on desktop privacy settings, extending histogram expiry dates accordingly. Bug: 1032584 Change-Id: I3f8ba2806b84c1d3307e09e1255b530d29aa9938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303389Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#789227}
-
Matt Menke authored
We're still only allowing one push per URL and cancelling push requests when the NIK doesn't match, which leaks data across NIKs. I'll fix those in followups. Bug: 1105544 Change-Id: Ica297f93071d2d72744750db68b727ac340d8719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302916Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#789226}
-
Theresa Wellington authored
Bug: 1105831 Change-Id: Ic433031ce79b7eb837bbc6599f5a098760006704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299470Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#789225}
-
Clark DuVall authored
This conversion should have no functional change. Note: I will convert base::Bind calls to base::BindOnce all at once once all the uses of Callback and Closure are converted in //chromeos/network. Bug: 1007660 Change-Id: Idd9e92559fcb7adce3104269ee0014c7b7863aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289191Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Xinan Cheng authored
Previously FuchsiaAudioRenderer dependent on FuchsiaMediaResourceProvider, but not all clients will use it. Bug: b/149863069 Change-Id: I7a8c46c7acdfa6a90674d23b25fb50fe5d8a7437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293467Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Xinan Cheng <xinan@google.com> Cr-Commit-Position: refs/heads/master@{#789223}
-
Clark DuVall authored
This conversion should have no functional change. Note: I will convert base::Bind calls to base::BindOnce all at once once all the uses of Callback and Closure are converted in //chromeos/network. Bug: 1007660 Change-Id: Id38c76057055ffb3eac02f31c37763928e98e6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289086 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Henrique Nakashima authored
Make the centering force strong for filtered classes, average for 1st level dependencies, and weak for 2nd+ level dependencies. Bug: 1106108 Change-Id: Iad51bec900e150a13161a9d7a86f8ead721b713e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301041 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#789221}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I7729c3b94f12daee7d80483bb881c18aff1b11ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303099Reviewed-by:
-
Sahel Sharify authored
Flake portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFVuaWZpZWRBdXRvcGxheVNldHRpbmdCcm93c2VyVGVzdC5EZWZhdWx0QWxsb3cM TBR=sergeyu@chromium.org Bug: 1101524 Change-Id: I81a5e4e4f8c175c88cda9be3e80285c790ab8c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303124Reviewed-by:
-
Stephen Roe authored
Build times, stability, and capacity look good in a 100% CQ experiment run from 2020-07-09 through 2020-07-15. Pending times for the fuchsia arm64 100 %CQ bot are similar to the existing fuchsia x64 trybot: builder fuchsia_arm64 fuchsia_x64 tasks 48025 60618 pending_seconds_p90 2 4 pending_seconds_p95 6 10 pending_seconds_p99 238 175 Build times for the fuchsia arm64 100% CQ experiment are similar to the existing fuchsia x64 trybot: builder fuchsia_arm64 fuchsia_x64 builds 2579 2607 build_minutes_p50 28.88 30.60 build_minutes_p70 47.63 48.45 build_minutes_p90 57.88 58.72 Stability is good at 100%: https://ci.chromium.org/p/chromium/builders/try/fuchsia_arm64 Capacity is good at 100%. The average number of bots running varies from 40 to 54 over weekdays out of 240 bots. There are spikes from 180 to 240 bots when multiple CL builds overlap. Bot usage percentages for the 54-bot weekday are p50 46 bots p90 105 bots p99 169 bots out of 240 bots Pending time data is from: https://docs.google.com/spreadsheets/d/1UFZCo52fm5ysfFzrK0OC3SMaAnRCOVWBlJzpakxVmc8 Build time data is from: https://docs.google.com/spreadsheets/d/18xUnQqVuWrIxenEsRZBJYpi94kr6ICaQcrdw04ezWl4 Capacity and bot loading data is from: https://docs.google.com/spreadsheets/d/1F04LjQf11s-itlgsAQg3J57I8mjWMSE_h-2bt8ABSb4 Bug: 1042511 Change-Id: I12f2213fa43dd0b3d10d1306b1ae252034285798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303359Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#789218}
-
Torne (Richard Coles) authored
Add the SDK 30 packages to android-sdk-packager. Bug: 1106471 Change-Id: I2819109ac43e7dafeb36fea015fcf6f651a57b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303550Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789217}
-
Maxime Charland authored
The new Bookmarks empty state, when inside empty folders, will be implemented by TableViewIllustrated. Bookmarks will take care of creating and keeping a reference to its own TableViewEmptyView instead of using ChromeTableViewController's helper functions because the view's insets will need to be tweaked by the view on the root level when the Sign in promo is visible. This particularity will be visible in a future CL. (Googlers only links) Screenshot: https://drive.google.com/file/d/1ji5vMJpt_qEd7VWJMpayuw59zLBokrDx/view?usp=sharing Design Doc for Chrome Empties: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing Mocks of the new Chrome Empties look: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: I704aeebb60717c061f610614dbf8a86f199091f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293219 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#789216}
-
