- 25 May, 2018 40 commits
-
-
Alex Newcomer authored
Put touchable app context menus and notification indicators under two different flags. The notification indicator flag will also control the notifications in context menu feature. These features are still very related, but the ability to enable them selectively is desirable for dogfooding. Bug: 845316 Change-Id: Id30715dae05fe50c7d4eed9a462df13ccd1cec6c Reviewed-on: https://chromium-review.googlesource.com/1068149Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#562048}
-
Christopher Cameron authored
Resize the ui::Compositor's size in BrowserCompositorMac's SynchronizeVisualProperties method. Re-disable using a unified ui::Compositor (it was accidentally enabled by a botched merge). Bug: 840173 Change-Id: I701574e385ae288b991adce81e1ab5efde23e0c2 Reviewed-on: https://chromium-review.googlesource.com/1073682Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#562047}
-
Wez authored
Use of QuitCurrent*Deprecated() is ambiguous, since RunLoops can be nested, and so is unsafe to use in general. TBR: bartfab Bug: 845966, 844016, 749312 Change-Id: I537862ea02c4ed67887db32993f40e53f614b3cd Reviewed-on: https://chromium-review.googlesource.com/1019967Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#562046}
-
Tom Sepez authored
This particular stat() variant was not being handled in the same way as the others. Bug: 846800 Change-Id: I2ec9b94f704f9f00aa3dd1dbd0a3be71a0583b75 Reviewed-on: https://chromium-review.googlesource.com/1073869Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#562045}
-
Iker Jamardo authored
Improves the support for requestSession in WebXR mainly focused on allowing ARCoreDevice to receive a call when the session request is made. Also adds a check to both supportSession and requestSession to ensure the device supports AR capabilities when the hit-test flag is enabled. Bug: 835037 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I8090f64a981114b130e446025ec6299fbb5619e4 Reviewed-on: https://chromium-review.googlesource.com/1046107 Commit-Queue: Iker Jamardo <ijamardo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#562044}
-
Dominic Mazzoni authored
Speculative revert, see build failures on Win10 Tests x64 (dbg): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/803 Bug: http://crbug.com/846837 This reverts commit 983e926b. Reason for revert: <INSERT REASONING HERE> Original change's description: > Re-land: Avoid serializing the same accessibility node twice in the same message > > Originally landed: r560165, crrev.com/c/1063007 > Reverted: r561246, crrev.com/c/1069891 > > TBR=dtseng@chromium.org > Bug: 651614, 845778 > > Change-Id: I77b54de28cb0c4a231b5b0758ba4708100d27fff > Reviewed-on: https://chromium-review.googlesource.com/1072875 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561913} TBR=dmazzoni@chromium.org,dtseng@chromium.org Change-Id: I5cbf8006e4917a9c008143ae4b746543d2b038c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 651614, 845778, 846837 Reviewed-on: https://chromium-review.googlesource.com/1074050Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#562043}
-
Reid Kleckner authored
This works around a bug (https://llvm.org/pr37592) in LLD, where if foo.lib appears on the link line without -wholearchive:, it doesn't take effect. Instead, only pass the -wholearchive:foo.lib flag, which adds the library as an input and turns on the wholearchive behavior that we need. Fixes base_unittests StackSamplingProfilerTest.OtherLibrary and related tests, which were failing because chrome.exe was missing an exported function. Remove the /include flag workaround for https://crbug.com/777087. BUG=777087,844398 R=mmoroz@chromium.org Change-Id: I493e1dcf6963048f7e83df1c937b4a4a62dd96bb Reviewed-on: https://chromium-review.googlesource.com/1073890Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#562042}
-
Yuwei Huang authored
This CL unconditionally enables the fullscreen exit UI as we get all approvals on the launch bug. Bug: 829606 Change-Id: Ia8dd65b0946999d5cba9d897f068f4c9858ff163 Reviewed-on: https://chromium-review.googlesource.com/1073625Reviewed-by:
-
James Cook authored
This saves 140 KB of chrome binary size on 64-bit Intel. Previously for --enable-features=Mus we were running the window service on a background thread in the browser process, so it was slightly more efficient to use lazy serialization for mojo calls. We have eliminated the "Mus" config and with ws2 the window service mojo implementations will be directly implemented in the "ash" service/process. All mojo calls will be cross-process, so there's no advantage to using lazy serialization. This is a revert of: https://chromium-review.googlesource.com/c/chromium/src/+/849657 Bug: 798800, 799072 Test: bots Change-Id: I3f1ffe0e598e6bee7d3a54f41ffbbce23fd592e6 Reviewed-on: https://chromium-review.googlesource.com/1072460Reviewed-by:
-
Nate Fischer authored
No change to logic. This adds startup traces to track how long it takes to invoke the constructors of AwContentsClient and AwContentsClientCallbackHelper. These are both called as part of the work for instantiating the WebViewContentsClientAdapter. Bug: 838702 Test: N/A Change-Id: Id04cde3f65d18522893c1bc82621a0740242962b Reviewed-on: https://chromium-review.googlesource.com/1073915 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#562039}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d0a7d10f397d..1478afaf119e $ git log d0a7d10f3..1478afaf1 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 lfy GLES1: Lighting and materials (renderer) 2018-05-17 lfy Reland "GLES1: Entry points for lighting and materials" Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: Iec45f84d4ffead93ac64f0d61deacf72c753faee Reviewed-on: https://chromium-review.googlesource.com/1073667 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562038}
-
danakj authored
The "cc" traces in the component become "viz". The "cc.debug.overdraw" becomes "viz.overdraw". The "cc.debug.triangles" becomes "viz.triangles". The "cc.debug.quads" becomes "viz.quads". There is one instance of this in cc/ as well, but renamed it to be consistent. The idea is to trace quads that arrive in viz and include the quads from the cc origin, so I *think* this makes sense. R=weiliangc@chromium.org Bug: 751814 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6b25ac8e86ffe8a2bbefc0824929e96eb12be104 Reviewed-on: https://chromium-review.googlesource.com/1073889Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#562037}
-
Matthew Jones authored
This is a reland of b422141f Original change's description: > Clean up scrim logic in LocationBarLayout > > Scrim visibility in the location bar is now completely controlled by > a single function. The scrim observer is now added and removed based > on the scrim visibility to avoid conflict with other observers (like > the bottom sheet). > > Bug: 834927 > Change-Id: I172ca637dde5bc026b1b7f629bc34c6d939dff2d > Reviewed-on: https://chromium-review.googlesource.com/1026168 > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558785} Bug: 834927 Change-Id: I8c5d5a93574024f8f5783e71d0db29e76dc4acab Reviewed-on: https://chromium-review.googlesource.com/1073490Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#562036}
-
Ryan Tseng authored
To easily visualize the green luci builders. Bug: 840631 Change-Id: Ic06e92870f7a169a8a720140fa3ab0615e92672c Reviewed-on: https://chromium-review.googlesource.com/1073962Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#562035}
-
Jennifer Apacible authored
This change adds support for tabbing through the controls in the window. Previously, the user can only utilise mouse clicks to interact with the controls. ControlButton will likely be updated to accommodate the addition of a non-constant number of custom actions in the future. UI affordances for the currently focused control will be added in a separate patch. BUG: 836389 Change-Id: Ic25524cfab9ceeba1d17ef00975347f6e3d562e6 Reviewed-on: https://chromium-review.googlesource.com/1072516 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#562034}
-
Carlos Knippschild authored
This fixes the presentation of this histogram in the UMA dashboards where it currently shows as representing a numeric value. Bug: 794828 Change-Id: I549d7460440435861cb4364f303845cfcac5d2e0 Reviewed-on: https://chromium-review.googlesource.com/1072712Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#562033}
-
Luna Lu authored
UseCounter now checks if a page is an ordinary page when it logs usage. This means all UseCounter realted unit tests need to use a dummy page holder that is added to ordinary pages. Previously a dummy page holder is added to ordinary pages upon construction, which is not ideal. This CL only explicitly add a dummy page holder to ordinary pages when needed. Change-Id: I7b48d894a546849797e656e66cad13cc58b20635 Reviewed-on: https://chromium-review.googlesource.com/1070670 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#562032}
-
Kristian H. Kristensen authored
We need to allocate the native pixmap for the unittest using the SCANOUT_VDA_WRITE usage flag like we do in Chrome so we get the right tiling. Bug: 845076 Test: video_decode_accelerator_unittest passes Change-Id: I877bf94e6f7f90c14973be76c1f53d841aed4305 Reviewed-on: https://chromium-review.googlesource.com/1072638Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#562031}
-
Xiaocheng Hu authored
If an NGPhysicalTextFragment is created from first-letter, its GetNode() method returns nullptr, which leads to false negative when hit-testing on this fragment. This patch adds a new method to obtain the text node for first- letter fragments, and applies it in hit test code, so that we can correctly obtain the text node when hit-testing the first letter. Bug: 811502 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I70e5cd4948f248a6e51e3a1732273779ef36509c Reviewed-on: https://chromium-review.googlesource.com/1072691 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#562030}
-
Nicolas Pena authored
Bug: 836310 Change-Id: Ib2d8796129e34c22c922e21b492e474130ea4420 Reviewed-on: https://chromium-review.googlesource.com/1057434 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#562029}
-
Ryan Tseng authored
This adds max_concurrent_invocations on a per-builder basis for chromium.lkgr builders. Bug: 840631 Change-Id: Id45281695c35b7d0f1549183ac5e72fd8e5ae957 Reviewed-on: https://chromium-review.googlesource.com/1073925Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 794289 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If1ed00732e07bd0f9b3bdf2cf97cd257d8054f8e Reviewed-on: https://chromium-review.googlesource.com/1069793Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#562027}
-
Aga Wronska authored
This is a new User Policy that is used to determine if Sync Consent should be displayed for the user during login. TBR=atwilson@chroumium.org Bug: 841156 Change-Id: Ibf5e0bdbe7a1037b6c2760032901e3cbe1924146 Reviewed-on: https://chromium-review.googlesource.com/1073623 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#562026}
-
Michael Spang authored
This adds the missing override of viz::OutputSurface::UpdateGpuFence to content::VulkanBrowserCompositorOutputSurface. Bug: none Test: compile Change-Id: I8dc0c40d98c16f4bb85c404b51f654f90bce47ca Reviewed-on: https://chromium-review.googlesource.com/1073063Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#562025}
-
Eugene But authored
This optional method is not implemented by native content classes. Bug: 725239 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I70bb3e0e308762bd90c354769eccd1cc2616ed73 Reviewed-on: https://chromium-review.googlesource.com/1073676Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#562024}
-
Sergey Abbakumov authored
With these gn args: is_clang = false target_cpu = "x64" the file fails to compile due to uint64 -> uint32_t conversion. Change-Id: I76126e6d170f01eedcccfd3a17f6aa4184753fe9 Reviewed-on: https://chromium-review.googlesource.com/1071287Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#562023}
-
Charlie Harrison authored
This CL: 1. Stops null-checking the WebContents when considering to block popups. All callers pass in a valid contents already. 2. Tests the case when a caller calls ShowBlockedPopup with an invalid id. This seemed like a more reasonable API to be defensive with, but it wasn't tested. Bug: None Change-Id: I3913ed540b06f57e7fd31cae1f7da7de4da37dab Reviewed-on: https://chromium-review.googlesource.com/1073847Reviewed-by:
-
Steve Kobes authored
Bug: 823365 Change-Id: I847384bf51dfe78dcb772afde72d7d19c876b44b Reviewed-on: https://chromium-review.googlesource.com/1073659Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#562021}
-
Sadrul Habib Chowdhury authored
Remove FrameTokenAllocator since it is no longer needed or used. BUG=811961 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I760a1dcaf220dd13d8b4ac448de911ec46acf593 Reviewed-on: https://chromium-review.googlesource.com/1073081Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#562020}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0ceb1eccef76..393b0fd9c739 $ git log 0ceb1ecce..393b0fd9c --date=short --no-merges --format='%ad %ae %s' 2018-05-23 wangxianzhu [Tracing UI] Use ResizeObserver for picture chart resizing Created with: roll-dep src/third_party/catapult BUG=chromium:842238 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1a64cd37f4324f1a7e07e206129016c8dca424c0 Reviewed-on: https://chromium-review.googlesource.com/1073644 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562019}
-
wutao authored
This cl adds the support to toggle the shortcut view by the same shortcut: Ctrl + Alt + /: 1. If the KSH window is active, close it. 2. Otherwise, open it (if it's not open already) or activate it (if it's open but not active). Bug: 819815 Test: New unit test KeyboardShortcutViewTest.ToggleWindow Change-Id: Icbc9fba5644208750d1632b7473c66f53b923a80 Reviewed-on: https://chromium-review.googlesource.com/1073101Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#562018}
-
erikchen authored
This CL is a refactor with no intended behavior change. This CL: * Removes the mojom interface ClientProcesss::EnableHeapProfiling. * Removes the implementation, primarily hosted in MemoryDumpManager. Change-Id: Id55835da60d86520f692385930208a31206f7dce Bug: 822843 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1069000Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562017}
-
James Cook authored
We removed ash::Config::MUS as part of the switch to //services/ui/ws2. ShellPortMus isn't used independently anymore. Bug: 841941 Test: ash_unittests --enable-features=Mash Change-Id: I506a0526aebd8b90f07d654ceaad8f90891106cb Reviewed-on: https://chromium-review.googlesource.com/1072454 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
Olivier Robin authored
When elements don't have scope, setting the model value throws an undefined element exceptions, causing autofill to fail. Test existence of scope before updating model. Bug: 846730 Change-Id: Ia1119604252829d2012bfc728de297607aa92883 Reviewed-on: https://chromium-review.googlesource.com/1072473Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#562015}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/710fa99b0bd2..d4d645abecec $ git log 710fa99b0..d4d645abe --date=short --no-merges --format='%ad %ae %s' 2018-05-25 rharrison Reserve space for code words when creating encoder context Created with: roll-dep src/third_party/pdfium BUG=chromium:846027 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I26d090f4a72bd512979b45a7799106a90ad1cc68 Reviewed-on: https://chromium-review.googlesource.com/1073680 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562014}
-
Matt Reynolds authored
The W3C Gamepad spec says that gamepad timestamps should be returned as DOMHighResTimeStamps relative to the navigationStart attribute of the PerformanceTiming interface. This CL modifies the internal Gamepad buffer to store the timestamp as a 64-bit signed integer count of milliseconds since the base::TimeTicks origin. When returning the value to the page, the value is converted to a DOMHighResTimeStamp relative to navigationStart. Additionally, all gamepad data fetchers are modified to set the last-update timestamp using the base::TimeTicks clock. This is a reland of commit: 2464a382 The first attempt broke OculusGamepadDataFetcher and was reverted: https://chromium.googlesource.com/chromium/src/+/fb0674220c41322d99ba8a08347356af20061bbd BUG=398642 Change-Id: I1a77881be388d91131443d93e22395e3f5a78363 Reviewed-on: https://chromium-review.googlesource.com/1070996Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#562013}
-
Weidong Guo authored
Background: New specs require that an item can be dragged to next page without having to fill up the current page. However, all items in launcher currently are laid out linearly and no gap is allowed between items. And the item's visual index (e.g. (i, j) means ith page and jth slot.) can be calculated by it’s model index (index of the item view in |view_model_|) via formula: visual_index.page = model_index / max_items_per_page visual_index.slot = model_index % max_items_per_page However, this formula does not work for new specs, so we need a new view structure to map from model index to visual index. Changes: 1. Add a view structure to represent the item view's structure we show to users. 2. Add functions to operate on the view structure: load, save, sanitize, move, remove, add, etc. 3. Create a new page if the user drag an item to the end of last page. 4. Put everything behind a home launcher flag because it is part of home launcher feature. Design doc: go/applist-gap BUG=837871 Change-Id: I9718bfca0ebf31da5a5d63aa73c4a6f1fb20459a Reviewed-on: https://chromium-review.googlesource.com/1058715 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
David Trainor authored
Restructure new download home code to pull out the list specific information from the DownloadManagerCoordinator. This will make it easier to separate the rest of the code (things like undo snackbars, etc.) from the list specifics, and allows us to just expose the list coordinator to keep the interfaces clean. Bug: 842345 Change-Id: Id2bf042f3e2af865ee741dfce18cd6427aea5b66 Reviewed-on: https://chromium-review.googlesource.com/1072152Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#562011}
-
Kevin Bailey authored
The tab switch button wasn't quite vertically centered in the GM2 style result view, and the icon was being clipped. This CL makes provisional size changes to make them fit. Bug: 780835 Change-Id: Ia72cb406088f50c2e22c0929e9e0acdb8d0db31e Reviewed-on: https://chromium-review.googlesource.com/1069569Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#562010}
-
Jennifer Apacible authored
Currently, resizing sometimes doesn't always adhere to the aspect ratio when the window also moves (origin point updates) alongside it. OnNativeWidgetMove() is called in these cases. With this change, if the sizes of the previous and new bounds are the same, the window was only moved rather than resized. This change will make OnNativeWidgetSizeChanged() handle the updates for |current_bounds_|. BUG: 829677 Change-Id: Id7df25c0a888efa4b2a7cad39cf83105aa03a759 Reviewed-on: https://chromium-review.googlesource.com/1071125Reviewed-by:
-
