- 02 Jan, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5abfe3af46e6..7af927e60755 git log 5abfe3af46e6..7af927e60755 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 mmortensen@google.com query_build_logs: Check/set prodaccess before dremel query 2020-01-02 engeg@google.com cbuildbot: add todo for branch release archive filename mismatch Created with: gclient setdep -r src/third_party/chromite@7af927e60755 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Iaaeefac0cf22b48285dcafccbdf180fc6c766b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728013}
-
Oriol Brufau authored
<img> elements are usually replaced, so they can't originate a ::marker pseudo-element even if they have 'display: list-item'. However, if they point to an invalid image and have an alternative text, then they are not replaced. Therefore they can have ::before and ::after pseudo-elements, and also a ::marker if they have 'display: list-item'. Before this patch, markers with 'content: normal' were never generated. And non-normal ones worked fine in the inside case, but when outside they triggerede a DCHECK failure because the marker was created but not laid out. BUG=1038644 TEST=external/wpt/css/css-pseudo/marker-content-017.html The test fails in legacy because the 'content' property is not supported yet in ::marker. Change-Id: I4420bc2e9a0460f3a59fa030e5e3d249428aa6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985759Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#728012}
-
Clark DuVall authored
This should not be in org.chromium.chrome.browser since it is part of components/content_settings. This will be needed to move chrome/browser/permissions into a component for WebLayer. Bug: 1025609 Change-Id: I828c7c11c8ae6786e0f91399c105a4871a44c600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981134 Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#728011}
-
John Abd-El-Malek authored
We weren't passing a profile name so it was always in-memory. I'm using this in a follow-up cl to force all downloads in weblayer_browsertests to go to this temp profile directory instead of filling up the default download folder. It also makes sense that WebLayer Android browser tests match desktop, and non-WebLayer as well. Bug: 1025603 Change-Id: I1f4fe20e77e6405b97365a9dfa30917fd1c5d486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984761Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#728010}
-
Andrew Grieve authored
Bug: 1036426 Change-Id: I44ca24f69b23169860ab115a6e4e7de720d67841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984799 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#728009}
-
Avery Musbach authored
Near the end of SplitViewHighlightView::OnWindowDraggingStateChanged, there is a DCHECK that the previous window dragging state is kNoDrag, when actually it is expected that the previous window dragging state also can be kOtherDisplay. I should have removed this DCHECK in https://chromium-review.googlesource.com/c/chromium/src/+/1977155 Bug: 961170 Change-Id: Ifdd27ae5e610f05e754c401e7805798df4a95098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981648Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#728008}
-
Brian Sheedy authored
Updates several VR goldens that were affected by a slight difference in antialiasing. TBR=alcooper@chromium.org Change-Id: I63dec08f93eea81cfa3e1c7eb0be7b90ea688e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985824Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728007}
-
Marijn Kruisselbrink authored
The file system provider API passed metadata back from the extensions without any kind of sanitization. This means that for example "valid" blobs with negative sizes could exist. We don't want to have to deal with these weird beasts on the blob size, so add some assertions to the blob code to make sure this doesn't happen, and sanitize negative sizes on the file system provider side before passing them back. This is part of a series of changes to improve consistency surrounding how snapshot state of files/blobs is implemented. Bug: 844874 Change-Id: Ie3dd1de9d49b071b615e969ec68529bf3074c875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976431Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#728006}
-
Bettina authored
For saved password reuse warning text, the domains are reordered based off of which are most commonly spoofed. Thus, the correct domain ranges should be used when bolding. Bug: 1038132 Change-Id: If7f372b3bd7b8f2aaf379f556dee5348f1441dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983352Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#728005}
-
Olivier Robin authored
NavigationManager can return -1 as the last committed index when back/ forwarding to a restored URL (even if IsRestoreSessionInProgress returns false). Accept -1 from navigation manager in that scenario. Also rename storage_has_navigation_items variable. Bug: 1035960 Tbr: eugenebut Change-Id: Ie3c126c76c884c91997303728265ee2b5572851f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985762 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#728004}
-
John Abd-El-Malek authored
Per the comments in BrowserTestBase, PreRunTestOnMainThread is meant to be inherited just by test harnesses. Change-Id: I8e3e0e20589219f4a1561ca194ea3d73c7378b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980983Reviewed-by:
-
Adithya Srinivasan authored
Changes browser side implementation to use last committed origin instead of receiving and checking an origin sent from the renderer. Bug: 1030892 Change-Id: I5a2c007b80bd1a0a71ac041efc046eb7b8a2317e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978998 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728002}
-
Daniel Libby authored
There are a few tests which call PageScheduler::EnableVirtualTime at the start of the test, then PageScheduler::DisableVirtualTimeForTesting at the end of the test, to reset state. Disabling virtual time currently does not reset the MainThreadSchedulerImpl's initial_virtual_time* fields. If a subsequent test then calls EnableVirtualTime, since the MainThreadScheduler is shared across tests, we can end up in a situation where the ThreadLoadTracker sees inconsistent timestamps and DCHECKs. This happens due to the fact that there is at least one task that runs and records timing between DisableVirtualTimeForTesting and EnableVirtualTime - the ExitRunLoop task from blink::test::RunPendingTasks, which is invoked from SimTest::TearDown. When the next test comes along and does EnableVirtualTime, the MainThreadSchedulerImpl sees that there was a previous initial_virtual_time and proceeds to apply the BaseTimeOverridePolicy::OVERRIDE policy to the AutoAdvancingVirtualTimeDomain along with a timestamp in the past. When the next task's timings are recorded by ThreadLoadTracker, it sees that time has gone backwards and we DCHECK. This change makes it such that the initial_virtual_time fields are reset when DisableVirtualTimeForTesting is called. This will cause them to be re-populated on the next test's call to EnableVirtualTime and time won't go backwards. Bug: 845197 Change-Id: I756949db2b4dbbdd1b7b2b35b92fab80a4b20d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984875Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728001}
-
Rune Lillesveen authored
If the flat tree children of a a slot is not up to date during DetachLayoutTree, they may contain nodes adopted into another document since the previous reassignment. Make sure we don't DetachLayoutTree for such nodes during when a flat tree ancestor is RemovedFromFlatTree. This bug is a regression for FlatTreeStyleRecalc since we used to traverse the tree for DetachLayoutTree in light tree order. This regressed with crrev.com/b225e2e7 Bug: 1035228 Change-Id: Ibd4c03dee855851c120eebf1010a9b127827f7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985839Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#728000}
-
behdad authored
Revert "Roll src/third_party/catapult c9e75ab1ff47..b3788f22c908 (1 commits)" This reverts commit 570f192d. Reason for revert: run_benchmark fails TBR=sadrul@chromium.org Bug: chromium:1038690 Original change's description: > Roll src/third_party/catapult c9e75ab1ff47..b3788f22c908 (1 commits) > > https://chromium.googlesource.com/catapult.git/+log/c9e75ab1ff47..b3788f22c908 > > git log c9e75ab1ff47..b3788f22c908 --date=short --first-parent --format='%ad %ae %s' > 2019-12-31 khokhlov@google.com Reland "Reland "[Telemetry] Make proto trace format the default"" > > Created with: > gclient setdep -r src/third_party/catapult@b3788f22c908 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/catapult-autoroll > Please CC rmhasan@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: chromium:1028612 > Tbr: rmhasan@google.com > Change-Id: Ifbffcda56802cd5b133a445bdfe9f552f34c898e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984905 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#727871} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,rmhasan@google.com Bug: chromium:1028612 Change-Id: I098e9df293c9f245ca664ffb15e3e3f2798afffa Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986025 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#727999}
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Change-Id: I9e4374144f3358e6b02d25bdb8a6ea034aedd13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976700 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727998}
-
David Bokan authored
This CL makes it so that the CC animated scroll path latches only in ScrollAnimatedBegin and prevents it from re-latching at all in ScrollAnimated. Since the targetted scrolling node can no longer change in ScrollAnimated it no longer needs to return any value so the signature of the method and some tests had to change. Bug: 1016229 Change-Id: I9b3609de3f22dd7859bece5bb121c7ea752779a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980984 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#727997}
-
Philipp Hancke authored
adds a test to assert that RTCPeerConnection.onconnectionstatechange is not fired when RTCPeerConnection.close() is called. BUG=699036,1023736 Change-Id: I623deeb4f0948cf213ff8913c33610ef0e7315e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959969Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#727996}
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: I2ac74aa8ee774ecf95a0a249b0aaab32abd46c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985767 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727995}
-
Harald Alvestrand authored
Spec link: https://w3c.github.io/webrtc-pc/#announcing-a-data-channel-as-closed Bug: chromium:1030631 Change-Id: I6634773bfc217883affb0a9ac4dafd8d271129d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978677Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#727994}
-
Rakesh Soma authored
serial number [1] in SaveAccountInfo is returning empty. [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/credential_provider/gaiacp/gem_device_details_manager.cc;l=81 Change-Id: I941cfe0afcd0130fcd972620780a2975bff8268e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981863Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#727993}
-
Caleb Rouleau authored
It is believed that this test suite is somehow causing the bot that it is run on to die the next time it gets run. Bug: 1036846 Change-Id: Ib18512cfe6636f7b879416ee617ec7b4642233e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984637 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727992}
-
Jan Scheffler authored
This cl reenables and fixes a test to refactor how Cookies are handled in devtools frontend. Cl with the actual changes: crrev.com/c/1959984 Cl disabling the test: crrev.com/c/1960350 Bug: chromium:1030258 Change-Id: I8f8bf9f4b0a6956dbbd019a5ced88fa2db066648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960279 Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#727991}
-
Manu Cornet authored
This is a pure cleanup with no expected behavior change. Change-Id: I843327b4881f3321de0a12f9aa391ef1bb15b4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978181Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#727990}
-
Michael van Ouwerkerk authored
Bug: 1030266 Change-Id: I08e3f59e0a3d03ce77b6f669e1cfa1a72fae2ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985760Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#727989}
-
Aaron Gable authored
This updates the windows build instructions to indicate that Visual Studio 2019 is the preferred VS IDE version, and to align with the default changing in https://gn-review.googlesource.com/c/gn/+/6900 Bug: 1038361 No-Try: true Change-Id: I2a9908f02d7a8dc42e94d330550035554968b4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984701 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#727988}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/bb8e777557dd..f71aaa0be84a $ git log bb8e77755..f71aaa0be --date=short --no-merges --format='%ad %ae %s' 2019-12-29 junyer Make DFA use hints. 2019-12-13 junyer std::is_pod<> was deprecated in C++20. 2019-12-09 junyer Simplify the bytecode for the 80-10FFFF rune range. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I47de205ccacde2054daf2b6b81cb09ccf4a1a375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983509Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#727987}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d81bc733ae0c..4ee635638fc1 git log d81bc733ae0c..4ee635638fc1 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 brianosman@google.com Add SkRuntimeEffect::makeColorFilter 2020-01-02 bsalomon@google.com Fix GrColorMatrixFragmentProcessor handling of premul transparent black. 2020-01-02 benjaminwagner@google.com Fix asan_device_setup path 2020-01-02 kjlubick@google.com [canvaskit] Update compile.sh with initial code size findings 2020-01-02 benjaminwagner@google.com [infra] Handle failure from addr2line 2020-01-02 bryct@amazon.com Add instructions for compiling CanvasKit and viewing example page. Created with: gclient setdep -r src/third_party/skia@4ee635638fc1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1024935 Tbr: nifong@google.com Change-Id: I36b756bcffbcc91673aaaaf37ffcfab809355f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985696Reviewed-by:
-
Rodney Ding authored
- plumbing ExecutionContext through various callsites to isWebExposed() - add stopgap override for cssPropertyID passing nullptr in place of actual ExecutionContext - Use nullptr in place of actual ExecutionContext for PropertySetStyleDeclaration constructor - Design doc https://docs.google.com/document/d/1Lc3U2WV38GZ3ShTAm3-p6fbZeGJGkxL-KZfWIQ-p8GU/edit?usp=sharing Bug: 775189 Change-Id: Ia4e1c5b1dd363bb7f5b22436c144eb709f867f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960472Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rodney Ding <rodneyding@google.com> Cr-Commit-Position: refs/heads/master@{#727985}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1f7eaa155d09..b0e11f6c807f git log 1f7eaa155d09..b0e11f6c807f --date=short --first-parent --format='%ad %ae %s' 2020-01-02 lalitm@google.com trace_processor: add Id wrapper type returned by Insert in all db tables Created with: gclient setdep -r src/third_party/perfetto@b0e11f6c807f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I629275b86e518c781a3d95ed482653761331c8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985697Reviewed-by:
-
Dave Tapuska authored
When a mouse wheel event was acked the two queues compared whether it matched an outstanding one it had. For more correctness and to avoid the comparison we can use callbacks. That way the correct consumer is notified when the event gets processed. This change is necessary to remove a compare on WebMouseWheelEvent. BUG=836826 Change-Id: I2985216b681e02799bea12a30162726915867b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979147Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Updating the expiration date from M81 to 2020-11-01. Bug: 1037293 Change-Id: I9b07d9a0fe4081342d7e48886c983f34a5d4c2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984303Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#727982}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ef86f4793da..45ab65a9bfcc git log 6ef86f4793da..45ab65a9bfcc --date=short --first-parent --format='%ad %ae %s' 2020-01-02 leese@chromium.org Add wasmparser library to front end 2020-01-02 leese@chromium.org Do not lint third party code Created with: gclient setdep -r src/third_party/devtools-frontend/src@45ab65a9bfcc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1013527 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7ebb0e3a7d5f84a1fffa615af61f39f0ecb4a054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985692Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/34b8e4d6..77faebf0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d64d2cac277064157f5d7c0953f567a30e2880f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985604Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727980}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99be05ca5b0b..79df1292b2aa Created with: gclient setdep -r src-internal@79df1292b2aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic47a6727d42c59f3d1d4f8b134308d696f6caa83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985694Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727979}
-
Gauthier Ambard authored
This CL resizes the frame of the NTP instead of adjusting its content inset. It allows the content of the NTP to not be displayed below the toolbar, avoid issues with VoiceOver reading the item behind it. It also allows to fix the content insets for the safe area. Fixed: 1034509, 1030422 Change-Id: I306ecf5b771fa3a7b0b88fb6d99425154695c6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969580Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727978}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5f454b72. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." e8e1bf91 "rtcpeerconnection: dont fire signalingstatechange from close()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iddcdc5519be1aeb7b7f267c54ed04b39b2aa43f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985603Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727977}
-
Jan Scheffler authored
This cl disables a test to land crrev.com/c/19671359. Tbr: yangguo@chromium.org Bug: chromium:1019723 Change-Id: I458397c58d1b8fe96d7e13054ee9f813ef64559b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985772 Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Auto-Submit: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#727976}
-
Christian Dullweber authored
Notification channels persist across tests. Reset them to avoid test failures. Bug: 981972 Change-Id: Ica37d2d0a8f3e746a38b8e8a1d6aa74202cec231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985763 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#727975}
-
Balazs Engedy authored
The tests attempt to a start the EmbeddedTestServer on a fixed port, but this will fail if the bot is simultaneously running multiple test cases from this test suite, which happens routinely for `content_browsertests`. Bug: 1038346 Change-Id: Ice7264ef5b811ef3c7d8a194627f7b77fec33a59 TBR: horo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985774Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#727974}
-
