- 02 Jul, 2020 40 commits
-
-
Guillaume Jenkins authored
As a follow-up to crrev.com/c/2267645, moves the unit tests for the DM token storage to components/enterprise. Also moves the associated mock class to the same location. Bug: 1091929 Change-Id: I2f5e4712505a60f5ee496249245d0209ad5945fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269968Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#784842}
-
Kushagra Sinha authored
Mark |AccountManager.LegacySetPrimaryAccountAndUpdateAccountInfo| as obsolete. It was removed in M84 with https://crrev.com/c/2131912. Change-Id: I5769f781999b37e34f53fa1b3fa79db5671f1623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275905Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#784841}
-
Dirk Pranke authored
This will hopefully make it a bit easier to find the best documentation we currently have on the syntax of the file and how it works. Bug: 1099242 Change-Id: I23aa9210d25bea57f4c7f61a49f6d98f665e3528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278591 Auto-Submit: Dirk Pranke <dpranke@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#784840}
-
Sylvain Defresne authored
One possible workaround to use New Build System in Xcode is to post-process the build output to convert the relative paths in absolute paths. See https://gn-review.googlesource.com/c/gn/+/9080 for gn part of this CL. Bug: 852522 Change-Id: I3c1c984dd3a0e89d136a543adfb0c78011e846ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279192 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#784839}
-
Lukasz Anforowicz authored
After removing blink::Platform::CreateDefaultURLLoaderFactory method in r783649, there are no more callers of CreateNetworkURLLoaderFactory and CreateDefaultURLLoaderFactoryBundle _inside_ RendererBlinkPlatformImpl. Therefore, this CL moves CreateNetworkURLLoaderFactory and CreateDefaultURLLoaderFactoryBundle into an anonymous namespace in render_frame_impl.cc, where their only remaining caller is. This helps (slightly) in two ways: 1. It helps with encapsulation - after the CL, no headers expose an API for getting the origin-agnostic/process-wide factory via CreateDefaultURLLoaderFactoryBundle. 2. It highlights that the helpers are unrelated from RendererBlinkPlatformImpl - even before this CL they could have been |static| methods. Bug: 1098938 Change-Id: I7a13c4d4fdfaaedda25acfa7f40404d307a2b537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276227Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#784838}
-
Vasilii Sukhanov authored
The bubble follow "Save/Update password?" bubble and tells the user about other compromised passwords to fix. Bug: 1049200 Change-Id: I18f330cc75c3c4ecc6885302313a33543a5bbf97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278252 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#784837}
-
Pavol Marko authored
The UI was mistakenly displayed FailedWorkerInfo::state in the UI, which is the state prior to failure, so it will never say Failed. Clarify the meaning of the field by renaming/comments and always display failed for failed workers. In a follow-up, the status text will be changed to Failed (was <other status>) or similar. This is not done in this CL in case we want to merge it back, which does not allow UI string changes. Bug: 1098244 Change-Id: Ib7c2a8308211bb4459640a99dd44e7c5c06dc23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276420Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#784836}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a5e8178b385e..2b8d80936336 2020-07-02 nuskos@google.com Add the descendant_slice table. 2020-07-02 nuskos@google.com Add the ancestor_slice dynamic table. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:160148605 Tbr: perfetto-bugs@google.com Change-Id: I0afdf60523522ca11a03e8fdecd2f6286e847fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278298Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784835}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 46c3a3dd. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I6135ca0e944646ddf1cc8119acc6f6580848af35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277675Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784834}
-
Maxime Charland authored
This CL adds PDF assets for the empty state of Reading List. PDF assets will be used as vector images to display at big scale without impacting binary size. These assets will have colour information, so there will be one version for dark mode and another one for any appearance. (Googlers only links) Design Doc: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing UX Specs with mocks: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: I440dfb4e2abec07e81ca26de7857154377a4cf9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269973Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#784833}
-
edchin authored
This CL adds 2 reusable handlers: - TableViewURLDragDropHandler - URLDragDropHandler These are constructed similarly, so I put them into one CL for contrast and comparison. I'll create separate CLs that demonstrate how they are used. The delegate and dataSource protocols draw inspiration from UITableViewDropDelegate and UITableViewDataSource. This is in a series of CLs to enable drag and/or drop of URLs in Bookmarks, Reading List, History, Recent Tabs, Omnibox, and tab strip. Note, unit tests will be added in a fast followup CL. Bug: 1087847 Change-Id: Ia2dca93d032054447b5305fe4ce7f8c86655e966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272117 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784832}
-
arthursonzogni authored
COOP was approved to launch in M82. The current development version is M86. This patch turns the flag on by default. This is still disabled on Android WebView. Since the parser is already behind a flag, there is no need to check for the flag again and again everywhere in the code. Only some DCHECK are necessary. Bug: chromium:922191 Change-Id: I5f43652e38d4df5e003eb36b82eccc6f0a952cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274882Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784831}
-
Stepan Khapugin authored
Adds support for multiple levels of blocking UI in the same scene to simplify accounting. Provides a ScopedUIBlocker object that increments and decrements the blocking counter while it's alive. Bug: 1072408 Change-Id: I39e5713e3b23e0e233958389a5ec8f0c1263bf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259857 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#784830}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ad0b2b8dd121..92c33f329a56 2020-07-02 reed@google.com document Make for paths, and move from pathbuilder into path If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: Icadb31c30ff0ad286219176e0f9ed8f58341846e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278299Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I040f38188c2296ecca55089cdcf54e8af57743d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278852Reviewed-by:
-
Thomas Tellier authored
Bug: 1066489 Change-Id: Ic997e1b8de256ab66ef28710ff41c2ff9299a378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219889 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Elad Alon authored
Bug: 1100295 Change-Id: Id4dd2ef665e5ef6e03ef241f861bcdf37c28aa87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278263Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#784826}
-
Samuel Huang authored
The instructions to build caspian_web is failing due to wasmbuild.patch apply failure. This CL updates updates the patch to get things working again. Bug: 1040645 Change-Id: I2e204e622a29309915ca1086a89d42e9c146132a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272615 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#784825}
-
Matthias Körber authored
This reverts commit f2db4e69. Reason for revert: Bad name for finch study Original change's description: > [Autofill] Allow address profile import from unfocusable fields > > Currently, Autofill does not import address profile data from fields > that are not focusable. This is problematic because such fields are > often used in combination with synthetic form fields. To resolve this, > a finch flag is implemented that allows importing profiles from > unfocusable fields. > > R=battre@chromium.org > > Bug: 1101280 > Change-Id: If1027a26f0cb8f563bb02690d21142fc32d653dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276285 > Commit-Queue: Matthias Körber <koerber@google.com> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784599} TBR=battre@chromium.org,koerber@google.com,schwering@google.com Change-Id: I9669586f8b93c7613e00406b2b3fdba46dc29fe5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279770Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#784824}
-
Guido Urdaneta authored
These tests are flaky on ChromeOS. Bug: 1096082 Change-Id: I5abc6a1bcecac09737a1995ccecaf7a8721e3afa TBR: wtlee@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278057Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I4775b9cd30508288ce5e02ab3a963344e0d99cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279131Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784822}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ee1b328d6a78..53c05a8f0110 2020-07-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idcea12ba23cd52cded56ac6159ec99d0a4c49cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278297Reviewed-by:
-
Kushagra Sinha authored
Extend expiry of AccountManager.InitializationTime histogram by 1 year. Fixed: 1100369 Change-Id: I77d8ecbf749e4b59f424e573574fc6a0d0f108a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276268Reviewed-by:
-
Jeremy Roman authored
Expectations are now inherited by virtual test suites automatically: https://groups.google.com/a/chromium.org/d/msg/blink-dev/E6WX-D63UtE/vavMuD4DAAAJ This should fix webkit_lint failures on the bots: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/91823 Bug: 1101699 Change-Id: Ic10f0f7f9bbcd62fc4b39f288507ff4e912d5535 No-Try: true Tbr: hbos@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279690Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#784819}
-
OlivierLi authored
Verify wake-ups are independent on two seperate WakeUpBudgetPools when one of the two is empty. Bug: 1075553 Change-Id: If58baec2afc318c1f3d413ac2bc7dfb1d0159f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267435Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#784818}
-
Viktor Semeniuk authored
This change adds unit tests for Password Issues View Controller. This is follow up CL for https://chromium-review.googlesource.com/c/chromium/src/+/2257852 Bug: 1075494 Change-Id: I8cc23ce6e8ba90c8ba1741cdd30e5d952ff4b870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272325 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c0bb99a..65c9ff30 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib6be7600d86aa2accd5b893ea1f7804fa2099165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277676Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784816}
-
Peter E Conn authored
The other half of the mojo API was added in: https://chromium-review.googlesource.com/c/chromium/src/+/2215865 Change-Id: I3e3c50c3ad51990cf56567728732e51149203592 Bug: 1096428 Binary-Size: Involves a Java mojo binding (https://crbug.com/1062647). Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250252 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#784815}
-
Benoit Lize authored
Currently, when CommitPages() fails in GigaCage, we crash "on the spot". This is the right behavior, as there is not much we can do at this level. However it short-circuits PartitionAlloc's regular OOM handling, which confuses crash reports. Let AddressPoolManager::Alloc() return nullptr, so that the higher levels crash as usual. Bug: 1086388, 1101447 Change-Id: I91a25bad2ff595dca7722a12765c7b42155be600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279111Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#784814}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I9b002b0fea2b93e44d51728a8972f49b5776ed6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218370 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
-
Mikel Astiz authored
This patch introduces factory functions that enforce how BookmarkPermanentNode instances are created, with consistent values, most importantly the GUID, which had a subtle implementation prior to this patch. The previously-existing function PermanentNodeTypeToGuid() was flawed when it came to the managed bookmark node, since there is no explicit value in enum BookmarkNode::Type to identify managed bookmarks, and FOLDER was used to conclude that it must be the managed bookmarks folder. Instead, it's cleaner and less fragile to force all callers of BookmarkPermanentNode's constructor to specify a GUID. Change-Id: Ife11f5289053fdcb99b1a65d38accf9d80c9e89e Bug: 1060311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083479 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#784812}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. Note that when crossing the Blink API boundary, references to WebMediaStreakTrack kept. BUG=704136 R=guidou@chromium.org Change-Id: Iec9e78e6329e6fa30c04b9d1ad30df4a7b398a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274594 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3cb0985983c1..29444c65244a 2020-07-02 hbos@webrtc.org [Adaptation] Multi-processor support for injected Resources. 2020-07-02 titovartem@webrtc.org Revert "Add rtc::Thread invoke policy." 2020-07-02 mbonadei@webrtc.org Revert "peerconnection: prefer spec names for signaling state" 2020-07-01 fippo@sip-communicator.org sdp: parse and serialize non-key=value fmtp lines 2020-07-01 dminor@webrtc.org Prevent undefined shift in TimestampWrapAroundHandler::Unwrap 2020-07-01 titovartem@webrtc.org Add TimeController to the CreatePeerConnectionE2EQualityTestFixture API 2020-07-01 alessiob@webrtc.org Revert "Fix data channel message integrity violation" 2020-07-01 lennart.grahl@gmail.com Fix data channel message integrity violation 2020-07-01 titovartem@google.com Add rtc::Thread invoke policy. 2020-07-01 landrey@webrtc.org Add av sync metrics to pc level tests 2020-07-01 tommi@webrtc.org Add 1 sec timer to ModuleRtpRtcpImpl2 instead of frequent polling. 2020-07-01 landrey@webrtc.org Add sync group mapping to TrackIdStreamLabelMap 2020-07-01 sprang@webrtc.org Reland "Lets PacingController call PacketRouter directly." 2020-07-01 philipp.hancke@googlemail.com Build: Disable the iLBC audio codec by default 2020-07-01 landrey@webrtc.org Add Start method with TrackIdStreamLabelMap to PeerConnectionE2EQualityTestFixture::QualityMetricsReporter 2020-06-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 037e07fe..a6259aec (784045:784160) 2020-06-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4b369c17..037e07fe (783936:784045) 2020-06-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2c0b70ba..4b369c17 (783820:783936) 2020-06-30 perkj@webrtc.org Ensure CreateTimeControllerBasedCallFactory use simulated time in Call::SharedModuleThread 2020-06-30 tommi@webrtc.org Update a few places in DataChannel to clarify RTP vs !RTP. 2020-06-30 mbonadei@webrtc.org Inclusive language in PRESUBMIT.py. 2020-06-30 philipp.hancke@googlemail.com peerconnection: prefer spec names for signaling state 2020-06-30 mbonadei@webrtc.org Inclusive language in //sdk/android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101263 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0c53e923de3933b7c5fb0406f8c7bf6c39211d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278294Reviewed-by:
-
Viktor Semeniuk authored
This change adds a new screen to Settings > Passwords. This screen shows the user a list of compromised credentials found during password check. Unit tests will be added in follow up CL. Bug: 1075494 Change-Id: I05c4a15a01e27007ece7503d0df54987588d0305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257852Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Benoit Lize authored
Aligned allocations are required to use PartitionAlloc as malloc(). Move the support from dispatch_to_partition_alloc.cc to partition_alloc.h, and add a test. Bug: 998048 Change-Id: Ie3f47f84c1c61adbfb429c3fa40d7a3ecacdd9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277820 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Stephen Nusko authored
The problem is this test became flaky after http://crrev/c/2201762 landed (and stayed landed after reverts), because it moved some code onto the threadpool by default. Whereas before we would serialize and deserialize on the current sequence. However since both get posted to a different sequence we end up having different threads serialize the CopyOutputResult and they both invoke their respective callbacks which share the |results_count| variable between them. Creating a data race. Where sometimes both threads would read the value 0 and we'd lose an increment. The fix is to simply make the increment atomic when we share the same variable across multiple callbacks (which can run on different sequences). Bug: 1098372 Change-Id: I94bb3931e3375196c6fe972b419c963010385576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279229 Auto-Submit: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784807}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie5761759bafb3e3159100aa4202e41f7b27885ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278850Reviewed-by:
-
Guido Urdaneta authored
This reverts commit fd0e9fe3. Reason for revert: The affected bot got green before the revert had an effect. Original change's description: > Revert "base/synchronization: Always Try() in LockImpl::Lock()." > > This reverts commit 6cabb581. > > Reason for revert: Speculative revert to see if it fixes a failure in the win-asan bot. > > First failure: https://ci.chromium.org/p/chromium/builders/ci/win-asan/13067 > > Original change's description: > > base/synchronization: Always Try() in LockImpl::Lock(). > > > > The current implementation of base::Lock on Windows and POSIX assumes > > that base::LockImpl::Try() performs a kernel call, which is not true on > > Linux, macOS and Windows at least, since they all use a variant of "fast > > user-space mutexes" (e.g. futex() on Linux). > > > > Since these calls are cheap (On Android for instance, an external call > > to libc and a compare-and-exchange with acquire ordering), do them all > > the time. An alternative is to remove the branch altogether, as > > base::debug::ScopedLockAcquireActivity checks whether it is enabled as > > well. However it still does a non-zero amount of work, so we may as well > > avoid it, assuming that locks are mostly uncontended. > > > > All in all, assuming that the lock is not held and that ActivityTracker > > is not enabled, this replaces: > > - 2 acquire loads (for the if, and then in ScopedLockAcquireActivity) > > - A predictable branch > > - A call to to Try() > > > > with a single call to Try() (as the native lock() call will effectively > > try() first). > > > > Change-Id: Ie77392db4008966b6379eaadb5d20d1ebfcbc276 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270203 > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > Reviewed-by: Wez <wez@chromium.org> > > Reviewed-by: Brian White <bcwhite@chromium.org> > > Commit-Queue: Benoit L <lizeb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#784736} > > TBR=wez@chromium.org,bcwhite@chromium.org,brucedawson@chromium.org,lizeb@chromium.org > > Change-Id: I852b5565512ef12fe8ce324193846c18a2a03aca > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279118 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784776} TBR=wez@chromium.org,bcwhite@chromium.org,brucedawson@chromium.org,lizeb@chromium.org,guidou@chromium.org # Not skipping CQ checks because this is a reland. Change-Id: I8eafbc431a8398b6d28fc3d0fd03f56c626d3130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279202Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#784805}
-
Omar Morsi authored
This is reland of CL:2270069. It was reverted in CL:2277117 because it broke linux-chromeos-chrome compile. The main reason was CL:2275879 that was merged before it and used a string token id. Original change's description: > Refactor platform keys service token ID > > This CL changes how platform keys service expects token IDs from the > service consumers and makes it clear what to expect in special cases > like empty/unprovided token IDs. > > Before this CL, platform keys service was accepting token IDs as strings > which is not as clear as enums especially for the cases of empty > strings. > > Bug: 1073512 > Change-Id: I4cbdfdc8f22b23ce0297314915e52804b2e495f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270069 > Commit-Queue: Omar Morsi <omorsi@google.com> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Michael Ershov <miersh@google.com> > Cr-Commit-Position: refs/heads/master@{#784448} Bug: 1073512 Change-Id: I0d3a16b0badb6e9f298c2fed609f15f3b9731973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278247Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#784804}
-
Antonio Gomes authored
... instead of WebMediaStream. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I1287e1133852bb31cdd14d9ef691ec1e32c0a777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274593 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
