- 04 Feb, 2020 40 commits
-
-
Yann Dago authored
Bug: 1045887 Change-Id: Iee367ff529aaa268aa0a558f13c3727c29f67880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036397Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#738185}
-
Andreea Costinas authored
This CL adds a new device policy that will control the availability of System-proxy service and the web proxy credentials for system services connecting through System-proxy. BUG=chromium:1042621 TEST=unit_tests:SystemProxySettingsPolicyHandlerTest Change-Id: I183ccd8accd7348d3b3d4580382ddbecc7b5f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007749Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#738184}
-
Robbie Gibson authored
This extends the definition of kZeroSuggestionsOnNTP from Desktop/Android to iOS. Bug: 1048193 Change-Id: I593c8dfd287a20b7afb9b4041ce6c33abbb99c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036030 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738183}
-
Raul Tambre authored
map() returns a list in Python 2. Python 3 returns an iterator. Wrapping in a list() results in the same behaviour on both. [1/2] ACTION //chrome/common:service_process_mojom__generator(//build/toolchain/win:win_clang_x64) Traceback (most recent call last): File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module> sys.exit(main()) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main return args.func(args, remaining_args) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate processor._GenerateModule(args, remaining_args, generator_modules, File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 238, in _GenerateModule generator.GenerateFiles(filtered_args) File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 478, in GenerateFiles self.WriteWithComment(self._GenerateModuleSource(), File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 37, in GeneratorInternal return ApplyTemplate(args[0], path_to_template, parameters, **kwargs) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 30, in ApplyTemplate return template.render(params) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\asyncsupport.py", line 76, in render return original_render(self, *args, **kwargs) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 1008, in render return self.environment.handle_exception(exc_info, True) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 780, in handle_exception reraise(exc_type, exc_value, tb) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\_compat.py", line 37, in reraise raise value.with_traceback(tb) File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_443233f41d2b3f893c5bf0eb0f069e01da908ebe.py", line 100, in <module> File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_71c6d092b6dca901ff3ed0d20e7c827a088fac2d.py", line 523, in <module> File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 183, in HasPackedMethodOrdinals max_ordinal = len(interface.methods) * 2 TypeError: object of type 'map' has no len() Bug: 941669 Change-Id: I0a3797c57d9345beb8b6f305cb696051366ce9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033508 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:Ken Rockot <rockot@google.com> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#738182}
-
Marc Treib authored
TBR=bokan@chromium.org No-Try: true Bug: 1047818 Change-Id: I65fa745164ee41de85f3049a9531a5b899525803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036064 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738181}
-
Wez authored
ScopedRunTimeout is intended to be used to fail tests if a loop is Run() for too long, rather than to Run() the loop for a specific length of time. Clean up some tests which were using ScopedRunTimeout inappropriately. Bug: 1021777 Change-Id: If6b2ee5f3eab498698d09fdee103e759fff51ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033445 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#738180}
-
Rushan Suleymanov authored
Forward commit failures for proxy and forwarding model type processors. Bug: 1047123 Change-Id: Icfca411086c2bc86976ef0234ba43484e81a640a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034524 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
Michael Ludwig authored
Fix the bad expectation image for mac10.10 video-layer-crash.png and removes the suppression. Bug: 1045050 Change-Id: Ib32967e221ad6dde9e49b0faea04bad6639edb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033373Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#738178}
-
Filip Filmar authored
This test started failing recently and consistently on the arm64 build bot, but does not fail locally on device, nor on a repeated job run. Adding a few more asserts to check if those reveal some issues, e.g. OOM or similar. Bug: 1047475 Change-Id: I91f0a3e08d0f2fdeb0b974715575e5486633702c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036279 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#738177}
-
Xiyuan Xia authored
- WorkspaceWindowResizer::CompleteDrag() does not necessarily trigger a new compositor frame. As a result, the wait for the next frame could time out. This CL fixes the issue by explicitly marking a damaged rect to ensure a new frame is produced; - Fix ui::WaitForNextFrameToBePresented use-after-free by using a CancelableCallback as the frame presented callback so that local var |runloop| is not accessed when it times out; Bug: 1047657 Change-Id: I6e7ac27f14d92adf3c9d1535fec62e32e3964f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036369Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738176}
-
Marc Treib authored
TBR=ccameron@chromium.org No-Try: true Bug: 1048149 Change-Id: Ie3d719e6e87cd86e54a72c7ef1a6377ae971e13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036174 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Alexander Hendrich authored
profile() is only needed for regular extension policies associated to the user's profile(). The login screen extensions use the signin profile instead, so we don't need to check for existence of profile(). Bug: 1025760 Change-Id: I8c28de42aead26aed13d3e5f6c9f72af03913e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035977Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#738174}
-
Ben Joyce authored
Bug: 1021634 Change-Id: I86c754d84924eba122e62168867a9aea0379a61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036445Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#738173}
-
Marc Treib authored
This reverts commit 5edf3130. Reason for revert: Suspected of breaking many test targets on 10.10, see crbug.com/1048495 Original change's description: > macOS HDR: Add HDRCopierLayer > > It used to be that setting the contents of a CALayer to an IOSurface > that has an HDR color space, and setting that the CALayer wants > extended range content was sufficient to display HDR content. This was > an undocumented behavior, and macOS has recently fixed it (made it not > work). > > The documented way to get HDR is to use a CAMetalLayer. Unfortunately, > one cannot call setContents (or provide a pre-existing IOSurface) to > this API. As a consequence, we need to perform a copy from the > IOSurface to the CAMetalLayer. Add HDRCopierLayer subclass of > CAMetalLayer, which overrides setContents to blit the specified > contents to the CAMetalLayer. > > Add tests for this. It appears that the test suite is not running, > because most of the tests are broken. Fix all the tests (next step > there is to add them to bots, but that will get a separate patch). > > Bug: 976426 > Change-Id: I8115f2ad19f9a9fd3d1018d2bde7132f7bcfc6e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033906 > Commit-Queue: ccameron <ccameron@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737885} TBR=ellyjones@chromium.org,ccameron@chromium.org Bug: 976426, 1048495 Change-Id: I20e6ed27e3a6e3da0421f8a57ff4d9aa50b36e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035957Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/43c981c9..842c4bc2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifecf3d46f7bc4194e3b67ec9730e193bf7396c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037374 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738171}
-
Tomas Popela authored
The main reason for the flag is so called dialog hell, when you try to share the screen on Wayland through PipeWire. To address it we've created two changes, that are currently under review[0][1]. Once that's done the flag could be removed. [0] - https://webrtc-review.googlesource.com/c/src/+/160649 [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1942327 Bug: 682122 Change-Id: I9ced38a015e4b7806bdaac7b1ab32ef0345e4548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036095 Auto-Submit: Tomáš Popela <tomas.popela@gmail.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#738170}
-
Hesen Zhang authored
- update-notification-scheduling-integration references to an incorrect OWNERS file. Bug: 1048360 Change-Id: Ifac09c577afc4ca62d19557e3a6f935f829bc530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036446 Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
-
arthursonzogni authored
This class wasn't owning any data. It was used like this: ~~~ network::ContentSecurityPolicy content_security_policy content_security_policy.Parse(...) policies = content_security_policy.TakeContentSecurityPolicy(); ~~~ Now, it becomes a function: ~~~ ContentSecurityPolicyParse(&policies, ...); ~~~ Why? 1) Keep it simple. 2) The content/common/content_security_policy/ directory will be merged into service/network/. It contains only functions. It would be nice to turn the existing class into a set of function to keep everything consistent. Bug: 1021462 Change-Id: I250b5137737e921b0e7c5e27ffa4f7222d7c44ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030958 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#738168}
-
Bo Liu authored
There is a race during an unexpected process death. |rebind| and |updateGroupImportance| are called from content code which are notified of process death through IPC code. ChildProcessConnection is also notified of process death directly from Android in onServiceDisconnected. So it is possible Android notices the death and delivers the message first while content code is still trying to access the connection. Simply ignore these calls in that case. Fixes: 1026626 Fixes: 1033577 Change-Id: I13eb65fb796e7a8999f781ae11df23c69d40161a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031866Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738167}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/32bee3cbd581..349930ee9cd3 git log 32bee3cbd581..349930ee9cd3 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 primiano@google.com Merge "Client library: make code gc-sections friendly" Created with: gclient setdep -r src/third_party/perfetto@349930ee9cd3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I04a0aac74a0ccae68348eaa1ed0f29dc8d1c7725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036823Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738166}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ie2e75cbd1b266fb6da0ede320bedb8511f3da15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036110 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#738165}
-
Fabian Sommer authored
Previously, the UI could not distinguish between a failed log in attempt and the user cancelling the attempt. By saving that the user cancelled the request, we suppress the error that would otherwise be displayed. Fixed: 1045029 Change-Id: I758d2934db7da7206d13b6036c0723677ada33ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017351 Commit-Queue: Fabian Sommer <fabiansommer@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0bf9b99cb6fb..2543c5cbffca git log 0bf9b99cb6fb..2543c5cbffca --date=short --first-parent --format='%ad %ae %s' 2020-02-04 tvanderlippe@chromium.org Migrate source_frame/ to import cross-module 2020-02-04 tvanderlippe@chromium.org Migrate text_editor/ to import cross-module 2020-02-04 tvanderlippe@chromium.org Migrate quick_open/ to import cross-module 2020-02-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@2543c5cbffca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id8a89c72e319d0aec8d96ced8bf81f41e4cfa0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036825Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7fff9177174c..7e86a6a616ab Created with: gclient setdep -r src-internal@7e86a6a616ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1048438 Tbr: jbudorick@google.com Change-Id: Ia2934bafe8e5747fbaaa799ab5b2b27edbd3d513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036821Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738162}
-
Eriko Kurimoto authored
This CL sets real values passed from the browser process to referrer_policy, outgoing_referrer and insecure_requests_policy in SharedWorker. There parameters are used for outside settings. Bug: 937177 Change-Id: I54a671d36d0bb8e701dac5cd1b2c954123fadc7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026340Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738161}
-
Patrick Monette authored
This is a reland of dec0aa0b The fix for the failure is in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2036479 Original change's description: > [PM] Add support for dedicated workers > > The WorkerWatcher observes dedicated workers through the > DedicatedWorkerService interface. > > Change-Id: If62d911e500def7ebb905311485a8d89eeaca8df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992208 > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736411} Change-Id: I40b86ea7de8fa4b252ffe805ec5992020dffc515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028214 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#738160}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I3c5406b19457ba5427cae24785fbae0a3c161d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037278Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#738159}
-
Dominik Röttsches authored
Remove explicit hash and trait references when defining HashMaps based on FontCacheKey in place where that is used. Change-Id: Id77bb4a21102d8ed19c2fba66eda174d6e01ec65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035999Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#738158}
-
Roman Sorokin authored
Use OobeScreenWaiter to check if the screen is up. Fixed: 978267 Change-Id: I6725ae9b9184a4a0af3540ddff9c12423f2c9e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036094Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738157}
-
Side Yilmaz authored
|getLastUsedProfile#getOffTheRecordProfile| |Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This change replaces |Profile#getLastUsedProfile#getOffTheRecordProfile| with |Profile#getLastUsedRegularProfile#getOffTheRecordProfile|. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I4b1b97fb26beafaaae6c59bd6557eada032bf601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030870Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738156}
-
Philipp Hancke authored
in order to estimate how much of a use-case simulcast is BUG=823036 Change-Id: Id01ba23692d5fbe7ad95c5bb8f2904891cf9f2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036092 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#738155}
-
Nikita Podguzov authored
As far as these methods are computationally intensive we want to add quotas for them. Bug: 996785 Change-Id: I8573d39fa3d6388b97de08636a3997d51a768a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007812Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#738154}
-
Jan Krcal authored
This is a reland of ba52e783 The test flakiness introduced by the previous attempt has been fixed by another CL [1] that removed unneccessary expectations). Thus, this CL should be safe to land again. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2022651 Original change's description: > Reland "Fix flaky test ServerAddressConvertsToSameLocalAddress" > > This is a reland of commit b3873b4d. > > The CL fixes a race condition in production code of autofill profile > sync bridge by modifying merge logic of the datatype. Previously, the > logic for dealing with duplicate entities was to always prefer the > remote one and silently delete the local one. This could end up with > two clients having a different entry each and the sync server having > both duplicate entries. The new behavior, introduced in this CL is to > keep the profile with greater GUID, lexicographically. > > This change should also remove flakiness of one integration test (that > uncovered the actual issue), so the CL reenables the test. > > The original CL caused flakiness in another integration test since GUIDs > in that test are randomly attributed. In this reland, we fix this by > making the expectation on the number of sync deletions depend on which > one of the test GUIDs is bigger. > > Bug: 917498 > Change-Id: I13994ac5bef8fcae41d37350e08ee80ab90f0916 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002571 > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733636} Bug: 917498 Change-Id: I380f5f38de58a2250f19e28c3429869ca8624f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020927 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738153}
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: I4fa18067d55314b2e2e01531343216aba3ff360e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033158 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738152}
-
Dale Curtis authored
Locally if I run "pactl exit" and log the start time, up to 3 seconds may elapse before the pa_context reaches the PA_CONTEXT_READY state. On my local machine, something is restarting the pulse daemon automatically within a few seconds. It's possible the bots are running in some state where the pulsedaemon will not respawn, so we end up hanging forever. There's no easy way to timeout the wait for PA_CONTEXT_READY since on the call into pa_threaded_mainloop_wait() just hangs and there's no way to pump the mainloop otherwise it looks like. If we want to make the loop timeout, we need to switch away from wait() to a spin/sleep loop. Lets see if this fixes the issue first, if not then we can try a timeout based approach. R=guidou Bug: 1047655 Change-Id: If81ef546c04aa33df8e35368102fd890016db76f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036901 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#738151}
-
Ewann authored
Bug: 1035850 Change-Id: Ib261d2d4651c2a3c60de03f7696d44f1ec618380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033150 Auto-Submit: Ewann Pellé <ewannpv@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dbebc4acd3b6..0bf9b99cb6fb git log dbebc4acd3b6..0bf9b99cb6fb --date=short --first-parent --format='%ad %ae %s' 2020-02-04 leese@chromium.org Test for duplicate tabs on reload Created with: gclient setdep -r src/third_party/devtools-frontend/src@0bf9b99cb6fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1035843 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I053c3f4c2ce9ba0465476bc8bad7fcb59bf328ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036817Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3fa2b80e14fa..f5d877847fae git log 3fa2b80e14fa..f5d877847fae --date=short --first-parent --format='%ad %ae %s' 2020-02-04 ilnik@webrtc.org Reland "[VP9] Shift spatial layers on RTP level to always start from 0." Created with: gclient setdep -r src/third_party/webrtc@f5d877847fae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I82a063a098d5d2297c7883867fbcf7d8a3e9ca52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036818Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8f2b5ba75973..32bee3cbd581 git log 8f2b5ba75973..32bee3cbd581 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 fmayer@google.com Merge "Get rid of UnixSocket::BlockingMode." Created with: gclient setdep -r src/third_party/perfetto@32bee3cbd581 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2414f7bb80f0350c9002b3d7223b72083b059884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036816Reviewed-by:
-
Yuki Shiino authored
Bug: 924839, 839389 Change-Id: I1c8c6dcd0d3e83f06816852e55351bc925974ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037293 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
