GitLab

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/46b16a4..9e49999

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=alph@chromium.org,eae@chromium.org

Review URL: https://codereview.chromium.org/1321293004

Cr-Commit-Position: refs/heads/master@{#347854}

These tests depend on prerender feature which is disabled on svelte devices.

BUG=529490

Review URL: https://codereview.chromium.org/1305063010

Cr-Commit-Position: refs/heads/master@{#347853}

Ethersuggest++ stopped working on CR44. https://codereview.chromium.org/1189033002/patch/20001/30002 made the change in such a way that current URL is not sent to GWS. More details can be found in the bug.

BUG=529447

Review URL: https://codereview.chromium.org/1305163010

Cr-Commit-Position: refs/heads/master@{#347852}

This reduces the DOM nodes in the page roughly in half, and I haven't
even started on the dangerous ones yet :).

R=tommycli@chromium.org
BUG=526577

Review URL: https://codereview.chromium.org/1325853006

Cr-Commit-Position: refs/heads/master@{#347851}

This makes final integration with the MemoryPressureMonitor easier, as it will own a single TickClock which can be injected down the entire stack of dependencies.

BUG=520962

Review URL: https://codereview.chromium.org/1317353006

Cr-Commit-Position: refs/heads/master@{#347850}

When a spell checker service is not available on a device (e.g. Samsung S4)
Android will return a null object and thus SpellCheckerSessionBride will
return null. This CL adds early returns for such cases.

BUG=529355

Review URL: https://codereview.chromium.org/1310093007

Cr-Commit-Position: refs/heads/master@{#347849}

[!] instead of [x] badge

BUG=505953

Review URL: https://codereview.chromium.org/1309063006

Cr-Commit-Position: refs/heads/master@{#347848}

They're already disabled on Beta and Stable channels. Leaving them
enabled in Dev/Canary confuses users and makes people suspect
regressions.

After this, panels are only enabled when --enable-panels is set in
chrome://flags and for the whitelist (Hangouts).

CL also tries to consolidate all the Hangouts extension IDs scattered
around the codebase.

BUG=467808, 526708

Review URL: https://codereview.chromium.org/1329033002

Cr-Commit-Position: refs/heads/master@{#347847}

J420ToABGR is impliemented using I420ToABGR with a jpeg color matrix parameter.
BUG=libyuv:470

Review URL: https://codereview.chromium.org/1321023006

Cr-Commit-Position: refs/heads/master@{#347846}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dd364bc..46b16a4

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=alph@chromium.org,eae@chromium.org

Review URL: https://codereview.chromium.org/1320563005

Cr-Commit-Position: refs/heads/master@{#347845}

Blink side CL: https://codereview.chromium.org/1303343009/

BUG=527249
TEST=conformance2/state/gl-object-get-calls.html related parts pass
R=piman@chromium.org

Review URL: https://codereview.chromium.org/1319453010

Cr-Commit-Position: refs/heads/master@{#347844}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b34cb4e..dd364bc

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=alph@chromium.org,eae@chromium.org

Review URL: https://codereview.chromium.org/1312833012

Cr-Commit-Position: refs/heads/master@{#347843}

Based on the structure given at https://msdn.microsoft.com/en-us/library/windows/desktop/ms684280(v=vs.85).aspx.

BUG=528450

Review URL: https://codereview.chromium.org/1328703003

Cr-Commit-Position: refs/heads/master@{#347842}

BUG=
R=felt@chromium.org

Review URL: https://codereview.chromium.org/1308693013

Cr-Commit-Position: refs/heads/master@{#347841}

Before, two static methods (GetAll and FindByID) were declared
on SyncedWindowDelegate but defined in platform specific files.
Now, those methods exist on SyncedWindowDelegatesGetter so
they can use polymorphism for platform specificity.

SyncedTabDelegate was the biggest challenge since it is not
really accessible when constructed to pass the getter in.
Instead, the SyncedWindowDelegatesGetter is set in
SyncedTabDelegate::ImplFromWebContents, before anything
else uses the object as a SyncedTabDelegate.

This CL is a prerequisite to componentizing SyncedWindowDelegate
and SyncedWindowDelegatesGetter.

BUG=512472

Review URL: https://codereview.chromium.org/1310373009

Cr-Commit-Position: refs/heads/master@{#347840}

Revert of Fix typo in install-sysroot.py (patchset #2 id:20001 of https://codereview.chromium.org/1317973005/ )

Reason for revert:
Caused check_licenses to fail:

https://build.chromium.org/p/chromium/builders/Linux/builds/66701

Original issue's description:
> Fix typo in install-sysroot.py
>
> install-sysroot.py was intended to default to installing
> the sysroot ia32, but within this script 'i386' is used to
> refer to this architecture.
>
> This most likely went unnoticed since the ia32 builder
> either use branding=Official, or explicitly set
> use_sysroot=1, or have a complete set of packages for
> cross building on the host system.
>
> BUG=504446
>
> Committed: https://crrev.com/1d62049b4c176fbd43bed90fc9a76273b11ad406
> Cr-Commit-Position: refs/heads/master@{#347821}

TBR=dpranke@chromium.org,sbc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504446

Review URL: https://codereview.chromium.org/1315773003

Cr-Commit-Position: refs/heads/master@{#347839}

For the expression F(G(), H()), C++ does not guarantee whether G() or
H() will be evaluated first.  Apparently the system compiler on Chrome
OS makes a different decision than on Ubuntu, which causes the golden
file tests introduced by https://crrev.com/1306723002 (which were
generated on Ubuntu) to fail on Chrome OS.

Easy fix: rewrite the expression as

    g = G()
    h = H()
    F(g, h)

to avoid any compiler behavior dependency.

BUG=529480

Review URL: https://codereview.chromium.org/1327693005

Cr-Commit-Position: refs/heads/master@{#347838}

Revert of [Android][telemetry] Break logging deadlock when attempting to log an AppCrashException. (patchset #2 id:20001 of https://codereview.chromium.org/1328093006/ )

Reason for revert:
somehow managed to break Linux Tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/30632/steps/telemetry_unittests/logs/stdio

Original issue's description:
> [Android][telemetry] Break logging deadlock when attempting to log an AppCrashException.
>
> BUG=
>
> Committed: https://crrev.com/e1bf30fc53406ba3bc1b302e87ecda6e3ad2025d
> Cr-Commit-Position: refs/heads/master@{#347816}

TBR=nednguyen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1314953011

Cr-Commit-Position: refs/heads/master@{#347837}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3e944fd..b34cb4e

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=alph@chromium.org,eae@chromium.org

Review URL: https://codereview.chromium.org/1329143005

Cr-Commit-Position: refs/heads/master@{#347836}

Review URL: https://codereview.chromium.org/1312843012

Cr-Commit-Position: refs/heads/master@{#347835}

BUG=
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/1320983006

Cr-Commit-Position: refs/heads/master@{#347834}

BubbleManager doesn't always know when to update a bubble.
Ex: Bubble needs to change label from "Translating..." to "Translated".

Also fix naming from UI -> Ui

BUG=496955

Review URL: https://codereview.chromium.org/1310483003

Cr-Commit-Position: refs/heads/master@{#347833}

Prefixed EME is deprecated.

BUG=451117

Review URL: https://codereview.chromium.org/1322443005

Cr-Commit-Position: refs/heads/master@{#347832}

BUG=525144,514472

Review URL: https://codereview.chromium.org/1309813003

Cr-Commit-Position: refs/heads/master@{#347831}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/87a5c9f..036fd8e

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Commits in this roll:
036fd8e wangyix@google.com Added TestCreate for SkComposeShader;  will pick two random child procs that don't have children of their own.  This prevents creating an arbitrarily large tree of procs.  Also, it will choose a random coefficient mode for the xfermode.
894a2e4 hendrikw@chromium.org skia: Initialize value passed to GetShaderiv in GLBench
925979f mtklein@chromium.org Make SkGraphics::Term a no-op, stop calling it.

Review URL: https://codereview.chromium.org/1323153003

Cr-Commit-Position: refs/heads/master@{#347830}

BUG=528325
TEST=none
R=tapted@chromium.org

Review URL: https://codereview.chromium.org/1313353007

Cr-Commit-Position: refs/heads/master@{#347829}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c30c899..3e944fd

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=alph@chromium.org,eae@chromium.org

Review URL: https://codereview.chromium.org/1328313003

Cr-Commit-Position: refs/heads/master@{#347828}

BUG=457446

Review URL: https://codereview.chromium.org/1318003007

Cr-Commit-Position: refs/heads/master@{#347827}

The Resize() method is supposed to be passed the size of the payload, not
including the header. In the copy constructor, it was being passed the size of
the payload plus the header.

BUG=
R=mark@chromium.org

Review URL: https://codereview.chromium.org/1327523006 .

Cr-Commit-Position: refs/heads/master@{#347826}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a717754..c30c899

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=alph@chromium.org,eae@chromium.org

Review URL: https://codereview.chromium.org/1319263003

Cr-Commit-Position: refs/heads/master@{#347825}

BUG=514815

Review URL: https://codereview.chromium.org/1323263005

Cr-Commit-Position: refs/heads/master@{#347824}

A follow-up CL will delete the remnants of
ChromeMainDelegateStagingAndroid once downstream dependencies have been
updated.

BUG=526335

Review URL: https://codereview.chromium.org/1320253002

Cr-Commit-Position: refs/heads/master@{#347823}

This event gets fired upon the popup button that hosts the menulist. In processing this event, we output feedback that stomps on a focus event (which targets the desired selected menulist option).

BUG=525648

Review URL: https://codereview.chromium.org/1321823004

Cr-Commit-Position: refs/heads/master@{#347822}

install-sysroot.py was intended to default to installing
the sysroot ia32, but within this script 'i386' is used to
refer to this architecture.

This most likely went unnoticed since the ia32 builder
either use branding=Official, or explicitly set
use_sysroot=1, or have a complete set of packages for
cross building on the host system.

BUG=504446

Review URL: https://codereview.chromium.org/1317973005

Cr-Commit-Position: refs/heads/master@{#347821}

Moved the BubbleReference to its own file to avoid having to include
bubble_manager.h everywhere.

The BubbleUI needs to be able to notify the bubble manager when it needs
to be closed.

BUG=496955

Review URL: https://codereview.chromium.org/1323133002

Cr-Commit-Position: refs/heads/master@{#347820}

When Chrome is closed, opening a bookmark app from the app launcher on
Mac leads to an additional Bookmarks menu appearing on the left of the
Mac menu bar. The issue only manifests itself under these exact
circumstances.

The problem appears to be caused by a bug in AppKit. Calling setSubmenu
on a *hidden* NSMenuItem with a *different* NSMenu to the current
submenu leads to the NSMenuItem becoming non-hidden. This precise
situation occurs when caching the bookmark menu on Mac, which is done to
improve profile switching performance.

This CL removes the extra Bookmarks menu by saving the hidden state of
the menu prior to caching, setting the menu to be visible, allowing the
existing caching to run, and then resetting the hidden state once
caching is complete. It is insufficient to skip setting the menu to be
visible in this process.

BUG=497813

Review URL: https://codereview.chromium.org/1308983009

Cr-Commit-Position: refs/heads/master@{#347819}

includes new functionality of J420ToABGR and H420ToARGB/ABGR.

R=dalecurtis@chromium.org
BUG=libyuv:488

Review URL: https://codereview.chromium.org/1315893005

Cr-Commit-Position: refs/heads/master@{#347818}

Also fix config name for asan builds

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk

Review URL: https://codereview.chromium.org/1331443008

Cr-Commit-Position: refs/heads/master@{#347817}

BUG=

Review URL: https://codereview.chromium.org/1328093006

Cr-Commit-Position: refs/heads/master@{#347816}

BUG=https://github.com/jmcgeheeiv/pyfakefs/issues/50

Review URL: https://codereview.chromium.org/1313163007

Cr-Commit-Position: refs/heads/master@{#347815}