- 20 Jul, 2020 23 commits
-
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-002.html" to utilize |selection_test()| to avoid using unnecessary reference images for ease of maintenance and enabling new features, e.g. EditingNG, high-DPI font, etc. Bug: 679977 Change-Id: Idd5e56cece8cf891373add23e924fb15107155cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306495 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789826}
-
Xiaocheng Hu authored
According to the finch results on M83 Stable and the discussion, all launch blockers of this feature have been cleared. This patch first enables it on trunk. A followup internal CL will enable it in other channels via finch configurations. Bug: 1040632 Change-Id: Icd9ab4a85c9d755072310c1be4fc4e524133d6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296280Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#789825}
-
Leo Lai authored
With this CL, the CA type can be configures as the way we do in AttestationCAClient. BUG=b:158955123 Change-Id: I78c4c23c334bec456e86f9591fb6363e99a50d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297060 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#789824}
-
Bartek Nowierski authored
This CL reduces the estimated pre-processed size of partition_alloc.h by 200KB. It affects 8,400+ compilation units. Co-author: bartekn@ Bug: 242216 Change-Id: I0cce59b944eb092dd44c9dd8bc2d5fdb90521cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298787Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#789823}
-
Asami Doi authored
Webapp.CheckServiceWorker.Time is used for the Finch experiment (CheckOfflineCapability), but it always records a minimum value (0.01) because the order of a subtraction was wrong. The result of a subtraction became a minus value and it was rounded to a minimum value. This CL fixes the order in a subtraction. Bug: 965802, 1106693 Change-Id: Ia0e6172a34ba1e30e4c791e5e38a230aa312eaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303933 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789822}
-
Leo Lai authored
This CL replaces the complex object construction of AttestationFlow with FakeAttestationFlow because the consumers of fake attestation flow doesn't care about the details. The CL was validated by browser_tests. BUG=b:158955123 Change-Id: Ida31a3c933ecac639fe86ff9ba62e610e26d2a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297063Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibe68ef1ca66bbfbf16f70e582d1a7d8543972fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306828Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789820}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Bug: 1107272 Change-Id: Ic18a96b452e56d97fa2921d8844ca2364aeddcdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306912Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789819}
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-008.html" to utilize |selection_test()| to avoid using unnecessary reference images for ease of maintenance and enabling new features, e.g. EditingNG, high-DPI font, etc. Bug: 679977 Change-Id: I13c6a3ee454f3c57e40ee127defb7bc38dce95b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306132 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1233b66c90d4..d0dd661f1805 2020-07-20 jiawei.shao@intel.com Implement buffer lazy initialization before CopyBufferToTexture() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I832be03cc65723dd4a509a7786570e2a184733ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306910Reviewed-by:
-
Kai Ninomiya authored
Add GPUMapMode/GPUMapModeFlags definitions, in prep for implementing the new WebGPU buffer mapping primitives. GPUDevice.lost is exposed on workers; it was just a small mistake that GPUDeviceLostInfo wasn't as well. Bug: 1069302 Change-Id: Icc54e28d1b65b05a8d189dda9ce4dad1e0ec29d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305022Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#789816}
-
Leo Lai authored
This test item seems ineffective since the very beginning. Unlike machine certificate uploader, this uploader doesn't rely on cryptohome client to check the key status. The observasion is also validated by flipping the bool flag inside the callback in the test item and the test is still passed. Thus, let's remove it. Change-Id: Iea3d231be5c82537e542902103ee2793914dde03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303742 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-007.html" to utilize |selection_test()| to avoid using unnecessary reference images for ease of maintenance and enabling new features, e.g. EditingNG, high-DPI font, etc. Bug: 679977 Change-Id: I75d5eec57c60cda04c3b1c69d8a8a0a6e11e6eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306497 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595128170-41dd96f269c6178da52f4506adb3f775bbe1eece.profdata to chrome-mac-master-1595191024-184b839913bdf74d85d86bbb55656bedc1cb42fe.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ief092edda87772e9e3892532682891e486b734ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306824Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-005.html" to utilize |selection_test()| to avoid using unnecessary reference images for ease of maintenance and enabling new features, e.g. EditingNG, high-DPI font, etc. Bug: 679977 Change-Id: I5dd880cd156443e5294e66a371e67513d059d5a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305822 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Dmitry Torokhov authored
Instead of sending only permissions that have been granted, send also the ones that have not been granted, but can potentially be granted. Only suppress permissions completely disabled via either a Chrome feature flag, or enterprise policy. Bug: 1071872 Change-Id: I00a9a11b00c908753e9d21d26b646ff204a5f958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304990Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#789811}
-
Asami Doi authored
ServiceWorker.FetchEvent.QueuingTime is used for the Finch experiment (CheckOfflineCapability), but it always records a minimum value (0.001) because the order of a subtraction was wrong. The result of a subtraction became a minus value and it was rounded to a minimum value. This CL fixes the order in a subtraction. Bug: 965802, 1106693 Change-Id: I93b60f301a16caef355e221712372c8e5bcde56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303236 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#789810}
-
Kunihiko Sakamoto authored
It's safer, and easier to understand. Bug: 1082020 Change-Id: I8bd3de0692f66ce53897bd86587f86800394650f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305819Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#789809}
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-006.html" to utilize |selection_test()| to avoid using unnecessary reference images for ease of maintenance and enabling new features, e.g. EditingNG, high-DPI font, etc. Bug: 679977 Change-Id: Ia65186ddc212a6b28bf6f7343c9e4f1d398b4c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306116 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce6323355933..870e2d8168cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: If350f3b75bb9f037a7461ccb7456ae03a90abc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306727Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789807}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595045354-328642a46be4dbf95f23eb2252f408ba578dc2a5.profdata to chrome-win64-master-1595128170-8aaf6de27e89b142e6e1e7e7a3316cb88b9b2b37.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I85c510028e67960a80309c23dd328db5221e8f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306725Reviewed-by:
-
tby authored
There's an extra kind of result action (impression, launch, abandon) that we don't currently log: ignores. These happen when results are shown (impression logged) but not used, in such a way that it's not reasonable to log an abandon. We don't have much interest in ignores on their own, but they're useful for validating that the metrics are correct. Let's log them. Bundled with the change: we're erroneously triggering impressions and abandons sometimes when there are zero results of a kind displayed. This adds an extra check. Bug: 1097599 Change-Id: Ib02ab5a0adb8e986c29375cd022fabf24d31fc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301530Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#789805}
-
Alice Boxhall authored
Revert "Roll ChromeOS Silvermont AFDO profile from 86-4181.3-1594638142-benchmark-86.0.4205.0-r1 to 86-4181.3-1594638142-benchmark-86.0.4206.0-r1" This reverts commit 54a48146. Reason for revert: Seems to have caused a crash: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/19910 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874314486948271696/+/steps/oobe_only_browser_tests__experimental_/0/logs/Deterministic_failure:_DemoSetupArcSupportedTest.OfflineSetupFlowErrorDefault__status_CRASH_/0 Original change's description: > Roll ChromeOS Silvermont AFDO profile from 86-4181.3-1594638142-benchmark-86.0.4205.0-r1 to 86-4181.3-1594638142-benchmark-86.0.4206.0-r1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/cros-afdo-silvermont-chromium > Please CC c-compiler-chrome@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Tbr: c-compiler-chrome@google.com > Change-Id: I0ccba979d989b4ea0285003791734f346b4bc495 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306397 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#789775} TBR=llozano@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I4daed93491b8fb8c0ee83a2e307fb405635c763b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305827Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#789804}
-
- 19 Jul, 2020 17 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595066475-06b3dcece41862329e0ef703dc4c262b7afbda1f.profdata to chrome-mac-master-1595128170-41dd96f269c6178da52f4506adb3f775bbe1eece.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I0eebad736748df6d51014c653b728da2761e4c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306724Reviewed-by:
-
Haiyang Pan authored
This reverts commit 5d52e576. Reason for revert: org.chromium.chrome.browser.omnibox.suggestions.SwitchToTabTest#testSwitchToTabSuggestion flakily fails with java.lang.NullPointerException For example: https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1524 https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1525 https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/1272 Also, it is flaky in android-pie-arm64-rel. See https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyhAELEgVGbGFrZSJ5Y2hyb21pdW1AY2hyb21lX3B1YmxpY190ZXN0X2Fwa0BvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIub21uaWJveC5zdWdnZXN0aW9ucy5Td2l0Y2hUb1RhYlRlc3QjdGVzdFN3aXRjaFRvVGFiU3VnZ2VzdGlvbgw Original change's description: > Reland "Reland "[Omnibox] Use ActivityState to check if we are in browser mode"" > > This is a reland of 5ae112d1 > > Original change's description: > > Reland "[Omnibox] Use ActivityState to check if we are in browser mode" > > > > This is a reland of be1e9636 > > > > Update the test to run on UI thread. > > > > Original change's description: > > > [Omnibox] Use ActivityState to check if we are in browser mode > > > > > > > > > In multi windows mode, check if we are in browser mode by WindowAndroid > > > is not working, should check ActivityState instead. > > > > > > Bug: 1102640 > > > Change-Id: I35a720a2aa6f337cc9f9ae43e39d83c9368fcb5a > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286478 > > > Commit-Queue: Gang Wu <gangwu@chromium.org> > > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#786636} > > > > Bug: 1102640 > > Change-Id: Iefba5a5d0c181535bd7fb86cf0e073be2ebdbcdb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293074 > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Commit-Queue: Gang Wu <gangwu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#788816} > > Bug: 1102640 > Change-Id: I6da3c7ad8402cef83083a53f7ffc517f975720f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301285 > Commit-Queue: Gang Wu <gangwu@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789727} TBR=tedchoc@chromium.org,gangwu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1102640 Change-Id: I2227da6e687932a6a90c3eb73f2a5386ba2c6d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306749Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#789802}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/19856e664354..4ed789b24fc7 2020-07-19 cduvall@chromium.org Disable WebView fallback logic when using WebView APK If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1105096 Tbr: wenbinzhang@google.com Change-Id: I2668fb73fa2ec90f9f724e4bbc8bc3c985fbc16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306721Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c85f6b9d1233..ce6323355933 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I39dc4addb7ab203b8350195b00867ec072137054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306049Reviewed-by:
-
Gavin Williams authored
Preferable to use an enum rather than a hardcoded color string. Bug: 1059607 Change-Id: I5b4d99ce84558f25e1a82b26e1a0c67aedbec270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300776 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#789799}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594753046-ef9d371c47540400b1490f52cf3260906b5b98d4.profdata to chrome-win32-master-1595066475-962e9a9c381a2273ccfe1834d9f1dc2b972cf2cf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I73c1f36102a57d438b83fc7321d631046e001fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306059Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4181.3-1594633354-benchmark-86.0.4205.0-r1 to 86-4181.3-1594633354-benchmark-86.0.4206.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ib2bedb3389bc4dcedb9d2bd6af0dd00471df7877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306399Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/d07e90e7ff54..13480cb0ab94 2020-07-18 bclayton@google.com Mingw - use `posix` toolchain flavor (#1108) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I97d7e70eb70ed371461eac29f31d7f10f917a4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305745Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595008812-5036916016644b79d121c74cb88a6e5ec9532f3c.profdata to chrome-win64-master-1595045354-328642a46be4dbf95f23eb2252f408ba578dc2a5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I0336e974ac84e9b6f46d25e8bccafb7ffb0e0b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305715Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9662fd6cbdfb..324e3e521fd4 2020-07-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Idd005ef744afcff98e85695cb96e3e1051d318bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306404Reviewed-by:
-
Bartek Nowierski authored
In this variant, the unwrapper does the least possible amount of work, by simply clearing the generation bit. This is good for perf testing of only the wrapper side. Furthermore, it allows perf testing of partial wrapper implementations that don't leave the wrapped pointer in a good state, but it doesn't matter, because the unwrapper ignores that state. Bug: 1073933 Change-Id: Ied6f7683888e321fb2992eb3124beb899f53e843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306489 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Robert Ogden authored
If the SubresourceManager is destroyed in the same stack as the TabHelper's page_.reset(), then it seg faults because TabHelper:: OnPrerenderStop changes state on page_. To fix, the handle should not be observed when it is cancelled due to destruction of the SubresourceManager. FWIW, I checked all other code paths to ensure this is the only place where this bug can occur. TBR=ryansturm@chromium.org Bug: 1107168 Change-Id: Id8f74e2433e2cec2f9c4c2f4ada9a31790df8219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306549Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#789792}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I10473862560d83be6b403bd8d38ac608766cf202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306394Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88d3e25b6b97..426f13e93f99 2020-07-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id574fcd1838b2b486e9be4776a520f28d995ac14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306400Reviewed-by:
-
Yi Gu authored
There were 3 tests disabled in Feb due to flakiness (RunLoop timeout). This patch re-enables one of them to verify whether the flakiness has been fixed by recent changes and gather up-to-date failure logs if not. Bug: 1052385 Change-Id: Ib9dcabf769a4ff03d31e1ec1601c69717f590040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302409Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789789}
-
Oriol Brufau authored
CalculateSizeBasedLayoutCacheStatusWithGeometry checks if the cached layout information can be reused. The problem was that, if a flex container had a percentage height, and the size of its containing block changed, a new layout would only be performed in case it was a column flex container. For row flex containers, the cached layout would be reused. However, row containers may also need a new layout in some cases. This patch removes the check for column flex containers, so that row ones can be included too. Bug: 1103592 TEST=external/wpt/css/css-flexbox/height-percentage-with-dynamic-container-size.html Change-Id: Ib2c119febdfa56b31f5524be3df85c9749dd1f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302997 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#789788}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a8b8ef775c75..ea6f21a052c9 2020-07-18 capn@google.com Fix GN UBSanVPtr build of LLVM 10 JIT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3b84364f982ccbffd8934cbaa2074c530b30d433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306053Reviewed-by:
-
