- 14 Aug, 2014 40 commits
-
-
treib@chromium.org authored
- Remove "of this user" from the supervision disclaimer. In the profile list in about:settings: - Change the SU label from "Supervised user" to "Supervised" In the create profile overlay: - Hide the "import existing supervised user" link if the current user is signed in, but has no supervised users. - Remove "sign in to import SUs" label. - Change strings. BUG=400744,403290,403293,403295 Review URL: https://codereview.chromium.org/445003002 Cr-Commit-Position: refs/heads/master@{#289576} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289576 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=403774 TBR=michaeln@chromium.org Review URL: https://codereview.chromium.org/474993002 Cr-Commit-Position: refs/heads/master@{#289575} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289575 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=none R=isherman@chromium.org,asvitkine@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/470933002 Cr-Commit-Position: refs/heads/master@{#289574} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289574 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=402190 TBR=dmazzoni@chromium.org Review URL: https://codereview.chromium.org/477523003 Cr-Commit-Position: refs/heads/master@{#289573} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289573 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=401226 TBR=rdevlin.cronin@chromium.org Review URL: https://codereview.chromium.org/474953003 Cr-Commit-Position: refs/heads/master@{#289572} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289572 0039d316-1c4b-4281-b951-d872f2087c98
-
kaliamoorthi@chromium.org authored
This CL adds the json file containing test_spec for linux_browser_asan. BUG=399730 NOTRY=true Review URL: https://codereview.chromium.org/471963002 Cr-Commit-Position: refs/heads/master@{#289571} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289571 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
This reduces cycle time by about 15 seconds and has the desirable property that it prevents developers from doing anything racy with a Wait. Waits should only be used for a period of perf measurement like smoothness, energy, etc. They shouldn't be used to wait for some condition to be true. BUG=388256 Review URL: https://codereview.chromium.org/473703002 Cr-Commit-Position: refs/heads/master@{#289570} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289570 0039d316-1c4b-4281-b951-d872f2087c98
-
megjablon@chromium.org authored
Currently the UMA tells us whenever audio/video is bypassed as collateral damage of a short bypass. We want to know when audio or video is the cause of a bypass so we now report to DataReductionProxy.BypassedBytes.ShortTriggeringRequestAudioVideo when audio or video triggers a bypass. BUG=401257 Review URL: https://codereview.chromium.org/447933002 Cr-Commit-Position: refs/heads/master@{#289569} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289569 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=403687 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/471003002 Cr-Commit-Position: refs/heads/master@{#289568} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289568 0039d316-1c4b-4281-b951-d872f2087c98
-
asargent@chromium.org authored
If you both deleted the computed_hashes.json and modified the verified_contents.json so that the signature failed, we'd never fix it. This patch changes things so that we validate the verified_contents.json instead of just assuming that the file existing means it's contents are ok. BUG=402727 R=rockot@chromium.org Review URL: https://codereview.chromium.org/465333003 Cr-Commit-Position: refs/heads/master@{#289567} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289567 0039d316-1c4b-4281-b951-d872f2087c98
-
shuchen@chromium.org authored
After below CLs, the check is unnecessary, because for linux_chromeos, if no extension background pages, key events won't be blocked by IMF. https://codereview.chromium.org/433163005/ https://codereview.chromium.org/444523003/ BUG=None TEST=Verified on linux_chromeos. Review URL: https://codereview.chromium.org/462383003 Cr-Commit-Position: refs/heads/master@{#289566} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289566 0039d316-1c4b-4281-b951-d872f2087c98
-
shuchen@chromium.org authored
BUG=402935 TEST=Verified on Pixel. Review URL: https://codereview.chromium.org/466223004 Cr-Commit-Position: refs/heads/master@{#289565} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289565 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
R=dalecurtis@chromium.org,brettw@chromium.org BUG=354261 Review URL: https://codereview.chromium.org/471753002 Cr-Commit-Position: refs/heads/master@{#289564} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289564 0039d316-1c4b-4281-b951-d872f2087c98
-
sgurun@chromium.org authored
BUG=398612 The value of proxy action name also changes from K to L release. Fix it. Review URL: https://codereview.chromium.org/473613002 Cr-Commit-Position: refs/heads/master@{#289563} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289563 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
This CL updates the size of the new avatar button that is needed after updating the resources in this CL: https://codereview.chromium.org/462043003/ BUG=395798 Review URL: https://codereview.chromium.org/460233003 Cr-Commit-Position: refs/heads/master@{#289562} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289562 0039d316-1c4b-4281-b951-d872f2087c98
-
jeremycho@chromium.org authored
BUG=397738,397734 Review URL: https://codereview.chromium.org/465183002 Cr-Commit-Position: refs/heads/master@{#289561} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289561 0039d316-1c4b-4281-b951-d872f2087c98
-
skyostil@chromium.org authored
The MessageLoop has some code for adding debug annotations such as trace flows and memory usage tags to posted tasks. Since we want to use these annotations more generally for tasks that are scheduled outside the base message loop, this patch factors it out into a standalone class. TEST=TaskAnnotatorTest BUG=391005 Review URL: https://codereview.chromium.org/455833004 Cr-Commit-Position: refs/heads/master@{#289560} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289560 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#289559} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289559 0039d316-1c4b-4281-b951-d872f2087c98
-
ncbray@chromium.org authored
Originally landed as 289216 and reverted as 289223 due to a GYP bug. BUG=401761 Review URL: https://codereview.chromium.org/401453002 Cr-Commit-Position: refs/heads/master@{#289558} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289558 0039d316-1c4b-4281-b951-d872f2087c98
-
mcasas@chromium.org authored
TBR=sergeyu@chromium.org BUG= Review URL: https://codereview.chromium.org/475683002 Cr-Commit-Position: refs/heads/master@{#289557} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289557 0039d316-1c4b-4281-b951-d872f2087c98
-
eakuefner@chromium.org authored
Previously, we were having Summary take a boolean had_failures. Now that failures are part of Telemetry's value system, it is easy to have Summary reason about how to summarize values when failures and/or skips are present. This CL is the first step: it eliminates had_failures from being passed around and instead computes it directly based on the presence of failures in the passed list of page-specific values. Review URL: https://codereview.chromium.org/465063002 Cr-Commit-Position: refs/heads/master@{#289556} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289556 0039d316-1c4b-4281-b951-d872f2087c98
-
kelvinp@chromium.org authored
This CL implements the HostInstaller, a class that enables the caller to download the host binary and monitor the install progress of the host by pinging the host periodically via native messaging. Review URL: https://codereview.chromium.org/466143003 Cr-Commit-Position: refs/heads/master@{#289555} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289555 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
Previously you had to pass the flag to get failures to be retried; now we will retry failures by default if you run all of the tests (i.e., do not specify any tests explicitly on the command line). You can still pass --retry-limit=0 to turn off the retries and --retry-limit=3 (or whatever) to force them on. TBR=tonyg@chromium.org BUG=402089 Review URL: https://codereview.chromium.org/468363002 Cr-Commit-Position: refs/heads/master@{#289554} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289554 0039d316-1c4b-4281-b951-d872f2087c98
-
guohui@chromium.org authored
BUG=403018, 403181 Review URL: https://codereview.chromium.org/463183002 Cr-Commit-Position: refs/heads/master@{#289553} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289553 0039d316-1c4b-4281-b951-d872f2087c98
-
mcasas@chromium.org authored
This is a refry of http://crrev.com/410363002, original description: >Force BlackMagic cameras to be opened in HD > >The Blackmagic driver causes a crash in QTKit when opened in VGA >when NTSC/PAL 10-bit is selected. QTKit does not allow us to query a >device's supported resolution, so this change adds BlackMagic to another >blacklist so that it is always opened in HD. In this continuation CL, Blacklisted QTKit devices are found during enumeration and flagged, so a) a special capability list is cooked for them, only including HD, b) they are not reconfigured on opening/capturing. BUG=396812, 347371 COLLABORATOR= vrk@chromium.org R=tommi@chromium.org, vrk@chromium.org Review URL: https://codereview.chromium.org/468833002 Cr-Commit-Position: refs/heads/master@{#289552} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289552 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#289551} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289551 0039d316-1c4b-4281-b951-d872f2087c98
-
dcaiafa@chromium.org authored
BUG=134226 Review URL: https://codereview.chromium.org/469953002 Cr-Commit-Position: refs/heads/master@{#289550} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289550 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#289549} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289549 0039d316-1c4b-4281-b951-d872f2087c98
-
bungeman@google.com authored
https://skia.googlesource.com/skia/+log/fbd3576a18799da88988ef26fa9bce09e8ebba37..c773390eefe70d13faab147a70bd9319b9ac3afb CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel TBR=bsalomon@google.com BUG= Review URL: https://codereview.chromium.org/467363002 Cr-Commit-Position: refs/heads/master@{#289548} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289548 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#289547} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289547 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
Moves (some of) gyp environment setup out of gyp_chromium into separate module, and shares that between gyp_chromium and landmines.py. landmines.py is added as the first entry in DEPS hooks so that it can clobber the entire build directory before running other hooks that extract/generate into the build dir. Reland with fix for ios, and for clean pull. R=iannucci@chromium.org BUG=400011 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289099 Review URL: https://codereview.chromium.org/457003004 Cr-Commit-Position: refs/heads/master@{#289546} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289546 0039d316-1c4b-4281-b951-d872f2087c98
-
mlerman@chromium.org authored
BUG=357693 Review URL: https://codereview.chromium.org/459853002 Cr-Commit-Position: refs/heads/master@{#289545} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289545 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
This CL introduces a memory leak. Line 126 of notification_conversion_helper.cc contains a new[] that has no corresponding delete[]: unsigned char* bitmap_data(new unsigned char[pixel_count * BYTES_PER_PIXEL]); > Route newly created notifications to notification provider API. > > Whenever a new notification is created, route it to an > extension/app that has notification provider permission. > Currently, if there's an app with notificationProvider > permission, notifications will go to both message center > and that app. In the future, when additional sections in > Chrome Settings is implemented, this will send notifications > to only one party based on the user's selection. > > BUG= > > Review URL: https://codereview.chromium.org/441753002 TBR=liyanhou@chromium.org Review URL: https://codereview.chromium.org/469313002 Cr-Commit-Position: refs/heads/master@{#289544} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289544 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
The leak is in the actual code, not just in the test. > Disable leaky NotificationToNotificationOptions > > LSan detected a memory leak in this newly added test. > > BUG=403759 > TEST=Disabling leaky test > TBR=liyanhou > > Review URL: https://codereview.chromium.org/470153002 TBR=bartfab@chromium.org Review URL: https://codereview.chromium.org/470113003 Cr-Commit-Position: refs/heads/master@{#289543} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289543 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
LSan detected a memory leak in this newly added test. BUG=403759 TEST=Disabling leaky test TBR=liyanhou Review URL: https://codereview.chromium.org/470153002 Cr-Commit-Position: refs/heads/master@{#289542} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289542 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
Speculative revert as a lot of Mac bots broke when this landed: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%282%29/builds/54365 http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/43947 http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%283%29/builds/52314 > Fix Mac sandbox meta data access > > Sandbox::AllowMetadataForPath() currently allow all metadata access due to > https://codereview.chromium.org/10539009/ made the for loop comparison > in Sandbox::AllowMetadataForPath() always false, when we actually only > want to allow access to the path and all its parent path until root. > > Turn the for loop to a do/while loop instead as it's a better fit, also > add a test case for Sandbox::AllowMetadataForPath(). > > It should only affect component builds on OS X 10.6 and utility process > as no other process is using this mechanism. > > Review URL: https://codereview.chromium.org/472513002 TBR=jiangj@opera.com Review URL: https://codereview.chromium.org/469293002 Cr-Commit-Position: refs/heads/master@{#289541} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289541 0039d316-1c4b-4281-b951-d872f2087c98
-
kelvinp@chromium.org authored
This CL - Introduces an It2MeService component that listens to incoming connection requests between Hangouts and the webapp and establish a channel between them. - It enables launching an IT2Me helper session from Hangouts Review URL: https://codereview.chromium.org/468693002 Cr-Commit-Position: refs/heads/master@{#289538} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289538 0039d316-1c4b-4281-b951-d872f2087c98
-
mlerman@chromium.org authored
BUG=306322 TEST=When the policy prohibits guest mode, the option should not be selectable from the User Manager. When no policy or policy permits guest mode, Guest Mode should be selectable. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287212 Review URL: https://codereview.chromium.org/385073008 Cr-Commit-Position: refs/heads/master@{#289536} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289536 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalyp@chromium.org authored
BUG=393873 R=dbeam@chromium.org,tbreisacher@chromium.org TEST=third_party/closure_compiler/runner/how_to_test_compiler_pass.md Review URL: https://codereview.chromium.org/460163002 Cr-Commit-Position: refs/heads/master@{#289535} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289535 0039d316-1c4b-4281-b951-d872f2087c98
-
djsollen@google.com authored
NOTRY=True Review URL: https://codereview.chromium.org/468393002 Cr-Commit-Position: refs/heads/master@{#289534} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289534 0039d316-1c4b-4281-b951-d872f2087c98
-