GitLab

Add a boolean metric MediaRouter.Sink.SearchOutcome, which records
whether or not a sink was found for the ID that the user entered and
attempted to cast to.

Bug: 867086
Change-Id: Ie1bf8072b7700298b8a783480b05a2e845666946
Reviewed-on: https://chromium-review.googlesource.com/1148956Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578721}

For me2me operations that return an AsyncResult, use RESULT_CANCELLED
when the user cancels the UAC prompt on Windows. Operations that return
true/false still return false, and it2me still returns ELEVATION_ERROR.

Change-Id: Ia4bff10d80c0c3bb570497ab80ed83799e32f5b1
Reviewed-on: https://chromium-review.googlesource.com/1148881
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578720}

Fixes two CSS issues:
* The options sidebar has no bottom padding
* The infocard table sometimes expands past the screen width

Bug: 847599
Change-Id: Ic39b594c777194e24fa8233094c41106166703cb
Reviewed-on: https://chromium-review.googlesource.com/1152902
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578719}

Additional base::Value cleanup in preparation for some NetworkState
cleanup. This causes ProxyConfigDictionary to conform to the new
base::Value patterns.

Specifically ProxyConfigDictionary now uses base::Value instead of
std::unique_ptr<base::DictionaryValue> and pass by value semantics.

This CL changes ProxyConfigDictionary::GetPacMandatory to return false
if kProxyPacMandatory is not present, making the method consistent with
other similar methods and consistent with the usage in the one call
site that checks the result (proxy_api_helpers::CreatePacScriptDict).
If that logic is incorrect and not covered by any tests (unlikely,
test coverage for this code is quite thorough), then we will see the
following error:
"Invalid proxy configuration. Missing PAC mandatory field."

For trivial changes to c/b/extensions and c/b/net:
TBR=mattm@chromium.org, benwells@chromium.org

Bug: 651157
Change-Id: I6fa01f2be11c8484d8783c3bf94445c3c4addbc7
Reviewed-on: https://chromium-review.googlesource.com/1150846
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578718}

Bug: None
Change-Id: Ie69dc81ced929895ff2241b8c862656f86f921c7
Reviewed-on: https://chromium-review.googlesource.com/1153434Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578717}

R=cmasso@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If99a958b253265e638565e24a31ec5c0fb30d6b3
Reviewed-on: https://chromium-review.googlesource.com/1153478Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578716}

In Win32 some headers defines "interface" to mean struct which
makes it unsuitable to cross platform code. This instance was
hit in a jumbo experimental build where apparently enough
win32 headers were included in the translation unit.

Bug: 864986
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1e906a46620378be2ded6a4a4868e2034cc1868b
Reviewed-on: https://chromium-review.googlesource.com/1152735Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#578715}

During OOBE, salt value is empty and boot.art relocation
fails. This is a normal case. Should be reported separately.

Bug: b:72291323
Change-Id: I0bec29d767fb131c0551bf0853b4dc4a62d97d59
Reviewed-on: https://chromium-review.googlesource.com/1152114
Commit-Queue: Xiaoyong Zhou <xzhou@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578714}

Screen readers should read the title ("Add <extension>?") of extension
install dialogs.

Bug: 849910
Change-Id: I9d37b3810c046419f4c5a3b4428a57cb0a5f3289
Reviewed-on: https://chromium-review.googlesource.com/1135595
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578713}

R=achuith@chromium.org

Bug: none
Test: none
Change-Id: I4aae47d7919c36474eba760387c1017332da4b1d
Reviewed-on: https://chromium-review.googlesource.com/1151898
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578712}

This patch stops batching SkPaint::getTextWidth() on Mac.

Batching SkPaint::getTextWidth() http://crrev.com/c/1150010
has no benefits on Mac because Mac uses getTextPath() instead
of getTextWidth() due to
https://bugs.chromium.org/p/skia/issues/detail?id=5328

The cost to prepare batching is usually much lower than the
benefit of batching, the total speed is more than 10x faster,
but since Mac does not get the benefit at all, the cost of
the preparation turned out to be not ignorable.

http://crrev.com/c/1150010:
https://pinpoint-dot-chromeperf.appspot.com/job/14d1dc0fa40000
This CL:
https://pinpoint-dot-chromeperf.appspot.com/job/11a873fda40000

Bug: 868148
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ifbb0f6576cd58f36cd17463a550a15924f5b2209
Reviewed-on: https://chromium-review.googlesource.com/1153007
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578711}

https://chromium.googlesource.com/catapult.git/+log/6a67dd77dfc3..d8072e683a00


git log 6a67dd77dfc3..d8072e683a00 --date=short --no-merges --format='%ad %ae %s'
2018-07-27 changwan@google.com Fix lint errors for systrace


Created with:
  gclient setdep -r src/third_party/catapult@d8072e683a00

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:814330
TBR=sullivan@chromium.org

Change-Id: Id0a010a7b20a5bc2549f796ee26367898b1bb3cc
Reviewed-on: https://chromium-review.googlesource.com/1153327Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578710}

Show the native UI's accessibility tree for all open chrome windows
in chrome://accessibility

Change-Id: I119ac76f406010b9b2711de845aa3ace7ef69f5f
Bug: 785493
Reviewed-on: https://chromium-review.googlesource.com/1147511
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578709}

When the system voice is selected, chrome.tts.speak is not passed
any voiceName parameter, allowing the system to pick a voice.

Change-Id: I5abeccc6712d09e64e54c52cf3d4579b8ed60336
Reviewed-on: https://chromium-review.googlesource.com/1152215
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578708}

https://chromium.googlesource.com/angle/angle.git/+log/21e9baf71e6e..021bad40ff8b


git log 21e9baf71e6e..021bad40ff8b --date=short --no-merges --format='%ad %ae %s'
2018-07-27 jmadill@chromium.org D3D: Add streaming buffer initialize.


Created with:
  gclient setdep -r src/third_party/angle@021bad40ff8b

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I0ee27b59b3be6c4369cec8a5ba375e01bd78c7bc
Reviewed-on: https://chromium-review.googlesource.com/1153328Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578707}

Bug: NONE
Change-Id: Ic15fc24e7bf75d259084566cefdefe7b3102a20f
Reviewed-on: https://chromium-review.googlesource.com/1152694Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578706}

NOTRY=true
TBR=fserb@chromium.org

Bug: 866850
Change-Id: I7fdda7adc5c777e2da3cd0ce5cec43016a740a78
Reviewed-on: https://chromium-review.googlesource.com/1153439Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578705}

This saves almost 4% of hit test time on some examples, and improves performance of
occlusion hit testing for IOv2 accordingly.

Bug: 831762

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I045e0414c84208b60796fe44ea023ebbb3fbe40a
Reviewed-on: https://chromium-review.googlesource.com/1152296
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578704}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8c84d971..0147f5d1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Id598b8841c5c43ea9532b2babb4bae053b83190b
Reviewed-on: https://chromium-review.googlesource.com/1152324Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578703}

In most instances, ChromeVox wants to respect and process document selections for editable nodes triggered from its own action.

This includes braille routing and any number of other commands that may programmatically set selection.

This change undoes more specific logic to ignore actions, and only ignores selection actions for the ChromeVox toggle selection command. In toggle selection, we preemptively update ChromeVox's selection before actually getting the selection change. We likely still want this because we only want to report the incremental change in the selection and not the entire (possibly larger) selection.

Change-Id: I4082f3cace42cccc369b2148791cbe0ae8db76c0
Reviewed-on: https://chromium-review.googlesource.com/1150291Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578702}

This is:
  s/TaskPriority::BACKGROUND/TaskPriority::BEST_EFFORT/g
  git cl format
applied to //src/base.

TBR=robliao@chromium.org

Bug: 863341
Change-Id: I5273c666b41a192e436a0629d385bc5877b40343
Reviewed-on: https://chromium-review.googlesource.com/1152160Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578701}

There's a race condition where acknowledgement of having marked a
request as completed comes in after the Background Fetch has been
aborted, due to the way the BackgroundFetchDataManager executes its
tasks. We need to handle that appropriately in the scheduler.

Change-Id: Idb4483433aae4abb57e56be68362c4e0333402a7
Reviewed-on: https://chromium-review.googlesource.com/1152969
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578700}

This patch changes to compute grapheme list for mid-ligature
support only when needed.

This patch is part of the LayoutNG performance efforts.
As we measure LayoutNG performance, computing grapheme list
for every ShapeResult turned out to be not cheap.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I58880530e56e0b1b965bd1a246bb8c3415b968a6
Reviewed-on: https://chromium-review.googlesource.com/1152640
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578699}

Releasing ChromeDriver version 2.41

Change-Id: If3355dc85425fbe799f0c8d3f9b999d1aedc1565
Reviewed-on: https://chromium-review.googlesource.com/1152563Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578698}

In the policy description of VideoCaptureAllowedUrls, it says "audio
capture devices...". Instead it should say "video capture devices..".
It was probably caused by copy-pasting.

Bug: 841003
Change-Id: I027e1d5ecaae27263668ef0e97d96434e9418f02
Reviewed-on: https://chromium-review.googlesource.com/1152450Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578697}

Instead, make the right decision on the callsite.
This makes the implicit dependency between the request's
cache mode and frame load type a bit smaller.

Bug: 789577
Change-Id: Id82797025c7ff7160ec9cbeb37f681468127a34c
Reviewed-on: https://chromium-review.googlesource.com/1150836
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578696}

This cl adds use counters to find out the ratio of the web pages that
add document level wheel event listeners with passive:false, true, or
unspecified. It also counts the number of document level wheel event
listeners with passive:unspecified that preventDefault wheel events.

This information is useful to investigate the potential performance
benefits and risks of changing the default value of the passive option
to be true for document level wheel/mousewheel event listeners.

Bug: 626196
Change-Id: Ib0ee64b1a5085813d9b70073747ec3f544fbb660
Reviewed-on: https://chromium-review.googlesource.com/1148783
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578695}

This reverts commit 628bdce6.

Reason for revert: virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi.html started failing on WebKit Mac10.13 (retina) and this patch is on the blame list and seems related. Output isn't that useful, other than to say golden images don't match:

9:34:53.543 49202 "/b/s/w/ir/out/Release/image_diff --diff /b/s/w/itqSin9p/tmp_EMj8D/actual.png /b/s/w/itqSin9p/tmp_EMj8D/expected.png /b/s/w/itqSin9p/tmp_EMj8D/diff.png" took 0.20s
09:34:53.546 49154 [1087/5973] virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi.html failed unexpectedly (image diff)
09:34:53.545 49202 worker/6 virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi.html failed:

Original change's description:
> Move some of VisualProperties to RenderWidget::Init().
> 
> VisualProperties are passed to the RenderViewImpl::Create() method via
> the IPC params, then are passed along to the RenderWidget, but in a
> lot of different steps.
> 
> 1st, screen info is passed to the RenderWidget constructor.
> 2nd, the display mode is set directly on the RenderWidget.
> [ a bunch of other initialization here ]
> 3rd, the whole set of properties is passed to
> OnSynchronizeVisualProperties like an IPC was just received.
> 
> The 3rd step sends the screen info and the display mode again, though
> they won't be changed of course.
> 
> This combines step 1 and 2 into one step where they are passed to the
> RenderWidget::Init() method. Then we can look at combining with step 3.
> 
> R=​ajwong@chromium.org, avi@chromium.org
> 
> Bug: 419087
> Change-Id: Ifcb8eaa0915bb235172e8c5b7bee188e863c18c3
> Reviewed-on: https://chromium-review.googlesource.com/1150673
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: Albert J. Wong <ajwong@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578660}

TBR=avi@chromium.org,ajwong@chromium.org,danakj@chromium.org

Change-Id: Ife47ce2124a0a5baffaa2dd08b3dfe7de79cc568
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 419087, 868444
Reviewed-on: https://chromium-review.googlesource.com/1153398Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578694}

Also a typo is fixed.

Bug: 850624
Change-Id: I48e73389406327d373ce3c4e269a141314bf3bc7
Reviewed-on: https://chromium-review.googlesource.com/1152178Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Lu Chen <chelu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578693}

This reverts commit e7b3bd5b.

Reason for revert: Suspected of breaking CFI bots:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2266
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/9276

Example failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939838131233782656/+/steps/content_browsertests/0/logs/DoNotTrackTest.FetchFromWorker/0

../../third_party/blink/renderer/platform/bindings/wrapper_type_info.h:178:10: runtime error: control flow integrity check for type 'blink::ScriptWrappable' failed during cast to unrelated type (vtable address 0x0000009aab90)
0x0000009aab90: note: vtable is of type 'blink::V8EventListener'
 00 00 00 00  10 96 ab 08 00 00 00 00  90 9c ab 08 00 00 00 00  40 9b ab 08 00 00 00 00  f0 ad ab 08

Original change's description:
> [bindings] Replace JSFunction backlink with GC-aware wrapper link
> 
> Replaces the custom backlink from V8->Blink that was using a v8::External with a
> GC-aware backpointer that is encapsulated in the CustomWrappableAdapter
> interface.
> 
> CustomWrappableAdapter establishes a link from a given JavaScript object to the
> Blink object inheriting from CustomWrappableAdapter. The link is known to
> garbage collectors and thus the Blink object will be kept alive as long as the
> JavaScript object is alive. The adapter can be used to model liveness across V8
> and Blink component boundaries. In contrast to ScriptWrappable, there is no IDL
> definitions required and the JavaScript object must not escape to user-visible
> JavaScript.
> 
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Id9b6a046fd5e3f4c31ddf15894a9968701831e90
> Bug: chromium:843903
> Reviewed-on: https://chromium-review.googlesource.com/1145262
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578621}

TBR=yukishiino@chromium.org,haraken@chromium.org,mlippautz@chromium.org

Change-Id: I2fdc26e9ecffcb2b5d39295650aa061b742985c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:843903
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1153390Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578692}

This is a part of effort to remove /wd4018 warning suppression.

Master CL is
https://chromium-review.googlesource.com/c/chromium/src/+/1152755

This CL was uploaded by git cl split.

R=bajones@chromium.org

Bug: 868248, 588506
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I980cd92d9e69cd3914e2066f159a786959823ba2
Reviewed-on: https://chromium-review.googlesource.com/1152839Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578691}

- Add TestDragDropClient based on ash::DragDropController to map mouse
  events to DragTargetEvents and dispatch them;
- Implement RunDragLoop/CancelDragLoop in test_ws using
  TestDragDropClient;
- Re-enable RunDragLoop/CancelDragLoop;

Bug: 864616
Change-Id: I349e5c80abe8f20e27a5da34992c15cc611a98b3
Reviewed-on: https://chromium-review.googlesource.com/1152461
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578690}

This reverts commit b29fffc2.

Reason for revert: Caused https://crbug.com/861728

Original change's description:
> Avoid unbounded queueing of IPC messages for crashed renderers.
>
> If a renderer process crashes, then we retain the associated
> RenderProcessHostImpl object (to retain the old render_process_host_id
> that may have been stored elsewhere in the system).  Before this CL this
> had an undesired interaction with the ability of RenderProcessHostImpl
> to queue IPCs between the call to Init and the time when a renderer
> process is actually spawned (disclaimer - in practice the queueing has a
> slightly/undesirably longer timeline).
>
> Before this CL, RenderProcessHostImpl::ProcessDied(...) would call
> EnableSendQueue().  This meant that an unbounded number of IPC messages
> may be accumulated in
> ChannelAssociatedGroupController::outgoing_messages_ (until the crashed
> process is restarted).
>
> After this CL, RenderProcessHostImpl::ProcessDied(...) no longer calls
> EnableSendQueue().
> - Short-term: subsystems that require queueing of IPCs should
>   call RPH::EnableSendQueue() themselves (e.g. like RenderViewHostImpl's
>   constructor does).
> - Long-term: we should discard IPCs until RenderProcessHostImpl::Init
>   is called - queueing should only take place in the short time between
>   calling RenderProcessHostImpl::Init and the time the renderer process
>   is actually launched.
>
> There is a small risk that this CL will introduce crashes similar to the
> ones seen in https://crbug.com/658759.
>
> Bug: 813045
> Change-Id: I838bf7ea443633ba0f2314d2de5c83891ec9ac5f
> Reviewed-on: https://chromium-review.googlesource.com/1073621
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562491}

TBR=nasko@chromium.org,rockot@chromium.org,lukasza@chromium.org


Bug: 813045, 861728
Change-Id: I640ad5080d8b5475d3ab0350c45ff32a6d152667
Reviewed-on: https://chromium-review.googlesource.com/1151912
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578689}

Transition the y position of items in launcher to 0 and change the
opacity of these items while dragging between peeking and closed state.

Demo: https://drive.google.com/open?id=1U64zU-0VctEnjRvW7gFYei5-WqaBN-pg

Bug: 862891
Change-Id: Icad43167661ed31ed9a8514fd39708e3fe4a3689
Reviewed-on: https://chromium-review.googlesource.com/1147329
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578688}

Test ChromeDriverTest.testWindowMaximize started to fail on Waterfall on Mac build bot.
Disabling test execution on Mac build bot.

Bug: chromedriver:2522
Change-Id: I96c0de4cfa1ade871dc4605386968145523917ca
Reviewed-on: https://chromium-review.googlesource.com/1153210Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578687}

This also switches RenderViewTest to LoadHTMLString method,
instead of StartNavigation.

Bug: 789577
Change-Id: Ide2fc31dbf2ce62fd928c30d9170677e4a00e557
Reviewed-on: https://chromium-review.googlesource.com/1147212
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578686}

This reverts commit df6e77ca.

Reason for revert: Reverting as suspect of failing case_media_unittests . https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Audio%20Linux/16824 :

[ RUN      ] CastAudioManagerTest.MakeAudioOutputStreamProxy
../../chromecast/media/audio/cast_audio_manager_unittest.cc:106: Failure
Actual function call count doesn't match EXPECT_CALL(*backend, Initialize())...
         Expected: to be called once
           Actual: never called - unsatisfied and active
Stack trace:
#0 0x00000054cffc testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x00000054c9d9 testing::internal::AssertHelper::operator=()
#2 0x00000053ddd3 testing::internal::GoogleTestFailureReporter::ReportFailure()
#3 0x0000005405b6 testing::internal::UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked()
#4 0x0000003e7142 chromecast::media::MockCmaBackend::~MockCmaBackend()
#5 0x0000003a7340 testing::StrictMock<>::~StrictMock()
#6 0x0000003a44b5 chromecast::media::(anonymous namespace)::CastAudioManagerTest_MakeAudioOutputStreamProxy_Test::TestBody()
../../chromecast/media/audio/cast_audio_manager_unittest.cc:105: Failure
Actual function call count doesn't match EXPECT_CALL(*backend, CreateAudioDecoder())...
         Expected: to be called once
           Actual: never called - unsatisfied and active

Original change's description:
> Fetch and apply Multiroom info in CAOS
> 
> CastAudioOutputStream can now use internal backends with multizone. In
> order for multizone to work, we first need to retrieve the multiroom
> info and pass it to the backend.
> 
> BUG=b:111694183
> TEST=Build, cast_media_unittests
> 
> Change-Id: I128a6b0cc1a389d01102007244fdb5594dd4c637
> Reviewed-on: https://chromium-review.googlesource.com/1145892
> Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Aidan Wolter <awolter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578670}

TBR=sky@chromium.org,gab@chromium.org,halliwell@chromium.org,jameswest@chromium.org,kmackay@chromium.org,awolter@chromium.org

Change-Id: I519349d1cd87709c2a1bd39299420b5a7df7bcee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:111694183
Reviewed-on: https://chromium-review.googlesource.com/1153309Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578685}

WTF vector and strings cannot be larger than UINT_MAX so change the
indexing, length and find methods to return wtf_size_t.

The desire to change this to the maximum size and not align it with
std::vector which returns size_t is such that callers actually know
the desired maximum size. One example is PaintChunks are currently using
size_t indicies but the size of PaintChunks can be reduced by 8 bytes
(moving two indicies to be 32 bit from 64 bit on 64 bit platforms).

This change is a minimal change. Progressively all the call sites will be
fixed such that they are using wtf_size_t.
https://chromium-review.googlesource.com/c/chromium/src/+/1128178
is a prototype of all the fixes but is to large to commit by itself since
approximately 1100 files need to be fixed.

BUG=652586

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I77db5df1313e6ab92497d4a811204707d5419c53
Reviewed-on: https://chromium-review.googlesource.com/1145045
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578684}

The new name:

* pairs well with the concept of "Observable"
* describes the role rather than the implementation details
* is consistent with other reactive frameworks
* is more concise

Additionally, the Observer's interface method has been renamed
to open(), instead of create(). This intuitively pairs better
with Scope.close(), hopefully reducing the amount of jargon one
needs to learn to use this reactive framework.

Bug: None
Test: cast_base_junit_tests, cast_shell_junit_tests
Change-Id: I20803a484951f886182eb078b07b7c9bfe11acca
Reviewed-on: https://chromium-review.googlesource.com/1152120Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578683}

If the BookmarkModel finishes loading after the
BookmarkHomeViewController is created, but before it is displayed, then
it is possible that a root node is never set on the VC.  This leaves the
VC in an invalid state, causing crashes when its views are eventually
loaded.

This crash can be avoided by always setting the VC's root node when the
bookmark model finishes loading, even if the VC's views have not yet
loaded.

BUG=862592

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3d5fb9519a07f901c0e4dcd7622c9dbac276443a
Reviewed-on: https://chromium-review.googlesource.com/1153136Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578682}