- 12 Dec, 2017 40 commits
-
-
Nate Chapin authored
Bug: 793028 Change-Id: Ice4ec0acdd179f2a7e2b17a497ee3bdf6e91fff4 Reviewed-on: https://chromium-review.googlesource.com/822916Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#523607}
-
Raymes Khoury authored
This updates 2 UI surfaces to reflect notifications permissions set for the DSE. Specifically: 1) In android Site Details, when toggle the DSE permission for notififications, it will show the options "Allow/Block for the current search engine". 2 cases are handled here: one when that setting links directly into Notification Channels on Android O+ and the other in the case where the permission is handled directly in Chrome. 2) In Settings>Search Engines, underneath the currently selected search engine, it will display a link indicating whether notifications/geolocation are allowed. The link will take the user to the Site Details for the search engine. Several changes have been made to the behavior here: -The link used to indicate if location was disabled. Now, if notifications are location are disabled, nothing will be shown in the text for those permissions. -The link used to take users directly to Android Location Settings when the text indicated that system location was disabled. But now due to the link handling combined permissions, it always takes the user directly to Site Details for the search engine, where the user can follow a link into Android Location Settings. Bug: 780344 Change-Id: I41e0dd1028ad289141d1632875d30373b528f17c Reviewed-on: https://chromium-review.googlesource.com/799534 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523606}
-
Paul Jensen authored
Exposes a Tag(SocketTag) API on StreamSocket and DatagramClientSocket. Deduplication of tagging is done at the TcpClientSocket and UdpClientSocket layers, which includes avoiding applying the default tag to newly created sockets. This ensures that underlying TCPSocket::Tag() and UDPSocket::Tag() are never called on non-Android targets where tagging is not yet supported because it's not possible to create non-default SocketTags on these targets. Socket impls that wrap other sockets pass the tag down to the wrapped socket in cases where the wrapped socket only services the one wrapping socket. Retagging is disallowed when the wrapped socket services multiple wrapping sockets, though the underlying socket can be tagged before being wrapped. Bug: 520198 Change-Id: I53bf343409268a4c6a32f9a3f4f1a565bd44be0e Reviewed-on: https://chromium-review.googlesource.com/793986 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Le-Chun Wu <lcwu@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#523605}
-
Koji Ishii authored
This patch adds layout_ng try bots for following directories: - Source/core/paint/ng - LayoutTests/FlagExpectations/enable-blink-features=LayoutNG - LayoutTests/flag-specific/enable-blink-features=LayoutNG in the same way as slimming-paint does. Bug: 591099, 708452 Change-Id: I1d4f5d0655794837f6292f0030862cece6db4f55 Reviewed-on: https://chromium-review.googlesource.com/822553Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#523604}
-
dpapad authored
Bug: 781439 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2aff2f2096f6824ceffc05c2c94fcbf013166e5a Reviewed-on: https://chromium-review.googlesource.com/816354Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#523603}
-
Tom Anderson authored
BUG=793801 R=thestig@chromium.org Change-Id: I60ee6ec48d2686d0b42ca25311a9b76009ce9768 Reviewed-on: https://chromium-review.googlesource.com/823245Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#523602}
-
Andrey Lushnikov authored
This patch starts computing unique suffixes for file system projects. BUG=633305 R=dgozman Change-Id: I9e0cea72ccf7750b21d0708e079f69178e06650d Reviewed-on: https://chromium-review.googlesource.com/822603 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523601}
-
Robert Sesek authored
This also changes wherever possible from the old implicit value of READ_WRITE to READ_ONLY. Bug: 793503, 793519 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0ebafb2eb93af9718e71a303e239ecaa4e7d8f35 Reviewed-on: https://chromium-review.googlesource.com/820011Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523600}
-
Nate Chapin authored
* DocumentResource has one easy case to plumb a ResourceClient, and one very difficult case that's already friend'ed for ResourceClient::SetResource * ImageResource and LinkFetchResource never add clients, just always pass nullptr for the ResourceClient*. * FontResource will be correctly plumbed in https://chromium-review.googlesource.com/c/chromium/src/+/818304, just use nullptr in the meantime. Bug: 793028 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I49a20de543f4570ca2a8940a57bd22ff5c8f70cc Reviewed-on: https://chromium-review.googlesource.com/822162Reviewed-by:
-
Xianzhu Wang authored
This CL let the counts of category filters show the counts with text filter applied. I had hesitated which to choose: counts before text filter and after text filter and after tries both I feel the latter is more informative. Wdyt? Change-Id: I229fb0e49e628ffa1685f59f44b5ca848d3f410f Reviewed-on: https://chromium-review.googlesource.com/822754 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#523598}
-
Ted Choc authored
BUG= Change-Id: I776c0b5a9c25d3804e14ce922c8ac4905097f3a9 Reviewed-on: https://chromium-review.googlesource.com/822512Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523597}
-
Xiaohan Wang authored
Previously we always truncate logs from the beginning, but there could be important information there. This CL changes the behavior so that we always truncate the middle part of the log to preserve potentially important information in the top and bottom part of the log. BUG=793426 TEST=This improves test infrastructure. Change-Id: I058f735fbaedec324960b2c7a269d549b1a0178e Reviewed-on: https://chromium-review.googlesource.com/823191Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
dpapad authored
Bug: 790755 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9762cb10a50531f9e169ea16cf05d0ecd98c5534 Reviewed-on: https://chromium-review.googlesource.com/823075 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523595}
-
Matthew Jones authored
This change increases the maximum recorded value for reciprocal velocity in the bottom sheet. Early metrics indicate a high number of swipes in the 20k - 60k range. Reproducing these values is possible by idly keeping your thumb at near the bottom of the screen; moving very slightly (thus triggering a swipe). BUG=779615 Change-Id: I9662d9d8a8ceb0d9853adea30b296bde23b0da3a Reviewed-on: https://chromium-review.googlesource.com/823220Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#523594}
-
Tom Sepez authored
Reverted as part of https://chromium-review.googlesource.com/c/chromium/src/+/818486 because it interfered with tests. Corrected via https://chromium-review.googlesource.com/c/chromium/src/+/820611 but not re-enabled there to avoid reversion should there be another issue found down the road. This CL takes the last step. Change-Id: I2ad4c14f6ebf4195b374584bc45e9e64b90eb453 Reviewed-on: https://chromium-review.googlesource.com/822984Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#523593}
-
Eric Lawrence authored
Installation requires that the security level of the page be SECURE or EV_SECURE, but this omitted the equivalent state on ChromeOS with a policy-installed certificate. This CL ensures that all valid HTTPS states permit installation. Bug: 794256 Change-Id: I8ac7f2e6a7ca215197a32ec5ee534410d20d82b0 Reviewed-on: https://chromium-review.googlesource.com/823152Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#523592}
-
Brett Wilson authored
Converts TreeNodeModel to allow an index-based removal for cases where an index is known. This prevents a linear search in that case. A pass-through function is provided that does the search if the index is not known. This requires a similar change in TreeNode. TreeNode::Add and ::Remove used to be virtual but these were never overridden. They are changed to non-virtual member functions. Additional documentation is added referencing TreeNodeModel from TreeModel, and some additional examples are provided. Change-Id: I5c062420bada437f1ef127ce80518e37f5c2aaae Reviewed-on: https://chromium-review.googlesource.com/820671 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
-
Chris Morin authored
Remove the --arc-start-mode=only-start-after-login flag functionality from Chrome. Passing this flag to Chrome caused the mini-container to be disabled. Bug: 65548422 Test: Ensure container boots and upgrades successfully. Change-Id: Ife77df29e6bcafaa848465a1e65350a263b40a72 Reviewed-on: https://chromium-review.googlesource.com/821711Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Christopher Morin <cmtm@google.com> Cr-Commit-Position: refs/heads/master@{#523590}
-
Fady Samuel authored
This CL plumbs an OnSurfaceCreated over from Surface to SurfaceManager to FrameSinkManagerImpl to HostFrameSinkManager so that the host can assign an owner to the temporary reference. Previously we waited until activation to assign an owner to the temporary reference but that had the effect of taking longer for a newer fallback surface to be picked by SurfaceManager. This CL also simplifies GetLatestInFlightSurface by removing the parent FrameSinkId parameter. Instead, the parent FrameSinkId is extracted from the surface hierarchy already stored in SurfaceManager. Bug: 672962 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I012f5feda5e3172978cc3686694362e4d85f5832 Reviewed-on: https://chromium-review.googlesource.com/820162Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#523589}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/296a61d6007688a1472798879b81517920e35dff..0c9c1aad352235db1be3bf05e769c97fcc215112 BUG=none Change-Id: I538290c1b6389f94a11cd411b20193f5f4e58e64 Reviewed-on: https://chromium-review.googlesource.com/822777 Commit-Queue: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#523588}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/09757b29feeb..aeff9eaa1903 $ git log 09757b29f..aeff9eaa1 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 angle-deps-roller Roll skia/third_party/externals/angle2/ 3c613c0d7..a98a28112 (1 commit) 2017-12-12 brianosman Push much of the SkColorSpace_Base interface up to SkColorSpace Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I57068384a7c9d8fe8ccae2a69a1b7a7730fa32c1 Reviewed-on: https://chromium-review.googlesource.com/822920Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523587}
-
David Trainor authored
Grabs all permissions that have been granted or not to Chrome and adds them to the feedback collector list of feedback. BUG=773411 Change-Id: Iafdaaf474d3ad269ea1cc585db8068b66a5848c2 Reviewed-on: https://chromium-review.googlesource.com/806244 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#523586}
-
Filip Gorski authored
Creates FileExistenceChecker with a static method to check whether a file from a provided list is missing in the OS. Implementation is template based, because it allow to link such file back to the original item related to that file, such as an offline page or a download. Types of identifiers for these items could vary. Bug: 758690 Change-Id: I97f1701d9d8e44cc42fc8863e001401938d22965 Reviewed-on: https://chromium-review.googlesource.com/818183 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#523585}
-
Andrey Lushnikov authored
DevTools expect the "!important" modifier to be a part of the property value. This patch brings CSSOM-generated property values in line with the assumption. BUG=735282 R=dgozman Change-Id: I2b3b852c66e07799c6437dd04841b5197b6c3201 Reviewed-on: https://chromium-review.googlesource.com/820974 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
-
Pavel Feldman authored
This is a reland of 6745e12d Original change's description: > DevTools: do not report raw headers and cookies for protected subresources. > > In case subresource request's site needs to have its document protected, don't > send raw headers and cookies into the frame's renderer. > > Bug: 793692 > Change-Id: I9f41adfe35717eec284130f89ac92ecc78089969 > Reviewed-on: https://chromium-review.googlesource.com/821410 > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523364} Bug: 793692 Change-Id: Ib0bd20ae7a34c32797fee19533f597094f384c83 Reviewed-on: https://chromium-review.googlesource.com/822134Reviewed-by:
-
Dominik Laskowski authored
The ET_MOUSE_CAPTURE_CHANGED event has no location, but would generate a pointer motion event. When capture was released after ending a drag, the client would receive an event located at (0, 0) and update the cursor to the top-left resize sprite. Bug: b:67384524 Test: No top-left resize cursor after ending drag. Change-Id: I882c4e51f98c9b6e451f716fcc0057848c3b72e5 Reviewed-on: https://chromium-review.googlesource.com/823216Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#523582}
-
Jinsuk Kim authored
This CL introduces java UserData for WebContents in order to handle data of the lifetime of WebContents without having them directly associated with it. GestureStateListener objects being managed by ContentViewCore is used to show how UserData can be used. They are now managed by GestureListenerManager that implements UserData. It can be obtained by |GestureListenerManager.fromWebContents()| modeled after native UserData-inherited class, though it is not as universal i.e. no SupportsUserData but only for WebContents. Bug: 789000 Change-Id: Icfbd3480314d261d90454f585d181e56f64aa8da Reviewed-on: https://chromium-review.googlesource.com/792575Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#523581}
-
Sunny Sachanandani authored
crrev.com/804597 accidentally set gmb id for anonymous surfaces to 0 to use it as a hint for whether to clear surfaces. This causes a memory regression similar to the one before unique ids were introduced. Instead, client_id, which is 0 for anonymous images and non-zero otherwise, can be used for the same purpose. R=ccameron BUG=793445 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I76b2fa6cf498b0f2727bef7983ebc063cfb5e9d0 Reviewed-on: https://chromium-review.googlesource.com/820618Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/ebcbb85ea364..1228ae247f21 $ git log ebcbb85ea..1228ae247 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 npm Roll pdfium/third_party/freetype/src/ bec14f688..2c048a8a6 (25 commits) 2017-12-12 dsinclair Move Script_Som_*Message methods to CJX_Object 2017-12-12 dsinclair Move Script_Som_{Fill|Font}Color to CJX_Object Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I748c3ca88cd2739e2f66e5701e79c77d5bdc23b7 Reviewed-on: https://chromium-review.googlesource.com/822217 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523579}
-
Vadym Doroshenko authored
SecurityOrigin in WebKit has port=0 for ports that are default for scheme. But url::SchemeHostPort requires effective port. This CL adds a call to url::DefaultPortForScheme before creating url::SchemeHostPort. Bug: 554927 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3e6ccf17d5b8fc221ff954b3ac39a8fb0d195ca9 Reviewed-on: https://chromium-review.googlesource.com/823082Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#523578}
-
Bailey Forrest authored
tmpfs doesn't support file attributes. BUG=internal b/70425842 TEST=base_unittests Change-Id: I23d0473680f3e8648971ee39f0c38cbff7fe0819 Reviewed-on: https://chromium-review.googlesource.com/821354Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#523577}
-
Vadim Tryshev authored
Multiple improvements for UMA sequence analyzer. Bug: 769416, 763612, 763611, 770427 Change-Id: Ib5141963cd76729ccf833bc52ffadde9b1017db7 Reviewed-on: https://chromium-review.googlesource.com/804406 Commit-Queue: Vadim Tryshev <vadimt@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#523576}
-
Michael Thiessen authored
We were previously only creating it once on entering VR, so if we switched tabs, or the tab was closed, weird things could happen. Bug: Change-Id: I70187cb56a2fa8e0edc5978c17a760895789ccb4 Reviewed-on: https://chromium-review.googlesource.com/823093Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#523575}
-
Emilio Cobos Álvarez authored
The style of an element should only depend on the closest self-including link ancestor, but we're missing to check for that while walking the ancestors in SelectorChecker. BUG=793298 Change-Id: I0449a4d743f9ab1b747f69679c096e96681548ad Reviewed-on: https://chromium-review.googlesource.com/817597Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Cr-Commit-Position: refs/heads/master@{#523574}
-
Kevin Bailey authored
The Omnibox was calling SwitchToTabWithURL() directly from OpenMatch() for tab-switch suggestions. This change creates a special disposition for the suggestions and adds support for it within the browser stack. Bug: 780835 Change-Id: I4f48e6a7a4b46cf9c1a88baedafc87aaf763ebef Reviewed-on: https://chromium-review.googlesource.com/809527Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#523573}
-
Aga Wronska authored
Blur (without dimming) is applied when the lock screen animation starts. Blur is removed when unlock screen animation finishes. Dimming is applied only on lock screen. This cl is smoothing the transition, but wider revision and update is planned for the future (crbug.com/793171). Bug: 789320 Change-Id: Ib79bf348a837af7814095136155183b74aafc87a Reviewed-on: https://chromium-review.googlesource.com/812112 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#523572}
-
Ned Nguyen authored
TBR=eyaich@chromium.org NOTRY=true Bug: 786010 Change-Id: I9d9d9d38c99537f17833fe8de0e50f95e50a8279 Reviewed-on: https://chromium-review.googlesource.com/823230Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#523571}
-
Lukasz Anforowicz authored
This CL makes sure that RenderViewImpl::GetURLForGraphicsContext3D doesn't crash if |webview()->MainFrame()| is null. This restores the behavior of the code from r187650 which used to do the null check (the check was dropped later in https://codereview.chromium.org/444503002/patch/80001/90022). Bug: 793999 Change-Id: I2027b69ff533fcdbc3bd7fedefc21059f032d023 Reviewed-on: https://chromium-review.googlesource.com/822911Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#523570}
-
Nate Chapin authored
This lets us get rid of the last non-trival usage of ResourceClient::SetResource in ClassicPendingScript Bug: 793028 Change-Id: I39a4859cb1b941ff6a399fad88d40e353df4d462 Reviewed-on: https://chromium-review.googlesource.com/822176Reviewed-by:
-
Erik Luo authored
DevTools currently bails out when trying to autocomplete large TypedArrays. This relaxes our condition to bail out on large regular Arrays, too. The original condition is introduced here: https://crbug.com/444116 Bug: 740488 Change-Id: I65e04fc8497fe848d25a78cfad049fcc1e1919a9 Reviewed-on: https://chromium-review.googlesource.com/820935Reviewed-by:
-
