- 25 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1dddaa1a8433..4f2783b9fe77 git log 1dddaa1a8433..4f2783b9fe77 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 phoglund@webrtc.org Speculative Revert: "Use FakeRenderer when fuzzing" 2019-10-25 gustaf@webrtc.org Cleanup of EchoControl interface after downstream fixes 2019-10-25 saza@webrtc.org Add APM test of pre-amplifier gain 2019-10-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 64883b3e..3c5165be (709283:709394) Created with: gclient setdep -r src/third_party/webrtc@4f2783b9fe77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1015797,chromium:952606,chromium:1009077,chromium:1009073,chromium:b/130016532,chromium:None Change-Id: Ic6a298f17bfbcba42dd33a1d811994514e0f42c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879193Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709444}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/480809720bfa..208c36706ef6 git log 480809720bfa..208c36706ef6 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 treehugger-gerrit@google.com Merge "traceconv: add --full-sort option" 2019-10-25 eseckler@google.com Merge "processor: Add ProtoImporterModules for android + system probes" Created with: gclient setdep -r src/third_party/perfetto@208c36706ef6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I073059aee791c0ba6917ccfdbb7c112ba2f43859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880590Reviewed-by:
-
Yuki Shiino authored
This is a reland of b3a546fe It turned out that it's not going well to output v8_example.cc under bindings/scripts/bind_gen/, so reverted the path to out/Default/gen/... as same as before. Added some asserts in example.py. Original change's description: > bind-gen: Support generation of function definitions. > > This is just a first step to support the code generation > of bindings callback functions. > > Introduces CodeGenerationContext for convenience, and > also demonstrates make_common_local_vars(). > > Bug: 839389 > Change-Id: I9ff49b4bfc6bd98e6b29687cc01f986c2baa01fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855325 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709389} Bug: 839389 Change-Id: I57ff27abdf2a01a9cc926bbf27d1a0c8ceb5ce88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880991 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#709442}
-
Miyoung Shin authored
This CL converts AudioInputStreamClient{Ptr, Request} in chrome, components, content and media to the new Mojo type, and uses pending_receiver<pending_receiver> in resource_provider.mojom. Bug: 955171 Change-Id: Ib7856c3c65ff70f658b9e6c56b72a9a2b73648e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866709 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Ken Rockot <rockot@google.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#709441}
-
Javier Ernesto Flores Robles authored
This reverts commit b27f6c3c. Reason for revert: Fixed the compilation issue. Two different targets where stubbing the same app interface, which caused duplicated symbols. Now the stubbing happens on its own .mm file. Original change's description: > Revert "[iOS][MF][EG2] Migrate credit card tests" > > This reverts commit 919aab84. > > Reason for revert: Suspected of breaking compile for xcode-ios-bots - https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/113639 > > Original change's description: > > [iOS][MF][EG2] Migrate credit card tests > > > > Consolidate Manual Fallback matchers in one place. > > Consolidate credit card Autofill helpers in the respective app > > interface. > > > > TBR= eugenebut@chromium.org > > > > Bug: 1017685, 1016367 > > Change-Id: Ib91e2baba9e72f6e065e8ebf08fdd5f5d3c0c9bb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878197 > > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#709020} > > TBR=stkhapugin@chromium.org,javierrobles@chromium.org > > Change-Id: I644e9e91acab68e69d7cba86af2037fd43603b36 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1017685, 1016367 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878911 > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709028} TBR=stkhapugin@chromium.org,smcgruer@chromium.org,javierrobles@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017685, 1016367 Change-Id: I8cf4fe3a3f7960a0ff27459003884a7ba08a455a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878490Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#709048} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878772Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709440}
-
Yoshifumi Inoue authored
This patch formats "FlagExpectations/enable-blink-features=LayoutNGFragmentItem" for ease of updating it by tool[1]. [1] http://crrev.com/c/1880898 TBR=kojii@chromium.org NOTRY=true Change-Id: Ie723c1d235ec068badeb6843bcd069f103dc59d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880998Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709439}
-
Yoshifumi Inoue authored
This patch changes |AbstractLineBox| to utilize |NGInlineCursor| to reduce usage of |NGPhysicalLineBoxFragment| for prepration of migrating |NGFragmentItem|. Note: To reduce patch size, following patch will introduce |NGInlineCursor| version of |ClosestLeafChildForPoint()|. Bug: 982194 Change-Id: I539b940509ae608f0068a013670889bfc16dd4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877499 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709438}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/33455d1c48..d3ddd33257 TBR=aerotwist@chromium.org Change-Id: Ibf69370cfd87c5a74975ef33c04978bb34005049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879939Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709437}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I040c2ecf60da17ad6e7cd6fe52423bcae7a8bdcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880053Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709436}
-
Felipe Andrade authored
Kerberos credentials manager should notify observers exactly once when it finishes adding a list of accounts. This CL removes the flag that was blocking notifications in case of failure because, even in this cases, managed accounts might have been added and observers should be notified. Change-Id: Idf07f4f755cc5f81aa1788f28c416bfed0fec106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878251 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#709435}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5ebd4c5ebf28..38f98ead10af git log 5ebd4c5ebf28..38f98ead10af --date=short --no-merges --format='%ad %ae %s' 2019-10-25 perezju@chromium.org [Telemetry] Remove support for output formatting Created with: gclient setdep -r src/third_party/catapult@38f98ead10af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:921000 Change-Id: Ic61238ca03e7c18276316800f8a09eceeae92698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880665Reviewed-by:
-
arthursonzogni authored
Generated using: ~~~ #! /bin/bash --utf8 directories="content chrome components" regex="DisableForRenderFrameHost(\(([^\(\)]++|(?1))*\))" label=$(grep -Pzoh $regex -r $directories \ | tr -d '\000' \ | grep -Po '\"[^"]+"' \ | tr -d '"' \ | sort -u ) echo "<enum name=\"BackForwardCacheDisabledForRenderFrameHostReason\">" for i in $label do hash=$(echo -n $i | md5sum | tr -d ' -') hash=${hash^^} hash=$(echo $hash | head -c 16) hash=$(echo "ibase=16; $hash" | bc) hash=$(echo "($hash + (2^31)) % (2^32) - 2^31" | bc) echo " <int value=\"$hash\" label=\"$i\"/>" done echo "</enum>" ~~~ Bug: 1001087 Change-Id: I4f9bc9b9c50eb1a27642f0afa900dac300890e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879937Reviewed-by:Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#709433}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cfa4b4a65a57..480809720bfa git log cfa4b4a65a57..480809720bfa --date=short --no-merges --format='%ad %ae %s' 2019-10-25 tneda@google.com Merge "Adding heap profiling to the record page" 2019-10-25 lalitm@google.com Merge "trace_processor: switch to creating ranged RowMap when filtering" 2019-10-25 lalitm@google.com Merge changes I7b4e3667,Ie36db4d9 Created with: gclient setdep -r src/third_party/perfetto@480809720bfa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: If5724b02487c621eda7e706b042806dad9a083fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880664Reviewed-by:
-
Clemens Arbesser authored
Currently, autofill assistant does not validate the set of basic card networks sent by the autofill assistant backend. In the UI, this can lead to crash due to an assert. This CL adds the missing validation and terminates the action with INVALID_ACTION for unsupported cards. Bug: b/143136284 Change-Id: If248fa0edd671078ef6459de34228e392f542800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871700 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709431}
-
Minggang Wang authored
This CL moves ThrottlingURLLoader and its unit test into Blink. Bug: 860403 Change-Id: I25429971608737c9f37ff126dbbb5ef40ccdc794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865142 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709430}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/24fd62c5..a446a6f7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie5fd99091faf3499a5adc65e201ae39e65472088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880052Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709429}
-
Kent Tamura authored
The table at https://html.spec.whatwg.org/C/#focusable-area says: > the element is either not a shadow host, or has a shadow root > whose delegates focus is false; is a requirement of focusable area. That is to say, shadow hosts with delegatesFocus can't be focusable. This CL has two behavior changes: * A shadow host with delegatesFocus and tabIndex doesn't get focus even if its shadow tree contains no focusable elements. * tabIndex IDL attribute for a host with delegatesFocus returns -1 if tabindex content attribute is invalid or missing, instead of 0. Implementation: Element::Is*Focusable() don't return true any longer for shadow hosts with delegatesFocus. This CL adds delegatesFocus checks to some of Is*Focusable() callsites. focus_controller.cc assumed shadow hosts with delegatesFocus and no tabindex attribute return 0 for tabIndex(). This CL updates AdjustedTabIndex() to return 0 in such case, and replaces raw tabIndex() calls with AdjustedTabIndex(). Change-Id: If1b06dc727134f834df4ebc00fc78c72b77c4a2e Bug: 1014094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880494Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#709428}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ef0e4d043845..1dddaa1a8433 git log ef0e4d043845..1dddaa1a8433 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 hbos@webrtc.org [PeerConnection] Use an OperationsChain in PeerConnection for async ops. Created with: gclient setdep -r src/third_party/webrtc@1dddaa1a8433 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I14e15a085f476cd79f4bd40c43028aac2cbe4248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880575Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds ExplicitArgumentBarrier to base::make_span, blocking callers from explicitly specifying types the compiler can deduce for them. It also performs some other minor clean-ups in effected code, such as getting rid of base::make_span completely when an implicit conversion would have been performed anyway. TBR=khushalsagar,caseq,mcasas,kouhei,rockot@google.com Bug: 828324 Change-Id: I4c462b9802c477baf6f601ee5651a90a6d929fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871699 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#709426}
-
Marian Fechete authored
This CL is a first step to refactoring the fallback logic in Autofill Assistant. Specifically, this refactors the UseAddress and UseCard actions to remove duplicated code for checking required fields and filling in fallback values. Bug: b/141362833 Change-Id: I7bbfb767e2768b79a73a07242e68e0925063c663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875257 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#709425}
-
Chih-Yu Huang authored
Currently only ChromeOS platform uses DmabufVideoFramePool. This CL moves the related files //media/gpu/chromeos. BUG=chromium:1012587 TEST=ninja chrome on kevin and eve. TEST=ninja video_decode_accelerator_tests on kevin and eve TEST=ninja media_unittests TEST=gn check on kevin and eve Change-Id: I553831492b238046e454af73cee5e62876240e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877495 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Shuo-Peng Liao <deanliao@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#709424}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4822cdce35a..52d33c48770b Created with: gclient setdep -r src-internal@52d33c48770b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I41d07756b703b080449dd4ec6d031a23e08b6c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880574Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709423}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a38631cd7417..5ebd4c5ebf28 git log a38631cd7417..5ebd4c5ebf28 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 perezju@chromium.org [Telemetry] Validate response of Tracing.start request Created with: gclient setdep -r src/third_party/catapult@5ebd4c5ebf28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1011232 Change-Id: I62f86a5ca84656e3efee84f0e85ff1c3e9507554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880662Reviewed-by:
-
Mario Sanchez Prada authored
Convert the remaining bits referencing the viz::mojom::Gpu and the viz::mojom::GpuMemoryBufferFactory mojo interfaces using the old APIs to the new mojo types. TBR=kinuko@chromium.org Bug: 955171 Change-Id: Ib210e455a9642803d6414e6daf42756eb929e0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876350 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#709421}
-
Roman Aleksandrov authored
Add ChromeOS device DeviceShowNumericKeyboardForPassword policy. It will be used to show numeric keyboard on the login screen to enter password. Bug: 1015743 Change-Id: I22b9400be32195fd5ac136a3d1ea0434b6e904eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872225Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#709420}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ff7d06ba71fd..cfa4b4a65a57 git log ff7d06ba71fd..cfa4b4a65a57 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 eseckler@google.com Merge "processor: Handle chrome traces with clock_id but no ClockSnapshot" Created with: gclient setdep -r src/third_party/perfetto@cfa4b4a65a57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I0074a4fa9fa48bf8ee7f607847c641dfd6db3846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880573Reviewed-by:
-
Mario Sanchez Prada authored
Convert the remaining bits related to the viz::mojom::CopyOutputResultSender and viz::mojom::TextureReleaser interfaces to the new mojo types. Bug: 955171 Change-Id: Id1fd4e81e9c4708516ef03a9ec69d6b272a1fde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872065 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#709418}
-
Robbie McElrath authored
This metric records the number of consecutive times the WebView browser process starts with a stale seed. It's written when a fresh seed is loaded after previously loading a stale seed. Test: Manually verified with logging that the metric was written. Bug: 1010625 Change-Id: Iadedb45af08d59ecd6662472670f848e8e99a8d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851126 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709417}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients for the viz::mojom::VideoDetectorObserver interface to the new mojo types, and adapt unit tests. Bug: 955171 Change-Id: Icb678b4070bc69045f901e4454565cd121fa8564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875262 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
-
Yuzu Saijo authored
This CL enables ServiceWorkerOnUI on BackForwardCache related trybots because BackForwardCache will be dependent on ServiceWorkerOnUI feature after the CL below: https://chromium-review.googlesource.com/c/chromium/src/+/1782247 Change-Id: I29f9a6c8d9abbc193f2236bd2e9a963e70df7407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863057Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#709415}
-
Wei Lee authored
This CL returns the window url when the window is created so that tests could distinguish between regular instance and intent handling instance. This CL is needed for adding corresponding tests in tast.camera.CCAUIIntent: https://crrev.com/c/1858065 Bug: b/139650048 Test: tast run [DUT] camera.CCAUIIntent Change-Id: I7eb0d06932bd1cddf6709f291897659dda0c5769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859420 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#709414}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/28fc8a61d004..57b9fe40c414 git log 28fc8a61d004..57b9fe40c414 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@57b9fe40c414 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7cc1bb0c9c8d8045267d874495fd4a3a5fee6e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880660Reviewed-by:
-
Armando Miraglia authored
After the launch on all platforms of the audio service, this code path is unused hence the associated metrics is not needed any longer. BUG=906934 Change-Id: I4e6527116a291fcbf681abd72ed81c73d17ccabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878768Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#709412}
-
Jose Dapena Paz authored
Add #include <vector> for using std::vector. This fixes GCC build. ./../chrome/browser/apps/launch_service/launch_manager.h:46:15: error: ‘vector’ in namespace ‘std’ does not name a template type static std::vector<base::FilePath> GetLaunchFilesFromCommandLine( ^~~~~~ Bug: 819294 Change-Id: I02ec3a2914a8fbe3aa0041017a0228f4b0ca1ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879289Reviewed-by:Alexey Baskakov <loyso@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#709411}
-
Yoshifumi Inoue authored
This patch changes |LayoutText::GetTextBoxInfo()| to use |NGInlineCursor| to reduce usage of |NGPaintFragment| for preparation of migrating |NGFragmentItem|. Bug: 982194 Change-Id: Ib37fae0241efaca73184710cc0af3050a041bde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880890 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
Flaky crashes in prediction_metrics_handler.cc NOTRY=true TBR=crouleau@chromium.org Bug: 1017661 Change-Id: I5a17d19a19231bbc2d5b36a7d20d12bd5c639ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879232Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#709409}
-
arthursonzogni authored
1) The test has been fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/1816509 The fix was to flush the BackForwardCache to avoid the FrameHostInterceptor to miss "simulating RenderFrameHostCreated" on the RenderFrameHost in the BackForwardCache. 2) Flushing the cache became asynchronous, which caused the test to fail again. https://chromium-review.googlesource.com/c/chromium/src/+/1807321 In this CL, instead of flushing the BackForwardCache, we create the FrameHostInterceptor before the navigations. That way, it can correctly index every created RenderFrameHost. It won't have to simulate receiving RenderFrameHostCreated anymore. Bug: 1017605 Change-Id: I882d459e53a84331f4ec8dfaa4df1b07cc160c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878187Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#709408}
-
Steve Becker authored
Updates postMessage() to clone FileSystemFileHandle and FileSystemDirectoryHandle objects for same origin targets. Including a FileSystemHandle object with a cross origin message fails by dispatching a 'messageerror' event instead of 'message' event. The change consists of four parts: (1) Updates V8ScriptValueSerializerForModules to serialize FileSystemFileHandle and FileSystemDirectoryHandle into blink::SerializedScriptValue, by following these steps: * Write a tag for the handle type (file or directory). * Write the name of the file or directory. * Creates a mojom::blink::NativeFileSystemTransferTokenPtr by calling blink:NativeFileSystemHandle::Transfer(). This token informs the storage::NativeFileSystemManagerImpl that a transfer is in progress. The NativeFileSystemManagerImpl creates a NativeFileSystemTransferTokenImpl to store the information required to clone the handle. * Stores the token in blink::SerializedScriptValue::native_file_system_tokens_. This array tracks all cloned FileSystemFileHandle. The blink::mojom::CloneableMessage struct is also updated to hold this array for MessagePort and BroadcastChannels. * Write the index of the token in the native_file_system_tokens_ array. (2) Updates V8ScriptValueDeserializerForModules to deserialize FileSystemFileHandle objects when creating clones for the message targets. This is the inverse of (1). Deserializing uses mojom::blink::NativeFileSystemManager to redeem the token, which creates the mojom::blink::NativeFileSystemFileHandlePtr or mojom::blink::NativeFileSystemDirectoryHandlePtr using the info stored by NativeFileSystemTransferTokenImpl. (3) Updates content::NativeFileSystemManagerImpl to support token transfers. To redeem a token, NativeFileSystemManagerImpl receives a mojo message that includes the token as well as a request for a handle interface like mojom::blink::NativeFileSystemFileHandlePtr. NativeFileSystemManagerImpl finds the token and then binds the request. Token redemption does not return any results. Token redemption should never fail, unless a render process is misbehaving. NativeFileSystemManagerImpl performs a few sanity checks before binding the mojo request, including a token existence check, a handle type check and an origin check. If any of the sanity checks fail, NativeFileSystemManagerImpl silently fails closing the redeemed FileHandle's pipe. (4) Adds a cross origin check to window and message port messaging. Most message targets, like dedicated workers, are same origin only. However, both windows and message port messages can go cross origin. When a cross origin message includes a FileSystemHandle, the message must fail with a 'messageerror' event to prevent cross origin access to the FileSystemHandle. Messaging between windows already included origin information before this change. This change adds a NativeFileSystem origin check before dispatching a message event to a window. The message event is replaced with a message error when a cross origin NativeFileSystem object exists in the message data. For message ports, no sender origin information existed before this change. This change updates the CloneableMessage structs to include a 'sender_origin' url::Origin property. Message ports use this property to perform the same cross origin NativeFileSystem check as the window. The NativeFileSystemManagerImpl performs an additional origin check before binding the FileSystemHandle mojo request. The NativeFileSystemManagerImpl cannot trust the postMessage() origin check performed in the render process. Bug: 955192 Change-Id: Ieeb76bd8102067d70c5d7719622ecd4930c3a88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791942 Commit-Queue: Steve Becker <stevebe@microsoft.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#709407}
-
Yi Su authored
This reverts commit 4fcce6d7. Reason for revert: SCBadgeTestCase.testBadgesVisible is failing consistently after this CL: https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/5469 Original change's description: > [ios] Fix BadgeViewController interpretation of badgeState > > Since BadgeState is a mask, a direct equality comparison to > BadgeState values for the BadgeItem properties is not the correct > way to assess if a badge is accepted. > > To add testing support for this case, accepted a11y identifiers > for BadgeButtons are created, and they will be properly set > in setAccepted: in BadgeButton. > > Bug: 976901, 1016793 > Change-Id: Id17eb82e0764fbbf80b871df0b974fe148c2339f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872938 > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Reviewed-by: Peter Lee <pkl@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709037} TBR=pkl@chromium.org,sczs@chromium.org,thegreenfrog@chromium.org Change-Id: I7cc7f67cbb24a962388c2079a71e9e168c32fdfb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976901, 1016793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880029Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#709406}
-
Oriol Brufau authored
In the other reftests the width of the marker text is not known, so the references have to rely on some tricks with the ::before pseudo-element. This patch adds a test that uses the Ahem font, so that the width of the characters is known. Then the result can be checked with a simpler reference file. Note it fails in LayoutNG due to the lack of scrollbar (bug 1012294), but it passes in legacy. Bug: 687946 Change-Id: I7fd0856e93d4e489af65b5c767ec81c109804c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879067 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#709405}
-
