- 21 Apr, 2020 40 commits
-
-
Kurt Horimoto authored
The previous implementation returned whether or not the active request was set to a non-null value. However, this is not always correct because there is a brief period between the overlay UI's dismissal and the resetting of OverlayPresentationContextImpl state during which the request is non-null, but its overlay UI is dismissed. This caused breakage for queued OverlayRequests, as OverlayPresenterImpl only attempted to present UI for a subsequent request if the context returned false from this function. Since the context reported that it was still showing overlay UI, the next request was not presented and the context cleaned its state up by resetting its presentation capabilities to kNone. If the prior request required UIViewController presentation, this resulted in the dismissal of the presentation context view controller. When the OverlayPresenterImpl is notified of the updated kNone presentation capabilities, it then attempted to present the next request. If the next request also required UIViewController presentation, this attempted to re-present the presentation context view controller and this presentation would no- op since the previous view controller was not finished being dismissed. This CL updates IsShowingOverlayUI() to return false if the dismissal callback for the active request has already been executed, which prevents the early return in OverlayPresenterImpl's PresentOverlayForActiveRequest(). As an implementation detail, this CL updates GetRequestUIState() to use const std::map APIs so that it can be called from IsShowingOverlayUI(), which is also const. Bug: none Change-Id: Id3b519f6129838f78d3fdcf0d65436ee4bf74cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159689Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#761129}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ff772a7bcc98..ceb6258ae101 git log ff772a7bcc98..ceb6258ae101 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 amaiorano@google.com CMake: fix astc code not being enabled correctly Created with: gclient setdep -r src/third_party/swiftshader@ceb6258ae101 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib6d74cde9f454a21c14fb7e02c7ba3f1c7196edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159278Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761128}
-
Elly Fong-Jones authored
Bug: 1071877 Change-Id: I3b56e8d59a5383d599105c3d80595222093af460 Tbr: jdonnelly@chromium.org Cc: ender@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159538Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#761127}
-
Toby Huang authored
If an extensions developer pushes an update that requires additional permissions, and the extension was previously approved by the parent, and the parent has set the "Permissions for sites, apps and extensions" toggle to on, then the supervised user should be able to approve the additional permissions and re-enable the extension by themselves without parent approval. Currently, supervised users are not able to accept extension updates requiring additional permissions at all. This CL fixes that behavior. Bug: 1068660,1070760 Change-Id: Icc6af9a8a05f3782a12c2f4e001d7d6470cacefd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140596 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#761126}
-
Ana Salazar authored
The new feature will enable the new app dragging functionality in the launcher. When the user drags an app within the launcher, the apps grid pages will be scaled down to 84% and will show a background card to show them in a more modular way. Bug: 996822 Change-Id: I993693f7ada613760384c981792b57e08ac8f3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159756Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#761125}
-
Bettina authored
This updates the InterstitialAction and PasswordAlertModeOutcome histograms. Bug: 1070243,1070260 Change-Id: I3ac38a9dab9c76c99ee997480c5eca5f498a3746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157684Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#761124}
-
Navid Zolghadr authored
pointerevents/touch-pointercancel.html test verifies the touch and pointer events interaction in single and multi touch point cases when scrolling happens or not. The single touch point portion is already tested as part of wpt/pointerevents/pointerevent_pointercancel_touch.html The two finger interaction is not very well specified and is tested as part of wpt/pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html and that only is missing the pointerid checks that this CL adds as well. Change-Id: I3ee27866dddc02cb87b1082b5a4fe2f9e8ba9220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159577Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#761123}
-
Oksana Zhuravlova authored
Since ReportValidationError() already logs the description from its |context| parameter, there is no need to pass the description separately. Test: temporarily triggered the deserialization error and confirmed the error message has only one instance of interface name and method number Change-Id: I813052bbaf4485d1fd269174b3a645535f548c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157721 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#761122}
-
David Grogan authored
An item that stretches to a flexbox's previously-indefinite height should use cached results when its sibling item changes the flexbox's height. NG is slower than legacy but there's a fix at https://chromium-review.googlesource.com/c/chromium/src/+/2154489 Bug: 845235 Change-Id: I4687742c20cae6aaa97bf34933c458f4308b8837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158490Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#761121}
-
Eugene But authored
This CL extends expiration dates for the following histograms, which are still useful: - Download.IOSPresentAddPassesDialogResult - Download.IOSDownloadReplaced Bug: 1072568 Change-Id: I5341bf921aa65004d6462221ae2398d48b15a17f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157898 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#761120}
-
Dominic Mazzoni authored
This change moves some of the code from BlinkAXTreeSource::SerializeNode to AXObject::Serialize. That will allow us to get rid of a lot of interfaces in WebAXObject. Bug: 1068668 Change-Id: Ic4b9a81ea4b79e25119ac7582429476971606103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140593 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#761119}
-
Robert Ogden authored
Allows the connection listener to take ownership of a connection's socket once a response has finished being written. This is being exposed to allow the EmbeddedTestServer to act as a CONNECT proxy tunnel for testing the IsolatedPrerender feature (see chained CL). Bug: 1067300 Change-Id: I47d627262f96a50b09f90a82d140456a797901c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148038 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#761118}
-
Sean Gilhuly authored
Change-Id: I4dfa1a776b17d767708d893fc2c18be9b21ce3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159367Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#761117}
-
Jeroen Dhollander authored
This code was meant to handle volume related queries in ChromeOS, but these queries are actually handled inside LibAssistant. The code I removed expects to handles of the volume through a |device.MODIFY_SETTING| request. Instead, LibAssistant gets a |device.UPDATE_VOLUME| request which it handles here: https://cs.corp.google.com/libassistant/libassistant/internal/assistant/action/device/device_control_module.cc?type=cs&q=libassistant/internal/assistant/action/device/device_control_module.cc+package:%5Elibassistant$&g=0&l=339 After discussing this with the Assistant Device Actions team, I learned that the server can either send device.MODIFY_SETTING or device.UPDATE_VOLUME, based on the client preference. Given that LibAssistant expresses a preference for device.UPDATE_VOLUME, we can safely assume we will never receive a device.MODIFY_SETTING request. Test: queries "increase volume", "set volume to 20%", "increase volume by 5". Bug: b/154040671 Change-Id: I763f4d1d1ace0924f81faf7f33eb7cc364e99d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157585 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#761116}
-
Joshua Pawlicki authored
This callback can be called more than once, for example once for a differential update and then (if that fails) again for a full update. Bug: 1071475 Change-Id: I6d5ebce996aa13ece5b5d1d088eb1a9fff31d2c0 Fixed: 1071475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159534 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#761115}
-
Oystein Eftevaag authored
These calls were already being done in ChromeMainDelegate::BasicStartupComplete() resulting in the Renderer/GPU main threads to be sampled twice. R=avi@chromium.org Bug: 1067416 Change-Id: I5e7f57989fde11224c905f092483185ab5be54e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154402Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#761114}
-
Nasko Oskov authored
This test was disabled on some bots due to flakiness. I am updating the test to explicitly wait for process crash, which will likely eliminate the source of flakiness and updating some of the code to take advantage of newer test methods instead of using base::StringPrintf. Bug: 974787 Change-Id: I68182c88905f187b972d93da3504e701a82b96d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159318Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#761113}
-
chrome://flagsKatie D authored
This will help us test the feature in Canary! Bug: 1055150 Change-Id: I02a5deb241dfd26ddf4dc58a84f04a79b1c3d227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158008Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#761112}
-
Dana Fried authored
Much more reliable capture based on a state machine. Now thumbnail capture walks through the following steps: - Navigating to new page - Navigation complete - Capture requested - Frame capture - Cooldown* - Capture complete** * Cooldown allows us to continue capturing for a short period of time after a page indicates it's loaded; this gives the renderer time to actually draw the final version of the page ** Once we've captured a background page, there's no further need to try to capture it again unless it navigates, or the user makes it active, interacts, and then leaves again (a case we handle separately). Typically these states move forward. However, there are potential issues with trying to frame capture a visible/active tab, so we pause video capture while a page is active and then return to capturing it after the user switches away. Since we do not show preview images for the current tab in desktop mode, it's not a problem. For tablet mode (Mohnstrudel), if the tabstrip is observing the thumbnail image for the current tab, the tab will be captured. This complex behavior of stepping forward and backwards based on whether a tab is visible, being observed, etc. is all handled by ThumbnailTabHelper::ThumbnailTabHelperState::UpdateCaptureState(). Still to do: - Create a queue of thumbnails to be captured that prioritizes thumbnails for pages that are being or have recently been observed, to actively limit the number of thumbnails we are trying to observe at once in order to save memory. In-flight thumbnails are uncompressed, which can have a significant impact on RAM usage. Bug: 1057713, 1059862, 1068459 Fixes: 1068459 Change-Id: If81798c0d3df26a5c309e834483042a5b5f24857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145161 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#761111}
-
Collin Baker authored
TBR=ellyjones@chromium.org Bug: 956191 Change-Id: I335e377a40aa937917f95a799e6609c0b2489afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159422Reviewed-by:
-
Brandon Wylie authored
Change-Id: I4c02e2326922ff76fdbc3a4a9a4dcd053bcf0e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158930Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#761109}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d3f79db3fdef..09e523d4093e git log d3f79db3fdef..09e523d4093e --date=short --first-parent --format='%ad %ae %s' 2020-04-21 michael.liao@microsoft.com [Elements]: Fixing failure when onNodeResolved receives a null parameter Created with: gclient setdep -r src/third_party/devtools-frontend/src@09e523d4093e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1071952 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If042c65030ad8e1fc4687dc15953e8ecc3969d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159281Reviewed-by:
-
Leon Scroggins III authored
Bug: skia:10154 This file is being moved in https://skia-review.googlesource.com/c/skia/+/284721. Once that CL lands in upstream Skia, there will be no need to remove it, since Skia's build files will not tell the build system to build it. Change-Id: Ib886325168042f7fe6ce279182462b0200f1ae11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158929 Auto-Submit: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#761107}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //ipc. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=jam@chromium.org Bug: 714018 Change-Id: I323ecd822f7dbf4eefdf4cabf29a39d21d2e0ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132260 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: -
Edman Anjos authored
arc-keymasterd should run while ARCVM runs in order to serve the Keymaster HAL service. This change starts arc-keymasterd in the per board feature flow, ensuring the service is stopped and restarted if it's already running. The change https://crrev.com/c/2153037 enables the D-Bus policies needed and must land before this one. && autoninja -C out/Default components_unittests && out/Default/components_unittests --gtest_filter='ArcVm*' - verify `status arc-keymasterd` says it is running Bug: b:153278258 Test: gn gen out/Default --args='target_os = "chromeos"' \ Test: manual - deploy chrome to an eve-arc-r device and sign in Change-Id: Ib79c0e407c3724cc9511162103b1196b09a66fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153038 Commit-Queue: Edman Anjos <edman@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#761105}
-
Hans Wennborg authored
Fix code that was implicitly depending on logging.h or its dependencies. For example, code that uses DISALLOW_COPY_AND_ASSIGN should include base/macros.h, but it currently happens to work if it pulls in logging.h directly or through some dependency. This is part of refactoring the codebase to use check.h/check_op.h for the CHECK and CHECK_op macro instead of logging.h. Bug: 1031540 Change-Id: I723f79de3ff4f75df75d899922980576db23551e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157105Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/09aea59a8d8b..9c7b4453b116 git log 09aea59a8d8b..9c7b4453b116 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 rslawik@google.com Merge "Thread time_in_state metric" Created with: gclient setdep -r src/third_party/perfetto@9c7b4453b116 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1de2c714e7226f87ed4d8987a09d42a70e9d5439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159274Reviewed-by:
-
Nate Chapin authored
ResizeObservers are ExecutionContextClients, have them take a LocalDOMWindow or a ScriptState in the constructor (instead of a Document). Since ResizeObservers are strongly tied to a ResizeObserverController, their object associations should match, so ResizeObserverController should be per-LocalDOMWindow. Make it a Supplement<LocalDOMWindow>, since Document doesn't use it directly. Bug: 1029822 Change-Id: Ib57d50ab4973d7abfdeb0ba40870cb354a8e06df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106571 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#761102}
-
Ben Pastene authored
Change-Id: Ib5b4cfc157715273115baf6907fbf8211662bbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159747Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#761101}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Bug: 1029822 Change-Id: I208d233652916cbb19b06e24090289995012611c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111066 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c5db0b25. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." daae887f "CookieStore: Add validation behavior for __Host- prefixed cookies" b9d8ee54 "[WPT] Fix paths in svg-image-orientation.html and ref" 502e3797 "ServiceWorker: Fix timeout on client-navigate.https.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I59a06de43b3ac5df5cb154ec5b258bba90cd0400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159253Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761099}
-
Wenyu Fu authored
Bug: 1068831 Change-Id: I6d6aefb0b6e2f787d40da742ab4214eee9695812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159316 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
During flex-row layout we typically perform three passes: 1) Determine the min/max sizes. 2) Layout with a non-stretched size. 3) Layout with a stretched size. Previously we were using the "layout" cache slot for both steps, (2, 3). This patch changes step (2) to use the "measure" cache slot. This also updates the simplified layout pass to abort if it is trying to use a fragment from the "measure" pass, which was triggering a DCHECK. Bug: 845235, 1072429 Change-Id: Ib98187e09b23e86d67b39306a24318e9e932ca60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154489 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#761097}
-
Yuke Liao authored
This CL sets up win64 official ci and try bots, and one of the use cases is for PGO auto roller to validate the profiles and warm up GOMA caches for other official builders. Bug: 1071576 Change-Id: I234cac58eb473bdf7834d584c0615ce771fd9dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159530Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#761096}
-
Roberto Carrillo authored
62 Builders will now have their test results exported to luci-resultdb.chromium.ci_test_results R=nodir,chanli,bpastene Bug: 1048825 Change-Id: I98630e07043e76f65d929b8e73317858a0df8aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157718Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#761095}
-
Charlie Harrison authored
As documented in crrev.com/c/2151840, the host variant of GetDomainAndRegistry has non-ideal performance if callers are using already-canonicalized hosts (e.g. those pulled from GURL or Origin). This CL migrates a few callers where this is obviously happening (i.e. where no significant plumbing is needed to get access to an underlying Origin or GURL). This CL has no intended behavior change. Bug: None Change-Id: Ia39f87f0ab1df20b9350b7e68aa5a7ea6ea66aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153573 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#761094}
-
Devlin Cronin authored
The NotificationService is deprecated. Remove two notifications from it: NOTIFICATION_EXTENSION_COMMAND_ADDED and NOTIFICATION_EXTENSION_COMMAND_REMOVED. These (as the names imply) were used to notify of when an extension command was added or removed, but can be substituted with the CommandService::Observer. This also fixes a bad cast bug. Bug: 411569 Change-Id: I7b2f0a1cf006a80d62571d20cf8a20968f2d0ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155248Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#761093}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e59f718fc277..efb2133b0dd3 git log e59f718fc277..efb2133b0dd3 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 brianosman@google.com Update CK particle examples 2020-04-21 bsalomon@google.com Notify RTC when OpsTask is closed so it can drop ownership 2020-04-21 egdaniel@google.com Create a shared spirv uniform and varying handling class. 2020-04-21 robertphillips@google.com Add path renderer selection spew 2020-04-21 jvanverth@google.com Implement GrD3DGpu::onReadPixels and GrD3DGpu::onWritePixels. 2020-04-21 lepton@chromium.org Allow empty rendertests commandline flags. Created with: gclient setdep -r src/third_party/skia@efb2133b0dd3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: I9564145e4938b767261bc992a81ac6163357278e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159141Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/811efc06df3d..f2b06ce5c82d git log 811efc06df3d..f2b06ce5c82d --date=short --first-parent --format='%ad %ae %s' 2020-04-21 sprang@webrtc.org Reduces unnecessary thread wakeups in TaskQueuePacedSender. Created with: gclient setdep -r src/third_party/webrtc@f2b06ce5c82d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5007215bc255585cbe7d4c5541962e2653b701e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159277Reviewed-by:
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //services. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=rockot@google.com Bug: 714018 Change-Id: Ic3a80f8510f9ee5fc50549a07e28803aa7cccc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132374 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
