Commits · d8234d2f9c6addca17f8917143512944dc299800 · eriksson monteiro / tangled

18 Jul, 2014 40 commits

generate_stubs: Add a new option --export-macro. · d8234d2f

rsesek@chromium.org authored Jul 18, 2014

This allows specifying the shared_library MODULE_EXPORT constant so that stub
symbols can be called across shared library boundaries.

BUG=none
R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/403493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284210 0039d316-1c4b-4281-b951-d872f2087c98

d8234d2f

Roll dom_distiller_js · ff294095

yfriedman@chromium.org authored Jul 18, 2014

Picked up changes:
047ef5d Hookup the MarkupParser into title detection.
885a0af Also track whitespace text in TextBlocks.
39ef3db Add more colors to debug output.
0577e31 Add comments about UnicodePatternGenerator ranges
805c65e Simplify iteration in *RulesClassifier
fe610d7 Make debug output colorful
edc26e0 Introduce a DomDistillerTestSuite for running multiple tests in one context.
7a7f948 Convert relative "poster" attribute to absolute for HTML5 video.
73225c7 Remove unused Clone method from TextDocument/TextBlock.
bb65cef Don't merge non-content lists with trailing content.
3d00eba check for opacity for element visibility
79f3bae ignore invisible page links
8416ada Allow DocumentTitleMatchClassifier to match repeated titles.
8dade4b Fix id check for comment exclusion.
7f91f0d improve heuristics for tables in eval set
5fa3c95 Make DomDistiller's text-only output include all extracted text.

BUG=367233,368941,376107,378385,380792,381973

Review URL: https://codereview.chromium.org/403803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284208 0039d316-1c4b-4281-b951-d872f2087c98

ff294095

Move adb_profile_chrome to profile_chrome. · 46d8f4c5

alokp@chromium.org authored Jul 18, 2014

This is being done with the intention to port this tool to other
platforms. The first step is to move the existing code to a common
location.

Review URL: https://codereview.chromium.org/402803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284207 0039d316-1c4b-4281-b951-d872f2087c98

46d8f4c5

Adding v new p9 page to tough_video_cases. · 415038a6

prabhur@chromium.org authored Jul 18, 2014

Review URL: https://codereview.chromium.org/396213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284206 0039d316-1c4b-4281-b951-d872f2087c98

415038a6

Land Recent QUIC Changes. · a692ad9d

rtenneti@chromium.org authored Jul 18, 2014

Cleanup and adding GetCongestionControlType.

Merge internal change: 71125139
https://codereview.chromium.org/400813002/

QUIC test only change to add track the observed loss rate in
SendAlgorithmSimulator.

Merge internal change: 71116533
https://codereview.chromium.org/399763004/

Minor formatting changes to keep the code similar to internal tree.

Merge internal change: 71059110
https://codereview.chromium.org/393283005/

Add more testing to QUIC's BbrTcpSender to verify it shares bandwidth
fairly with itself.

Also includes fixes to SendAlgorithmSimulator.

Merge internal change: 71000950
https://codereview.chromium.org/399793002/

Will merge BbrTcpSender changes in a future CL after the approvals.

Add a DLOG that indicates the peer sent us a QUIC_PUBLIC_RESET. Makes it
more obvious why the connection ended when running the quic_client.

Merge internal change: 70900278
https://codereview.chromium.org/399793002/

QUIC test only change to add a convenience operator for printing
SendAlgorithmSimulator stats.

Merge internal change: 70897829
https://codereview.chromium.org/399773003/

Adds dynamic setting of FEC group size based on the connection's current
congestion window.

There will be two triggers for transmitted an FEC packet, when
protection is required -- max_packets_per_fec_group, and an FEC alarm
that triggers an FEC packet if the FEC group has been open for long
enough. This CL implements dynamically setting
max_packets_per_fec_group. The FEC alarm will be written in a
subsequent CL.

Merge internal change: 70821636
https://codereview.chromium.org/398873003/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/399153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284205 0039d316-1c4b-4281-b951-d872f2087c98

a692ad9d

about_os_credits.html: Update ChromeOS license information. · 3a9ea284

dgarrett@chromium.org authored Jul 18, 2014

This update was generated on ChromeOS with:

chromite/licensing/licenses --board x86-alex -a -out about_os_credits.html

BUG=chromium:379056
TEST=Diffed license files, the changes appear to match reality.



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284204 0039d316-1c4b-4281-b951-d872f2087c98

3a9ea284

Fix data race with synthetic delay initialization · 1ad54bb7

skyostil@chromium.org authored Jul 18, 2014

The synthetic delay macro initializes a local atomic variable to point
to a delay implementation class. Because initializing the class involves
writing data to memory which is subsequently deferences through the
atomic pointer, we need to use memory barries when updating the pointer
to make sure the data behind it is committed.

Thanks to Alexander Potapenko for spotting this.

Review URL: https://codereview.chromium.org/392933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284203 0039d316-1c4b-4281-b951-d872f2087c98

1ad54bb7

Audit the last time the media stream content settings have been used. · 194cf64f

dhnishi@chromium.org authored Jul 18, 2014

This will be used as part of a resource/permission manager which will allow users to easily see and modify which permissions are being granted to which websites.

Design Doc: https://docs.google.com/document/d/1oQwmj3AU4QYhTyGrYEGr6zaZhHUfx-wqUgEcQGbUU-U/edit?usp=sharing

BUG=372607

Review URL: https://codereview.chromium.org/398373006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284202 0039d316-1c4b-4281-b951-d872f2087c98

194cf64f

Get rid of the rest of CreateStringValue · 04be9805

estade@chromium.org authored Jul 18, 2014

BUG=160586

Review URL: https://codereview.chromium.org/388963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284201 0039d316-1c4b-4281-b951-d872f2087c98

04be9805

Implement argument validation for chrome.cast.channel.{open,send} · 434a6e8d

mfoltz@chromium.org authored Jul 18, 2014

Cleanup namespace usage in cast_channel_api.h.

TESTED=Browser test.  Manually with Cast extension
BUG=331165

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266804

Review URL: https://codereview.chromium.org/255443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284200 0039d316-1c4b-4281-b951-d872f2087c98

434a6e8d

Revert of Experimentally disable termination on heap corrruption in order to... · 8c72dfe7

tonyg@chromium.org authored Jul 18, 2014

Revert of Experimentally disable termination on heap corrruption in order to measure the contribution of this… (https://codereview.chromium.org/402723002/)

Reason for revert:
Crashes chromium.perf bots.

	ChildEBP RetAddr  
	0052f9f4 6a47d2ff chrome_69f00000!base::debug::BreakDebugger+0x10
	0052fa64 6a47df08 chrome_69f00000!CheckIsChromeSxSProcess+0x26
	0052fa68 6a47e664 chrome_69f00000!InstallUtil::IsChromeSxSProcess+0x16
	0052fa70 6a47e53b chrome_69f00000!BrowserDistribution::GetSpecificDistribution+0x3b
	0052fa78 6a47bb77 chrome_69f00000!BrowserDistribution::GetDistribution+0x7
	0052fb64 6a47bb2e chrome_69f00000!`anonymous namespace'::GetChromeChannelInternal+0x2c
	0052fb7c 6a2d03f8 chrome_69f00000!GoogleUpdateSettings::GetChromeChannel+0x21
	0052fbe8 6a2cd0d8 chrome_69f00000!chrome::VersionInfo::GetChannel+0x60
	0052fbec 6a2cd1ab chrome_69f00000!`anonymous namespace'::GetBeaconKeyPath+0x5
	0052fc08 6a2cc624 chrome_69f00000!ShouldExperimentallyDisableTerminateOnHeapCorruption+0xe
	0052fc50 0020720b chrome_69f00000!ChromeMain+0x42
	0052fce0 00206c36 chrome!MainDllLoader::Launch+0x15f
	0052fd24 00228c9e chrome!wWinMain+0x5a
	0052fd70 766e338a chrome!__tmainCRTStartup+0xfd
	WARNING: Stack unwind information not available. Following frames may be wrong.
	0052fd7c 76f99f72 kernel32!BaseThreadInitThunk+0x12
	0052fdbc 76f99f45 ntdll!RtlInitializeExceptionChain+0x63
	0052fdd4 00000000 ntdll!RtlInitializeExceptionChain+0x36

Original issue's description:
> Experimentally disable termination on heap corruption in order to measure the contribution of this feature to missing crash reports.
> 
> Because this feature is configured very early in the process lifetime it cannot be directly controlled by a field-trial. Rather, we query the status during a given execution, store that status in the registry, and then query the registry during startup. This means the experiment will only take effect the 2nd time it is executed.
> 
> BUG=394842
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284100

TBR=jochen@chromium.org,brettw@chromium.org,jhawkins@chromium.org,wfh@chromium.org,erikwright@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=394842

Review URL: https://codereview.chromium.org/401913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284197 0039d316-1c4b-4281-b951-d872f2087c98

8c72dfe7

Revert 284177 "Make NativeViewHostAura clipping window non-focus..." · 0977aa52

waffles@chromium.org authored Jul 18, 2014

Reason for revert: use-after-free with #3 0x897b331 in
views::NativeViewHostAura::ClippingWindowDelegate::CanFocus()
ui/views/controls/native/native_view_host_aura.cc:43 in the stack trace.
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/5437

> Make NativeViewHostAura clipping window non-focusable.
> 
> This CL fixes an issue where the clipping window would get a focus event
> when the SadTab was displayed causing the focus to be set to nothing,
> disabling all keyboard shortcuts.
> 
> This is fixed by making the clipping window nonfocusable.
> 
> BUG=393119
> 
> Review URL: https://codereview.chromium.org/397493005

TBR=calamity@chromium.org

Review URL: https://codereview.chromium.org/403853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284196 0039d316-1c4b-4281-b951-d872f2087c98

0977aa52

Refactor WebCrypto code. · d008566b

eroman@chromium.org authored Jul 18, 2014

Split up the monstrously large platform_crypto_nss.cc, platform_crypto_openssl.cc into multiple files.

-----------
Overview:
-----------

* algorithm_implementation.h:

This defines a base class AlgorithmImplementation, which has virtual methods for synchronous encrypt/decrypt/generatekey. All of the information about an algorithm is now encapsulated by an AlgorithmImplementation. So for instance the JWK specific knowledge, key usages for each key type are pulled into this interface.

* algorithm_registry.cc:

Contains a mapping from WebCryptoAlgorithmID --> AlgorithmImplementation, stored by a singleton.

* algorithm_dispatch.cc:

Given parameters from Blink, looks up the appropriate AlgorithmImplementation in the registry and dispatches the operation. Also implements wrap/unwrap in terms of encrypt/decrypt.

* structured_clone.cc:

Contains the code related to structured cloning (which still needs some cleanup, and is implemented in terms of import/export).

* nss/*, openssl/*:

Contains the AlgorithmImplementation concrete classes for each algorithm. 

This reorganization also unintentionally fixes a few bugs.

  * ExportKey() for spki/pkcs8/raw uses the already serialized key data rather than re-exporting
  * Some exception codes were fixed.

BUG=389325,389342,389327,374912

Review URL: https://codereview.chromium.org/379383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284192 0039d316-1c4b-4281-b951-d872f2087c98

d008566b

Really disable clang's SLP vectorizer on Linux. · b31dbfcc

thakis@chromium.org authored Jul 18, 2014

Follow-up to https://codereview.chromium.org/393193003/ .
-fno-slp-vectorize was passed before -O2 on linux, and -O2 would
reenable it. I checked that the order of -O3 and -fno-slp-vectorize
is correct as-is on Mac.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/408523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284191 0039d316-1c4b-4281-b951-d872f2087c98

b31dbfcc

clang/win: Make winstorage:: not ambiguous. · 5443d65b

thakis@chromium.org authored Jul 18, 2014

stdafx.h declared a global winstorage namespace alias, this file
declared a winstorage namespace alias in an unnamed namespace.
clang correctly points out that

  error(clang): reference to 'winstorage' is ambiguous
  note(clang): candidate found by name lookup is 'winstorage'
  note(clang): candidate found by name lookup is '(anonymous namespace)::winstorage'

Just remove the unneeded duplicate.

BUG=82385
TBR=ananta@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/393083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284190 0039d316-1c4b-4281-b951-d872f2087c98

5443d65b

Update .DEPS.git · 5514928d

chrome-admin@google.com authored Jul 18, 2014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284189 0039d316-1c4b-4281-b951-d872f2087c98

5514928d

revert Skia back to before XP bots started failing · 8a1795a8

scottmg@chromium.org authored Jul 18, 2014

speculative revert to try to resolve XP bot binaries not launching.

R=dpranke@chromium.org
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/407623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284188 0039d316-1c4b-4281-b951-d872f2087c98

8a1795a8

Revert of [Telemetry] Fix a flake in android browser finder.... · 70fcbab8

tonyg@chromium.org authored Jul 18, 2014

Revert of [Telemetry] Fix a flake in android browser finder. (https://codereview.chromium.org/394423002/)

Reason for revert:
BUG=395228

Original issue's description:
> [Telemetry] Fix a flake in android browser finder.
> 
> Traceback (most recent call last):
>   File "tools/perf/../telemetry/telemetry/decorators.py", line 50, in wrapper
>     func(*args, **kwargs)
>   File "/b/build/slave/Android_Tests/build/src/tools/perf/benchmarks/benchmark_unittest.py", line 51, in BenchmarkSmokeTest
>     self.assertEqual(0, SinglePageBenchmark().Run(options),
>   File "tools/perf/../telemetry/telemetry/benchmark.py", line 84, in Run
>     results = page_runner.Run(test, ps, expectations, args)
>   File "tools/perf/../telemetry/telemetry/page/page_runner.py", line 346, in Run
>     possible_browser = browser_finder.FindBrowser(finder_options)
>   File "tools/perf/../telemetry/telemetry/decorators.py", line 26, in Cacher
>     cache[key] = obj(*args, **kwargs)
>   File "tools/perf/../telemetry/telemetry/core/browser_finder.py", line 73, in FindBrowser
>     curr_browsers = finder.FindAllAvailableBrowsers(options)
>   File "tools/perf/../telemetry/telemetry/core/backends/chrome/android_browser_finder.py", line 214, in FindAllAvailableBrowsers
>     pids  = [p.pid for p in psutil.process_iter() if 'adb' in p.name]
>   File "/usr/lib/python2.7/dist-packages/psutil/__init__.py", line 161, in name
>     cmdline = self.cmdline
>   File "/usr/lib/python2.7/dist-packages/psutil/__init__.py", line 188, in cmdline
>     return self._platform_impl.get_process_cmdline()
>   File "/usr/lib/python2.7/dist-packages/psutil/_pslinux.py", line 327, in wrapper
>     raise NoSuchProcess(self.pid, self._process_name)
> NoSuchProcess: process no longer exists (pid=13764)
> 
> Observed here:
> http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14626/steps/telemetry_perf_unittests/logs/stdio
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284144

TBR=dtu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/407633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284187 0039d316-1c4b-4281-b951-d872f2087c98

70fcbab8

Fix infinite loop around FocusManager.onDocumentFocus_() when getFocusParent()... · 70ff25dc

alekseys@chromium.org authored Jul 18, 2014

Fix infinite loop around FocusManager.onDocumentFocus_() when getFocusParent() returns document.body (encountered the problem trying to add FocusManager to Print Preview).

BUG=276784

Review URL: https://codereview.chromium.org/398243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284186 0039d316-1c4b-4281-b951-d872f2087c98

70ff25dc

Update .DEPS.git · 054550b8

chrome-admin@google.com authored Jul 18, 2014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284185 0039d316-1c4b-4281-b951-d872f2087c98

054550b8

Blink roll 178434:178453 · 8dc2e09d

blink-deps-roller@chromium.org authored Jul 18, 2014

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178435:178453&mode=html
TBR=abarth@chromium.org,johnme@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/406593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284184 0039d316-1c4b-4281-b951-d872f2087c98

8dc2e09d

Added frequency stats and c-state residency to CrOS power monitor. · dcf3f642

tmandel@chromium.org authored Jul 18, 2014

BUG=336561

Review URL: https://codereview.chromium.org/352583007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284183 0039d316-1c4b-4281-b951-d872f2087c98

dcf3f642

Apps&Extensions for supervised users: Cleanup · bddf240a

treib@chromium.org authored Jul 18, 2014

Remove an obsolete "already loaded" check.
Allow all component locations, not just Manifest::COMPONENT.

BUG=none

Review URL: https://codereview.chromium.org/404773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284182 0039d316-1c4b-4281-b951-d872f2087c98

bddf240a

Add adb version check to adb_remote_setup.sh. · 65a0687a

newt@chromium.org authored Jul 18, 2014

This ensures that the local and remote versions of adb are the same,
since using different versions of adb will probably result in protocol
errors.

NOTRY=true

Review URL: https://codereview.chromium.org/395393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284181 0039d316-1c4b-4281-b951-d872f2087c98

65a0687a

Video Player: Add a message which is shown on casting · 94bd40d9

yoshiki@chromium.org authored Jul 18, 2014

This patch shows a message like "Playing on xxxx", andd adds the dummy video element which will be used to control the casting video.

BUG=305511
TEST=none

Review URL: https://codereview.chromium.org/397813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284180 0039d316-1c4b-4281-b951-d872f2087c98

94bd40d9

IndexedDB: Fix coding style issues c/o cpplint.py · f3c1e7f6

jsbell@chromium.org authored Jul 18, 2014

Most of these are non-const refs that should be pointers.

BUG=381456
TBR=dgrogan@chromium.org

Review URL: https://codereview.chromium.org/405433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284179 0039d316-1c4b-4281-b951-d872f2087c98

f3c1e7f6

Add initial components unit tests to GN build. · 0260b7a9

brettw@chromium.org authored Jul 18, 2014

R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/398423007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284178 0039d316-1c4b-4281-b951-d872f2087c98

0260b7a9

Make NativeViewHostAura clipping window non-focusable. · e8e29424

calamity@chromium.org authored Jul 18, 2014

This CL fixes an issue where the clipping window would get a focus event
when the SadTab was displayed causing the focus to be set to nothing,
disabling all keyboard shortcuts.

This is fixed by making the clipping window nonfocusable.

BUG=393119

Review URL: https://codereview.chromium.org/397493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284177 0039d316-1c4b-4281-b951-d872f2087c98

e8e29424

[Ozone-DRI] Migrate cursor to using ScanoutBuffer · b794b3fa

dnicoara@chromium.org authored Jul 18, 2014

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/407603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284176 0039d316-1c4b-4281-b951-d872f2087c98

b794b3fa

Disable PrerenderOmniboxBrowserTest.PrerenderOmniboxCancel · 6627e73f

waffles@chromium.org authored Jul 18, 2014

TBR=gavinp
BUG=395152

Review URL: https://codereview.chromium.org/406603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284175 0039d316-1c4b-4281-b951-d872f2087c98

6627e73f

Revert of [DevTools] Move DevToolsWindow testing code to a separate class.... · a9cc57a8

gab@chromium.org authored Jul 18, 2014

Revert of [DevTools] Move DevToolsWindow testing code to a separate class. (https://codereview.chromium.org/395783002/)

Reason for revert:
Mac 10.7 has become flaky for ViewIDTest.Basic (http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%282%29?numbuilds=100) and this CL is suspected as it touches this exact test.

Example crash stack trace below:

BrowserTestBase signal handler received SIGTERM. Backtrace:
0   browser_tests                       0x0132e9ba base::debug::StackTrace::StackTrace() + 26
1   browser_tests                       0x04e5ecb8 _ZN7content12_GLOBAL__N_1L27DumpStackTraceSignalHandlerEi + 72
2   libsystem_c.dylib                   0x9090259b _sigtramp + 43
3   ???                                 0xffffffff 0x0 + 4294967295
4   browser_tests                       0x01328f56 base::AtExitManager::RegisterCallback(void (*)(void*), void*) + 102
5   browser_tests                       0x02614bb4 Singleton\u003Ccc::TaskRunnerPairs, DefaultSingletonTraits\u003Ccc::TaskRunnerPairs>, cc::TaskRunnerPairs>::get() + 276
6   browser_tests                       0x026141e7 cc::BlockingTaskRunner::current() + 23
7   browser_tests                       0x02614762 cc::BlockingTaskRunner::CapturePostTasks::CapturePostTasks() + 18
8   browser_tests                       0x026404eb cc::SingleThreadProxy::Stop() + 59
9   browser_tests                       0x02619e04 cc::LayerTreeHost::~LayerTreeHost() + 132
10  browser_tests                       0x0261a2c1 cc::LayerTreeHost::~LayerTreeHost() + 17
11  browser_tests                       0x04011e94 ui::Compositor::~Compositor() + 148
12  browser_tests                       0x040120c1 ui::Compositor::~Compositor() + 17
13  browser_tests                       0x03fa8dfd -[BrowserCompositorViewCocoa .cxx_destruct] + 173
14  libobjc.A.dylib                     0x995863bf object_cxxDestructFromClass + 104
15  libobjc.A.dylib                     0x99583204 objc_destructInstance + 40
16  browser_tests                       0x021dd2c2 (anonymous namespace)::ZombieDealloc(objc_object*, objc_selector*) + 98
17  AppKit                              0x96b68b39 -[NSResponder dealloc] + 156
18  AppKit                              0x96b66fee -[NSView dealloc] + 74
19  libobjc.A.dylib                     0x9958254e _objc_rootRelease + 47
20  browser_tests                       0x03fa7f16 base::LazyInstance\u003Cbase::scoped_nsobject\u003CBrowserCompositorViewCocoa>, base::DefaultLazyInstanceTraits\u003Cbase::scoped_nsobject\u003CBrowserCompositorViewCocoa> > >::OnExit(void*) + 38
21  browser_tests                       0x013291e2 base::internal::Invoker\u003C1, base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cvoid (*)(void*)>, void ()(void*), void ()(void*)>, void ()(void*)>::Run(base::internal::BindStateBase*) + 18
22  browser_tests                       0x01328e27 base::AtExitManager::ProcessCallbacksNow() + 119
23  browser_tests                       0x01328ec2 base::AtExitManager::~AtExitManager() + 34
24  browser_tests                       0x013bbb20 base::TestSuite::~TestSuite() + 48
25  browser_tests                       0x00b5f783 ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) + 51
26  browser_tests                       0x012fd642 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite(int, char**) + 34
27  browser_tests                       0x04e97e42 content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) + 738
28  browser_tests                       0x012fd5f3 LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) + 67
29  browser_tests                       0x00b5f73d main + 77
30  browser_tests                       0x00039635 start + 53
31  ???                                 0x0000000b 0x0 + 11

Original issue's description:
> [DevTools] Move DevToolsWindow testing code to a separate class.
> 
> This change:
> - allows for proper docking testing (including toolbox);
> - removes all test friends from DevToolsWindow;
> - unifies testing approach to use load callback instead of notifications;
> - adds simple toolbox tests.
> 
> BUG=393566
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284050

TBR=pfeldman@chromium.org,lushnikov@chromium.org,sky@chromium.org,dgozman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=393566

Review URL: https://codereview.chromium.org/403833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284174 0039d316-1c4b-4281-b951-d872f2087c98

a9cc57a8

Update .DEPS.git · 197c92cc

chrome-admin@google.com authored Jul 18, 2014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284173 0039d316-1c4b-4281-b951-d872f2087c98

197c92cc

Roll pdfium. This brings in: · b0c19d04

thakis@chromium.org authored Jul 18, 2014

6256a14  Fix pdfium building issue on VS2010
5eb9f7b  pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac.
a9c29e0  Fix garbled text when loading linearized pdf document
c7cd3c8  Fix building pdfium for x64 with ninja under windows.
3fb18f4  Hook up the default v8::Platform implementation to pdfium

BUG=260112, 249006, 275281, 354966, 365302, 236952
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/398273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284172 0039d316-1c4b-4281-b951-d872f2087c98

b0c19d04

Fixes for wifi side of GCD prototype · 16ee2632

noamsml@chromium.org authored Jul 18, 2014

1.  Moved actual device indicator to config.json
2.  Wireless interface now part of config.json
3.  LED path now part of config.json
4.  udhcpd config now generated by script

This should make the script a fair bit more robust and allow it to work on any
machine.

In addition, updated the SSID to the new format.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/405483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284171 0039d316-1c4b-4281-b951-d872f2087c98

16ee2632

Adding a router class to handle messages that expect responses. · acc18a83

qsr@chromium.org authored Jul 18, 2014

This also introduce the notion of message header to allow routing.

R=rmcilroy@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283767

Review URL: https://codereview.chromium.org/371603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284170 0039d316-1c4b-4281-b951-d872f2087c98

acc18a83

[Password Generation] Trigger confirmation bubble when a password is saved · d07e19ac

gcasto@chromium.org authored Jul 18, 2014

BUG=318977

Review URL: https://codereview.chromium.org/399573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284169 0039d316-1c4b-4281-b951-d872f2087c98

d07e19ac

Update .DEPS.git · 6db3d352

chrome-admin@google.com authored Jul 18, 2014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284168 0039d316-1c4b-4281-b951-d872f2087c98

6db3d352

Roll ICU to icu52 · 9ba3fbcd

jshin@chromium.org authored Jul 18, 2014

The ICU update does the following among other things:
  - Update EUC-JP (no more JIS X 212 round-trip coverage) per WHATWG
    encoding spec.
  - Add CP866
  - Add far better/more extensive support for plural, format, etc
  - Numerous locale data update
  - Khmer/Lao line/word-breaking support
  - More compact Chinese/Japanese dictionary (now a part of the upstream
    instead of our local patch)
  - Better plural support that we plan to use right away.

- Update icu/BUILD.gn : file list update, new defines, etc.
- Update tests
  a. icu_string_conversions_unittests : drop iscii (nobody uses it) and
     remove JIS X 212 code points from the round-trip test
  b. l10n_util_unittests: Display names for zh-*.
  c. ThaiSnippet's expected result. (due to a Unicode grapheme definition change).
  d. Update Expected results in file_manager_browsertest/test_util.js
     (see http://crbug.com/383930)
- Update SpellcheckerWordIterator
  a. Add U+0027 back to MidNumLet
  b. Add Lao and Khmer scripts to the list of scripts requiring dictionary-based
     word-breaking.
- l10n_util : alias 'tl' to 'fil' (Tagalog to Filipino)
- Update IdentityInternalsSingleTokenWebUITest.verifyGetters (DateTimeFormat-Full
  has 'at' before time, which is not handled by Date.parse()
- update license.py because we don't have a separate Chinese/Japanese
  dictionary any more. It's now a part of ICU

Note to Sheriff :
1. 140 ~ 200 kB size increase is expected for all platforms.
This size increase was singed off by laforge@.
The expected size has to be updated with both reva/revb pointing to the
revision corresponding to this CL.

2.  http://codereview.chromium.org/348913002 has to be applied before running make_expectations.py to update tools/perf_expectations/perf_expectations.json
after this CL is landed.


BUG=132145,277023,136148,360433,364072
TEST=base_unittests:*ICU*, net_unittests:*IDN*, ui_unittests:*Lang*,
     browser_tests (encoding related, Iden*verifyGet*),
     unit_tests:Ext*L10*, unit_tests:*Lang*, component_tests:*Snipp*,
     layout tests (encoding, date/calendar, line breaking, and others),
     build 'base_i18n_nacl', GN build bots.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277111

R=arv@chromium.org, brettw@chromium.org, fgorski@chromium.org, groby@chromium.org, hirono@chromium.org, tony@chromium.org, toyoshim@chromium.org

Review URL: https://codereview.chromium.org/265613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284167 0039d316-1c4b-4281-b951-d872f2087c98

9ba3fbcd

ui/gfx: optimize UnPreMultiply operation by checking alpha value · bb9e9d43

hyunki.baik@samsung.com authored Jul 18, 2014

Don't need to do Un-premultiplying operation,
if alpha value equals to 0 or 255.

BUG=none
Test(DONE)=gfx_unittests --gtest_filter="ColorAnalysisTest*"

Review URL: https://codereview.chromium.org/399053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284166 0039d316-1c4b-4281-b951-d872f2087c98

bb9e9d43

Currently, bionic only build a subset of the examples. This changes turns on... · 7539b931

noelallen@chromium.org authored Jul 18, 2014

Currently, bionic only build a subset of the examples. This changes turns on all the examples and tests compiling those examples.

BUG=344574
R=sbc@chromium.org, binji@chromium.org

Review URL: https://codereview.chromium.org/339393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284165 0039d316-1c4b-4281-b951-d872f2087c98

7539b931