- 15 Mar, 2012 9 commits
-
-
thakis@chromium.org authored
73: Delete unused function IsGoodRlz(). 74: Change the unit of several constants from WCHARs to bytes. 75: Start moving functions from win/lib/rlz_lib.h to lib/rlz_lib.h 76: Move GetPingParams() and ParseFinancialPingResponse() to the common code. 77: Move PingFinancialServer to common part. 78: Move FormFinancialPingRequest() to the common part. 79: Address comments from https://codereview.appspot.com/5823050/ BUG=chromium:46579 TEST=should be a no-op change on windows TBR=rogerta Review URL: http://codereview.chromium.org/9699039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126800 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
method to support both nonexistent context and zero-length context. R=agl@chromium.org,rsleevi@chromium.org BUG=none TEST=existing unit tests Review URL: http://codereview.chromium.org/9663043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126799 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
The display names are used for showing the file names in web pages, and for uploading. BUG=chromium-os:27222 TEST=manually confirm that file selection on chrome os works, the files are displayed and uploaded properly. Review URL: https://chromiumcodereview.appspot.com/9700009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126798 0039d316-1c4b-4281-b951-d872f2087c98
-
abodenha@chromium.org authored
Continuation of issue 9648009. Fixes the problem with the print dialog being in the background when launched from the command line by the cloud print print driver. BUG=112011 TEST=No visible changes for chromium. Review URL: http://codereview.chromium.org/9706023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126797 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
The crux of the problem is that buttons and text inputs are being aligned on their baseline, which I believe is correct. However they place their baseline differently relative to the top and bottom border, so the top and bottom borders wind up misaligned. To correct this, we have to add padding to the buttons and/or text inputs. The amount of padding is platform-specific. Using vertical-align: (not-baseline) would work, but would make it look bad because the baselines would not align. BUG=117662 TEST=visual (on win, mac, linux, chromeos) Review URL: http://codereview.chromium.org/9689048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126796 0039d316-1c4b-4281-b951-d872f2087c98
-
enal@chromium.org authored
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126474 Review URL: http://codereview.chromium.org/9689015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126795 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126794 0039d316-1c4b-4281-b951-d872f2087c98
-
ronghuawu@chromium.org authored
Roll webrtc to 1888. BUG=115702,117252 TEST=apprtc.appspot.com on windows and linux Review URL: https://chromiumcodereview.appspot.com/9600066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126793 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
BUG=115650 TEST=LauncherUpdaterTest.*, including new tests Review URL: https://chromiumcodereview.appspot.com/9689047 TBR=davemoore@chromium.org Review URL: https://chromiumcodereview.appspot.com/9702054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126792 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Mar, 2012 31 commits
-
-
scottmg@google.com authored
TBR=abarth BUG=118293 Review URL: https://chromiumcodereview.appspot.com/9703043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126789 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=114745 TEST=Theming works on 10.8. Review URL: http://codereview.chromium.org/9700002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126787 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=117634,118070 TEST=manual Review URL: http://codereview.chromium.org/9696056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126786 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=none TEST=manual Review URL: https://chromiumcodereview.appspot.com/9695067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126785 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126784 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
This pulls in the following Native Client changes: r8009: (kschimpf) Change disassembled output for x86 new decoder to match xed, making it r8010: (kschimpf) Remove assert that is no longer applicable. r8011: (robertm) Undo hacks for qemu which worked around problems with sync primitives. r8012: (robertm) Remove obsolete qemu patches. r8013: (bradnelson) Set errorlevel=1 so fatal error in untarring actually raises. r8014: (dschuff) Add test running support for tests generated as pexes. r8015: (mseaborn) NaClDesc: Rename SendMsg/RecvMsg methods to LowLevelSendMsg/LowLevelRecvMsg r8016: (jvoung) Add workarounds to get libelf building on Mac hosts, for pnacl. r8017: (dschuff) Rename pnacl_stop_with_pexe to pnacl_generate_pexe r8018: (jvoung) Make pnacl version visible from extension / move pnacl info to separate manifest. r8019: (mseaborn) Provide a more extensible startup interface to Chromium r8020: (mseaborn) Move trusted-crash tests into a common directory r8021: (robertm) Adding a simple test for eh_return builtin. r8022: (bsy) fix descriptor refcount leak. r8023: (jvoung) Introduce ProgramNameForNmf() to replace all the local patterns r8024: (bradnelson) Untar toolchain to a mkdtemp dir to avoid collisions with old failed untars. r8025: (bradnelson) Adding validator regression tests. r8026: (robertm) Improve the self documentation of the trusted toolchain creator sctipt. r8027: (mseaborn) Fix linking of sel_main_chrome.c (broken by r8019) BUG=none TEST=nacl_integration Review URL: https://chromiumcodereview.appspot.com/9702039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126783 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Define helper routines for doing array output using the new PP_OutputArray struct. Define routines in the completion callback factory for doing output parameters as parameters to the callback function. BUG= TEST= Review URL: http://codereview.chromium.org/9651002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126781 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
Add OnHasWork() method to TestingObserver. Make TestingObserver a constructor parameter, so it can be read outside the lock. BUG=117469 TEST= Review URL: http://codereview.chromium.org/9689028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126780 0039d316-1c4b-4281-b951-d872f2087c98
-
yzshen@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/9566002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126779 0039d316-1c4b-4281-b951-d872f2087c98
-
saintlou@chromium.org authored
TBR=sky@chromium.org BUG=105508 TEST=none Review URL: https://chromiumcodereview.appspot.com/9701048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126778 0039d316-1c4b-4281-b951-d872f2087c98
-
dyu@chromium.org authored
The GetSecurityState retrieves different security states for the current tab. The GetPageType returns the type of page showing (normal, interstitial, error). Added additional tests that uses the exposed hooks. - testSSLCertOK - testSSLCertIsExpiredAndCertNameMismatches - testSSLCertAuthorityOK TEST=none BUG=none Review URL: https://chromiumcodereview.appspot.com/9535022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126777 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
Revert 126750 (It still times out on the real bots) - Re-enable OriginBoundCertServiceTest on TSAN now that they use ECDSA. BUG=92439 TEST=try bot Review URL: https://chromiumcodereview.appspot.com/9700001 TBR=mattm@chromium.org Review URL: https://chromiumcodereview.appspot.com/9702049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126776 0039d316-1c4b-4281-b951-d872f2087c98
-
wjia@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/9702041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126775 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=100898 R=pkasting@chromium.org,sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/9703034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126774 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=117476 TEST=run base_unittests on Mountain Lion Review URL: http://codereview.chromium.org/9701031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126773 0039d316-1c4b-4281-b951-d872f2087c98
-
jhorwich@chromium.org authored
BUG=118216 TEST= TBR=suzhe@chromium.org Review URL: http://codereview.chromium.org/9701034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126772 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
linux-release-lowmem: 3.5% bloat http time regression http://build.chromium.org/f/chromium/perf/linux-release-lowmem/bloat-http/report.html?history=230&rev=126733 seems to start in 125608, "Roll WebKit r110147:110159" BUG=118252 TBR=cmp Review URL: https://chromiumcodereview.appspot.com/9699051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126771 0039d316-1c4b-4281-b951-d872f2087c98
-
dmikurube@chromium.org authored
It's a retry of r126715 with updating README.chromium. The major reason for us to enable a fix for HEAP_PROFILE_MMAP. Please note that this change doesn't affect Chromium builds. BUG=114302 TEST=none Review URL: https://chromiumcodereview.appspot.com/9702045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126770 0039d316-1c4b-4281-b951-d872f2087c98
-
peter@chromium.org authored
BUG= TEST=The "DumpRenderTree" target on the FYI bot should link. Review URL: http://codereview.chromium.org/9706022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126769 0039d316-1c4b-4281-b951-d872f2087c98
-
jrg@chromium.org authored
BUG=None TEST= Review URL: http://codereview.chromium.org/9705029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126768 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
BUG=None TEST=Visual Review URL: https://chromiumcodereview.appspot.com/9699044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126767 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
Reduce the size of gdata.h and remove gdata.h from gdata_files.h and gdata_file_system.h BUG=NONE TEST=NONE Review URL: https://chromiumcodereview.appspot.com/9700014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126766 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126765 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
BUG=115650 TEST=LauncherUpdaterTest.*, including new tests Review URL: https://chromiumcodereview.appspot.com/9689047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126764 0039d316-1c4b-4281-b951-d872f2087c98
-
tbreisacher@chromium.org authored
BUG=117632 TEST=none Review URL: https://chromiumcodereview.appspot.com/9689050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126763 0039d316-1c4b-4281-b951-d872f2087c98
-
yfriedman@chromium.org authored
This is most of the scaffolding. The logic to choose between Tablet/Phone requires Java code which can't be upstreamed yet due to other dependencies. BUG= TEST= Review URL: http://codereview.chromium.org/9664008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126762 0039d316-1c4b-4281-b951-d872f2087c98
-
mdm@chromium.org authored
of data, in drag action pickles. (The goal is to remove that method entirely. Uses that never persist or send pickles over the network are [probably] safe, but having the method around is waiting for accidental misuses.) Review URL: https://chromiumcodereview.appspot.com/9702013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126761 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
- Resolved several threading issues in and around ParallelAuthenticator. - Made cryptohome async calls respond on the calling thread. BUG=chromium-os:27689 BUG=make sure that you can re-login without crashing to an an existing account on linux workstation. Review URL: https://chromiumcodereview.appspot.com/9694022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126760 0039d316-1c4b-4281-b951-d872f2087c98
-
yfriedman@chromium.org authored
Fixes link errors in PasswordStoreFactory BUG=117407 TEST= Review URL: http://codereview.chromium.org/9669057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126759 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Rename the various 'Controller's to 'Observer's, because that makes more sense, and move these observers from Shell into SystemTray. BUG=110130 TEST=none Review URL: https://chromiumcodereview.appspot.com/9702037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126758 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
r1243 [windows ninja] Starting with additional includes, defines, and some basic cflags and ldflags r1244 Fix CharacterSet map for VS 2010 r1245 mac make: Don't put host shared libraries into the product directory r1246 Unbreak gyptest-toolsets.py on linux R=thakis Review URL: http://codereview.chromium.org/9706029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126757 0039d316-1c4b-4281-b951-d872f2087c98
-