- 17 Aug, 2020 40 commits
-
-
Samuel Huang authored
This CL adds adjustment to /build/config/compiler/BUILD.gn, to exclude ldflags += [ "-Wl,--no-call-graph-profile-sort" ] for WASM. The flag usage was added in http://crrev.com/c/2332591, but it's not yet supported by wasm-ld. Change-Id: I04b1e81569e23f6a0b6f44b5e5544e30a3b0433d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359401 Auto-Submit: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#798613}
-
Chris Sharp authored
Change-Id: Idb5111fb165d139be00cb26aab5f53154d5f3151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356186 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798612}
-
Friedrich Horschig authored
This change should not affect any behavior. This CL moves the change password code out of the coordinator. This keeps the coordinator clean from any logic and helper code so that it remains focused on assembling the component and forwarding events. Bug: 1092444 Change-Id: I2e380cf06403cfe91c39e02e9a65cc3352a44aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352920 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#798611}
-
Javier Ernesto Flores Robles authored
Adds ReauthenticationEvent for tracking reauth events. Logs ManualFallback reauth events. Bug: 1113120 Change-Id: Ia96dfabdbca40610a11f8467746b617f7c67e387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346437 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#798610}
-
Ewann authored
This Cl moves the implementation of the RecentTabsMenuProvider protocol in a separate helper. This helper is used to create context menu from the recent tabs and the tab grid coordinator. Bug: 1093302 Change-Id: I7c78adc6eded30f749b9a2dec8d159306452588a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351974Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#798609}
-
Naoki Fukino authored
This allows users to: - focus file-type filter buttons by TAB key. - toggle state of focused buttons by ENTER or SPACE keys. To do this, we use <button> element instead of default <div> and style them per the design, with html{.pointer-active,.focus-outline-visible} style to control <button> state activations and keyboard focus rings. And since <button> has in-built ARIA support, that comes for free too. Bug: 1114721 Test: Manual test with flag #files-filters-in-recents. Change-Id: Ib709f79d24ab8c3a41aabdae2be4cb237c1fad5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358947 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#798608}
-
Yuki Shiino authored
Adds a caution of auto-generated files. Bug: 839389 Change-Id: I212dd2eb8153669f964f7b1a1de3d7ad4c9f8bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358931Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#798607}
-
Rushan Suleymanov authored
The data type might stop with clearing all data on any server-side error (even transient). This might happen because the data type will be backed off on any server-side error. In some cases it's not desired behaviour, e.g. if there is a transient AUTH_ERROR which is transient and the next commit request most probably will succeed. Originally it was introduced to detect internet connection problems or other error during commit. However there is already a mechanism to detect if there is no internet connection. Additionally, there are more cases when the client gets a transient error and it would be better to try to send the message again. Bug: 1097054 Change-Id: Ibfe4fe2d5d2614965a8c105017bb943447316ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360076Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#798606}
-
Mugdha Lakhani authored
Update existing PageInfo test and add another one to verify the container UrlBarView shows Page Info when clicked by default. Bug: 1116056 Change-Id: I26719b3d47184a5fcf8132c00f9fce32c7a7874d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359075 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798605}
-
David Roger authored
This reverts commit 944fde32. Reason for revert: strongly suspecting this breaks All/DeclarativeNetRequestResourceTypeBrowserTest See https://crbug.com/1116995 Original change's description: > Reland "Change HeapObserverList to HeapObserverSet" > > This is a reland of f29d2ae1 > > ExecutionContext::NotifyContextDestroyed() has relied on the > deterministic iteration order of ObserverList, so landing the original > CL caused a problem. It is fixed in another CL: > https://crrev.com/c/2352588 > > Original change's description: > > Change HeapObserverList to HeapObserverSet > > > > The previous CL for HeapObserverList https://crrev.com/c/2060348 > > addressed two things: changing HeapObserverList to HeapObserverSet and > > allowing removal while iteration, and was reverted for performance > > reasons. This CL only does the former and avoids performance > > implications of the latter. > > > > This CL is for migration of NewLinkedHashSet. > > See: https://crrev.com/c/2134039 > > > > Bug: 1100257 > > Change-Id: I2426d14d77a68f200bf1398b16638e1605dd4ff1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319087 > > Commit-Queue: Yuki Yamada <yukiy@chromium.org> > > Reviewed-by: Keishi Hattori <keishi@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#797115} > > Bug: 1100257, 1115411 > Change-Id: Id8e1b9a4141777de89bbc471f6ac8c6508a0adff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352292 > Commit-Queue: Yuki Yamada <yukiy@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798576} TBR=haraken@chromium.org,keishi@chromium.org,yukiy@chromium.org,bartekn@chromium.org Change-Id: I8c3d3a159efb802cda84fe3cbb1779abbbe2670d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1100257 Bug: 1115411 Bug: 1116995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359036Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#798604}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d852ad24adc0..29271d0eece4 2020-08-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 1980311465cf to c1db3b8e7960 (1 revision) 2020-08-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from b4c4da3e7606 to b8de4f57e983 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I7fc274e7f5e2dbb7708f276b3098bc26f15f2779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358394Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798603}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/81e695c66040..2137e8afdcc7 2020-08-17 jacktfranklin@chromium.org Support HTML element types in component bridges 2020-08-17 sigurds@chromium.org Propose wolfi@ as an owner for front_end/resources 2020-08-17 jacktfranklin@chromium.org Add support for Map to component bridges If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia7e0eb3c48f0a396f300739d2debead5149d5fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358396Reviewed-by:
-
Viktor Semeniuk authored
This change adds delay before revealing password check result. Delay is added only if it took less than 3 seconds to finish the check. Bug: 1075494 Change-Id: Ibc1031e870e178a98b1f74f4122c9519a8e15d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351975Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#798601}
-
Rouslan Solomakhin authored
Before this patch, all TWA payment apps on Chrome OS were available for payment, even if they implemented an IS_READY_TO_PAY service that replied "false" to the query (when chrome://flags/#enable-web-payments-experimental-features flag was enabled). This patch queries the IS_READY_TO_PAY service of the TWA payment app on Chrome OS and enables payments only if the service is absent or returns "true". After this patch, the TWA payment app can control at runtime whether it's able to handle payments. Bug: 1061503 Change-Id: Idb267c0bbe2d8bb9173bcfde1b9a25e47a7fc505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269744 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#798600}
-
Mohamed Amir Yosef authored
Bug: 1093286 Change-Id: I13798515a76c1a1b5b15be27d03bc61a9cd0e4c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341129Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#798599}
-
Friedrich Horschig authored
This CL introduces opening an edit view as an additional means to change a compromised password. For that, the coordinator is now able to launch a fragment (that heavily leans on password_entry_editor.xml). The fragment itself has no functionality yet and doesn't make use of the passed credential. Screenshot in the bug. Bug: 1114720, 1092444 Change-Id: I0f871600d1c1d1e8c157ffbbeb6edd6f9fd7fbd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353336 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f8df7e0a..bff6472b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id98009486b7ff104650bdad59aa5e39e5ec9d020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358955Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798597}
-
Jan Wilken Dörrie authored
This change makes the observed_form parameter in the APIs of VotesUploader and PasswordSaveManager optional, since it doesn't exist when saving or updating HTTP and proxy auth credentials. TBR=arbesser Bug: 943045 Change-Id: I9794c65f8950a2cb20bb4d9882cc1a2730508159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341637 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
This is the first step to turn down linux-blink-cors-rel bot and Android WebView P Blink-CORS FYI (rel) bot. Bug: 1116928 Change-Id: Ib666a7f5a339554ab2e4d56ec072833d47f20792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359851 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#798595}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/758b30727efc..f257e0ea6b9a 2020-08-17 johnkslang@users.noreply.github.com Merge pull request #2371 from RafaelMarinheiro/master 2020-08-17 johnkslang@users.noreply.github.com Merge pull request #2369 from ezdiy/c_api_export If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: Iffd0c61e5666d652d615a8da78868ebdfb12ebe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358392Reviewed-by:
-
Nohemi Fernandez authored
In testing APIs we can distinguish between managed and non-managed identities based on their email and do not need to ask clients for this information. Bug: 1103274 Change-Id: I7b2980d049d0fe65ae0247bf3d9485b14f89877a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353453 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#798593}
-
Javier Ernesto Flores Robles authored
Adds |requiresReauth| to FormSuggestion, which indicates if a suggestion requires device re-auth before applying. Currently only used by password suggestions. Creates FormSuggestionLabelDelegate to avoid using the client directly from the label view and be more explicit on how the action is handled. Same for -formSuggestionView:didAcceptSuggestion:. Moves AutofillSecurityAlertPresenter to its own file. Fixed: 1113118 Change-Id: Ib79a0e811bb366b48c90a2d0e1eb9d36ba4af58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343041 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
WebLayerShellActivity behavior remains the same: https://drive.google.com/file/d/1Rg9uX6DBFiiP__ijoX95LHflzzp1CI2v/view?usp=sharing If the embedder indicates that Page Info UI should be shown when the URL bar text is clicked, we make the entire UrlBar view tappable. Long press click listener is also applied to the entire url bar: https://drive.google.com/file/d/1dRrDg6u1FQzXKWAOlumuO_ChKCHY-qO8/view?usp=sharing Bug: 1116056 Change-Id: I5b3e6f8ee002db097cc88e79148784ad240beecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356525Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b4c4da3e7606..b8de4f57e983 2020-08-17 jaebaek@google.com Allow DebugTypeTemplate for Type operand (#3702) 2020-08-14 antonikarp@google.com spirv-fuzz: Improve code coverage of tests (#3686) 2020-08-14 stefanomil@google.com spirv-fuzz: Fuzzer pass to randomly apply loop preheaders (#3668) 2020-08-14 vasniktel@gmail.com spirv-fuzz: Support identical predecessors in TransformationPropagateInstructionUp (#3689) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I8c818596ce9a1d1535b54c827ff9144f5605e2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359767Reviewed-by:
-
Philipp Hancke authored
BUG=chromium:1101699 Change-Id: I97d8e63702fc7825648ef864ed4b9c8ceb10feb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352731Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#798589}
-
Karel Král authored
Support tracing of mojo handle and remote/receiver kinds. Thus provide more precise debugging information for developers. Also avoid generating fallback literals for base::trace_event::ValueToString. Bug: 1103623 Change-Id: Ib01e79f7ae0aba64cabda3aea87cc1d1aed3b921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356005 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798588}
-
Peter Marshall authored
CL to enable: https://chromium-review.googlesource.com/c/chromium/src/+/2360072 Change-Id: I3384ebb2f999d3d4403af82326ebfa6df57d3875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359134Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#798587}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/467b0b16324b..81e695c66040 2020-08-17 alexrudenko@chromium.org Suggest accessible color 2020-08-17 petermarshall@chromium.org tests: Add a lint check for it.repeat() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1093227,chromium:1101782 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I89163c133c91870a290e706ef0e848d1df3ac964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360109Reviewed-by:
-
Philip Jägenstedt authored
This is a testharness.js test and shouldn't have any baselines, but appears to be treated as a pixel test. Why is not clear, but mark the test as expected to fail to unblock the importer. Bug: 1116954 Change-Id: Ic3e2e23e32f835447ced85cd98aff151ff110e72 Tbr: robertma@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359071Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#798585}
-
Rouslan Solomakhin authored
Before this patch, the platform-specific Chrome OS Android app communication code was checking the number of IS_READY_TO_PAY services in an Android app, which could cause duplication of logic between Chrome OS and Android. This patch moves the check for number of IS_READY_TO_PAY services from the platform specific Chrome OS Android app communication to the cross-platform Android payment app factory. After this patch, the logic for checking the number of IS_READY_TO_PAY services is cross-platform. Bug: 1061503 Change-Id: I72f3b3040771174d61e72bd71afe5665c5a30865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302369 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#798584}
-
Maksim Moskvitin authored
This CL adds high-level device registration logic for trusted vault together with required interfaces/skeletons. Device has to be registered in order to silently follow further key rotations in the future. Device registration means generation of device key pair and sending public key to the server. Most recent vault key must be locally available in order to register the device. Currently, device registration is supported only for active sync account. Bug: 1102340 Change-Id: If7f6034db56752622bd108598a80c3e19681ba17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339484Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I94a75a303c4515b6634545c68a9b19dffc36756b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360032Reviewed-by:
-
Viktor Semeniuk authored
This change updates delete password button and error description strings according to the mocks. Bug: 1075494 Change-Id: Icb08eb7531ac6914b1a826a7cb34bd0f347611c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353463Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#798581}
-
Christian Dullweber authored
This enum contains a subset of the values of ContentSettingsType. As WebsitePermissionFetcher defines which ContentSettingsType are fetched as ContentSettingsException and which as PermissionInfo, we do not need this duplicate and the code to convert between types. Bug: 1103597 Change-Id: I17667e76c5091ed6417795cdba807c78b35a85a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346425Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#798580}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a9b199b05c1f..d852ad24adc0 2020-08-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from d253278f9865 to 758b30727efc (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I0a84c82baf47072a4f459947306544d6867f7148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359766Reviewed-by:
-
Matthias Körber authored
This CL adds merging support of structured address tokens. When two profiles are merged, the substructure that corresponds to address line that is merged into the new profile is used. If the feature |kAutofillAddressEnhancementVotes| is disabled, the structure is dropped in the merging process. Change-Id: Ifc24c0a65b40fad0ae32b1001cc6560ad946cb6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353267 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#798578}
-
Victor Hugo Vianna Silva authored
The CL fixes minor UI details in passwords settings, namely: - The color of the computer icon should be grey-200. The same is done for the analog icon in the dialog to move a password to the account. - The icon is resized to be 40px size instead of 42px. - A gray separator is now displayed between the opt-in buttons and the link to the device passwords page, with a 16px spacing between them. Before the CL: https://screenshot.googleplex.com/ce9c4b15-1427-4cad-8ca0-ab009f14851d After the CL: https://screenshot.googleplex.com/5c84c711-7527-4938-a7f4-17ae9f789b45 Bug: 1115955 Change-Id: I61d76f6ca5b522bba99d27b9bc0bead6ac3f3088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352806Reviewed-by:
-
Yuki Yamada authored
This is a reland of f29d2ae1 ExecutionContext::NotifyContextDestroyed() has relied on the deterministic iteration order of ObserverList, so landing the original CL caused a problem. It is fixed in another CL: https://crrev.com/c/2352588 Original change's description: > Change HeapObserverList to HeapObserverSet > > The previous CL for HeapObserverList https://crrev.com/c/2060348 > addressed two things: changing HeapObserverList to HeapObserverSet and > allowing removal while iteration, and was reverted for performance > reasons. This CL only does the former and avoids performance > implications of the latter. > > This CL is for migration of NewLinkedHashSet. > See: https://crrev.com/c/2134039 > > Bug: 1100257 > Change-Id: I2426d14d77a68f200bf1398b16638e1605dd4ff1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319087 > Commit-Queue: Yuki Yamada <yukiy@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797115} Bug: 1100257, 1115411 Change-Id: Id8e1b9a4141777de89bbc471f6ac8c6508a0adff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352292 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798576}
-
Miyoung Shin authored
This is a reland of d8d1f551 Original change's description: > Reland "Convert WidgetMsg_WaitForNextFrameForTest to mojo" > > This is a reland of 75391394. > > Reason for reland: > - Fixed a flaky test failures in crrev.com/c/2309317 > - No changes in this CL between original & reland. > > Original change's description: > > Convert WidgetMsg_WaitForNextFrameForTest to mojo > > > > This CL uses VisualStateRequest Mojo API in FrameWidget mojo interface > > introduced at https://crrev.com/c/2178480 since > > WidgetMsg_WaitForNextFrameForTest has the same implementation with > > VisualStateRequest Mojo API notifying that the frame swap has occurred. > > > > Bug: 1071588 > > Change-Id: If317b98320ec3fb85fcf7a5d1e39f0fa202d4cde > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216145 > > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#789910} > > Bug: 1071588 > Change-Id: I7ade2819495cddf87862054095db361e0511dcf5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309497 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793839} Bug: 1071588 Change-Id: I9499c2b89eb892b9275f9fa7f0445858ea5b5bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342333 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#798575}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/00fc92a77376..467b0b16324b 2020-08-17 petermarshall@chromium.org tests: Use mocha-extensions in e2e tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101782 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia337ad643679cecad3805d8f0e268672d8f4c39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359763Reviewed-by:
-
