- 30 Sep, 2020 3 commits
-
-
Weilun Shi authored
Update the description to emphasize that newly marked obsolete histograms don't need to be moved into this file. Bug: 1132741 Change-Id: I6691db75b9579db09445e00d7b4ecbda16ad97a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438691 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#811886}
-
Darren Shen authored
On a typical textfield, the IME surrounding text change event is triggered by [1]. However, this is guarded by a check for inputmode != NONE. Whilst this makes sense for a virtual keyboard IME since inputmode of NONE means no virtual keyboard, it doesn't make sense for a physical keyboard IME as inputmode doesn't apply to the physical keyboard. Move the selection update check outside and only check for input type != NONE since it applies to both virtual and physical keyboard. This fixes incorrect surrounding text information on the Google sheets "input field" that that appears when pressing a key on a cell. Note: The comments for [1] suggests that it's only used for a11y, but actually it is crucial to getting the right surrounding text information to IMEs. [1] https://source.chromium.org/chromium/chromium/src/+/master:content/browser/renderer_host/render_widget_host_view_aura.cc;l=2483;drc=ca19c6d8767e8c7e9c0d01c223587183a2e1278d Bug: 1114559 Change-Id: I1b360a4f81d7c5e6479fab8f8fba4d1632881da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344331Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#811885}
-
Yi Gu authored
This reverts commit 7927c8a6. Reason for revert: suspecting that this patch caused consistent test failure on chromeos: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8852 Original change's description: > Use JS modules for the NTP module > > Uses JS modules for the NTP module and updates > closure so it can resolve chrome://kaleidoscope. > > Change-Id: I985b20a7faca215bd5194a4a21c790d5a4ff0262 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435441 > Reviewed-by: calamity <calamity@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811807} TBR=calamity@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: I3d4fed8789ad99a9c289ed604b83d22a2c243dc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438042Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811884}
-
- 29 Sep, 2020 37 commits
-
-
Boris Sazonov authored
Adds code to rollback MobileIdentityConsistency: when the feature is disabled, SigninManager will trigger a signout if there's only primary account, but no sync consent. Bug: 1132290 Change-Id: Ia9f0143b908c1867743e0b89b7589ddbb03bff02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434330 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#811883}
-
Chait Pinnamaneni authored
Bug: 1002914 Change-Id: I393bc371972d8140cf87308723af8852f5b80dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432130Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com> Cr-Commit-Position: refs/heads/master@{#811882}
-
Xiaohan Wang authored
In the last CL, "cpu_arch_full" was set to "arm64-highbd" for Windows ARM64, which seems not needed because "arm64 windows has it's own folder for vp9_rtcd.h etc". This CL revert that part of the change so Windows restores to the previous behavior. Tbr: jzern@google.com Bug: 1133301 Change-Id: Iba23fe496841965f491704d5a503b388c1859b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437745Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811881}
-
Patrick Noland authored
This reverts commit f218ef61. Reason for revert: Breaking downstream build. Feel free to reland once you have downstream fix ready to go, but I don't think we can let downstream be broken until then Original change's description: > Modularize Omaha on Android: modularized identity/ from //chrome/android > > New location: //chrome/browser/uid; this is a dependency of Omaha on Android. > > Bug: 1131415 > Change-Id: Id65534f432adb733c9b1224f8fc770f30cbf00df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426045 > Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> > Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811874} TBR=nyquist@chromium.org,msarda@chromium.org,waffles@chromium.org,bsazonov@chromium.org,chouinard@chromium.org,andzaytsev@google.com Change-Id: I729d7bc353cf44d2f6e32e7a764726c82b6dd83a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439026Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#811880}
-
Alexei Svitkine authored
This was never added to histograms.xml, but is being logged. Bug: none Change-Id: Id77fbd584c72d363e2dc7537f4a2ae5ebb65749a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438637 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#811879}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //buildtools. Bug: 1113033 Change-Id: I54fdf94f060220d189ce9c843e02fc22f12df623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438877 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#811878}
-
Matthew Mourgos authored
This change makes ShelfController and AppListControllerImpl a MessageCenterObserver. This allows them to hide/show the app badges from being shown whenever quiet mode is enabled/disabled. Bug: 1130940 Change-Id: Ia26890b266b1d8ba26529afddf8347f21729bfb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436859Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#811877}
-
Bo Liu authored
This is logged when webview is used in multiple processes in the same app, the warm up connection hits a service used by another process and is not retried again. It's not catastrophic, since launching a renderer process for real will still succeed. So lower it to a warning. Change-Id: Ic9b8bbdda4b6c5cbf45ea7ce15abca7289692625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438894Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811876}
-
Sophie Chang authored
Bug: 1117115, 1089311 Change-Id: I2d5c33342cdccf03554fb7ca287545e69120e592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438886Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811875}
-
Andrey Zaytsev authored
New location: //chrome/browser/uid; this is a dependency of Omaha on Android. Bug: 1131415 Change-Id: Id65534f432adb733c9b1224f8fc770f30cbf00df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426045 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#811874}
-
Domenic Denicola authored
Fixed: 1127960 Change-Id: I23af107492b2db6d51d05c804398823c1fdef606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426995 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#811873}
-
Henrique Nakashima authored
With this CL, whole packages can be supplied to print_class_dependencies.py so that dependencies from/to all classes in those packages are printed out. Bug: 1133017 Change-Id: I3cae0c6037905113e7250bf518c7100a9367d43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436411 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#811872}
-
Xing Liu authored
When startForeground called with a cancelled notification update, startForeground() will be bypassed in DownloadForegroundServiceManager. startOrUpdateForegroundService(). This leads to an Android crash. Instead we need to create an dummy notification and still call startForeground() with it to avoid the crash. This dummy notification will be dropped immediately in DownloadNotificationService. Bug: 1121096 Change-Id: I0f68bff47403b7478f504af6ee03f154c727c82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436511 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#811871}
-
Yi Gu authored
TBR=dmazzoni@chromium.org Bug: 1084871 Change-Id: I21e47bc71cdf5655a4b741ee938b155c77bb2d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438734Reviewed-by:
-
Hiroki Nakagawa authored
These were added by https://codereview.chromium.org/6625066 for the legacy prerender, but these are not used for the current no-state-prefetch. Bug: 755921 Change-Id: I7536260cbf2f33f7f99da8bfa458fdc1702bff55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437553Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#811869}
-
Patrick Noland authored
Disables testTabSwitcherModeTriggeredBeyondThreshold and testTabSwitcherModeNotTriggeredWithinThreshold Bug: 1130696 Change-Id: Iea001954b5bcff71be17d0e6ec7b29de8ba9c610 TBR: wychen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437746Reviewed-by:
-
Dominic Mazzoni authored
This is one more step towards enabling the flag AccessibilityExposeHTMLElementEnabled to include the HTML element in the accessibility tree. Bug: 1063155 Change-Id: I19a1e7e8daba1f2186db3428cfab5c0cc9ee41a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427878 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#811867}
-
David Dorwin authored
Also renames both methods in feedback_registration.h to be more accurate. This is a follow-up to https://crrev.com/c/2315796. Change-Id: I4960a7b1cc076ee00bd22e043e08e44ec476a57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422155 Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#811866}
-
Patrick Noland authored
This reverts commit 773b24b9. Reason for revert: Tests are failing on android-arm-official-tests https://ci.chromium.org/p/chrome/builders/ci/android-arm-official-tests/1369 Original change's description: > [Android] Implement tests for SyncErrorCardPreference > > This cl adds render tests for different types of sync errors in > SyncErrorCardPreference. > > Bug: 1107420 > Change-Id: I3ebc308932eadb677310ea041559bb54bbb1765c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353255 > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Alice Wang <aliceywang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811273} TBR=treib@chromium.org,triploblastic@chromium.org,aliceywang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1107420 Change-Id: Ib86c9353dd3f5389ec7446add5c60b1031f59893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438611Reviewed-by:
-
Miriam Zimmerman authored
The Platform.UncleanShutdownsDaily and Platform.UserCrashesDaily histograms are used to assess Chrome OS system health, so we need them to stay around. BUG=chromium:1089270 TEST=CQ Change-Id: I413c6191f9c484fa407a0141f3b2cea5f90c93d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427064 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#811864}
-
Zhenyao Mo authored
From histogram data, they are 100% renderable on all Mac. Avoid runtime check, where CheckFramebufferStatus() hangs from time to time. Also, limit this to AMD/Intel/Nvidia GPUs. BUG=1127387 TEST=bots R=kbr@chromium.org Change-Id: If7567f3410090241c2ab861b93bd45c117051c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436386Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#811863}
-
Ali Juma authored
This CL makes FakeSafeBrowsingService::ClearCookies call the callback it is given, fixing BrowsingDataRemoverImplTests when Safe Browsing is enabled by default. Bug: 1028755 Change-Id: Id586113c49a62133de4568b3dce35b9cdf17cae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438733 Commit-Queue: Ali Juma <ajuma@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#811862}
-
Klaus Weidner authored
The shaders were originally copied from VR Browser, and AR mode doesn't need support for a border region. Remove that to simplify it. Change-Id: I5ac59e32e4b029e6f94d54a64a1638a7df92f758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438610 Commit-Queue: Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#811861}
-
Michael Thiessen authored
I'm doing a series of cleanups on ChromeActivityTestRule. 1. ActivityTestRules are supposed to take in the exact class to be launched - we hack around this in ChromeActivityTestRule, but we really don't need to and it's confusing for those familiar with ActivityTestRule. To this end I plan to prevent directly using ChromeActivityTestRule in favor of derived classes specific to the Activity you actually want to launch. 2. (Almost) All existing usage of ChromeActivityTestRule is actually using ChromeTabbedActivity, and so should be using ChromeTabbedActivityTestRule. 3. A bunch of functions on ChromeActivityTestRule only apply to ChromeTabbedActivity, so I'll be moving the functions to ChromeTabbedActivityTestRule instead. 4. Right now some types of ActivityTestRule will finish the Activity between tests, and some won't (for batched tests). I intend to make this behavior consistent for all ActivityTestRules. This change kicks this off by deprecating the public ChromeActivityTestRule constructor and migrating some of the usages. A few followups will get the remainder of the usages as there are many. Bug: 989569 Change-Id: Ia16a252f0d77a053dc9e1733d52d8ea290574a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435724Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#811860}
-
Patrick Noland authored
This reverts commit b2925a91. Reason for revert: The re-enabled test is failing on several android builders Original change's description: > Wait for GPU initialization completion > > In RTC video decoder factory, wait until initialization of GPU is > finished before querying supported formats and creating a decoder. > Timeout is configurable via RtcDecoderSupportTimeout field trial. > The feature is enabled by default. The default timeout is 10 seconds. > > Bug: 1047994 > Change-Id: I9d827507664228f903e4ce46e2949785b13192ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411935 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Sergey Silkin <ssilkin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811143} TBR=fdoray@chromium.org,sandersd@chromium.org,guidou@chromium.org,chromium-reviews@chromium.org,etiennep@chromium.org,ssilkin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1047994 Change-Id: I19aec959a1542425d747b58acafdcaab3721b6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438570Reviewed-by:
-
Lei Zhang authored
Bug: 646113 Change-Id: Ie687bd9a3930d2cf5edbf39a019df717d93263a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436384Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#811858}
-
Boris Sazonov authored
Extends Signin.AndroidGetAccountIdsTime, Signin.AndroidGetAccountsTime, Signin.AndroidGetAccountsTimeUiThread to M89. Bug: 1089513 Change-Id: Ib1de4de350bdce417727ea11ff04d3893402c44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435231Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811857}
-
Lei Zhang authored
base::LazyInstance is deprecated. Change-Id: Ic8b37b335004ae0c5cd3cad1c82cb06f25551499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438575Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#811856}
-
Sven Zheng authored
The target is running on following bots and I've checked the tests are stable. Lollipop Tablet Tester Lollipop Phone Tester Marshmallow 64 bit Tester Marshmallow Tablet Tester android-arm64-proguard-rel android-marshmallow-x86-rel-non-cq android-pie-x86-rel Bug: 1117345 Change-Id: Ide487d7b48454d5779f03ff95106aeb66891deb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437229Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#811855}
-
Yi Gu authored
The test has been flaky since it was introduced. See bug for details. TBR=ssid@chromium.org Bug: 1133434 Change-Id: I7ecb38170912745d7b86fc3128b1601c8e6537e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438969Reviewed-by:
-
Sorin Jianu authored
This is an attempt to reland https://chromium-review.googlesource.com/c/chromium/src/+/2414847 after a couple of changes: * obviously, remove the dependency on WinRT, which is not available on Windows 7. * refactoring how the WRL module is configured at build time. * cleaning up headers a bit. The issue with the crashing code is that on the RPC client side of the updater, both update and control services must be instantiated. They both called WRL::Module::Create, which caused WRL code to assert. The server side of RPC also initializes the module, in a slightly different way. Therefore, module initialization in the App base class is not practical. It has to be done in a way specific to the client, or the server, or the mode App is instantiated as. Using a leaky singleton is not great. However, there is singleton already in the WRL::Module, so a leaking singleton in the updater just shows that fact. Bug: 1128748 Change-Id: Ib198161e2dda81d780658e7ee51157f7f13f0f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432131 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
-
Robert Ogden authored
Make sure surrounding whitespace, like a trailing newline, doesn't fail the probe. Bug: 1115731 Change-Id: I0acc753c7dd04dfa519b7a773870f5f2fdeb1d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432210Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#811852}
-
Etienne Bergeron authored
This CL is merging the TtsControllerTestHelper class into a base testing::Test class. Tests are converted to use that pattern: TEST_F(TtsControllerTest,...) The goal of that cleanup is to simplify the next refactoring where a content::BrowserTaskEnvironment is required for each test. Change-Id: Id3757b58fc05a93ac6ebacdf3ba11ec8b234e9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432751Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#811851}
-
Yi Gu authored
The test has been flaky on several bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=media%2Fcontrols-styling-strict.html TBR=mlamouri@google.com NOTRY=TRUE Bug: 1083605 Change-Id: Ia0736180fc02f8e258f88d2566a03fe0dc293cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437915Reviewed-by:
-
My Nguyen authored
Update languages' dialogs to have 24px padding. UX is fine with these dialogs's paddings deviate from others. Change device language: http://screen/xQa4J5bcswqWrJj Add languages: http://screen/5BFTcGwzKfxE9hg Add input methods: http://screen/37GF8UyM3z8THcM Bug: 1113439 Change-Id: Id3d7ed561120d519aae66dc65a22004ecceb7b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437074 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811849}
-
Gayane Petrosyan authored
Bug: 1102382 Change-Id: I6ef96d347ac4864a1eb2e6fc547b77858baf54a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432143Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Auto-Submit: Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#811848}
-
Liquan (Max) Gu authored
Change: * Add an ability for Android browser test to click the close button on the opened payment handler UI. * Test launching payment handler twice to prevent crbug.com/1131874 from happening again. Bug: 1131874 Change-Id: Id43def5f2d2be4a40e34eda1219942dabd70485e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434769 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811847}
-
