GitLab

When Forward Error Correction (FEC) packets arrive, jitter buffer
will consider them missing. The jitter buffer needs to use the
picture ID to see if a new frame is continuous to the previous
frame. Without picture ID, the jitter buffer will not determine
any frame decodable after FEC. Video will hang until the jitter 
buffer drops all packets and requests a key frame.

BUG=347477
TEST=Run apprtc.appspot.com between Linux and CrOS.
Run apprtc.appspot.com loopback on CrOS.

Review URL: https://codereview.chromium.org/216793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260269 0039d316-1c4b-4281-b951-d872f2087c98

On 10.6-10.8, there is a brief flicker of corruption when the
RWHVCocoa (which has a CALayer) is added to the already-visible
window's NSView hierarchy. I suspect that this is a mini-seizure
that the window system has when transitioning the window from
a "does not have layers" mode to a "has layers" mode. Adding a
layer to the window's NSView hierarchy before the window is made
visible makes this seizure not happen.

BUG=356627

Review URL: https://codereview.chromium.org/215593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260268 0039d316-1c4b-4281-b951-d872f2087c98

This change tests for overlays inside DirectRenderer::DrawFrame and if
new overlay passes were produced, it skips rendering them and forwards the
information to FinishDrawingFrame to allow subclasses like GLRenderer and
SoftwareRenderer to schedule overlays in a manner specific to their
implementation.

GLRenderer schedules overlays via ContextSupport.

Adds more tests to ensure overlay quads are not drawn and if no overlays
are present, no quads are skipped.

BUG=

Review URL: https://codereview.chromium.org/208213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260267 0039d316-1c4b-4281-b951-d872f2087c98

This way there isn't possible race conditions if main is run before
the page finishes loading.

BUG=none
TEST=none
R=darin@chromium.org

Review URL: https://codereview.chromium.org/215373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260266 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove ExtensionService Garbage-Collecting methods. (https://codereview.chromium.org/204983020/)

Reason for revert:
Launch the browser and just wait a bit, eventually it crashes with:

[6912:6955:0328/131903:FATAL:weak_ptr.cc(26)] Check failed:
sequence_checker_.CalledOnValidSequencedThread(). WeakPtrs must be checked on
the same sequenced thread.

Commenting out that check then gets you to:

[12009:12077:0328/133048:FATAL:extension_garbage_collector.cc(232)] Check
failed: content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE). 

Reverting the patch fixes the issue.

Original issue's description:
> Remove ExtensionService Garbage-Collecting methods.
> 
> Make a new class, ExtensionGarbageCollector, which performs:
> - ExtensionService::GarbageCollectExtensions(),
> - extension_file_util::GarbageCollectExtensions() (the file-thread impl of
>   ExtensionService::GarbageCollectExtensions()),
> - ExtensionService::GarbageCollectIsolatedStorage()
> 
> BUG=351891
> TBR=rkc@chromium.org (for c/b/chromeos/kiosk_mode - no functional changes, but the TODO has moved from ExtensionService to ExtensionGarbageCollector).
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260207

TBR=yoz@chromium.org,jyasskin@chromium.org,rkc@chromium.org,rdevlin.cronin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=351891

Review URL: https://codereview.chromium.org/217233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260265 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True

Review URL: https://codereview.chromium.org/216883007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260263 0039d316-1c4b-4281-b951-d872f2087c98

No changes are required beyond removing a stale include and componentizing
FakeAuthStatusProvider (which can be componentized as-is).

BUG=334000
TBR=jochen

Review URL: https://codereview.chromium.org/216943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260262 0039d316-1c4b-4281-b951-d872f2087c98

Holding off on this change until after the m35 branch.

This reverts commit 31b59d61.

BUG=258676
R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org

Review URL: https://codereview.chromium.org/215053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239656

Review URL: https://codereview.chromium.org/217133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260259 0039d316-1c4b-4281-b951-d872f2087c98

BUG=351251
TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/206513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260258 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332115

Review URL: https://codereview.chromium.org/185863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260257 0039d316-1c4b-4281-b951-d872f2087c98

PERF SHERRIFS: This patch can change the metrics of smoothness up or down.
The new values should be more accurate than what we had before. If there are
large changes on a platform, we should still sanity check that everything works
as expected.

Switch smoothness benchmark to use rendering stats from the top level
compositor; i.e. if data from a browser compositor is available, use that.
Otherwise use the data from the renderer compositor.

The re-land fixes the problem where a browser compositor was present, but
didn't record rendering stats. That was the case with the reference
builds (that didn't have the patch that enabled recording) and on Android.
The new version checks if the browser compositor rendering stats events
actually have frames in them. If not, the render compositor stats will be used.
There is also a fix on the way to enable the recording on Android
(https://codereview.chromium.org/168193004/).

R=tonyg@chromium.org,nduca@chromium.org
BUG=340753

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254811

Review URL: https://codereview.chromium.org/174663008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260256 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a basic demo mode browser test that verifies that a machine with 0 derelict timeouts correctly brings up the demo app.
This CL also fixes a bunch of style issues pointed out in

R=bartfab@chromium.org, xiyuan@chromium.org
BUG=343574,355134

Review URL: https://codereview.chromium.org/205713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260255 0039d316-1c4b-4281-b951-d872f2087c98

We were loading the icons with the scaling factor based on the loaded resource pak, which works on
all platforms except on Windows with high dpi enabled with dpi settings other than 100% or 200%.

Fix is to pass in the correct scaling factor when loading these resources like icons etc which ensures that
they get resized correctly.

I made the PlatformGetImageScale function in the ResourceBundle class static and passed in the loaded scale factor
to it. This function returns the correct scale to be used as before. We call this function from the extensions resource
loading code.

There may be other places which need similar fixes. Will address those in upcoming CL's

BUG=351170, 354706
R=sky@chromium.org

Review URL: https://codereview.chromium.org/211493009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260254 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=viettrungluu@chromium.org, viettrungluu

Review URL: https://codereview.chromium.org/214513009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260253 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344769

Review URL: https://codereview.chromium.org/204133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260250 0039d316-1c4b-4281-b951-d872f2087c98

The patch adds a flag to disable the feature, so as to avoid future reverts.
There is also a check to avoid mixed signed comparisons, as can
arise with enums from C files.  We need not bother checking these.

BUG=356816
R=mark@chromium.org
R=thakis@chromium.org

Re-enable flag.


patch from issue 150943005

Review URL: https://codereview.chromium.org/213403010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260249 0039d316-1c4b-4281-b951-d872f2087c98

This change modifes WebM stream parser to estimate missing WebM frame
durations using the following logic:
1) If the frame was a BlockGroup, it should already have a duration. Use
it. (This is previous behavior; no other WebM frames previously had
duration.)
2) If the frame was a SimpleBlock, derive its duration as follows:
2a) If the frame's TrackEntry had a DefaultDuration, use that value
capped at a precision no greater than TimeCodes with TimeCodeScale
applied.
2b) Otherwise, if there is a subsequent frame in the cluster, set the
duration to the difference in timestamps.
2c) Otherwise, use the maximum frame duration for the track encountered
so far, if any.
2d) Otherwise, use a hardcoded value.
Note, 2b-2c, for WebM audio, ideally would be calculated based on the
track's codebook. This is left for a future CL.

Adds related WebM track parser unit tests. Adjusts
existing ChunkDemuxerTests, PipelineIntegrationTests, and
WebMClusterParserTests based on new duration logic.

R=acolwell@chromium.org
TEST=All media_unittests and http/tests/media layout tests pass locally on Linux
BUG=351166

Review URL: https://codereview.chromium.org/213253006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260247 0039d316-1c4b-4281-b951-d872f2087c98

Ahh. Getting rid of unnecessary complexity!

BUG=343254
TEST=covered by unit tests & tested by hand

Review URL: https://codereview.chromium.org/213193007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260246 0039d316-1c4b-4281-b951-d872f2087c98

I suspect it was the cause of these file_manager_browsertest.cc failures:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22673

> [VideoPlayer] Browser tests for new separated video player app
> 
> BUG=357621
> TEST=manually tested
> 
> R=hirono@chromium.org
> TBR=arv@chromium.org
> # TBRing for adding a resource.
> 
> Review URL: https://codereview.chromium.org/209853011

TBR=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/216183006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260245 0039d316-1c4b-4281-b951-d872f2087c98

Second part of a 2-part changelist.
The first part is https://codereview.chromium.org/25883006/

BUG=304879

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259726

Review URL: https://codereview.chromium.org/25909005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260243 0039d316-1c4b-4281-b951-d872f2087c98

Add first_run/InstallHelper GetFirstRunSentinelFilePath helpers.
Use PathService to get the correct value of DIR_USER_DATA.
(may be overridden by a policy, env var, or commandline)
(InstallUtil::GetSentinelFilePath just uses the default dir)

Make the IsFirstRunSentinelPresent helper platform-specific.
(simplifies its predecessor's Win-specific legacy abstractions)
Some related refactoring, cleanup, and test updates.

TODO(msw): Fix InstallUtil::GetSentinelFilePath.
TODO(msw): Fix/Nix installer::GetChromeUserDataPaths.
TODO(msw): Further consolidate related/duplicated code.

BUG=354634,341049
TEST=Chrome install and first run work as intended; respect user-data-dir commandline, env var, and policy overrides.
R=grt@chromium.org
TBR=gab@chromium.org

Review URL: https://codereview.chromium.org/208393020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260242 0039d316-1c4b-4281-b951-d872f2087c98

 - Adding docstrings
 - Factoring out _CalculateBounds method
 - Bug fix???

BUG=

Review URL: https://codereview.chromium.org/209853009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/213513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260240 0039d316-1c4b-4281-b951-d872f2087c98

aura_unittests explicitly calls GLSurface::InitializeOneOffForTests in main().
The Ozone platform isn't initialized this early causing a CHECK failure when
trying to get SurfaceFactoryOzone.

At this point surface creation in unittests is handled by OSMesa, thus we don't
need SurfaceFactoryOzone initialized.

TBR=piman@chromium.org
NOTRY=true

TESTS=Ran aura_unittests manually using an Ozone build

Review URL: https://codereview.chromium.org/217003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260239 0039d316-1c4b-4281-b951-d872f2087c98

In ChromeContentBrowserClient, check for membership in the trial group, and if the autoreload field trial is enabled, set the renderer command-line flag to enable it.

BUG=355569
TEST=unit,trybot

Review URL: https://codereview.chromium.org/212533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349737

Review URL: https://codereview.chromium.org/211983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260237 0039d316-1c4b-4281-b951-d872f2087c98

BUG=352263
TESTS=PartnerBookmarksShimTest
NOTRY=True

Review URL: https://codereview.chromium.org/215693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260233 0039d316-1c4b-4281-b951-d872f2087c98

maintain their caches. r259958 altered the way the feature data was populated
and caused a big regression. This fixes it.

R=rockot@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/216703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260232 0039d316-1c4b-4281-b951-d872f2087c98

Without this change, all calls to get or set preferences simply show up
as "types.ChromeSetting.get" or "types.ChromeSetting.set" in the
extension activity log.  With this change, the argument list will
include the name of the preference being changed and (when the
preference is changed) the new value.

BUG=356314

Review URL: https://codereview.chromium.org/214843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260231 0039d316-1c4b-4281-b951-d872f2087c98

Original CL: http://crrev.com/156963003

Preserved ip_pattern* which is now being used by the DnsConfigService.

BUG=347382

Review URL: https://codereview.chromium.org/215623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260230 0039d316-1c4b-4281-b951-d872f2087c98

Also moves some logic into the platform-independent OmniboxEditController.  Future work may be able to move more code into this class for sharing across platforms.

BUG=338563

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259639

R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/200783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260228 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:416
NOTRY=true

Review URL: https://codereview.chromium.org/217233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260227 0039d316-1c4b-4281-b951-d872f2087c98

tpcontrol and mousecontrol have been merged into a new script for controlling
input devices. This CL updates input_device_settings to use this new script.

BUG=chromium:285663
TEST=Has to be tested with chromium-side CLs containing the new script.
Then make sure changing mouse and touchpad preferences is working well and
that your preferences are correctly applied on bootup.

Review URL: https://codereview.chromium.org/212873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260226 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357505
TBR=jdduke@chromium.org

Review URL: https://codereview.chromium.org/216313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260225 0039d316-1c4b-4281-b951-d872f2087c98

This is to avoid users using the window for hiding sensitive contents that they don't want to share.
See https://code.google.com/p/webrtc/issues/detail?id=2789#c36

BUG=https://code.google.com/p/webrtc/issues/detail?id=2789

Review URL: https://codereview.chromium.org/215363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260224 0039d316-1c4b-4281-b951-d872f2087c98

It solves issues where we were sometimes getting stale data,
especially if reading information after a DisplayListener event.

BUG=354275

Review URL: https://codereview.chromium.org/212933012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260223 0039d316-1c4b-4281-b951-d872f2087c98

I have a plan to add more audio player tests. Before that, make audio player tests
separated for readability.

This is the 2nd (last) part of the work of crrev.com/214463002. First part is committed as crrev.com/260069.

BUG=none
TEST=browser_test passes
TBR=hirino@chromium.org

Review URL: https://codereview.chromium.org/212123008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335208

Review URL: https://codereview.chromium.org/216523005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260221 0039d316-1c4b-4281-b951-d872f2087c98

For example, chrome://newtab#bookmarks becomes
chrome-native://bookmarks. This helps users transition smoothly to the
new NTP: any tabs open to the old NTP when the user updates will start
showing the new NTP. Also: opening a foreign session tab from other
platforms and pressing back until arriving at chrome://newtab will now
show the new NTP.

BUG=354063
NOTRY=true

Review URL: https://codereview.chromium.org/205983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260218 0039d316-1c4b-4281-b951-d872f2087c98