GitLab

https://webrtc.googlesource.com/src.git/+log/bc2959072dc5..c0f26d458d3d


git log bc2959072dc5..c0f26d458d3d --date=short --no-merges --format='%ad %ae %s'
2018-10-04 nisse@webrtc.org Drop unneeded inclusion of module_common_types.h
2018-10-04 sakal@webrtc.org Add checks to HW codecs to ensure unsupported features are not used.
2018-10-04 titovartem@webrtc.org Rename NetworkSimulationInterface into NetworkBehaviorInterface.
2018-10-04 ssilkin@webrtc.org Fix VP9 K-SVC full stack tests.
2018-10-04 sakal@webrtc.org Document methods that are only supported on a specific Android version.
2018-10-04 philipel@webrtc.org Parameterized full stack tests to test the new generic descriptor.
2018-10-04 ivoc@webrtc.org Add more NetEq information to NetEqState.
2018-10-04 danilchap@webrtc.org Temporarily increase visibility of pacing and call/rtp_interfaces
2018-10-04 mbonadei@webrtc.org Revert "Reland "Export symbols needed by the Chromium component build (part 1).""
2018-10-04 gustaf@webrtc.org Avoid incorrect filter alignment due to call skew detection
2018-10-04 mbonadei@webrtc.org Temporarily increase visibility of publicly used build targets.
2018-10-04 mbonadei@webrtc.org Reland "Export symbols needed by the Chromium component build (part 1)."
2018-10-04 kwiberg@webrtc.org AudioCodingModuleTest.TestRedFec: Don't let the ACM create audio encoders
2018-10-04 srte@webrtc.org Adds check for uninitialized window start sequence.


Created with:
  gclient setdep -r src/third_party/webrtc@c0f26d458d3d

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:889017,chromium:892040
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ibdce73c5a1edea4cc5568af04f8ae63992bdd754
Reviewed-on: https://chromium-review.googlesource.com/c/1261955Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596714}

This patch removes the gatherTransparentRegion implementation from the
BottomSheet in favor of attaching and detaching the sheet view from
the hierarchy. Gathering the transparent region of a moving view is
difficult since that method is only called on layout. By taking the
view out of the hierarchy, the view is always "transparent" when it is
not visible.

Bug: 876097
Change-Id: I6073903d23b49b963bf2f4b570f6b51389430e42
Reviewed-on: https://chromium-review.googlesource.com/c/1252852
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596713}

This CL add a default implementation of
ContentMainDelegate::PostEarlyInitialization() to create FeatureList,
and remove the creation in BrowserMainLoop which happens after staring
the TaskScheduler in CL (https://crrev.com/c/1174955). This
fix browser tests failures when the TaskScheduler is starting before
FeatureList is created.

Bug: 848615, 729596
Change-Id: I9f9e85c785d41ad518db4170db53c4fc1d57e90d
Reviewed-on: https://chromium-review.googlesource.com/c/1228615
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596712}

This CL expands the following 2 test cases from the
CrossOriginReadBlockingExtensionTest test suite:

1) FromForegroundPage_NoSniffXml

   This CL adds coverage of a fetch performed from an about:srcdoc frame
   that belongs to an extension origin.

2) FromDeclarativeContentScript_NoSniffXml

   This CL adds coverage of a fetch performed from a content script
   injected into an about:blank page.

In both cases above, the fetch is performed before the browser commits
the frame.  The new tests help ensure that in this scenario the
extension scripts are still subject to relaxed CORB rules - because of
the timing the relaxed CORB rules do not depend on
URLLoaderFactoryManager::ReadyToCommitNavigation, but rather on having
the renderer inherit the right URLLoaderFactory for the subframe.

Bug: 846346
Change-Id: I45a4eba6d1351f2bf722f31fbcb7f201cd990d34
Reviewed-on: https://chromium-review.googlesource.com/c/1259291
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596711}

This change creates a new UsbPolicyAllowedDevices class that reads the
preference value for kManagedWebUsbAllowedDevicesForUrls and creates a
mapping of the tuple (vendor_id, product_id) to a set of URL patterns.
The class also provides a method to check if a pair of requesting and
embedding origins are allowed to access a device with vendor_id and
product_id.

The design document for this feature can be found at:
https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w

Bug: 854329
Change-Id: I014849be2ef4779e45c28c6699ff34022d3e9b89
Reviewed-on: https://chromium-review.googlesource.com/c/1250060
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596710}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/7d4f284ecdc0..2e1f8c671bd4

$ git log 7d4f284ec..2e1f8c671 --date=short --no-merges --format='%ad %ae %s'
2018-09-27 xiaochu system_api: add update_engine proto for d-bus method parameter

Created with:
  roll-dep src/third_party/cros_system_api

Bug: 874735, 879313
Test: Try.
Change-Id: Ieab49202022b6f823989b32eaa7b8c5519c8c5d7
Reviewed-on: https://chromium-review.googlesource.com/c/1261535Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596709}

Following the launch of PlzNavigate, this IPC is no longer useful: the browser
process is fully responsible for setting a RenderFrame in a loading state and
does need a notification from the renderer process.

Bug: 789577
Change-Id: I18ea2965f0151170e765af4e225475ad7a2f6202
Reviewed-on: https://chromium-review.googlesource.com/c/1131739
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596708}

Bug: 889888
Change-Id: I2429361627ffea2e1b8d5a11eb0e34b0cbfa1abb
Reviewed-on: https://chromium-review.googlesource.com/c/1249265Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596707}

Bug: 887659
Change-Id: I6b201d3eb3e75bbdc56429228d82e72830a96709
Reviewed-on: https://chromium-review.googlesource.com/c/1261981Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596706}

This CL adds the following 2 test cases to the
CrossOriginReadBlockingExtensionTest test suite:

1) FromForegroundPage_NoSniffXml

   This test performs the fetch from a foreground tab that has committed
   an extension page.  This test is quite similar to the already
   existing FromBackgroundPage_NoSniffXml test, but might be worth
   keeping (e.g. in case background pages go away in the future, or in
   case the code handling background-vs-foreground page diverges).

2) FromServiceWorker_NoSniffXml

   This test covers the scenario where a fetch from a foreground tab is
   handled by the extension's service worker.  This scenario means that
   CORB correctly handles the response from the network to the service
   worker - this response in the NetworkService world is handled by
   a URLLoaderFactory that is created separately from the factory
   created by
   RenderFrameHostImpl::CreateNetworkServiceDefaultFactoryInternal.

Bug: 846346
Change-Id: Id8c1ac892b4c3f25ef2b37f980b234bb8f25b6e5
Reviewed-on: https://chromium-review.googlesource.com/c/1257151
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596705}

There is a race in between:
 1) The end of the test.
 2) The XHR 'abort' event handlers executed.

There is a PostTask in between:
 A) blink::XMLHttpRequest::HandleDidCancel()
 B) blink::XMLHttpRequest::HandleRequestError()

FrameLoader::FinishedParsing may be interleaved in between A) and B).

Make use of testRunner.{waitUntilDone, notifyDone} to get reliable
results.

Bug: 831155
Change-Id: Ibe1ad9020319aae7268f331b2dba0911035789e2
Reviewed-on: https://chromium-review.googlesource.com/c/1261520
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596704}

These should help with diagnosing some problems we've been seeing with
Sync not properly starting up.

While we're here, also rename "Token Request State" to "Last Token
Request Result" which is closer to what this field actually means.

Bug: none
Change-Id: I4c72c654abb848afffa6aa64076f92cf28c859cc
Reviewed-on: https://chromium-review.googlesource.com/c/1261817Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596703}

Switching between ephemeral and persisted card storage in PersonalDataManager
only worked in some cases: It worked correctly if it happened as part of a full
restart, but NOT as part of a data type reconfiguration. The problem was that in
the case of a reconfiguration, we weren't actually restarting the data types, so
they had no chance to properly re-wire everything.
This CL fixes that by restarting all data types in ModelAssociationManager if the
storage option changed, i.e. calling DataTypeController::Stop followed by
LoadModels.
It also adds two integration tests.

Bug: 885211
Change-Id: I58576f15da13055aab0f470a7433cadb56c4621a
Reviewed-on: https://chromium-review.googlesource.com/c/1245795
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596702}

Before this pach, the devtools client would log an error on every
unkown event from the devtools host. Most of these events are not
relevant for us and we should not give those a high visibility in
logs.

This change moves the unknown devtool event error logs to DVLOG(2).

After this patch, in order to see these errors, a developer has to
enable those via --v or --vmodule.

R=rouslan@chromium.org, szermatt@chromium.org

Bug: 806868
Change-Id: I166f9c09e2bb8b1c95fc26d339f2ca854ec21912
Reviewed-on: https://chromium-review.googlesource.com/c/1257829Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596701}

Gesture scrolling starts before top-chrome starts
sliding. During that small period, the
`DoBrowserControlsShrinkRendererSize` bit should
remain unchanged.

This CL fixes this issue and adds a test to verify
the state of the browser while top-chrome sliding
is in progress.

BUG=884440, 867063, 891516
TEST=Added new test

Reviewed-on: https://chromium-review.googlesource.com/c/1249729Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#595899}
Change-Id: I63f101175c1ec1052d6e0bb55bbe760fd7a8b369
Reviewed-on: https://chromium-review.googlesource.com/c/1260105
Cr-Commit-Position: refs/heads/master@{#596700}

IdentityManager::Observer now provides OnPrimaryAccountSigninFailed()
offering the same functionality than the SigninManager equivalent API.

Bug: 869418
Change-Id: I00d42b622a483bb9b763aaf04d10e4f639e39042
Reviewed-on: https://chromium-review.googlesource.com/c/1257835
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596699}

According to spec, if permission for at least one of the requested
tracks is denied, the whole request should be denied.

Before this CL, a getUserMedia() request for audio and video with
one of the permissions blocked and one allowed, would succeed and
return one track, which is against the spec.

Drive-by: minor lint include fixes.

Bug: 416162
Change-Id: Ibd49f4ccea00a042ccc1b5e7b546aa9ae55b84ab
Reviewed-on: https://chromium-review.googlesource.com/c/1251125Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596698}

Previously, the MultiDevice setup flow would make a connection to the
Mojo service as soon as the flow was loaded. However, in OOBE mode, this
means that the WebUI page requests a connection as soon as OOBE loads,
which is before the user has signed in. Since the MultiDeviceSetup
service is only created once the user has signed in, the strategy of
connecting as soon as the page loads resulted in trying to connect to a
service which had not yet been registered.

This CL delays the process of connecting to the Mojo service; now, a
connection is made only when the initializeSetupFlow() function is called
or the "multidevice_setup.initializeSetupFlow" WebUI event is fired.

Bug: 884065
Change-Id: I2dde7916ac400625677c45d6de1c0fc72afab976
Reviewed-on: https://chromium-review.googlesource.com/c/1259835
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596697}

Calling PrgoressFling right after Processing GFS which landed in
https://chromium-review.googlesource.com/1140912 was the root cause of this
regression.

This cl changes the fling controller logic to wait for the scheduler to
call progress fling. The following browser tests are also added to make sure
that the regression won't happen in the future.

Bug: 884728, 249063
Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF
Change-Id: I3018b32c9d40d36406b4f532dcab6cccf3ee3b97
Reviewed-on: https://chromium-review.googlesource.com/c/1252621
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596696}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I39e87bd9e388663fed442cce86ed42e4fa38a7b0
Reviewed-on: https://chromium-review.googlesource.com/c/1259202Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596695}

NOTRY=true
TBR=nednguyen@google.com

Bug: 892184
Change-Id: I8df9415f42ee83de7dba675cbb8aeb1ec2db5f48
Reviewed-on: https://chromium-review.googlesource.com/c/1262195Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596694}

Include <cctype> since it declares std::toupper, in order to fix build
breakage on Windows.

Bug: 891867
Change-Id: I856286b390e152592951ccb318ec2260a6514073
Reviewed-on: https://chromium-review.googlesource.com/c/1259828
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596693}

Removed default autocomplete to device domain.
Removed message for device name input with regex.

BUG=chromium:865474
TEST=manual

Change-Id: Ib334f89ae0d4a27153cd69e5100253cce18f40a1
Reviewed-on: https://chromium-review.googlesource.com/c/1255730
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596692}

Before this CL, when such a request was received, the renderer was
shut down. This prevents a crash in chrome://oobe resulting from a
rejected request.

Bug: 890963
Change-Id: Icd54728b877126af218ce762f888f1c252f56ef7
Reviewed-on: https://chromium-review.googlesource.com/c/1258981Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596691}

Bug: 883489
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ie56f18bf3d1c8c6186a6cd7812e873338cda45c8
Reviewed-on: https://chromium-review.googlesource.com/c/1252864
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596690}

Re-implement processing of capabilities based on W3C spec.

spec: https://www.w3.org/TR/webdriver/#processing-capabilities

Bug: chromedriver:1997
Change-Id: I3304c54ba886b2319b178dad38a09713e349da25
Reviewed-on: https://chromium-review.googlesource.com/c/1260506
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596689}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e3685e77a08d..dcf4ffb80c01


Created with:
  gclient setdep -r src-internal@dcf4ffb80c01

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I0b27feaf4b6582c95ccde12b2074084b010aa530
Reviewed-on: https://chromium-review.googlesource.com/c/1261956Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596688}

And also an assert within ApplicationStatus that was failing for webview
in the case a non-primary process creates a webview.

The isMainProcess() method is tells you whether or not the process has a ":" in
it, but is too easy to confuse with "isBrowserProcess", and so better to not
have it so readily available.

Note that the assert within ApplicationStatus was made redundant by the
build-time negative_main_dex_globs check that was added afterwards, so
we don't actually lose anything by removing it.

TBR=agrieve  # trivial refactor

Bug: 891868
Change-Id: I883a245134a78a84e704b73a314ce0929672f5d2
Reviewed-on: https://chromium-review.googlesource.com/c/1260495Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596687}

As a temporary measure, set crash keys before calling
CallbackBase::IsCancelled to see if there is any pattern among
the crashes.

Bug: 798554
Change-Id: I55fcba6b378abdbbd69531faeda91c7c19874eb6
Reviewed-on: https://chromium-review.googlesource.com/c/1257920
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596686}

This reverts commit 837b3c20.

Reason for revert: Crash on startup. https://crbug.com/892182

Original change's description:
> bluetooth: Add a new BluetoothAdapterClient instance and use it for GetState
> 
> There are two parts to this change:
> 
> 1. Create a new BluetoothAdapterClient instance. For this we add
>    "alternate_bluetooth_adapter_client()" to the bundle of DBus clients.
>    This new instance uses a separate DBus Connection through
>    BluezDBusThreadManager. This ensures actions on one client won't
>    affect the other client.
> 
> 2. Implement BluetoothSystem::GetState using the new client.
> 
> Bug: 870192, 882771
> Change-Id: I9faa92e8234b14dd374a04b4c9e9acbcfd7e6201
> Reviewed-on: https://chromium-review.googlesource.com/c/1215427
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596520}

TBR=derat@chromium.org,stevenjb@chromium.org,reillyg@chromium.org,sammc@chromium.org,ortuno@chromium.org,sonnysasaka@chromium.org

Change-Id: Icf5a244f163152ccc41d84f7ea43220afebae791
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 870192, 882771, 892182
Reviewed-on: https://chromium-review.googlesource.com/c/1261878Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596685}

This reverts commit 6d46cb28.

Reason for revert: Crash on startup. https://crbug.com/892182

Original change's description:
> bluetooth: Finish implementing GetState()
> 
> Use Adapter's power state for GetState().
> 
> Bug: 870192
> Change-Id: I4c431fad09e540e8f20b21feb638ae6ba701f637
> Reviewed-on: https://chromium-review.googlesource.com/c/1250581
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596532}

TBR=reillyg@chromium.org,ortuno@chromium.org

Change-Id: Ib6da2c1e13a03a86d8daf88eba89ea53d8bd9e45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 870192, 892182
Reviewed-on: https://chromium-review.googlesource.com/c/1261918Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596684}

The FormData -> PasswordForm parser has been just a function so far.
However, an increasing amount of metadata is being handled
(predictions, soon also statistics about the parsing such as whether
readonly fields were observed).

Therefore this CL encapsulates such optional data into a parser class.
Notable changes:
  * Predictions are set separately and can be reused for subsequent
    parsing runs. This also avoids passing nullptr for missing
    predictions.
  * Some names enclosed in the class have been shortened to avoid
    redundancy when presented with the class prefix.

Bug: 883633

Change-Id: Ib36d37e134d1abff644de2f167e891bd88735f37
Reviewed-on: https://chromium-review.googlesource.com/c/1236315Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596683}

Due to flakiness.

TBR=ekaramad@chromium.org

Bug: 892085
Change-Id: I96d8a3b14583c340abba18a725941b8ae0c1cf06
Reviewed-on: https://chromium-review.googlesource.com/c/1261700
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596682}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/test/base/testing_profile.cc.

This CL was uploaded by git cl split.

R=<anyone>

Bug: 809610
Change-Id: I5289c063a35968a1ea2bf9872e1b146e965d4dcf
Reviewed-on: https://chromium-review.googlesource.com/c/1259006
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596681}

Before this patch, checking and setting more than one fields with
AutofillAction fails. They cannot, at this time, be run in parallel.

With this patch, AutofillAction gets and sets field values one after the
other, which works.

This patch also makes the unit tests for AutofillAction more explicit to
make debugging easier. This is not strictly necessary for this change,
as the old tests pass with the new code.

Bug: 806868
Change-Id: If7574307850c61436b2e6afcaa249ed3d0421225
Reviewed-on: https://chromium-review.googlesource.com/c/1261375
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596680}

Occasionally crash:
  TouchActionBrowserTest.PanXYAtXAreaMainThreadJanky
  TouchActionBrowserTest.TouchActionNone

TBR=jamescook@chromium.org

Bug: 892097, 892098
Change-Id: Icc26e7c5e9dfe632447e185a9567d17f0bd404a9
Reviewed-on: https://chromium-review.googlesource.com/c/1261401Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596679}

Permanent folders such as the "bookmark bar" are placed directly under
the bookmarks root node.

Before this CL:
Permanent folders were assumed to have a specifics parent id.
This is wrong, since the bookmark root node is synced and assigned a
non-fixed id on the server. This caused dropping the mobile bookmarks
folder when received as a remote creation.

After this CL:
Permanent nodes are detected via the existence of a unique server tag.

Bug: 516866
Change-Id: I237613ace3cc037febfb3f57257b24cc36522628
Reviewed-on: https://chromium-review.googlesource.com/c/1257833Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596678}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/profiles.

This CL was uploaded by git cl split.

R=skuhne@chromium.org

Bug: 809610
Change-Id: Ic45b0fc9fbeb570f14e193b37723234c6ab74ee3
Reviewed-on: https://chromium-review.googlesource.com/c/1257932Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596677}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/views/autofill.

This CL was uploaded by git cl split.

R=vasilii@chromium.org

Bug: 809610
Change-Id: Idd31113f973dcb3906be2c0db166fb8536ee5c99
Reviewed-on: https://chromium-review.googlesource.com/c/1258176Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596676}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/webui/signin.

This CL was uploaded by git cl split.

R=rogerta@chromium.org

Bug: 809610
Change-Id: Ib267c7d43afb0b4682fa8232431169012389e732
Reviewed-on: https://chromium-review.googlesource.com/c/1259004Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596675}