GitLab

        Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
        https://bugs.webkit.org/show_bug.cgi?id=66460

        Reviewed by Pavel Feldman.

        Tests: http/tests/inspector/extensions-network-redirect.html
               inspector/extensions/extensions-network.html

        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.InspectorExtensionAPI):
        (WebInspector.injectedExtensionAPI.Network.requestDispatch):
        (WebInspector.injectedExtensionAPI):
        (WebInspector.injectedExtensionAPI.Network.prototype.getHAR):
        (WebInspector.injectedExtensionAPI.defineDeprecatedProperty.getter):
        (WebInspector.injectedExtensionAPI.defineDeprecatedProperty):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer):
        (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
        (WebInspector.ExtensionServer.prototype._notifyRequestFinished):
        (WebInspector.ExtensionServer.prototype._onGetHAR):
        (WebInspector.ExtensionServer.prototype._onGetResourceContent):
        (WebInspector.ExtensionServer.prototype._requestId):
        (WebInspector.ExtensionServer.prototype._requestById):
        (WebInspector.ExtensionServer.prototype._onAddAuditCategory):
        (WebInspector.ExtensionServer.prototype._onAddAuditResult):
        (WebInspector.ExtensionServer.prototype._onStopAuditCategoryRun):
        (WebInspector.ExtensionServer.prototype.initExtensions):
        (WebInspector.ExtensionServer.prototype._onmessage):

2011-08-18  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
        https://bugs.webkit.org/show_bug.cgi?id=66460

        Reviewed by Pavel Feldman.

        * http/tests/inspector/extensions-network-redirect-expected.txt: Added.
        * http/tests/inspector/extensions-network-redirect.html: Renamed from LayoutTests/http/tests/inspector/extensions-resources-redirect.html.
        * http/tests/inspector/extensions-network-test.js: Renamed from LayoutTests/http/tests/inspector/extensions-resources-test.js.
        (extension_getRequestByUrl.onHAR):
        (extension_getRequestByUrl):
        * http/tests/inspector/extensions-resources-redirect-expected.txt: Removed.
        * http/tests/inspector/extensions-useragent-expected.txt:
        * http/tests/inspector/extensions-useragent.html:
        * inspector/extensions/extensions-api-expected.txt:
        * inspector/extensions/extensions-events-expected.txt:
        * inspector/extensions/extensions-events.html:
        * inspector/extensions/extensions-network-expected.txt: Renamed from LayoutTests/inspector/extensions/extensions-resources-expected.txt.
        * inspector/extensions/extensions-network.html: Renamed from LayoutTests/inspector/extensions/extensions-resources.html.


git-svn-id: svn://svn.chromium.org/blink/trunk@93312 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66243

Reviewed by Martin Robinson.

The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
call it only when the "load-status" change.

This change is important in the context of bug 28851, which aims to change the
order in which "progress finished" and "load finished" callbacks are called. In
this new scenario, at the progress callback the load will never be finished.

* tests/testwebview.c:
(test_webkit_web_view_grab_focus):

git-svn-id: svn://svn.chromium.org/blink/trunk@93311 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        [Windows] editing/input/password-echo-passnode2.html, editing/input/password-echo-passnode3.html,
        editing/input/password-echo-passnode.html, editing/input/password-echo-textnode.html
        failing on Windows since they were added
        https://bugs.webkit.org/show_bug.cgi?id=66461

        Reviewed by Adam Roben.

        Skip the above tests as window.textInputController is not supported on windows.

        * platform/win/Skipped:



git-svn-id: svn://svn.chromium.org/blink/trunk@93310 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=57785

Add missing Qt results for tests added in r93287.

Unreviewed gardening.

* platform/qt/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
* platform/qt/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93309 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Web Inspector: extract content loading functions from RawSourceCode to ContentProvider implementations.
https://bugs.webkit.org/show_bug.cgi?id=66237

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/content-providers.html

* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype._loadResourceContent):
(WebInspector.RawSourceCode.prototype._loadScriptContent):
(WebInspector.RawSourceCode.prototype._loadAndConcatenateScriptsContent):
(WebInspector.ScriptContentProvider):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):

LayoutTests:

* inspector/debugger/content-providers-expected.txt: Added.
* inspector/debugger/content-providers.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93308 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66142

Source/WebCore:

Added code that checks the parent RenderFlowThread of a RenderRegion and creates
a dependency for its referenced RenderFlowThread (from CSS style).

There are two cases:
1. A RenderRegion tries to display the flow thread that laid it out. In this case
the region will be ignored and will not participate in the flow threads regions list.
2. A RenderRegion tries to display a flow thread that contains another region that
tries to display the first region's flow thread. This one can be generalized with any
number of intermediate flow threads. In this case the recursion is detected and only the
first added region will actually be selected. The other region will be ignored. However,
when the recursion is removed the invalid regions will be recovered.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-18
Reviewed by David Hyatt.

Tests: fast/regions/flows-dependency-dynamic-remove.html
       fast/regions/flows-dependency-same-flow.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::dependsOn):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::checkInvalidRegions):
(WebCore::RenderFlowThread::addDependencyOnFlowThread):
(WebCore::RenderFlowThread::removeDependencyOnFlowThread):
(WebCore::RenderFlowThread::pushDependencies):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
* rendering/RenderFlowThread.h:
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::detachRegion):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::parentFlowThread):
(WebCore::RenderRegion::isValid):
(WebCore::RenderRegion::setIsValid):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderFlowThreads):
(WebCore::writeLayers):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::renderFlowThreadWithName):
(WebCore::RenderView::layoutRenderFlowThreads):
* rendering/RenderView.h:
(WebCore::RenderView::hasRenderFlowThreads):
(WebCore::RenderView::isRenderFlowThreadOrderDirty):
(WebCore::RenderView::setIsRenderFlowThreadOrderDirty):
(WebCore::RenderView::renderFlowThreadList):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-18
Reviewed by David Hyatt.

* fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
* fast/regions/flows-dependency-dynamic-remove.html: Added.
* fast/regions/flows-dependency-same-flow-expected.txt: Added.
* fast/regions/flows-dependency-same-flow.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93307 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        [chromium] Updating test expectations.

        Unreviewed.

        * platform/chromium/test_expectations.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@93306 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        [chromium] Updating test expectations.

        Unreviewed.

        * platform/chromium/test_expectations.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@93305 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66233

Source/WebCore:

This is a next step towards splitting SourceFile into RawSourceCode and UISourceCode.
UISourceCode is a part of SourceFile's interface that is visible to ScriptsPanel.
UISourceCode represents a single entry in scripts panel's files select.

Reviewed by Pavel Feldman.

Test: inspector/debugger/ui-source-code.html

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/UISourceCode.js: Added.
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get id):
(WebInspector.UISourceCode.prototype.get url):
(WebInspector.UISourceCode.prototype.get isContentScript):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._didRequestContent):
(WebInspector.ContentProvider):
(WebInspector.ContentProvider.prototype.requestContent):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

LayoutTests:

Reviewed by Pavel Feldman.

* inspector/debugger/ui-source-code-expected.txt: Added.
* inspector/debugger/ui-source-code.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93304 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
device scale factor

Reviewed by Darin Adler.

Source/WebCore:

* WebCore.exp.in: Removed Frame::deviceScaleFactorChanged, added Page::setDeviceScaleFactor.

* css/MediaQueryEvaluator.cpp:
(WebCore::device_pixel_ratioMediaFeatureEval):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::devicePixelRatio):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addDashboardRegions):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::deviceScaleFactor):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addDashboardRegions):
Changed to get the device scale factor from Page.

* loader/EmptyClients.h:
* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
Removed Chrome[Client]::deviceScaleFactor.

* page/Frame.cpp:
* page/Frame.h:
Removed deviceScaleFactorChanged. Made deviceOrPageScaleFactorChanged public.

* page/Page.cpp:
(WebCore::Page::Page): Initialize m_deviceScaleFactor.
(WebCore::Page::setDeviceScaleFactor): Added. Code came from
Frame::deviceScaleFactorChanged.

* page/Page.h: Added m_deviceScaleFactor.
(WebCore::Page::deviceScaleFactor): Added simple getter.

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
* src/ChromeClientImpl.h:
Removed deviceScaleFactor.

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/ChromeClientEfl.h:
Removed deviceScaleFactor.

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
* WebCoreSupport/ChromeClientGtk.h:
Removed deviceScaleFactor.

Source/WebKit/haiku:

* WebCoreSupport/ChromeClientHaiku.cpp:
* WebCoreSupport/ChromeClientHaiku.h:
Removed deviceScaleFactor.

Source/WebKit/mac:

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
Moved code to calculate the device scale factor from here...

* WebView/WebView.mm:
(-[WebView _deviceScaleFactor]):
...to here.

(-[WebView _windowDidChangeResolution:]): Now calls Page::setDeviceScaleFactor.

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate): Removed pixelRatio.
(QWebPage::viewportAttributesForSize): Now calls Page::setDeviceScaleFactor.

* Api/qwebpage_p.h: Removed pixelRatio.

* WebCoreSupport/ChromeClientQt.cpp:
* WebCoreSupport/ChromeClientQt.h:
Removed deviceScaleFactor.

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
Removed deviceScaleFactor.

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.cpp:
* WebCoreSupport/ChromeClientWinCE.h:
Removed deviceScaleFactor.

Source/WebKit/wx:

* WebKitSupport/ChromeClientWx.cpp:
* WebKitSupport/ChromeClientWx.h:
Removed deviceScaleFactor.

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:
Removed deviceScaleFactor.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::deviceScaleFactor):
Changed to get the device scale factor from WebCore.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setDeviceScaleFactor):
* WebProcess/WebPage/WebPage.h:
Removed m_deviceScaleFactor. We always get the scale factor from WebCore now.

git-svn-id: svn://svn.chromium.org/blink/trunk@93303 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Dump-as-markup conversion: editing/pasteboard/paste-text-010.html and editing/pasteboard/paste-text-015.html
https://bugs.webkit.org/show_bug.cgi?id=66440

Reviewed by Kent Tamura.

Converted the tests.

* editing/pasteboard/paste-text-010-expected.txt: Added.
* editing/pasteboard/paste-text-010.html:
* editing/pasteboard/paste-text-015-expected.txt: Added.
* editing/pasteboard/paste-text-015.html:
* platform/chromium-linux/editing/pasteboard/paste-text-010-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/paste-text-015-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-010-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-010-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-015-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-015-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-010-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-015-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-010-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-010-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-015-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-015-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-010-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-015-expected.txt: Removed.


git-svn-id: svn://svn.chromium.org/blink/trunk@93302 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Dump-as-markup conversion: editing/pasteboard/paste-text-017.html and editing/pasteboard/paste-text-018.html
https://bugs.webkit.org/show_bug.cgi?id=66443

Reviewed by Kent Tamura.

Converted the tests.

* editing/pasteboard/paste-text-017-expected.txt: Added.
* editing/pasteboard/paste-text-017.html:
* editing/pasteboard/paste-text-018-expected.txt: Added.
* editing/pasteboard/paste-text-018.html:
* platform/chromium-linux/editing/pasteboard/paste-text-017-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/paste-text-018-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-017-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-017-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-018-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-018-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-017-expected.png: Removed.
* platform/gtk/editing/pasteboard/paste-text-017-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-018-expected.png: Removed.
* platform/gtk/editing/pasteboard/paste-text-018-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-017-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-017-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-018-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-018-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-017-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-018-expected.txt: Removed.


git-svn-id: svn://svn.chromium.org/blink/trunk@93301 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=65145

Reviewed by Nikolas Zimmermann.

Renamed the SVG-specific whitespace functions to call it "SVG space"
rather than just "whitespace". An alternative would have been to put
the functions into an SVG namespace instead of the top level WebCore
namespace.

* svg/SVGAnimateMotionElement.cpp:
(WebCore::parsePoint): Call skipOptionalSVGSpaces.
* svg/SVGAnimationElement.cpp:
(WebCore::parseKeySplines): Ditto.
* svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseViewBox): Ditto.
* svg/SVGLengthList.cpp:
(WebCore::SVGLengthList::parse): Call isSVGSpace and
skipOptionalSVGSpacesOrDelimiter.
* svg/SVGParserUtilities.cpp:
(WebCore::genericParseNumber): Call skipOptionalSVGSpacesOrDelimiter.
(WebCore::parseArcFlag): Ditto.
(WebCore::parseRect): Call skipOptionalSVGSpaces.
(WebCore::pointsListFromSVGData): Ditto.
(WebCore::parseGlyphName): Call skipOptionalSVGSpaces, isSVGSpace,
and skipOptionalSVGSpacesOrDelimiter.
(WebCore::parseDelimitedString): Call skipOptionalSVGSpaces.

* svg/SVGParserUtilities.h:
(WebCore::isSVGSpace): Renamed from isWhitespace. This better matches
the comment which specifically talks about SVG.
(WebCore::skipOptionalSVGSpaces): Renamed from skipOptionalSpaces.
(WebCore::skipOptionalSVGSpacesOrDelimiter): Renamed from
skipOptionalSVGSpacesOrDelimiter.

* svg/SVGPathStringSource.cpp:
(WebCore::SVGPathStringSource::moveToNextToken): Call skipOptionalSVGSpaces.
* svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): Ditto.
* svg/SVGStringList.cpp:
(WebCore::SVGStringList::parse): Call isSVGSpace and
skipOptionalSVGSpacesOrDelimiter.
* svg/SVGTransformable.cpp:
(WebCore::parseTransformParamList): Call skipOptionalSVGSpaces and
skipOptionalSVGSpacesOrDelimiter.
(WebCore::SVGTransformable::parseTransformAttribute): Call skipOptionalSVGSpaces.


git-svn-id: svn://svn.chromium.org/blink/trunk@93300 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66046

Reviewed by Alexey Proskuryakov.

* src/WebBindings.cpp:


git-svn-id: svn://svn.chromium.org/blink/trunk@93299 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66426

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Changed the branchTestPtr to branchTest32.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Reviewed by Oliver Hunt.

Added a trivial test of mod-by-zero, which fails with the previous version
of the DFG speculative JIT.

* fast/js/mod-by-zero-expected.txt: Added.
* fast/js/mod-by-zero.html: Added.
* fast/js/script-tests/mod-by-zero.js: Added.
(mod):


git-svn-id: svn://svn.chromium.org/blink/trunk@93298 bbb929c8-8fbe-4397-9dbb-9b2b20218538

check-webkit-style should detect incorrectly formatted file change descriptions.
Description, if present, should be separated from colon with a space.

Reviewed by David Levin.

* Scripts/webkitpy/style/checkers/changelog.py: Fix.
* Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.


git-svn-id: svn://svn.chromium.org/blink/trunk@93297 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before beginning an explicit history navigation in a newly initialized
frame, it's important to give a "previous" item to avoid crashes, and
give a state to the state machine to avoid extra validating loads.

https://bugs.webkit.org/show_bug.cgi?id=66322

Reviewed by Darin Fisher.

Source/WebCore:

No new tests, as history navigation is very difficult to test in
DumpRenderTree.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForHistoryNavigation):
* loader/FrameLoader.h:

Source/WebKit/chromium:

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadHistoryItem):


git-svn-id: svn://svn.chromium.org/blink/trunk@93296 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66282

Patch by Jing Zhao <jingzhao@chromium.org> on 2011-08-18
Reviewed by Kent Tamura.

No new tests since it only changes the behavior in Android Browser.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseMappedAttribute):

git-svn-id: svn://svn.chromium.org/blink/trunk@93295 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66418

Reviewed by Dimitri Glazkov.

* features.gypi:


git-svn-id: svn://svn.chromium.org/blink/trunk@93294 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://code.google.com/p/chromium/issues/detail?id=93044

This test should now pass after Chromium rolled V8 to 3.5.6 in r97287.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93293 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Handle "form" attribute updates in parseMappedAttribute() instead of attributeChanged() to better match HTMLElement practices
https://bugs.webkit.org/show_bug.cgi?id=66321

Reviewed by Darin Adler.

Source/WebCore:

This is simply a cleanup change: there's no need that I can see for
HTMLFormControlElement and HTMLObjectElement to override
Element::attributeChanged since they can properly handle form
attribute changes in parseMappedAttribute, which they also override.

Though no change in behavior, I've added test coverage of the moved
code to an existing test (fast/forms/form-attribute.html) and added
a new test.

Test: fast/forms/radio-remove-form-attr.html

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::parseMappedAttribute):
* html/HTMLFormControlElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
* html/HTMLObjectElement.h:

LayoutTests:

Added new coverage to ensure that adding a radio button to a radio
group in the document by removing a form attribute leaves the group in
a valid state (no more than one button checked).

Beefed up coverage of form associated elements to better cover
HTMLObjectElement.

* fast/forms/form-attribute-expected.txt:
* fast/forms/radio-remove-form-attr-expected.txt: Added.
* fast/forms/radio-remove-form-attr.html: Added.
* fast/forms/script-tests/form-attribute.js:
Added coverage of <object form=""> behavior.


git-svn-id: svn://svn.chromium.org/blink/trunk@93292 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66052

Patch by Chang Shu <cshu@webkit.org> on 2011-08-18
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Added runtime settings in WebCore.
Added support in window.internals for testing.

Tests: editing/input/password-echo-passnode.html
       editing/input/password-echo-passnode2.html
       editing/input/password-echo-passnode3.html
       editing/input/password-echo-textnode.html

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setPasswordEchoEnabled):
(WebCore::Settings::passwordEchoEnabled):
(WebCore::Settings::setPasswordEchoDurationInSeconds):
(WebCore::Settings::passwordEchoDurationInSeconds):
* testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::setPasswordEchoEnabled):
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit/qt:

Enable password echo under the build flag.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):

LayoutTests:

Added tests.

* editing/input/password-echo-passnode-expected.txt: Added.
* editing/input/password-echo-passnode.html: Added.
* editing/input/password-echo-passnode2-expected.txt: Added.
* editing/input/password-echo-passnode2.html: Added.
* editing/input/password-echo-passnode3-expected.txt: Added.
* editing/input/password-echo-passnode3.html: Added.
* editing/input/password-echo-textnode-expected.txt: Added.
* editing/input/password-echo-textnode.html: Added.
* editing/input/resources: Added.
* editing/input/resources/password-echo.js: Added.
(secureChar):
(secureText):
(log):
(assert):
(run.else):
(run):
(init):
* platform/wk2/Skipped: No support yet.

git-svn-id: svn://svn.chromium.org/blink/trunk@93291 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66288

Source/WebCore:

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-18
Reviewed by Tony Chang.

VisibleSelection returns a NoSelection to InsertTextCommand::doApply as
a new endingSelection, which isn't a sane state to be in. The code
tries to get a position on a higher node for a better selection, but
cannot go above the frameset (which exists in place of the body tag),
which lacks a renderer, and therefore cannot have a non-NoSelection
VisibleSelection.

Because this is a rare corner case, it seemed more reasonable to bail
out in this circumstance than to change the way VisibleSelection
canonicalization works. The new behavior is to delete the content, but
insert nothing. I investigated the possibility of trying to move above
or below the frameset in this particular case, but there still isn't a
renderer, so it didn't prevent the crash.

Test: editing/inserting/insert-text-into-empty-frameset-crash.html

* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::doApply):

LayoutTests:

This test selects all and inserts text in a page which contains a frameset.
It tests for a crash caused by a NULL ptr which can occur in InsertText::doApply.

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-18
Reviewed by Tony Chang.

* editing/inserting/insert-text-into-empty-frameset-crash-expected.txt: Added.
* editing/inserting/insert-text-into-empty-frameset-crash.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93290 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Unreviewed gardening.

* platform/qt/Skipped:


git-svn-id: svn://svn.chromium.org/blink/trunk@93289 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66294

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-18
Reviewed by Kent Tamura.

CloseEvent objects are initialized by initCloseEvent() in all cases.
Initialization in create() is redundant.

No new tests for no functional difference.

* websockets/CloseEvent.h:
(WebCore::CloseEvent::create):
(WebCore::CloseEvent::CloseEvent):
* websockets/WebSocket.cpp:
(WebCore::WebSocket::didClose):

git-svn-id: svn://svn.chromium.org/blink/trunk@93288 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=57785

Source/WebCore:

Reviewed by Simon Fraser.

Fixed two iframe and frameset scaling bugs:
  #1 iframes and frameset backgrounds and scroll areas are doubly scaled when they are styled with -webkit-transform.
  #2 frameset does not respect -webkit-transform-origin when scaled

Tests: fast/frames/frame-set-scaling-3d.html
       fast/frames/frame-set-scaling-centered.html
       fast/frames/frame-set-scaling-rotate.html
       fast/frames/frame-set-scaling-skew.html
       fast/frames/frame-set-scaling.html
       fast/frames/iframe-scaling-with-scroll.html

* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
Update the FrameSet's layer transform after we've computed size to correctly account for the transform origin.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::childrenClipRect):
The dirty rect should be the document's unscaled size.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
Don't scale the FrameView rect here. Scaling is done within the FrameView.

LayoutTests:

Added tests to verify that framesets and iframes are scaled and positioned correctly.

Reviewed by Simon Fraser.

* fast/frames/frame-set-scaling-3d-expected.png: Added.
* fast/frames/frame-set-scaling-3d-expected.txt: Added.
* fast/frames/frame-set-scaling-3d.html: Added.
* fast/frames/frame-set-scaling-centered-expected.png: Added.
* fast/frames/frame-set-scaling-centered-expected.txt: Added.
* fast/frames/frame-set-scaling-centered.html: Added.
* fast/frames/frame-set-scaling-expected.png: Added.
* fast/frames/frame-set-scaling-expected.txt: Added.
* fast/frames/frame-set-scaling-rotate-expected.png: Added.
* fast/frames/frame-set-scaling-rotate-expected.txt: Added.
* fast/frames/frame-set-scaling-rotate.html: Added.
* fast/frames/frame-set-scaling-skew-expected.png: Added.
* fast/frames/frame-set-scaling-skew-expected.txt: Added.
* fast/frames/frame-set-scaling-skew.html: Added.
* fast/frames/frame-set-scaling.html: Added.
* fast/frames/iframe-scaling-with-scroll.html: Added.
* platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
* platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
* platform/mac/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@93287 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66404

Reviewed by Dimitri Glazkov.

As requested by dglazkov.

* Scripts/webkitpy/tool/commands/prettydiff.py:


git-svn-id: svn://svn.chromium.org/blink/trunk@93286 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* dom/Document.cpp:
(WebCore::disableRangeMutation):

git-svn-id: svn://svn.chromium.org/blink/trunk@93285 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66156

Reviewed by Eric Seidel.

Convert RenderBox to new layout abstraction as a part of the ongoing
conversion work.

No new tests as no new functionality.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::absoluteRects):
(WebCore::RenderBox::absoluteContentBox):
(WebCore::RenderBox::absoluteContentQuad):
(WebCore::RenderBox::outlineBoundsForRepaint):
(WebCore::RenderBox::reflectionBox):
(WebCore::RenderBox::reflectedRect):
(WebCore::RenderBox::verticalScrollbarWidth):
(WebCore::RenderBox::horizontalScrollbarHeight):
(WebCore::RenderBox::computeContentBoxLogicalWidth):
(WebCore::RenderBox::computeContentBoxLogicalHeight):
(WebCore::RenderBox::maskClipRect):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::overflowClipRect):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::computeInlineStaticDistance):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::computeBlockStaticDistance):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::lineHeight):
(WebCore::RenderBox::baselinePosition):
(WebCore::RenderBox::logicalVisualOverflowRectForPropagation):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::logicalLayoutOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
(WebCore::RenderBox::locationOffsetIncludingFlipping):
* rendering/RenderBox.h:
(WebCore::RenderBox::borderFitAdjust):
(WebCore::RenderBox::intrinsicSize):
(WebCore::RenderBox::intrinsicLogicalWidth):
(WebCore::RenderBox::intrinsicLogicalHeight):
(WebCore::RenderBox::scrollbarLogicalHeight):
(WebCore::RenderBox::controlClipRect):
(WebCore::RenderBox::firstLineBoxBaseline):
(WebCore::RenderBox::lastLineBoxBaseline):


git-svn-id: svn://svn.chromium.org/blink/trunk@93284 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2011-08-17

* platform/qt/Skipped: Skip new failures.


git-svn-id: svn://svn.chromium.org/blink/trunk@93283 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix TestWebKitAPI build on Mac OS.

Reviewed by David Levin.

* TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.


git-svn-id: svn://svn.chromium.org/blink/trunk@93282 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66399

Constructs Strings with StringBuilder instead of calling createUninitialized.

Reviewed by Adam Barth.

No new tests; no functional change.

* dom/StyleElement.cpp:
(WebCore::StyleElement::process):
* dom/Text.cpp:
(WebCore::Text::wholeText):
* html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::sourceForToken):
* platform/graphics/Font.cpp:
(WebCore::Font::normalizeSpaces):
* platform/text/TextCodecUserDefined.cpp:
(WebCore::TextCodecUserDefined::decode):


git-svn-id: svn://svn.chromium.org/blink/trunk@93281 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66147

Reviewed by Eric Seidel.

Convert Frame & FrameView to new layout abstraction as a part of the
ongoing conversion work.

No new tests, no new functionality.

* page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):
(WebCore::Frame::rangeForPoint):
(WebCore::Frame::setPageAndTextZoomFactors):
(WebCore::Frame::scalePage):
* page/Frame.h:
* page/FrameView.cpp:
(WebCore::FrameView::create):
(WebCore::FrameView::reset):
(WebCore::FrameView::init):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::setMarginWidth):
(WebCore::FrameView::setMarginHeight):
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):
(WebCore::FrameView::scrollOffsetForFixedPosition):
(WebCore::FrameView::currentMousePosition):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::windowClipRectForLayer):
(WebCore::FrameView::scrollTo):
(WebCore::FrameView::invalidateScrollbarRect):
(WebCore::FrameView::getTickmarks):
(WebCore::FrameView::windowResizerRect):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::paintOverhangAreas):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):
* page/FrameView.h:
(WebCore::FrameView::marginWidth):
(WebCore::FrameView::marginHeight):
* page/mac/FrameMac.mm:
(WebCore::Frame::snapshotDragImage):
(WebCore::Frame::nodeImage):


git-svn-id: svn://svn.chromium.org/blink/trunk@93280 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66347

Reviewed by Eric Seidel.

Convert HTML* and shadow element to new layout abstraction as a part of
the ongoing conversion work.

No new tests, no new functionality.

* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::invalidateCachedRegion):
(WebCore::HTMLAreaElement::mapMouseEvent):
(WebCore::HTMLAreaElement::computePath):
(WebCore::HTMLAreaElement::computeRect):
(WebCore::HTMLAreaElement::getRegion):
* html/HTMLAreaElement.h:
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
* html/HTMLCanvasElement.h:
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::mapMouseEvent):
* html/HTMLMapElement.h:
* html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::finish):
(WebCore::ImageDocument::scale):
(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::imageFitsInWindow):
* html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::size):
(WebCore::CanvasRenderingContext2D::drawImage):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::startDrag):
(WebCore::MediaControlPanelElement::continueDrag):
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::defaultEventHandler):
* html/shadow/MediaControlElements.h:
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::dragFrom):
(WebCore::SliderThumbElement::setPositionFromPoint):
* html/shadow/SliderThumbElement.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::nodeAtPoint):


git-svn-id: svn://svn.chromium.org/blink/trunk@93279 bbb929c8-8fbe-4397-9dbb-9b2b20218538

leveldb refactoring going on in chromium: crbug.com/89378
https://bugs.webkit.org/show_bug.cgi?id=66332

Patch by David Grogan <dgrogan@chromium.org> on 2011-08-17
Reviewed by Tony Gentilcore.

Tests: new-run-webkit-tests --debug --chromium --no-retry-failures --build-directory=llvm storage/indexeddb

* WebCore.gyp/WebCore.gyp:

git-svn-id: svn://svn.chromium.org/blink/trunk@93278 bbb929c8-8fbe-4397-9dbb-9b2b20218538

implements load32WithCompactAddressOffsetPatch function
and fixes store32 and moveWithPatch functions for SH4 platforms.

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-08-17
Reviewed by Gavin Barraclough.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::rshift32):
(JSC::MacroAssemblerSH4::store32):
(JSC::MacroAssemblerSH4::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerSH4::moveWithPatch):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::movlMemRegCompact):
(JSC::SH4Assembler::readPointer):
(JSC::SH4Assembler::repatchCompact):
* jit/JIT.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@93277 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=61421

Reviewed by Dimitri Glazkov.

Introduces FocusEventDispatchMediator/BlurEventDispatchMediator so
that focus/blue events are stopped at the lowest common shadow boundary.

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* dom/Event.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
* dom/Event.h:
* dom/Node.cpp:
(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):
* dom/Node.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::dispatchBlurEvent):
* html/HTMLFormControlElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::dispatchFocusEvent):
(WebCore::HTMLSelectElement::dispatchBlurEvent):
* html/HTMLSelectElement.h:
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
(WebCore::HTMLTextFormControlElement::dispatchBlurEvent):
* html/HTMLTextFormControlElement.h:
* page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedNode):

LayoutTests:

* fast/dom/shadow/shadow-boundary-events.html:


git-svn-id: svn://svn.chromium.org/blink/trunk@93276 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Canvas fill and fillRect with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=66036

Source/WebCore:

These modes cannot be passed straight through to the underlying graphics context as the graphics context
and the HTML5 canvas spec have different interpretations to them. In the graphics context, the compositing
modes are applied just over the area being filled. In the HTML5 spec, the compositing modes are applied over
the entire canvas.

The SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy modes all need some kind of extra action
to just performing the composited fill on the canvas, as they need t he canvas to be cleared outside of the
area being filled.

Previous to this change the Copy mode did not do this clearing at all. The other modes did but if the
transformed path being filled contained anti-aliasing at its edges artifacts were introduced.

With this change, Copy now does a complete erase of the canvas before performing a fill as per normal.
The other modes use a temporary buffer just big enough for the transformed path (in device coordinates).
The fill is first done there in SourceOver mode. Then this is drawn into the canvas context using the
appropriate mode, with any areas outside the draw area being cleared.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-17
Reviewed by James Robinson.

Test: fast/canvas/canvas-composite-transformclip.html

* html/HTMLCanvasElement.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::transformAreaToDevice):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):
* html/canvas/CanvasRenderingContext2D.h:
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):

LayoutTests:

Patch by Ben Wells <benwells@chromium.org> on 2011-08-17
Reviewed by James Robinson.

* fast/canvas/canvas-composite-alpha.html:
* fast/canvas/canvas-composite-transformclip-expected.txt: Added.
* fast/canvas/canvas-composite-transformclip.html: Added.
* platform/chromium-linux/fast/canvas/canvas-composite-expected.png:
* platform/chromium-linux/fast/canvas/canvas-composite-transformclip-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/canvas/canvas-composite-expected.png:
* platform/mac/fast/canvas/canvas-composite-transformclip-expected.png: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93275 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66358

Reviewed by Eric Seidel.

Convert inspector code to new layout abstraction as a part of the ongoing
conversion work.

No new tests, no new functionality.

* inspector/DOMNodeHighlighter.cpp:
(WebCore::DOMNodeHighlighter::drawNodeHighlight):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willPaintImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willPaint):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willPaint):
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createPaintData):
* inspector/TimelineRecordFactory.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@93274 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66355

Reviewed by Eric Seidel.

Converting remaining editing code to the LayoutUnit abstraction.

No new tests, no change in functionality.

* editing/Editor.cpp:
(WebCore::Editor::rangeForPoint):
(WebCore::Editor::insideVisibleArea):
(WebCore::Editor::countMatchesForText):
* editing/Editor.h:
* editing/mac/FrameSelectionMac.mm:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):


git-svn-id: svn://svn.chromium.org/blink/trunk@93273 bbb929c8-8fbe-4397-9dbb-9b2b20218538