GitLab

Adds a "PdfIncrementalLoading" feature to control whether or not the PDF
viewer tries to use incremental loading. The default state is enabled,
as this feature has shipped already, but we would like to experiment
with disabling it to address certain problems related to incremental
loading.

crrev.com/c/2349429 added a similar control for "partial" loading. The
two features are orthogonal: Incremental loading tries to load a PDF
before all the bytes have arrived, while partial loading tries to fetch
the bytes out of order. (Partial loading currently is not useful without
incremental loading, however.)

The linearized.pdf file was derived from the equivalent file in
third_party/pdfium/testing/resources. For the purposes of this test, the
file has been relinearized and decompressed using qpdf.

Bug: 1115149
Change-Id: Ib9f9d3d66b9c5d051528a6d49b4662b70d236649
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352217
Commit-Queue: K. Moon <kmoon@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798225}

This change updates net_log_test_util's methods that retrieve strings
from NetLogEvent dictionaries to allow fetching a string from a nested
dictionary using the base::Value::GetStringPath syntax (for instance,
"inner.item" will fetch { "inner": { "item": "value" } }).

(This allows writing some slightly more concise test code in the child
CL crrev.com/c/2315641.)

R=eroman

Bug: None
Change-Id: Ie8552b9347e9bb147f12e1a57ca98a43b9216f88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354293
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798224}

Roll Chrome Mac PGO profile from chrome-mac-master-1597405958-c5a8fe7086bb1f6a4ff7abcf1204e717b88da2c5.profdata to chrome-mac-master-1597426673-550b761d47e655299dbb3d5b54525f083ab2d05d.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ia56486fb547441131e12c282dfe029a17a20a84c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357094Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798223}

Roll ChromeOS Silvermont AFDO profile from 86-4183.57-1597055597-benchmark-86.0.4231.0-r1 to 86-4183.57-1597055597-benchmark-86.0.4232.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Iedac652f41c5b9f9b05fad000bd0f29eff0c28a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357429Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798222}

All of TrustedWebActivityLocationDelegationTest.* are flaking on the
official tester. This just disables the entire test file.

Tbr: peconn@chromium.org
Bug: 1116518
Test: run_chrome_public_test_apk -f TrustedWebActivityLocationDelegationTest.* (verify nothing runs)
Change-Id: I168bbb668493fcc95578be67e7c1abbb3716b52f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356989Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798221}

BUG=chromium:1113362

Change-Id: I1a3fd4448c706991e25bba434273bd783bdcfea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355053
Commit-Queue: Brian Malcolm <bmalcolm@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798220}

The NetworkHealthService class owns both a NetworkHealth instance
and a NetworkDiagnostics{Impl} instance.

This CL cleans these classes up a bit to make them more consistant
and to make the relationships a bit more clear.

No functionatlity is changed.

TBR=tbegin@, khegde@

Bug: None
Change-Id: I6d07f0e6f7fc0b24ba51e4c999672ff0865c36ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356268Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798219}

The work to implement this as a proper option in the UI is still
pending. Until then, this flag is the only mechanism available for
this accessibility option.

Bug: 817814
Change-Id: I18d1d2d62071e85b1be5f6b017cb2b05271795df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356190Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Adam Goode <agoode@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798218}

LayoutObject::Destroy() should not be called inside a finalizer. This becomes dangerous when we migrate LayoutObje ct to Oilpan as finalizers are not allowed to access other on-heap objects.

This CL adds AllowDestroyingLayoutObjectInFinalizerScope to mark certain SVGImage() as exempt from this CHECK. This is OK as SVGImage is retaining the LayoutObject via a Persistent and so it is guaranteed to survive the current GC cycle.

Bug: 1030176
Change-Id: Ibdd0a29e7630747ea118d92d442776cf1bac8537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352294Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798217}

This reverts commit d69e7bfd.

Reason for revert: assertion failures in BrowserControlsOffsetManager::SetupAnimation per Issue 1116552 and related bugs.

Original change's description:
> Reland "[Offline indicator v2] Add field trial testing entry"
> 
> This reverts commit 52b501ca.
> 
> The reason for the revert has been fixed with crrev.com/c/2248931. This
> reland also includes changes in tools/perf/benchmarks. We basically add
> a command-line switch to force the offline indicator an online state.
> This is because these benchmarks are run on offline devices and this
> causes the offline indicator to show and affects the stories being run.
> Showing the offline indicator isn't realistic when the test is simulating
> navigating webpages that would normally require the device to be online.
> Also, showing the offline indicator might cause flakiness in the results
> or dilute real regressions. We've investigated the reported regressions
> and confirmed that they're WAI when the indicator is showing.
> 
> Original change's description:
> > Revert "[Offline indicator v2] Add field trial testing entry"
> >
> > This reverts commit ceaac935.
> >
> > Reason for revert: continued assertion failures on some phones; see http://crbug.com/1084740#c17 .
> >
> > Original change's description:
> > > [Offline indicator v2] Add field trial testing entry
> > >
> > > Enabling the feature causes some test failures since the bots are
> > > offline and the offline indicator is always visible. For the short term,
> > > we are adding a command-line switch to disable the offline indicator.
> > >
> > > The longer-term plan is to enable the feature for most tests, and only
> > > disable where we have to.
> > >
> > > Bug: 989148, 1091491, 1093085
> > > Change-Id: I89e7ef93233b4c4cc2bd395ce1309bc14d5dea09
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228367
> > > Reviewed-by: Steven Holte <holte@chromium.org>
> > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> > > Reviewed-by: Avi Drissman <avi@chromium.org>
> > > Reviewed-by: Theresa  <twellington@chromium.org>
> > > Commit-Queue: Sinan Sahin <sinansahin@google.com>
> > > Cr-Commit-Position: refs/heads/master@{#777216}
> >
> > TBR=avi@chromium.org,twellington@chromium.org,holte@chromium.org,bsheedy@chromium.org,sinansahin@google.com
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 989148, 1091491, 1093085
> > Change-Id: I6c22120bbb27ff430f73a40ea28f1bf1a9a7da31
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244195
> > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > Reviewed-by: Steven Holte <holte@chromium.org>
> > Commit-Queue: Kenneth Russell <kbr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#778024}
> 
> Bug: 1091491
> Change-Id: I3fd5e9d92f61c980a664ad6b5c311fe6b68cd57c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246834
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Commit-Queue: Sinan Sahin <sinansahin@google.com>
> Cr-Commit-Position: refs/heads/master@{#798016}

TBR=avi@chromium.org,bcwhite@chromium.org,twellington@chromium.org,bsheedy@chromium.org,sinansahin@google.com

Change-Id: Ic31ee74957d7803d3c8fa6669ac9adb9c9c43479
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1091491, 1116552, 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357672Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798216}

This is part of the work to enforce isolated world CSP for resource
requests when the feature IsolatedWorldCSP is enabled and to correctly
bypass the main world CSP otherwise.

Note that it's possible that the plumbed DOMWrapperWorld might not
always be completely correct (for example if it is plumbed
asynchronously from the point which caused the resource request).
However this is still better than the status quo where the CSP checks
for isolated worlds are bypassed based on calling
FrameFetchContext::ShouldBypassMainWorldCSP() which is often incorrect
especially for redirects since we might be in a different different
world by then.

Next CL will remove FetchContext::ShouldBypassMainWorldCSP.

BUG=1099975

Change-Id: I727513d0fa8e9e16aa05a0fdd7c86d987f983890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354566Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798215}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0e97afad480e..02b64b9591b9

2020-08-14 brgoddar@microsoft.com Elements: Remove Event Listener Pane focus override

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1114604
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I6e84984651a0c504757af0ad5d246d0f0f879788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356591Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798214}

This fixes run_weblayer_shell crashing on startup when no URL is passed
(broken in 8c5d422b)

Bug: none
Change-Id: I1b4a82853686f14f6a244eac226db21cecc69dbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354611
Auto-Submit: Evan Stade <estade@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798213}

Change-Id: I4687a02904771284055b902ce3431b4cc549bdff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356931
Auto-Submit: Eric Roman <eroman@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798212}

https://android.googlesource.com/platform/external/perfetto.git/+log/241a4a92fb96..4c3752c7f677

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I1882c62b34b6d312a530df8e2a6f021298ff14c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356266Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798211}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-win-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I9a87473492cf182ade2b279d0e2246678f0f8126
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355522Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798210}

To FaviconDatabase. I'm going to use this in weblayer code
to expire favicons. WebLayer doesn't use history, but needs
a way to prune the database.

BUG=1076463
TEST=covered by tests

Change-Id: If74a389a947eb465447009c620e0988f9545ab91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354998
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798209}

Bug: NONE
Change-Id: Ie3b5b44531c8e870fd0961ce4746313f6e5e4de5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351720
Commit-Queue: Lijin Shen <lazzzis@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798208}

Comparison image:
https://drive.google.com/file/d/1YqxC7U2VQ_X318GDHVmu6tOJnEblOQFs/view?usp=sharing
(Left:New Right:Old)

Bug: 1085419
Change-Id: I0ba685cf36db42e41daf11d7735600cffb5408a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355310
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Auto-Submit: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798207}

The newly added ShouldPasteHistoryAsPlainText test case is flaky.

Bug: 1116530
Change-Id: I75897352152844220ffbc3fbc0e27007d650ca29
Tbr: dmblack@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357050Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798206}

This DCHECK occasionally triggers, but for unknown reasons. Update the
DCHECK to exclude re-registering the same main web frame. This will
separate the issue from the same frame being re-registered which will be
caught by the next, already existing DCHECK.

Bug: 1014227
Change-Id: Ic5a248f12467812e2b6b287565aa37f675935661
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354713
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798205}

This CL adds an optional linux-lacros-rel try builder, and it will
replace linux-lacros-compile-rel in the future.

Bug: 1116180
Change-Id: I46f3827848ff64ade1773d18d146a888312b4bd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354723Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798204}

The AGA experiment id changes in:
  https://chromium-review.googlesource.com/c/chromium/src/+/2338934
does not work when the StartupTabPreloader is used. Since the
StartupTabPreloader launches the navigation before all of native is
loaded, fixing this isn't simply a matter of moving the experiment
reading code earlier - it would involve changing Chrome's startup logic.

This change allows clients to disable the StartupTabPreloader to ensure
that the experiment logic in the linked CL is triggered (at the cost of
a longer time to navigation on cold start).

Change-Id: Ie83b4f38705084c567d7c20821600de7cdf15695
Bug: 1111941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356505
Commit-Queue: Peter Conn <peconn@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Auto-Submit: Peter Conn <peconn@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798203}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-autoroll
Please CC gbiv@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: gbiv@chromium.org
Change-Id: I31ae2e232712c31a7f85476af1aa59ae14c6a585
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356545
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798202}

Instantiating a PrintBackend class is done through a CreateInstance()
call.  This call has included a parameter to optionally seed the new
instance with some initial values different from the defaults.  This
parameter is never made use of in the existing code.

Cleanup of this parameter will ease the effort to mojoify the
PrintBackend class.

Bug: 809738
Change-Id: I460e3edd14c2fd830d9d8f126b84619ec9e53597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354541Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798201}

Use the new bluetooth::mojom::Adapter::SetDiscoverable() to implement
Nearby Connections' BluetoothAdapter::SetScanMode(). Notably,
BluetoothAdapter::SetScanMode() can only toggle discoverability on or
off; it cannot be used to power Bluetooth on or off. This aligns to
the actual usage of this method by Nearby Connections.

See go/nearby-chrome-bt for more information.

Bug: b:154848416, b:154845584, b:154847207
Change-Id: I5802372d8f47d99af4fa1879efa89a3c0de52e32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350388Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798200}

This reverts commit 4feae4d0.

Reason for revert: this is failing on the official tester on M86, https://crbug.com/1112409#c9

Original change's description:
> Revert "Marking SiteSettingsTest.testClearDomainCookies as flaky test."
> 
> This reverts commit 1d4d72e9.
> 
> Reason for revert: I don't see flakiness on testers for trunk. Maybe the issue got fixed already and only exists in M85.
> 
> Original change's description:
> > Marking SiteSettingsTest.testClearDomainCookies as flaky test.
> > 
> > TBR=dullweber@chromium.org
> > 
> > Bug: 1112409
> > Change-Id: Idf31c4a8d709ddc3f4f87cff63d63881f0198424
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346853
> > Reviewed-by: Ben Mason <benmason@chromium.org>
> > Commit-Queue: Ben Mason <benmason@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#796524}
> 
> TBR=benmason@chromium.org
> 
> Change-Id: Idbbd6d8947bc9d986a16ccd094775e49bd7243d4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1112409
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348769
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Commit-Queue: Christian Dullweber <dullweber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#796769}

TBR=dullweber@chromium.org,benmason@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1112409
Change-Id: I7a20044bbae961197c6b3354b815bea6c645f238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357072Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798199}

Previously the only way to pin an unpinned open app in shelf is to use the context menu. In this update, we enable the feature that dragging an unpinned open app to the pinned app side is available to pin the app.

Bug: 1084856

Change-Id: I559a8967942a1c4d6ee7eb370cd81181b173c361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321065Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Wen-Chien Wang <wcwang@google.com>
Cr-Commit-Position: refs/heads/master@{#798198}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ec709593d585..3bd3c99b4d5c

2020-08-14 Han) Zhang Reland "Modified git cl format for distributed histograms"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: I84e5cc48426dfa1b13b533edd4f520de458f4eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354780Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798197}

This allows the flags field to be changed to a FIDL |bits| type without
breaking the Chromium build.

The |static_cast|s introduced in this change will be removed after the
next Fuchsia SDK roll.

Bug: 1099393
Change-Id: Ie0628ac0dbe7dd8dd407d5907b0ef38cbd839da8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353295
Commit-Queue: Tamir Duberstein <tamird@google.com>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798196}

Switches RenderTestRule to exclusively use the new naming scheme that
does not include device model or OS in the test name.

Bug: 1077274
Change-Id: I3dd4e4088151732e83d8ac7fe5a52e10cfe6252c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354715Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798195}

This change ensures that the surface can't be opened more
than once, and only closes after opening.

Also verifies that all conditions are met prior to opening.

While testing this, I noticed scroll restore wasn't working.
I've fixed this by waiting until the recycler view adapter
has the right number of items before attempting to restore.

Bug: 1115213
Change-Id: I86bae811926fa4a6c1caf1f8dce8e32e80152613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354656Reviewed-by: Vincent Boisselle <vincb@google.com>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798194}

CQ bots generate an html report using this script and we won't know if
the developer needs the host or device report, so generate both.

BUG: 1116208
Change-Id: Idd2a841c495b87d6f382acb1771b9f2842908508
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355571Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798193}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: Ic0167dca9bf05c30ec795a5f02fd220618b58e5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355523Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798192}

* Previously display idle event will restart ambient mode. Fixed the
  unittest that should have caught this.
* Also added some DVLOG for future debugging.

Bug: None
Change-Id: I49cc798f4d975a3449e506b835469bd740b4308f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354945
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798191}

This CL amends the units used on the histogram
Tabs.TabSearch.WindowDisplayedDuration from the incorrect units
"seconds" to the correct units "ms".

Bug: None
Change-Id: I80364b76d862834036a3eceaae586579e7a31560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354774Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798190}

This change cleans up some temporary crash keys used while investigating
crbug.com/1111735.

R=lukasza

Bug: 1111735
Change-Id: I441744d269f8afc508930b51623b992194d1327a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355293Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798189}

Bug: 1085419
Change-Id: I545fec75952e76b449179f3ec7e676df16db6bc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354602Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798188}

This CL adds the script and the target needed to extract Lacros binary /
resource size histogram JSON files, which are needed for size monitoring
on Chrome Performance Dashboard.

Following the methodology of how Android Chrome creates resource size
histograms (in //build/android), the key parts are:
* Target "resource_sizes_lacros_chrome" to create wrapper script in
  $OUT_DIR/bin for the main script. This will be called by build bots
  (hook to be added in follow-up).
* lacros_resource_sizes.py to read Lacros build artifact sizes, and to
  export the result to histogram JSON files.

lacros_resource_sizes.py is specialized for Lacros to simplify code. The
script accounts for each file in the ZIP file created by the
chromeos-amd64-generic-lacros-rel builder, but files can be aggregated
by a list and/or by directories. Changes in ZIP file content will require
updates to lacros_resource_sizes.py for proper size accounting.

Bug: 1106626
Change-Id: I9e42eeb2d54105b47fe37730ba098256bd67de54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346910Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798187}

Change NativeFS Drag & Drop from a 'test' runtime enabled feature to an
'experimental' runtime enabled feature. This will enable NativeFS drag
and drop by default if enable-experimental-web-platform-features flag
is set.

Bug: 1080811
Change-Id: Ie3fcc4a28f22a3287cf64607b90e44a0f7767607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356188Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Hazim Mohamed <hazimmohamed@google.com>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Hazim Mohamed <hazimmohamed@google.com>
Cr-Commit-Position: refs/heads/master@{#798186}