GitLab

SigninManager should always use application context, thus there's no
need to pass it to the ctor and ContextUtils.getApplicationContext can
be used instead.

Bug: 1007415
Change-Id: I8688889d52c71658183c7a4d32d36b7cf1378811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823197
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700349}

Change-Id: I453ca43a33a0f37a0418d7d653f59c445154618b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825123Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#700348}

Initial conversion performed using '2to3 -f print .'.
Imports added and duplicate parentheses removed manually.
Manually converted files, comments and inline code that 2to3 missed.
Afterwards ran "git cl format --python" and cherry-picked the formatting changes.

There are no intended behavioural changes.

Bug: 941669
Change-Id: Ia6b0f45b817a3eaeaa8a796f885d99a06513e6f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818480
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#700347}

Change-Id: I9e5c5c12bc4c37d1aded50a8c230c1db3fca2587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815458
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700346}

Previously initial focus in this dialog was the source list itself,
which was weird - the source list was focusable but had no keyboard
behavior or focus ring. An earlier change
(28f16f08) made it unfocusable but left
it as the initial focus view. When the initial focus view is
unfocusable, Widget::SetInitialFocus does not activate the widget at
all, which left it unusable with the keyboard. Oops!

This change drops initial focus on the dialog's cancel button. In
principle it would be nicer to drop focus on the first source in the
list, except that:
1) These lists are constructed asynchronously after the dialog appears
   so that view is not yet present when GetInitiallyFocusedView is
   called, and
2) Focusing one of the source views serves to select it, which would be
   surprising

Failing that it would be nice to use the dialog's default button, but
the default button is OK, and the OK button is disabled until the
user selects a source. We could change the default button to be Cancel
but on Mac Cancel cannot be the default button :(. As a result, this
change uses the Cancel button as the initially focused view but leaves
Ok as the default button.

Bug: 1007174
Change-Id: Ibc435b830394895551c99fd0fb4172729d981547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825321
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700345}

https://chromium.googlesource.com/angle/angle.git/+log/39d142e89afb..2bdefbf8162d

git log 39d142e89afb..2bdefbf8162d --date=short --no-merges --format='%ad %ae %s'
2019-09-26 jmadill@chromium.org Vulkan: Remove some redundant "vk" prefixes.

Created with:
  gclient setdep -r src/third_party/angle@2bdefbf8162d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: None
Change-Id: Ifcfd393254e031c68af5676e8a7b47d32bc67cc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827480Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700344}

This extends cts_config/README.md to clarify how to re-enable skipped
tests. This also updates some markdown formatting errors I observed.

Bug: 918221, 765873
Test: tools/md_browser/md_browser.py
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I1c11dc14c3b83b9a56b190e6ced9cb629b7a54cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825925
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700343}

This CL is adding a fuzzer for RenderText.
The current fuzzer only call SetText(...) and perform the layout.

This will give better coverage on
  1) TextItemize(...)
     * Splitting text into runs.
       Rely on third_party/icu.
  2) ShapeRuns(...)
     * Shape runs by finding fonts/glyphs
       Rely on DWrite, FontConfig, etc..
  3) GetFallbackFont(...)
     * Find a fallback font for a sequence of codepoint
       Rely on DWrite, FontConfig, etc..

R=robliao@chromium.org
CC=​etiennep@chromium.org

Change-Id: Id6917e6b65c33be228b38705904134bc6cdbeb39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826142
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700342}

Whether the home screen is available is strictly equivalent to whether
tablet mode is on. I understand the desire for the extra level of
indirection but it doesn't seem like this is changing anytime soon,
and if/when it does, it won't be hard to re-add :-) In the mean time,
I think we should favor readability / understandability.

Bug: 982512
Change-Id: Ifb34f316ae0fe579ee2854b70025a0b2de216d93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826198Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700341}

Bump flags from 79->82, except for webvr which is updated to 80 since it
is intended to be removed then.

Bug: 1007559
Change-Id: I543d1f2ee7228b9f303089c4934adae1e41ad4a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824026
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700340}

Fixes stop and start.
Resetting now will stop the children.
Updates tests to also verify the children are reset.

Bug: 1007257, 1007928
Change-Id: I19f24fbf8d0bf3f5e761d394e1a357544bd9752f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821905
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700339}

We were including build config and android support library files in the
weblayer aar. We really only want to include the weblayer files in the
aar, since the app including it will provide the support library and
other things we need. This adds arguments to the dist_aar rule to
filter what goes into the jar files, similar to other java rules.

Change-Id: Id5393d06dac8b0d957469a3279c74199088f3732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825567
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700338}

Users should be able to change the active color format in the color
picker via the keyboard. With this CL, users can press the down arrow
or space to select the next color format. Users can also press the up
arrow to select the previous color format.

Bug: 1007048
Change-Id: Id12ef30d80cbc7f56e029847d29d8bcf33f1b8cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819840Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Sanket Joshi <sajos@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#700337}

TabStrip doesn't semantically need to be a ContextMenuController, this
hides that implementation detail as a nested class.

Bug: None
Change-Id: I2e46adbea0689300c964c8b8ceac3fe9ec12ee6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825789
Auto-Submit: Peter Boström <pbos@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700336}

It is unclear whether caching the settings improved performance. The
performance regression resolved before the CL adding the caches
landed, and there was no significant improvement to performance once
the CL did land.

However, it did make the code less clear and introduced greater
potential for bugs (e.g. https://crbug.com/1002664).

Bug: 991838
Change-Id: Ia67a693596ead2a3b392b6e1835e0a2963f47d84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822477Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#700335}

https://skia.googlesource.com/skia.git/+log/403f2955e7f6..49c073257022

git log 403f2955e7f6..49c073257022 --date=short --no-merges --format='%ad %ae %s'
2019-09-26 fmalita@chromium.org [skottie] Add null sink option for skottie_tool
2019-09-26 herb@google.com Restrict SkStrikeInterface to GPU and rename to SkStrikeForGPU
2019-09-26 ethannicholas@google.com Revert "remove 'in uniform' support from GrSkSLFP, make rules more clear"
2019-09-26 fmalita@chromium.org [skottie] Minor MotionBlurEffect cleanup
2019-09-26 herb@google.com Blur both in x and y
2019-09-26 ethannicholas@google.com remove 'in uniform' support from GrSkSLFP, make rules more clear

Created with:
  gclient setdep -r src/third_party/skia@49c073257022

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@google.com

Bug: None
Change-Id: Id51f18a999186e37e291531f62dee43ac88bacba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827718Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700334}

CL:1825568 added parentheses around all print statements.
The parantheses result in things being printed as tuples in Python 2
and normally in Python 3.
Adding the import makes the behaviour consistent, reducing the
likelihood of incompatible changes between the two in the future.

Bug: 941669
Change-Id: I14275266ee3b410668b5fb1efab192aa1f7cb42b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827011
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700333}

BUG=None

Change-Id: If86397302ec2d5df2015c2a74527473cfc045d31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824471
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700332}

This code overrode layout to update the client rect based off of a
potential change in bounds to the children after layout.

Instead, this code should observe a bounds change for each child
and update the client rect on a bounds change.

BUG=1005568
TEST=browser_tests ScreenCaptureNotificationUiBrowserTest.InvokeUi visual inspection.

Change-Id: Iaee803706951bcf3c7e1cd9e0d78241952911fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825904
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700331}

Check for the sys tray when checking if an event is within the shelf
window. Also added a test.
TEST=automated

Bug: 1006032
Change-Id: I1e36b8d4ce761d7cebce8c0e5f312ea881ec23e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825485
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700330}

This was busted in r699860, where I incorrectly replaced a
base::AutoReset instance, which made |is_opening_| always remain false.

Bug: chromium:1003313, chromium:1008362
Change-Id: Ie4e1a5fb220672c00d178dded9605e290b10c217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826861Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700329}

In preparation to launch sandbox on Mac fully, this CL switches the
default value of the flag to always enable sandbox on Mac.

Bug: 974453
Change-Id: I79cce0dcf4471501d9ccc7c663c3de69067762b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821779Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700328}

https://android.googlesource.com/platform/external/perfetto.git/+log/e545db8d0486..d58b3ef67609

git log e545db8d0486..d58b3ef67609 --date=short --no-merges --format='%ad %ae %s'
2019-09-26 fmayer@google.com Add API to generate pprof from TraceProcessor*.

Created with:
  gclient setdep -r src/third_party/perfetto@d58b3ef67609

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: If7a866a41857caa0ebcaf27eb2b8a18261e80170
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827717Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700327}

https://webrtc.googlesource.com/src.git/+log/89e7fcb726e9..b4ffe881cdd7

git log 89e7fcb726e9..b4ffe881cdd7 --date=short --no-merges --format='%ad %ae %s'
2019-09-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fbc0a229..2d2f043b (700084:700199)

Created with:
  gclient setdep -r src/third_party/webrtc@b4ffe881cdd7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: I2d80be75ff8d23ee501042e97d535924b6c5e4df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826653Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700326}

Creation is now by way of a static function in WebLayer that returns
a Future.

BUG=none
TEST=none

Change-Id: Iaba3a264ae1f1f315656d0069e9c5b55f001df27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825721
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700325}

Switch the collection of cached_vpd and storage information
from runtime_probe to cros_healthd.

to a sona device with some code to log what StatusUploader is
uploading. I then checked that data was consistent with the data
reported by the command-line invocation of cros_healthd.

Bug: b:128683357
Test: manual and unit tests. Manually, I built and deployed Chrome
Change-Id: Id680449eed59cba7ed92bc4b4934e466d457ff79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809612Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Paul Moy <pmoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700324}

To detect whether Application Verifier is running,
sandbox/win/src/target_interceptions.cc checks if vrfcore.dll is loaded,
while sandbox/win/src/handle_closer_agent.cc checks for verifier.dll.

This change makes both use verifier.dll, to be consistent and remove any
confusion around whether these two are checking for the same thing (they
are).

      Open Application Verifier
      File > Add Application > chrome.exe (any chrome.exe binary works)
      Under 'Tests', uncheck everything but Basics > Handles, then Save
      Run chrome.exe with this change; it works normally
        (on versions without lines 176-177, no pages will load)
      Return to Application Verifier
      Right-click chrome.exe > Delete Application, then Save
        (so Chrome runs normally again)

Test: Manual
Change-Id: If97a1115373c394f0cbbf1d31d3ca7b60549bbee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776781
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700323}

There is no need anymore to block navigations from the signin page to
other chrome URLs, because concerns from https://crbug.com/366127 are no
longer applicable:

1. Site Isolation has shipped since then and guarantees process isolation
   between 1) the signin page, 2) other chrome URLs and 3) web/http
   content (in particular, see how r689561 and r595259 modified
   SiteInstanceImpl::DoesSiteURLRequireDedicatedProcess).

2. Project DICE has significantly refactored how the signin page works.
   In particular web/http content is now hosted inside a <webview> tag
   (see inline_login.html and new_inline_login.html in r449349 and
   r301130).

3. Chrome no longer has a "signin process" with higher privileges.

Bug: 1003957, 442674, 366127
Change-Id: I022af05d339d29a1f57b4a7128e69036c6eecb5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804680Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700322}

This test is flaky on iOS devices, but FLAKY_ prefix is no longer used,
so this test is disabled on iOS devices.

Bug: 1008023
Change-Id: I7bb3e2d530d584585f2c89c57a1c8b05067e30b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825319
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700321}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/87e5c742..6384e38b

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I308bce27d8f2fcdbb8c5afb3d92d6bb101276bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827607Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700320}

This CL was generated by
//base/android/jni_generator/jni_refactorer.py.

Bug: 929661
Change-Id: I93cfe2c52279c115e2c896aff034ef650c4e6ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809242Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700319}

Change-Id: Ib9710772ce534e49d42f51dd8c4b374d85659127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823852
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700318}

This removes almost all remaining usage of Connector from child
processes, instead preferring use of ChildProcessHost.BindHostReceiver
to acquire process-scoped interfaces from the browser.

The one remaining use case after this CL is for the Device Service's
PowerMonitor API. This is left as a separate change because it requires
substantial additional support code for testing.

Bug: 977637
Change-Id: I679c6d7f5ec01d1bc1bb6852e0f79a3f1650df34
Tbr: penghuang@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815731
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700317}

Translate option under Content Settings is not shown if Language Settings
is enabled. However, Sync can trigger the translate prefs to be changed
and Content Settings tried to update _translateDetailItem which hasn't
been initialized.

Added unit test to call -onPreferenceChange:.

Bug: 1006720
Change-Id: If97799c1a13b6913ff7bc8ceed0674fbebc3491c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826000
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700316}

Before the patch: the worker would never ignore corrupted passwords,
which blocks other updates.

After this patch: the worker ignore corrupted passwords.

Change-Id: Ia8d3fd9a351f6949b9348fb57c7b721643d2e182
Bug: 1008403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826892
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700315}

This wipes out the File service completely, migrating DOM Storage code
to direct usage of LevelDBServiceImpl. This is a precursor to further
migration over to Storage Service code.

Bug: 994911
Change-Id: Ic8f8219c1c07316598ead9d2b214f8cfa7e17c75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824025Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#700314}

This is CL [4/4] in a series of CLs to expose "display: none"
elements to the browser process AXTree.

1. Add and improve tests for CSS display and visibility.
2. Introduce new command line flag and chrome://flags entry.
3. Update AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree
   and relevant logic for the feature to work, disabled using the
   feature flag.
4. Enable the feature in tests; update expectation files.

---

This change enables exposing "display: none" nodes to the browser-side
AX tree for tests only by enabling the appropriate base::Feature
and assigning a "status" to the flag in :
third_party/blink/renderer/platform/runtime_enabled_features.json5
content/browser/accessibility/dump_accessibility_browsertest_base.cc

---

Bug: 651614
Change-Id: I70ebede486ef157ef0c0dce5b9338621101c76af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809421Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#700313}

https://chromium.googlesource.com/catapult.git/+log/eecf29fbbcd3..62960ae89911

git log eecf29fbbcd3..62960ae89911 --date=short --no-merges --format='%ad %ae %s'
2019-09-26 wnwen@chromium.org Add fake module support to device.Install API

Created with:
  gclient setdep -r src/third_party/catapult@62960ae89911

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC zhanliang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=zhanliang@google.com

Bug: chromium:1000751
Change-Id: Ie4c3d8b3ff401bb2ccbcd1b8164b1d5108eca7dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827662Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700312}

Bug: 1008161
Change-Id: Ib8daa0315d3c22c810848d4f696961e7ba005d82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824127Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Jenny Wong <jyw@google.com>
Cr-Commit-Position: refs/heads/master@{#700311}

The commands that were added to the command menu (i.e. ctrl+shift+p) were not calling ls().

This fix does two things:
1. Adds a call to ls() for Action.title, Action.category
2. Adds an ls call for title and category arguments for CommandMenu.createCommand, CommandMenu.createRevealViewCommand, and CommandMenu.createSettingCommand

Before:
https://imgur.com/sWQWAqK

After:
https://imgur.com/2O4xq3k

Bug: 941561
Change-Id: I82944ecf2a9eeb47bb7824336b6ac49283829e42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789843Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Lorne Mitchell <lomitch@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#700310}