- 31 Oct, 2019 40 commits
-
-
Xianzhu Wang authored
Move tests under paint/dark-mode/* to virtual/dark-mode*, so that virtual/dark-mode*/paint/dark-mode/* now becomes virtual/dark-mode*. Also we no longer run paint/dark-mode/* test in non-dark mode. Bug: 1014162 Change-Id: I23b80e4a535356855f11aa2f47a517fbc455f171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892214Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711371}
-
Ian Struiksma authored
For some sites they overload console commands, so we create an iframe to log element info for debugging. We need to make sure to remove that iframe afterwards, or we build up a collection of them that might affect elements on the page, particularly on lower resolutions. Bug: 984664 Change-Id: I2f81cd8e563c4ca275f561efe94bb03027ee0d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884815 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#711370}
-
Yi Gu authored
[VizHitTesting] Disable SitePerProcessHitTestBrowserTest.CrossProcessMouseEnterAndLeaveTest on Linux The test Site.Cross/0 could not be caused by the suspected change crrev.com/c/1797092 which only affected Site.Cross/1. The test is only flaky (timeout) on ChromeOS. Occurences on other platforms (crash) are no longer present [1]. Disable the test on the affected OS only. [1] https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybAsSBUZsYWtlImFjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5Dcm9zc1Byb2Nlc3NNb3VzZUVudGVyQW5kTGVhdmVUZXN0DA&show_all_occurrences=1 Bug: 1006635 Change-Id: I5cc99c678e258846643d933a216575e5268ea9e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837712Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711369}
-
minch authored
Bug: 1002733 Change-Id: Idfd3b12996e3a4942b07e2da6790129ee5469df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887747 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#711368}
-
Drew Fisher authored
This lets us remove ambient replace-as-executable from things that don't use V8. This includes: * cast_runner and web_runner, which simply provide fuchsia.sys.Runner glue implementations * http, which provides a legacy HTTP implementation that also doesn't need to directly execute memory. We can also remove the implied executability from some tests. As a start, convert the base unittests (which test LoadLibrary) to eschew the deprecated-ambient-replace-as-executable feature. Bug: fxb/37924 Change-Id: I461312972881a0e05d31834227e482c78b445ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881697 Commit-Queue: Drew Fisher <zarvox@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#711367}
-
Wei Li authored
The custom layout used by ComboxBox simply calls the parent's layout function and set up the arrow button's bounds. The latter can be replaced in OnBoundsChanged(). After that move, the custom layout is no longer needed. BUG=1005568 Change-Id: Ib3ea796fbaa6bf626ad5d07e00d6db8c2fbc31b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890976Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#711366}
-
RJ Ascani authored
Now that the soft transition of fuchsia.media/KeyId to a bytes field is complete for key_id, we can revert back to using key_id instead of key_id_temp in EncryptedFormat. Bug: fxb/38522 Change-Id: I86092467213964bed965561fe0b663bc7d5fc411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893677Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: RJ Ascani <rjascani@google.com> Cr-Commit-Position: refs/heads/master@{#711365}
-
Bill Budge authored
Bug: chromium:719172 Change-Id: I7d27bc66572c168607bd03ff6ee712fc6e863640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888741 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#711364}
-
Bo Liu authored
BrowserFragment has an explicit onDestroy which we rely on. There is no need rely on gc to check that embedder forgets to call this. Add methods to create a profile, and all live profiles. This and the fact that it's probably not catastrophic if embedder forgets to destroy profiles, it's deemed not necessary to rely on gc to check this. WebLayer is just the global factory that will never be destroyed, so remove the destroy method. This means weblayer currently does not rely on gc either to clean up or to warn embedder about forgetting to call destroy. Remove all finalizers. Other changes: * Inline and remove ProfileManager in the client library * Change static map for profile in the client library to be keyed by the path. Previous implementation is probably broken since getProfile returns a new object each time. Change-Id: Ic00ed31fda4445412913e6dbe81b7cf8d2205766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884661Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711363}
-
Gabriel Charette authored
A git cl split will follow this CL to migrate BrowserThread::DeleteSoon(BrowserThread::ID, FROM_HERE, *); to base::DeleteSoon(FROM_HERE, {BrowserThread::ID}, *); and will ask owners to verify that this no-op change indeed matches the code's intent. R=fdoray@chromium.org Bug: 1019767 Change-Id: I83111c55ea713f50c46761cf4d83ff593f7d505b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890632Reviewed-by:François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#711362}
-
Richard Knoll authored
If we show help text in Click to Call dialogs, we can just embed the origin into the help text itself instead of showing it as a separate line. We keep showing it as a standalone label in the footnote if there is no help text. Before: https://imgur.com/PSIfHmz After: https://imgur.com/UXeUbmp Bug: 1019242 Change-Id: Id59ff2e53d2f3a5e7ab9da9a1ed876fb5d45641d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887617 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#711361}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 79-3904.19-1569836348-benchmark-79.0.3923.0-r1 to 79-3940.0-1572257069-benchmark-79.0.3945.20-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Ic023d40addde5a21cd4c56b46a4b48744cddc518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893324Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711360}
-
Pavel Shmakov authored
The ShaderClearHelper never runs the callback if there is no cache to clear. Clearing shader cache is part of the BrowsingDataRemover's procedure when DATA_TYPE_CACHE flag is set. So this results in BrowsingDataRemover never reporting completion to its observers. Bug: 1020168 Change-Id: I23ba6ed2a99b6c44acf0b349dd398f26133369a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890310Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Kurt Catti-Schmidt authored
We discovered that the fragment root change that was recently submitted here: https://chromium-review.googlesource.com/c/chromium/src/+/1823822 regressed fragment root navigation in Inspect. This was not the case when Kevin had first submitted it. I traced it down to the changes that I made for Controller-For elements, so this change undoes those modifications. In order to stabilize the content_browsertest that prompted the changes (DumpAccessibilityTreeTest.AccessibilityInputDateWithPopupOpen/uia), it was discovered that there were several issues in how we were handling date-time popups. The first issue is that we were failing to return the proper parent window for the fragment root. In RenderWidgetHostViewAura::GetParentNativeViewAccessible, we were returning nullptr as the parent of datetime popups, which was parenting the popup under the root desktop window in Inspect. This change now returns the host's window, which places the popup under the correct parent window in Inspect. The second issue is that there was a cardinality problem with datetime popup windows. Since they share a BrowserAccessibilityManager with the main window (but are under a different fragment root), LegacyRenderWidgetHostHWND::GetOrCreateBrowserAccessibilityRoot would always return the main window's root kRootWebArea instead of the popup window's kRootWebArea. So we'd have two different fragment roots that map to the same gfx::NativeViewAccessible. This would cause GetFragmentRootParentOf to return the incorrect parent most of the time. This change fixes that issue by adding an extra step for popup windows that traverses the root node and searches for the popup web root via OneShotAccessibilityTreeSearch. Bug: 1019016 Change-Id: I678425c8417334275727053243a39b1039e6f135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885102 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
-
Nick Harper authored
This was requested by the DotGov registry. Change-Id: I9e962fee89158d1f876ded6cb51c545c444761c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888536 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711357}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fb075d558d6d..8d65e9ab98d8 git log fb075d558d6d..8d65e9ab98d8 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 sprang@webrtc.org Fixes pacing interval dependency and race in BandwidthEndToEndTest 2019-10-31 gustaf@webrtc.org AEC3: Handle multichannel audio in single CNG instance 2019-10-31 srte@webrtc.org Removes RPLR based FEC controller. 2019-10-31 minyue@webrtc.org Update comments on Audio Level RTP header extension. 2019-10-31 danilchap@webrtc.org Do not stop SingleThreadedTaskQueueForTestingTest near the end of the tests Created with: gclient setdep -r src/third_party/webrtc@8d65e9ab98d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: If21ae994235b5fffc4422a0be557754f9a6d8b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893675Reviewed-by:
-
Thomas Lukaszewicz authored
Fixed logic governing bounding box of the find bar in the browser layout view. Removed unnecessary insetting and fixed comments to better reflect its function. Bug: 871419 Change-Id: I89a341825508b1e088b0f10f449eb2c3a91fcc38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866969 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#711355}
-
haozhe authored
Chrome passes the tests and firefox doesn't support "to" in asssert_true. bug filed: https://bugzilla.mozilla.org/show_bug.cgi?id=1593036 Bug: 900581 Change-Id: I55df2d439c6c58665f1b1536def0b0b04635cf1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891758Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#711354}
-
Avery Musbach authored
The present CL addresses blatantly broken behavior when entering split view mode by snapping an ARC window. Bug: b/143499564 Change-Id: I777f03a356301d2be507fc85b74499ecc3a57173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893585Reviewed-by:
-
Jasper Chapman-Black authored
This changes both the ndjson-parsing JS library and the experimental .size-parsing WebAssembly library. Bug: 1019933 Change-Id: Ic050e4fb2162d29d2a4031f69bd88c43b0bfa6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890021 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#711352}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dbd554ed9e86..0c5f821e4023 Created with: gclient setdep -r src-internal@0c5f821e4023 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: If5f8aa2f2f70fbe08d443e96e9394ca42bb28207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893771Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711351}
-
Olivier Robin authored
Tbr: eugenebut Bug: 987646 Change-Id: I659aa88374381c8fc221efcb2287c17314b6cfa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892811 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711350}
-
Piotr Pawliczek authored
Corrects small misspelling. BUG=none TEST=none Change-Id: I3ab85b66923e90ed9c5e505af3ed6eedd5771810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893735 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711349}
-
Harald Alvestrand authored
The support for DTLS 1.0 is supposed to be removed in M81. Bug: webrtc:10261 Change-Id: Icfcb50d2d8cd0eb4212827c5d471ffc168efa780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559133Reviewed-by:
Steve Anton <steveanton@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#711348}
-
Vladislav Kaznacheev authored
Re-adding a line that initialized the layout manager. This line was deleted in http://crrev.com/c/1817149 which led to the "Shut down" button becoming not clickable. Bug: 1014774 Test: manual Change-Id: Ib2b8004a0c296f2d3355768e54bd9bc9b1331192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891140Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#711347}
-
Reilly Grant authored
These values are observed in the ISensor API result histograms. Bug: 958266 Change-Id: If771f3c4b8e2bacf97108b9b183ba05c4de7964e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891453Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#711346}
-
Alexander Timin authored
Remove kInternalIPC task type. - If it's used to bind associated interface, use kInternalNavigationAssociated instead. - If it's used to bind non-associated interface, use the task source mentioned in the spec or kInternalDefault if it's not speced. R=ayui@chromium.org Change-Id: I4ee9b994ba8b5ee91c0239b7c1de2ca16e902a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888032Reviewed-by:
Ayu Ishii <ayui@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711345}
-
Arnaud Mandy authored
Remove flag for EnableAccelerometerReading(bool) and split into EnableAccelerometerReading() and DisableAccelerometerReading(). Bug: 1018705 Change-Id: Ie385fe627b0969d0fbdb01f28423300acce66f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883573Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#711344}
-
Victor Hsieh authored
crostini_handler.cc - Collects the action before the opt-in/opt-out confirmation, which triggers reboot. enable_adb_sideloading_screen.cc - Collects the action/error when the actual confirmation dialog is shown upon reboot. Test: click some buttons, see the data in chrome://histograms Bug: chromium:893332 Change-Id: Ia0ac5609c6c6c5df0995833e98df1aff4d6d428b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888156 Auto-Submit: Victor Hsieh <victorhsieh@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#711343}
-
Vlad Tsyrklevich authored
base::ProtectedMemory is being deprecated and these headers are no longer used in these files. Bug: 1018834 Change-Id: Idf456986ba9607e5528d3a03dc75ef04f1915601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893581 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#711342}
-
Donn Denman authored
This default-enables the Simplified Server experiment. BUG=939460 Change-Id: I4359ba4214822c4150230a394736730f02b5f593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891582 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d67bf6590f8..3bc571a527f4 git log 5d67bf6590f8..3bc571a527f4 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 zakerinasab@google.com Merge "Fix multiple issues in vulkan memory tracker" 2019-10-31 lalitm@google.com Merge "trace_processor: add three more benchmarks for filtering code" 2019-10-31 treehugger-gerrit@google.com Merge "Enforce constructor constraints for uniform_int_distribution" 2019-10-31 primiano@google.com Merge "UI; unify File/ArrayBuffer/fetch() into TraceStream" 2019-10-31 tneda@google.com Merge "perfetto-ui: Correctly opening trace via link with only heap profile" Created with: gclient setdep -r src/third_party/perfetto@3bc571a527f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Id381124ae942a6bb68e5d5bca358413094d04dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893318Reviewed-by:
-
Ryan Sturm authored
This modifies field trial testing for navigation predictor to match the new arm rolling out to Beta with M79. Change-Id: Ibae0deb28cd9f96e788b67f4c5a7c95b94cf82ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891143Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Mike Wittman authored
Bug: 976864 Change-Id: I3847686020daec31e1dd9ec840252fad62bc2c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893356 Commit-Queue: Mike Wittman <wittman@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#711338}
-
David Bokan authored
I accidentally mislabeled the UMA histogram name in https://crrev.com/d7c43476bd654d85c7fe82dae63f610a7fdb1d82. Fixing these to match the values in histograms.xml so the histograms show up in the UMA dashboard. Change-Id: I60dd2d74b83b591f131c63e54d6f137600ddcf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890408Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#711337}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia1298d3166d244fda5c305488cafd8cb45e07582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893731Reviewed-by:
-
Josh Nohle authored
Replace request queues with vectors in FakeCryptAuthFeatureStatusSetter and FakeCryptAuthDeviceNotifier for better element access during testing. Bug: 951969 Change-Id: I7292e3b3e1d0a4b814cab22b960e20945b4d4c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893495 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#711335}
-
Joe Mason authored
This file is only used by an internal testing tool and has been moved back to the internal repo. R=drubery Bug: 1001604 Change-Id: Id7ece3ab84d225e821d28ef23f4224580b155fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891237Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#711334}
-
Natalie Chouinard authored
Move Clear Browsing Data feature-specific methods from PrefServiceBridge to the dedicated BrowsingDataBridge. Bug: 1016957 Change-Id: I4ee4397fc03b16debf44a7769ed8414a4608fde4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892151 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
The PlatformFontSkiaOnWindows is changing the use of PlatformFontWin by PlatformFontSkia. The experiment is deployed on canary and dev. This CL setting the default state of the experiment to enroll user in the PlatformFontSkia group. The legacy code (PlatformFontWin_ is kept as a kill-switch and will be remove soon. Bug: 944227 Change-Id: Ib32f2fdee225650d6f0728c2f791d358857f853c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888314Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
