GitLab

If using canvas.getImageData or GL textures of UNSIGNED_BYTE type, 16-bit depth
stream data is available only through 8-bit* API, so there is a precision loss.
Here, we add no-precision-loss** JavaScript access through WebGL float texture.

RGBA32F usage here enables lossless access to 16-bit depth information via WebGL1.
In related work, the same code path is used to upload 16-bit data to other WebGL2
supported formats; e.g. with GL_R16UI there is no conversion needed in
SkCanvasVideoRenderer::TexImageImpl.

* 8-bit access refers to JS ImageData and WebGL UNSIGNED_BYTE where 16-bit depth
data is now available as luminance (all 3 color channels contains upper 8 bits
of 16bit value).

** Float is used for no-precision-loss access to 16-bit data normalized to
[0-1.0] range using formula value_float = value_16bit/65535.0.

This patch also adds UNSIGNED_BYTE WebGL test which was earlier tested through
testVideoToImageBitmap since UNSIGNED_BYTE and canvas rendering still share the
same path through SkCanvasVideoRenderer::Paint.

BUG=369849, 624436
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2476693002
Cr-Commit-Position: refs/heads/master@{#436221}

Most if not all of this information is out of date, as incremental
linking is now handled more-or-less automatically by the build
and you probably shouldn't mess with the settings.

R=brucedawson@chromium.org
BUG=670518

Review-Url: https://codereview.chromium.org/2549443004
Cr-Commit-Position: refs/heads/master@{#436220}

Reason: There is no owner for this directory currently.

NOEXPORT=true

Review-Url: https://codereview.chromium.org/2553473002
Cr-Commit-Position: refs/heads/master@{#436219}

As a follow-up to https://codereview.chromium.org/2543893002/,
we make the code easy to read and remove unnecessary findbug suppression.

BUG=668692

Review-Url: https://codereview.chromium.org/2544163003
Cr-Commit-Position: refs/heads/master@{#436218}

build_config.h *looks* like a list of all of the OS_* macros, but it is
missing OS_CHROMEOS. This can lead to confusion. Documenting OS_CHROMEOS
here makes build_config.h the source of truth that developers already
assume that it is.

Review-Url: https://codereview.chromium.org/2130543002
Cr-Commit-Position: refs/heads/master@{#436217}

Account for leading space when selecting our offset for the visible text.

BUG=667128

Review-Url: https://codereview.chromium.org/2529243002
Cr-Commit-Position: refs/heads/master@{#436216}

BUG=669983

Review-Url: https://codereview.chromium.org/2537773008
Cr-Commit-Position: refs/heads/master@{#436215}

BUG=662644
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2549003002
Cr-Commit-Position: refs/heads/master@{#436214}

BUG=644626

Review-Url: https://codereview.chromium.org/2547333002
Cr-Commit-Position: refs/heads/master@{#436213}

This is a follow-up CL of crrev.com/2536533002.

BUG=670814

Review-Url: https://codereview.chromium.org/2552603002
Cr-Commit-Position: refs/heads/master@{#436212}

BUG=542537
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2532483003
Cr-Commit-Position: refs/heads/master@{#436211}

Hanshake => Handshake
occured => occurred

BUG=

Review-Url: https://codereview.chromium.org/2475933002
Cr-Commit-Position: refs/heads/master@{#436210}

When acceptAllDevices is true the chooser will show all devices in range.

BUG=654918

Review-Url: https://codereview.chromium.org/2510323002
Cr-Commit-Position: refs/heads/master@{#436209}

This patch refactors generate_perf_json.py to avoid using cwd logic.
File paths are now relative to src which is derived relative to the
script location.

BUG=667435

Review-Url: https://codereview.chromium.org/2542073003
Cr-Commit-Position: refs/heads/master@{#436208}

It's failing on most try jobs, causing retries and slowing down the CQ.

BUG=671048
TBR=dpranke@chromium.org, zakerinasab@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2551753002
Cr-Commit-Position: refs/heads/master@{#436207}

BUG=662644
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2550983002
Cr-Commit-Position: refs/heads/master@{#436206}

According to the mocks(go/fns-ui-spec), there should be a seperator between http
warning message and other autofill entries.

BUG=662298, 662297

Review-Url: https://codereview.chromium.org/2542593003
Cr-Commit-Position: refs/heads/master@{#436205}

https://skia.googlesource.com/skia.git/+log/d87fbee77524..8b4b56ac2927

$ git log d87fbee77..8b4b56ac2 --date=short --no-merges --format='%ad %ae %s'
2016-12-04 msarett Fix max/min error

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2553483002
Cr-Commit-Position: refs/heads/master@{#436204}

In the "Get the code" section, shouldn't it be "fetch chromium"? As
it is unlikely that people who build Chromium on Windows want to target
iOS.

Also this is my first patch submission, so I think I also need to add my
name to the AUTHORS file.

BUG=

Review-Url: https://codereview.chromium.org/2545313002
Cr-Commit-Position: refs/heads/master@{#436203}

BUG=670325

Review-Url: https://codereview.chromium.org/2547933003
Cr-Commit-Position: refs/heads/master@{#436202}

- InterfacePtrInfo
- InterfaceRequest
- InterfacePtr
- Binding

BUG=579646

Review-Url: https://codereview.chromium.org/2549683002
Cr-Commit-Position: refs/heads/master@{#436201}

- Use wire values in SpdySettingsIds,
- remove SPDY/3.1-only setting values from SpdySettingsIds,
- rename ParseSettingId() to ParseSettingsId(),
- merge IsValidSettingId() into ParseSettingsId(),
- remove SerializeSettingId(),
- factor out SettingsIdToString(); remove default case
  to make sure every enum value is handled.

These values are not persisted to disk (that was a SPDY/3.1 feature),
so the only downside to the value change is Chrome net-log incompatibility.

This lands server side change 140592266 by bnc.

BUG=622737, 488484

Review-Url: https://codereview.chromium.org/2544343003
Cr-Commit-Position: refs/heads/master@{#436200}

Because they are missing as [1] mentions.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=665150#c10

BUG=665150

Review-Url: https://codereview.chromium.org/2546293002
Cr-Commit-Position: refs/heads/master@{#436199}

Using update-w3c-deps in Chromium 0740b0df.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7818

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2548193002
Cr-Commit-Position: refs/heads/master@{#436198}

BUG=671018
TBR=perezju@chromium.org

Review-Url: https://codereview.chromium.org/2548993002
Cr-Commit-Position: refs/heads/master@{#436197}

Revert of Updating the CLD3 commit hash in DEPS (patchset #1 id:1 of https://codereview.chromium.org/2546943002/ )

Reason for revert:
I believe this breaks https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28AMD%29/builds/398
	base::WeakPtr<base::win::ObjectWatcher>::get [0x1035E083+67]
	invalid_parameter [0x66D62011+161]
	std::_String_const_iterator<std::_String_val<std::_Simple_types<char> > >::operator* [0x023398F3+211]
	std::_String_iterator<std::_String_val<std::_Simple_types<char> > >::operator* [0x0233994F+15]
	chrome_lang_id::FMLParser::NextItem [0x06832F16+726]
	chrome_lang_id::FMLParser::Initialize [0x06832B1F+111]
	chrome_lang_id::FMLParser::Parse [0x068330CF+31]
	chrome_lang_id::GenericFeatureExtractor::Parse [0x06835340+48]
	?Setup@?$EmbeddingFeatureExtractor@V?$FeatureExtractor@VSentence@chrome_lang_id@@$$V@chrome_lang_id@@VSentence@2@$$V@chrome_lang_id@@UAEXPAVTaskContext@2@@Z [0x0681AD70+128]
	chrome_lang_id::NNetLanguageIdentifier::Setup [0x0681AE8C+28]
	chrome_lang_id::NNetLanguageIdentifier::NNetLanguageIdentifier [0x06815F2F+527]
	chrome_lang_id::NNetLanguageIdentifier::NNetLanguageIdentifier [0x06816009+25]
	translate::DeterminePageLanguage [0x06A3F017+1287]
	translate::DeterminePageLanguage [0x06A3EC50+320]
	translate::TranslateHelper::PageCaptured [0x06A3D13F+335]
	ChromeRenderFrameObserver::CapturePageText [0x06874729+489]
	ChromeRenderFrameObserver::DidMeaningfulLayout [0x06874CA9+73]
	content::RenderFrameImpl::DidMeaningfulLayout [0x12BA7F73+99]
	content::RenderWidget::didMeaningfulLayout [0x12C5FC09+169]
	blink::WebViewImpl::updateAllLifecyclePhases [0x1A84A852+690]
	blink::WebViewImpl::resizeViewWhileAnchored [0x1A844719+265]
	blink::WebViewImpl::resizeWithBrowserControls [0x1A844A8E+670]
	content::RenderViewImpl::ResizeWebWidget [0x12C39199+89]
	content::RenderWidget::Resize [0x12C5AB34+756]
	content::RenderWidget::OnResize [0x12C595F2+114]
	content::RenderViewImpl::OnResize [0x12C37F54+516]
	base::DispatchToMethodImpl<content::RenderWidget *,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &),std::tuple<content::ResizeParams> const &,0> [0x12C4B006+54]
	base::DispatchToMethod<content::RenderWidget *,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &),std::tuple<content::ResizeParams> const &> [0x12C4A505+53]
	IPC::DispatchToMethod<content::RenderWidget,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &),void,std::tuple<content::ResizeParams> > [0x12C4AAD6+38]
	IPC::MessageT<ViewMsg_Resize_Meta,std::tuple<content::ResizeParams>,void>::Dispatch<content::RenderWidget,content::RenderWidget,void,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &)> [0x12C47F5C+300]
	content::RenderWidget::OnMessageReceived [0x12C580F7+1975]
	content::RenderViewImpl::OnMessageReceived [0x12C36F81+6561]
	IPC::MessageRouter::RouteMessage [0x0D90088A+58]
	content::ChildThreadImpl::ChildThreadMessageRouter::RouteMessage [0x109E2FF6+22]
	IPC::MessageRouter::OnMessageReceived [0x0D9005DA+58]
	content::ChildThreadImpl::OnMessageReceived [0x109E228F+1439]
	IPC::ChannelProxy::Context::OnDispatchMessage [0x0D8AD953+115]
	base::internal::FunctorTraits<void (__thiscall IPC::ChannelProxy::Context::*)(IPC::Message const &),void>::Invoke<scoped_refptr<IPC::ChannelProxy::Context> const &,IPC::Message const &> [0x0D8A6995+37]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall IPC::ChannelProxy::Context::*const &)(IPC::Message const &),scoped_refptr<IPC::ChannelProxy::Context> const &,IPC::Message const &> [0x0D8A7055+53]
	base::internal::Invoker<base::internal::BindState<void (__thiscall IPC::ChannelProxy::Context::*)(IPC::Message const &),scoped_refptr<IPC::ChannelProxy::Context>,IPC::Message>,void __cdecl(void)>::RunImpl<void (__thiscall IPC::ChannelProxy::Context::*cons [0x0D8A7453+83]
	base::internal::Invoker<base::internal::BindState<void (__thiscall IPC::ChannelProxy::Context::*)(IPC::Message const &),scoped_refptr<IPC::ChannelProxy::Context>,IPC::Message>,void __cdecl(void)>::Run [0x0D8AE364+36]
	base::internal::RunMixin<base::Callback<void __cdecl(void),0,0> >::Run [0x1008A944+68]
	base::debug::TaskAnnotator::RunTask [0x1008AADF+367]
	blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue [0x191CE676+1094]
	blink::scheduler::TaskQueueManager::DoWork [0x191CCDA1+737]
	base::internal::FunctorTraits<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),void>::Invoke<base::WeakPtr<blink::scheduler::TaskQueueManager> const &,base::TimeTicks const &,bool const &> [0x191C28ED+61]
	base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall blink::scheduler::TaskQueueManager::*const &)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager> const &,base::TimeTicks const &,bool const &> [0x191C2A43+83]
	base::internal::Invoker<base::internal::BindState<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager>,base::TimeTicks,bool>,void __cdecl(void)>::RunImpl<void (__thiscall blink::sc [0x191C2B32+114]
	base::internal::Invoker<base::internal::BindState<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager>,base::TimeTicks,bool>,void __cdecl(void)>::Run [0x191CEFC4+36]
	base::internal::RunMixin<base::Callback<void __cdecl(void),0,0> >::Run [0x1008A944+68]
	base::debug::TaskAnnotator::RunTask [0x1008AADF+367]
	base::MessageLoop::RunTask [0x10105444+660]
	base::MessageLoop::DeferOrRunPendingTask [0x1010323C+44]
	base::MessageLoop::DoWork [0x10103822+242]
	base::MessagePumpDefault::Run [0x1010B4FE+190]
	base::MessageLoop::RunHandler [0x1010513C+444]
	base::RunLoop::Run [0x101B7594+52]
	content::RendererMain [0x12C789FE+830]
	content::RunNamedProcessTypeMain [0x130B0007+135]
	content::ContentMainRunnerImpl::Run [0x130AFEC8+488]
	content::ContentMain [0x130ADDE4+100]
	ChromeMain [0x02315ED8+264]

Original issue's description:
> Updating the CLD3 commit hash in DEPS
>
> The main change are:
> - a retrained model with additional script-based features
> - replacing "vector" with "std::vector"
>
> Link to the page in GitHub showing the diff:
> https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a
>
> BUG=670742
>
> Committed: https://crrev.com/f31c5cafc3b085a1f08ed917e518dcc1b30e175f
> Cr-Commit-Position: refs/heads/master@{#436034}

TBR=groby@chromium.org,rouslan@chromium.org,abakalov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=670742

Review-Url: https://codereview.chromium.org/2547833004
Cr-Commit-Position: refs/heads/master@{#436196}

This reverts commit a53f3c37.

Original CL: https://codereview.chromium.org/2543743002

Reason for revert: Compilation issue on master.tryserver.chromium.win:win_optional_gpu_tests_rel

Failing [1] task on the bot:

FAILED: obj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj
ninja -t msvc -e environment.x86 -- E:\b\c\cipd\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj.rsp /c ../../third_party/deqp/src/modules/gles3/performance/es3pBufferDataUploadTests.cpp /Foobj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj /Fd"obj/third_party/angle/src/tests/angle_deqp_libgles3_cc.pdb"
e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): error C2220: warning treated as error - no 'object' file generated
e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): warning C4828: The file contains a character starting at offset 0x3714f that is illegal in the current source character set (codepage 65001).
e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings

[1]
https://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/5729/steps/compile%20%28without%20patch%29/logs/stdio

BUG=454858, 637203, 671021

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
NOTREECHECKS=true
TBR=scottmg@chromium.org, dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2550973002
Cr-Commit-Position: refs/heads/master@{#436195}

It is used only there and it is not part of the public protocol.

BUG=None
TEST=net_unittests
R=juliatuttle@chromium.org

Review-Url: https://codereview.chromium.org/2545163002
Cr-Commit-Position: refs/heads/master@{#436194}

R=dcheng@chromium.org
TBR=dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2545303002
Cr-Commit-Position: refs/heads/master@{#436193}

We cannot just abort in the middle of layoutBlockFlow() when we detect that we
need another layout pass (due to new column height or because we want an
earlier break to satisfy the widows requirement). We might miss our only
opportunity to detect size changes that way, and thus skip necessary layout and
repositioning of absolutely positioned descendants.

BUG=591637

Review-Url: https://codereview.chromium.org/2471623003
Cr-Commit-Position: refs/heads/master@{#436192}

Cr-Commit-Position: refs/heads/master@{#436191}

This also adds variadic helper functions CheckMax and CheckMin that
return the maximum or minimum (respectively) result of an arbitrary
number of arithmetic, CheckedNumeric, or StrictNumeric arguments.

Review-Url: https://codereview.chromium.org/2545253002
Cr-Commit-Position: refs/heads/master@{#436190}

Previously enabled for chromium_code, can now be turned on everywhere.

BUG=454858,637203

Review-Url: https://codereview.chromium.org/2543743002
Cr-Commit-Position: refs/heads/master@{#436189}

Since the function KeywordTable::MigrateKeywordsTableForVersion45
is not used in codebase, it's safe to remove it.

R=pkasting@chromium.org
BUG=665018

Review-Url: https://codereview.chromium.org/2542933002
Cr-Commit-Position: refs/heads/master@{#436188}

If fieldset's legend is floating it should be added to the existing fieldset\'s anonymous block instead of creating a nested one.
This is necessary because flexbox forces the floating legend to be non-floating and therefore if the legend needs to be floating it should be added to the fieldset's anonymous block.

BUG=661230, 670837
TEST=fast/forms/fieldset/fieldset-legend-float.html

Tested with real world websites:
https://jsbin.com/zutekilusi/1/edit?html,css,output
http://www.timico.co.uk/timico-ltd-application-form
http://codepen.io/michaelpumo/pen/VmZqrr
https://en.wikipedia.org/wiki/Special:ActiveUsers
https://jsfiddle.net/tdbthtra/

Review-Url: https://codereview.chromium.org/2550963002
Cr-Commit-Position: refs/heads/master@{#436187}

Move DCO + tests from ash to ui. All of the ash dependencies were
already removed, so it's mostly just changing the file location and
namespace.

BUG=667344

Review-Url: https://codereview.chromium.org/2524863003
Cr-Commit-Position: refs/heads/master@{#436186}

Cr-Commit-Position: refs/heads/master@{#436185}

Review-Url: https://codereview.chromium.org/2545923005
Cr-Commit-Position: refs/heads/master@{#436184}

The wpt_github code imports libhttp2, which is not part of the
standard Python libraries (at least on Mac). Luckily, we have
a hermetic instance of it in depot_tools, so let's use that instead.

R=jeffcarp
BUG=

Review-Url: https://codereview.chromium.org/2548163002
Cr-Commit-Position: refs/heads/master@{#436183}

BUG=662644
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2550023002
Cr-Commit-Position: refs/heads/master@{#436182}