- 13 Nov, 2019 40 commits
-
-
Stephen Roe authored
Reland "Add third_party/qemu-linux-arm64 to DEPS runhooks." https://chromium-review.googlesource.com/c/chromium/src/+/1913570 missed the Fuchsia ARM64 SDK version update from https://chromium-review.googlesource.com/c/chromium/src/+/1880067 which used an SDK CIPD created with copy mode instead of symlink mode. A copy mode CIPD is required to load the SDK into test isolates. Bug: 1000901 Change-Id: Iebc603a14c9b557b55a99de1d5968231c4bb40f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912895 Auto-Submit: Stephen Roe <steveroe@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#715076}
-
Tommy Steimel authored
This is flaking on the Mac10.13 Tests Debug bot: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/15476 Bug: 1022915 Change-Id: I03c36b4034b9a96e208ebe3fd683e41765ece25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914899 Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#715075}
-
Jasper Chapman-Black authored
Bug: 1011921 Change-Id: I88e87dc609307e68fffc9deb911b09ba6616e6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914545 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#715074}
-
Yoshifumi Inoue authored
This patch makes |NGBoxFragmentPainter::PaintInlineItems()| to support |kGeneratedText|, e.g. ellispsis, soft hyphen, for preperation of migration of |NGFragmentItem|. This patch is follow-up of the patch[1] which constructs |kGeneratedText| type fragment. Before the patch[1], we construct |kText| fragment item even if it is generated text type in |NGPhysicalTextFragment|. [1] http://crrev.com/c/1905045 Make ComputeNGCaretPosition() not to get Bidi level for layout generated text Bug: 982194 Change-Id: I4e3eaedc7f22756923a4b9763e8c727a2dc531cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910987 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715073}
-
Chris Lu authored
Adds a new "badge_public" source_set in //chrome/browser/infobar and "badges_constants" source_set in //showcase to avoid any chrome/app dependencies. Bug: 987646 Change-Id: I9116a971d0f90ef22ca02f4972f97c644ba481fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911222Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#715072}
-
John Budorick authored
Bug: 922145 Change-Id: I4403bd2a500297bb1c1166dc87900e065f10a060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913970 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#715071}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d4b3120e6071..4b642a6d90f5 git log d4b3120e6071..4b642a6d90f5 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 syoussefi@chromium.org Desktop GLSL input + Vulkan GLSL output in shader_translator Created with: gclient setdep -r src/third_party/angle@4b642a6d90f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: I409b960e0e0a7b9d7b977a0b4676c657d54730be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913037Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715070}
-
Tommy Steimel authored
This CL marks canvas-drawImage-live-video.html as flaky for the virtual/disable-deferred-rendering test suite TBR=dalecurtis@chromium.org Bug: 816914 Change-Id: I20b898c3ce13dd3adc7bccbdb98cfa7331d5c4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914969Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715069}
-
Jack Lynch authored
This adds an axe test for the watch expressions pane and is dependent on https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1884528 Bug: 963183 Change-Id: Ib43e9494d8ffa1ac825a6824a34b32d9d3095625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652369 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#715068}
-
James Cook authored
The add user flow has a sync consent screen. A new version of this screen was built in mid-2018 for project Unity but wasn't shipped. The SplitSettingsSync feature is building a third version of this screen, so remove the Unity version to simplify the code. This is a manual revert of most of this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1061213/ I've kept the logic around showing/hiding different versions of the screen since I'll need that for the SplitSettingsSync version. Bug: 822889, 1013466 Test: manually verified sync constent screen appears with correct text and images, verified "Review" checkbox works Change-Id: I88490b2b5109c6783084d039f19a9eea2888598f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910801Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#715067}
-
Min Qin authored
Part of the modulization effort. Bug: 1013759 Change-Id: I3a250fb293925ebe3c98fc068003b32568112ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902072Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715066}
-
Yao Xiao authored
TBR=avi@chromium.org Bug: 1024033 Change-Id: I257af8db8aa8951486c69bfe02078a0da303ee51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913123 Auto-Submit: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Yao Xiao <yaoxia@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#715065}
-
Anastasia Helfinstein authored
This changes adds additional functions for operation on rectangles. They will be used in a follow-up change. Bug: None Change-Id: I82d52a041e91660514db8f1376a034ed3514e5c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910866 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#715064}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b5407bfb585e..b2407dd746de git log b5407bfb585e..b2407dd746de --date=short --no-merges --format='%ad %ae %s' 2019-11-13 chrisforbes@google.com regres: Don't ignore abnormal exits Created with: gclient setdep -r src/third_party/swiftshader@b2407dd746de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/144426261 Change-Id: Ifd29c1c529f08c775867af6c544fb573b06c7c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914527Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/0865050e54e9..63e5e057851d git log 0865050e54e9..63e5e057851d --date=short --no-merges --format='%ad %ae %s' 2019-11-13 9856269+sarahM0@users.noreply.github.com Add spvc parser support and unit tests for: OpTypeMatrix, OpTypeRuntimeArray, OpTypeImage, OpTypeSampler, OpTypeSampledImage (#885) 2019-11-13 rharrison@google.com Remove the deprectated all-in-one generation API (#883) 2019-11-13 rharrison@google.com Expose spirv_cross compiler to ease integration into Dawn (#884) 2019-11-13 9856269+sarahM0@users.noreply.github.com Add spvc parser support and unit tests for: OpTypeBool, OpTypeFloat, … (#881) Created with: gclient setdep -r src/third_party/shaderc/src@63e5e057851d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I5b3d6469292c0bae9e3e48fcd0282a661c6da51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914524Reviewed-by:
-
Jeffrey Kardatzke authored
The --use-drm parameter is required to allocate buffers that have a valid bo inside of them which is used by the yuv client. Bug: None Test: Ran wayland_yuv_client w/ and w/out --use-drm param Change-Id: I29027ee4608da05ed82aeb03f6e8b63713df32ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914759Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#715061}
-
Esmael El-Moslimany authored
In order to support opaque ripples for cr-icon-button, the instances that used the background-image CSS property to specify the icon were changed to use --cr-icon-image. The reason is the mask-image property is being used instead inside cr-icon-button to allow the icon color to be easily changed as needed using CSS. The colors that were specified in the original SVG files need to now be specified in CSS using the --cr-icon-button-color CSS variable. This does not work for the camera-shutter-icon and videocan-shutter-icon which have two colors: one for the fill and one for the stroke. The mask-image approach is not able to accommodate more than one color. For this reason, the icons used in cr-camera were changed to use iron-icon which is also support by cr-icon-button. In order to support icons that have different stroke and fill colors the following CSS variables have been added. The *-focus-* variables are for when the ripple is showing. --cr-icon-button-fill-color --cr-icon-button-focus-fill-color --cr-icon-button-focus-stroke-color --cr-icon-button-stroke-color These new variables are to be used in place of the existing CSS variables --cr-icon-button-color and --cr-icon-button-focus-color. Bug: 1022752 Change-Id: I0a010e500186e029ca71445f200d4606312deb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906962 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715060}
-
Michael Spang authored
Change-Id: I11cef97eb166263b99b09e4fca09fcc1c34fb494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914965Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715059}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/06a394e036ab..60bd1aea3d6d git log 06a394e036ab..60bd1aea3d6d --date=short --no-merges --format='%ad %ae %s' 2019-11-13 srte@webrtc.org Detach thread checker in RtcEventLogImpl destructor. 2019-11-13 peah@webrtc.org Correcting the ACM upmixing from mono/stereo to surround 2019-11-13 srte@webrtc.org Providing EmulatedRoute instances when creating TcpMessageRoute 2019-11-13 jakobi@webrtc.org Synchronize is_screencast_ state in AndroidVideoTrackSource. 2019-11-13 peah@webrtc.org Allow extracting the linear AEC output Created with: gclient setdep -r src/third_party/webrtc@60bd1aea3d6d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:b/140823178 Change-Id: I2e16f71e06bec52c3c1cfd4fc6f91509582bf54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914741Reviewed-by:
-
kylechar authored
SkiaOutputSurfaceImplOnGpu::RemoveRenderPassResource() assumes that every RenderPassId exists in the |offscreen_surfaces_| map. If drawing the RenderPass fails before SOSIOG::FinishPaintRenderPass() adds a map entry, then the iterator in SOSIOG::RemoveRenderPassResource() will point to offscreen_surfaces_.end(). Calling flat_map::erase() with the end iterator is an error. SkiaOutputSurfaceImpl::SubmitPaint() assumes that SOSIOnGpu::FinishPaintRenderPass() will be successful. However if the context is lost in FinishPaintRenderPass() it will return early and not added a map entry. Both SkiaRenderer and SkiaOutputSurfaceImpl will think there are RenderPass resources to delete leading to a potential crash. This is a speculative fix as I'm unable to reproduce it locally. Bug: 1015613 Change-Id: Icd8f6922926892ccecb973041f5a626e75f78771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914298Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715057}
-
Gayane Petrosyan authored
Share tab https://screenshot.googleplex.com/f3uD32mMtwU.png Scan tab https://screenshot.googleplex.com/b8tCnu82tEu.png Bug: 993920 Change-Id: I34c834e497e709fd12a300328b5d9bc5ea54907a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906877Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#715056}
-
Hector Carmona authored
This has the changes needed to preserve focus. This change adds both v2 and v3 tests to validate the patch. Bug: 1020664 Change-Id: I7b4f62f14d6aa8a370b4ebb7c30494eacb48fd74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893547 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#715055}
-
Dana Fried authored
See attached issue. Accessibility users can now tab through the dialog, getting specific information (such as permissions), with the screen reader reading each element. A new subclass of Label has been created to ensure that non- accessible users can get visual feedback if they use TAB to traverse the dialog, since normal labels do not paint a text focus ring when focused. Future work: - Eliminate AppInfoPanel::CreateKeyValueField() - Merge AppInfoLabel functionality into views::Label Bug: 996764 Change-Id: I97655c925c02b7d0b943f7fbb916ec1a87eed175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910871Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#715054}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b6857b74..4636c1f0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54437f71c6192a7bf34607c5769d02b2d2dff830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914659Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715053}
-
David Bertoni authored
The BrowserActionApitest.CloseBackgroundPage was disabled in 2011 due to crashing on ASAN builds. I tested this for both regular Chrome on Linux and ChromeOS builds and it didn't crash after 500 runs. Bug: 98861 Change-Id: I3c896a4b6231b79fdc47d3be0c3ef3dca7683d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914605Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#715052}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae01f620091b..4f32a29a69b4 git log ae01f620091b..4f32a29a69b4 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 nigeltao@google.com Move SkWuffsCodec's reset_and_decode_image_config Created with: gclient setdep -r src/third_party/skia@4f32a29a69b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: I29a43a1daa15f7a418f192a0cb06c31c52f62a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914699Reviewed-by:
-
Owen Min authored
The API returns the extension status for installation. It returns a value based on an extension's install state, policy setting and request status. This API will be used by CWS extension detail page. Bug: 1006899, 995385 Change-Id: Icedc653829e255cf56d8c84c86fcd169fc4674e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885450 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715050}
-
Xianzhu Wang authored
Previously for a cc::Layer to have debug info (e.g. layer name, and information for tracing, inspection, etc.), we needed to create an instance of LayerClient implementation for the layer, and the layer pulled debug info from the client during frame update. Now change the pull model to push model to simplify clients, and remove cc::LayerClient. This fixes the issue in CompositeAfterPaint that foreign layers lack layer names. Change-Id: I06bbe689c8c9ee56be3c8dea8eb6b480faadc5d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906895 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#715049}
-
Adam Ettenberger authored
It's possible for NormalizeTextRange to return an inverted range when both endpoints are anchored within the same ignored subtree. Expanding the range endpoints to their equivalent unignored text position before calling "AsLeafTextPosition{Before|After}Character" fixes the issue where the range becomes inverted. This fixes another corner case related to : https://crrev.com/c/1879778 Bug: 1021443 Change-Id: Ifeb178c5b3c2fdf68c925ea3def523f0ddc1b059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902255 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#715048}
-
siyua authored
This CL fixes the problem that Chrome settings page won't refresh itself after exiting from a Incognito window and saving a new address. The root reason requires more investigation but this CL will fix the RB bug. SaveCardBubbleControllerImpl does not need to be created again (even though creating a new controller should not hurt) since if there is no controller then the promo is not visible. Bug: 1016669, 932818, 1024041 Change-Id: I7a8c3dc144ddb1b6b11672efe8e1dfd6b9a15b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898717Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#715047}
-
Toni Barzic authored
Updates EndOverview logic to mark session as shutting down sooner - before any windows are minimized, or observers are notified the session start was canceled, to prevent reentry in EndOverview() - in particular to prevent reentry due to active window change while minimizing windows while exiting to home screen (fade out, slide out exit types). This also makes OverviewItem::SetBounds() triggered by minimization exit early (instead of updating grid item widget bounds just before the overview session exits) - the cl updates OverviewSessionWithDragFromShelfFeatureTest.FadeOutExit expectations to address this change in behavior. The test now tests that grid item widget bounds remain the same during exit directly (instead of checking for identity transform). BUG=1024107 Change-Id: If0f301bccc41de7f33b30a6017e508c97767ced1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913508Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#715046}
-
sczs authored
- If the card will be uploaded the Modal with the ToS needs is shown before. - Creates SaveCardModalDelegate that its used by the Modal to Save the Card. - Adds a currentCardSaved property to the ModalVC in order to disable the SaveButton if the card has been already saved. Bug: 1014652 Change-Id: I3dadaf24b307c8ffe3b68d499e9ef3840c299623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913023 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#715045}
-
Andrew Grieve authored
Moved from manual deps into //third_party/android_deps: * Guava-jre * AutoService * ErrorProne It looks like this CL adds other libraries, but they are just those that already existed within errorprone-ant.jar. This updates how ErrorProne is invoked to the JDK9+ method of being a proper javac plugin. This move necessitated moving the above libraries into android_deps, because the version of Guava that was already in android_deps was conflicting with our non-android_deps one. Change-Id: Iaa0f927263baaec8180808769f97db9c5393ad18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885951 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#715044}
-
Patrick Noland authored
Bug: 1023533 Change-Id: I3c2165499bda87ae070982402ec5b5db02d2a776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913077Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#715043}
-
Peng Huang authored
This method is for deserializing paint ops from binary data, and append paint ops to the PaintOpBuffer. It can be used for reusing PaintOpBuffer to avoid re-allocating PaintOpBuffers. It will be useful for multithread chrome GPU experimental. It needs to deserialize paint ops from command buffer, and store it in shared image. This change allows reusing existing PaintOpBuffer. Bug: None Change-Id: I2f86b6c62f454495e591bbd841b8aa7156780e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906938Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715042}
-
Alex Keng authored
This change addresses two rendering issues: 1) The rounded corner changes dynamically when the value is close to 0. The fix is to re-implement the value track using a rectangle plus clipping (same approach as <progress>). 2) The thumb doesn't completely cover the track when the value is 0 or maximum. The fix is to shrink the background track by 1px on both ends Note the thumbs is also changed to solid color per design and kProgressValue/kSlider/kDisabledSlider/kHoveredSlider are introduced for different color designs between upstream and downstream. Test: range-appearance-basic.html (3 new test cases for extreme values) Bug: 1021232 Change-Id: Id9a5df157e42335f7afafa75376a461b85abc7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911663 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#715041}
-
Elly Fong-Jones authored
This change introduces DialogDelegate::set_buttons as a replacement for overriding DialogDelegate::GetDialogButtons(), and changes all the trivial overrides to use the new setter instead. Future CLs will remove all the other overrides and eventually remove the original method. Bug: 1011446 Change-Id: I0735a217f581edfb25ddc4a118ebffe5d24e900e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912801Reviewed-by:
-
Anqing Zhao authored
Previously, ReportUploader is designed for reporting ChromeDesktopReportRequest on Windows, Mac and Linux. To supporting Chrome OS, now we change this class a little bit to reuse its logic. Bug: 1010213 Change-Id: I724d203534ec1a831700842181aec4f1121b6d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908542Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#715039}
-
Xianzhu Wang authored
This will make the paint chunk id more meaningful and stable. Change-Id: I5aaacc183c2c359fcfe8b44e3ac17c1a00f9d4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912637 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Ken MacKay authored
Use mixer service for everything. Optionally move the mixer to a separate process. Bug: internal b/138938216 Change-Id: Ica1bd713babeda31ba267b657fc86ffc720ea651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895702Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#715037}
-
